Michael Anthony Knyszek
f01c20bf2b
runtime/debug: export SetMemoryLimit
...
This change also adds an end-to-end test for SetMemoryLimit as a
testprog.
Fixes #48409 .
Change-Id: I102d64acf0f36a43ee17b7029e8dfdd1ee5f057d
Reviewed-on: https://go-review.googlesource.com/c/go/+/397018
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-05-03 15:14:09 +00:00
Russ Cox
349cc83389
os/exec: return error when PATH lookup would use current directory
...
CL 381374 was reverted because x/sys/execabs broke.
This CL reapplies CL 381374, but adding a lookPathErr error
field back, for execabs to manipulate with reflect.
That field will just be a bit of scar tissue in this package forever,
to keep old code working with new toolchains.
CL 403256 fixes x/sys/execabs's test to be ready for the change.
Older versions of x/sys/execabs will keep working
(that is, will keep rejecting what they should reject),
but they will return a slightly different error from LookPath
without that CL, and the test fails because of the different
error text.
For #43724 .
This reverts commit f2b674756bhttps://go-review.googlesource.com/c/go/+/403274
Auto-Submit: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2022-05-02 14:54:05 +00:00
Bryan Mills
f2b674756b
Revert "os/exec: return error when PATH lookup would use current directory"
...
This reverts CL 381374.
Reason for revert: broke tests for x/sys/execabs.
Updates #43724 .
Updates #43947 .
Change-Id: I9eb3adb5728dead66dbd20f6afe1e7a77e2a26f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/403058
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
2022-04-29 23:04:17 +00:00
Russ Cox
3ce203db80
os/exec: return error when PATH lookup would use current directory
...
Following discussion on #43724 , change os/exec to take the
approach of golang.org/x/sys/execabs, refusing to respect
path entries mentioning relative paths by default.
Code that insists on being able to find executables in relative
directories in the path will need to add a couple lines to override the error.
See the updated package docs in exec.go for more details.
Fixes #43724 .
Fixes #43947 .
Change-Id: I73c1214f322b60b4167a23e956e933d50470fe13
Reviewed-on: https://go-review.googlesource.com/c/go/+/381374
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
2022-04-29 20:16:31 +00:00
Carl Johnson
a5d61be040
net/http: add MaxBytesError
...
Fixes #30715
Change-Id: Ia3712d248b6dc86abef71ccea6e705a571933d53
GitHub-Last-Rev: 6ae68402a5golang/go#49359
Reviewed-on: https://go-review.googlesource.com/c/go/+/361397
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-25 23:36:50 +00:00
Ian Lance Taylor
0bf545e51f
regexp/syntax: rename ErrInvalidDepth to ErrNestingDepth
...
The proposal accepted the name ErrNestingDepth.
For #51684
Change-Id: I702365f19e5e1889dbcc3c971eecff68e0b08727
Reviewed-on: https://go-review.googlesource.com/c/go/+/401854
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2022-04-22 22:35:03 +00:00
Ian Lance Taylor
575fd8817a
regexp: change ErrInvalidDepth message to match proposal
...
Also update the file in $GOROOT/api/next to use proposal number.
For #51684
Change-Id: I28bfa6bc1cee98a17b13da196d41cda34d968bb0
Reviewed-on: https://go-review.googlesource.com/c/go/+/401076
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2022-04-22 00:10:17 +00:00
Bryan C. Mills
b34838913d
os/exec: set PWD implicitly if Dir is non-empty and Env is nil
...
Fixes #50599 .
Change-Id: I4e5dbb3972cdf21ede049567bfb98f2c992c5849
Reviewed-on: https://go-review.googlesource.com/c/go/+/401340
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2022-04-21 17:37:05 +00:00
Joe Tsai
35a92f92bd
encoding/binary: add AppendVarint AppendUvarint
...
This adds a straight-forward implementation of the functionality.
A more performant version could be added that unrolls the loop
as is done in google.golang.org/protobuf/encoding/protowire,
but usages that demand high performance can use that package instead.
Fixes #51644
Change-Id: I9d3b615a60cdff47e5200e7e5d2276adf4c93783
Reviewed-on: https://go-review.googlesource.com/c/go/+/400176
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Joseph Tsai <joetsai@digital-static.net>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-15 01:19:37 +00:00
Roland Shoemaker
9298f604f4
crypto/x509: add CertPool.Clone
...
Export the previously private method copy as Clone.
Fixes #35044
Change-Id: I5403d6a3b9f344c980c1c89a6823e1a49dcda26b
Reviewed-on: https://go-review.googlesource.com/c/go/+/400175
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-13 19:04:59 +00:00
Russ Cox
27b7b1fa19
go/doc: use go/doc/comment
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Use go/doc/comment to implement the existing go/doc comment APIs,
as well as adding new APIs more tailored to the new world.
For #51082 .
Change-Id: I05b97ecedbf7cf7b8dede7ace6736ed6d89204a9
Reviewed-on: https://go-review.googlesource.com/c/go/+/384265
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2022-04-11 16:31:52 +00:00
Russ Cox
6eceabf119
go/doc/comment: parse and print headings
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Implement both old-style and new-style headings, like:
Text here.
Old Style Heading
More text here.
# New Style Heading
More text here.
For #51082 .
Change-Id: I0d735782d0d345794fc2d4e1bdaa0251b8d4bba2
Reviewed-on: https://go-review.googlesource.com/c/go/+/397284
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
2022-04-11 16:31:46 +00:00
Russ Cox
910a33a0ee
go/doc/comment: parse and print doc links
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Implement parsing and printing of documentation links,
like [math.Sqrt] or [*golang.org/x/text/runes.Set].
For #51082 .
Change-Id: I1cc73afbac1c6568773f921ce4b73e52f17acef6
Reviewed-on: https://go-review.googlesource.com/c/go/+/397281
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-11 16:31:42 +00:00
Russ Cox
6130b88130
go/doc/comment: add Printer and basic comment printing
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Implement printing of plain text doc paragraphs.
For #51082 .
Change-Id: Ieff0af64a900f566bfc833c3b5706488f1444798
Reviewed-on: https://go-review.googlesource.com/c/go/+/397279
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-11 16:31:40 +00:00
Russ Cox
98b17892a0
go/doc/comment: add paragraph parsing and test framework
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Implement parsing of plain text doc paragraphs,
as well as a txtar-based test framework. Subsequent CLs will
implement the rest of the possible markup.
For #51082 .
Change-Id: I449aac69b44089f241fde8050ac134e17cb25116
Reviewed-on: https://go-review.googlesource.com/c/go/+/397278
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-11 16:31:37 +00:00
Russ Cox
494b79f39a
go/doc/comment: add data structures
...
[This CL is part of a sequence implementing the proposal #51082 .
The design doc is at https://go.dev/s/godocfmt-design .]
Implement just the data structures of the new API for
parsing and printing doc comments, as well as a syntax tree
form for inspecting and manipulating them.
The API itself was discussed and accepted as part of the
proposal process in #51082 .
For #51082 .
Change-Id: Iae7fbc85705964585273b970c5c62e394feb1288
Reviewed-on: https://go-review.googlesource.com/c/go/+/397276
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-11 16:31:33 +00:00
Eli Bendersky
063f4032f5
sort: add Find function
...
For golang/go#50340
Change-Id: I3b4d278affc8e7ec706db8c9777f7a8c8ce7441d
Reviewed-on: https://go-review.googlesource.com/c/go/+/396514
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-07 14:42:13 +00:00
Roland Shoemaker
2de2f6df64
crypto/x509: add new CRL parser, deprecate old one
...
Adds a new, cryptobyte based, CRL parser, which returns a
x509.RevocaitonList, rather than a pkix.CertificateList. This allows us
to return much more detailed information, as well as leaving open the
option of adding further information since RevocationList is not a
direct ASN.1 representation like pkix.CertificateList. Additionally
a new method is added to RevocationList, CheckSignatureFrom, which is
analogous to the method with the same name on Certificate, which
properly checks that the signature is from an issuing certiifcate.
This change also deprecates a number of older CRL related functions and
types, which have been replaced with the new functionality introduced
in this change:
* crypto/x509.ParseCRL
* crypto/x509.ParseDERCRL
* crypto/x509.CheckCRLSignature
* crypto/x509/pkix.CertificateList
* crypto/x509/pkix.TBSCertificateList
Fixes #50674
Change-Id: I27dc219e39bef09a396e666b4fccaa32578fd913
Reviewed-on: https://go-review.googlesource.com/c/go/+/390834
Reviewed-by: Damien Neil <dneil@google.com>
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-05 23:32:55 +00:00
Russ Cox
9e16cc1541
hash/maphash: add Bytes and String
...
For very small inputs, h.Reset+h.Write+h.Sum64 is fundamentally
slower than a single operation, by about a factor of two, because
Write must copy the data into h's buffer, just in case there is another
Write before the Sum64.
A single function doing the whole sequence knows there is no extra
write that will happen, so it doesn't need the buffer, so it avoids the copy.
Fixes #42710 .
Change-Id: Icc79c68ccb10827f6640071d026df86b4940fcc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/392494
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-05 18:01:26 +00:00
Dmitri Shuralyov
eec47d06c1
api: add x509.CertPool.Equal to next/46057.txt
...
CL 388915 added an exported API but was authored (and tested)
before the API check became stricter.
Updates #46057 .
Change-Id: Iee6e4969ade77fb0539fa97fcef0047389fb2cf6
Reviewed-on: https://go-review.googlesource.com/c/go/+/398237
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2022-04-05 03:54:36 +00:00
Xiaodong Liu
cd33b4089c
debug: define ELF relocation for loong64
...
Contributors to the loong64 port are:
Weining Lu <luweining@loongson.cn>
Lei Wang <wanglei@loongson.cn>
Lingqin Gong <gonglingqin@loongson.cn>
Xiaolin Zhao <zhaoxiaolin@loongson.cn>
Meidan Li <limeidan@loongson.cn>
Xiaojuan Zhai <zhaixiaojuan@loongson.cn>
Qiyuan Pu <puqiyuan@loongson.cn>
Guoqi Chen <chenguoqi@loongson.cn>
This port has been updated to Go 1.15.6:
https://github.com/loongson/go
For #46229
Change-Id: I0c58305754c20d2a59328adbd82caa527de254ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/396735
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Mui <cherryyz@google.com>
2022-04-04 21:43:42 +00:00
Russ Cox
1af60b2f49
regexp/syntax: add and use ErrInvalidDepth
...
The fix for #51112 introduced a depth check but used
ErrInternalError to avoid introduce new API in a CL that
would be backported to earlier releases.
New API accepted in proposal #51684 .
This CL adds a distinct error for this case.
For #51112 .
Fixes #51684 .
Change-Id: I068fc70aafe4218386a06103d9b7c847fb7ffa65
Reviewed-on: https://go-review.googlesource.com/c/go/+/384617
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-04-04 10:59:27 +00:00
Ian Lance Taylor
31ee4bb28d
strconv: quote rune 007F as \x7f, not \u007f
...
\u007f is not wrong but it's weird to use \u when we could use the
shorter \x.
Fixes #52062
Change-Id: Ica4bdc2463128051876f44e15297ed1e9edf1de8
Reviewed-on: https://go-review.googlesource.com/c/go/+/397255
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
2022-03-31 20:37:15 +00:00
Than McIntosh
378221bd6e
debug/pe: add APIs for reading section def aux info
...
Add hooks to support reading of section definition symbol aux data
(including COMDAT information) from the aux symbols associated with
section definition symbols. The COFF symbol array made available by
"pe.File" includes entries for aux symbols, but doesn't expose their
structure (since it varies depending on the type of aux symbol). This
patch adds a function for returning a specific class of aux symbol
("type 5") that immediately follows a COFF symbol corresponding to a
section definition.
Updates #35006 .
Updates #51868 .
Change-Id: I21fcc057150f7a3c64f01a5961aabca0fa43399e
Reviewed-on: https://go-review.googlesource.com/c/go/+/394534
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-31 14:57:35 +00:00
Emmanuel T Odeke
81f1cc52ab
html/template: make FuncMap a type alias of text/template.FuncMap
...
In preparation to make html/template and text/template use a
single generics package, this change make FuncMap a type alias
of text/template.FuncMap.
Fixes #46121
Change-Id: I5e94cc8fdf4fe029ff223992b5cdfe79f9c098ab
Reviewed-on: https://go-review.googlesource.com/c/go/+/389156
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2022-03-31 00:54:34 +00:00
Patrick Gundlach
0eea25159f
encoding/xml: expose decoder line and column
...
The existing implementation of the xml decoder uses the line number
only for reporting syntax errors. The line number of the last read
token and the column within the line is useful for the users even
in non-error conditions.
Fixes #45628
Change-Id: I37b5033ff5ff8411793d8f5180f96aa4537e83f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/311270
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
2022-03-27 20:26:46 +00:00
Carl Johnson
0bbd05b826
time: add Duration.Abs
...
Fixes #51414
Change-Id: Ia3b1674f2a902c8396fe029397536643a3bc1784
GitHub-Last-Rev: 67159648afgolang/go#51739
Reviewed-on: https://go-review.googlesource.com/c/go/+/393515
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
2022-03-27 20:23:17 +00:00
Russ Cox
b7041c7ad1
cmd/api: require proposal # for new API features
...
Having the proposal numbers recorded in the API files
should help significantly when it comes time to audit
the new API additions at the end of each release cycle.
Change-Id: Id18e8cbdf892228a10ac17e4e21c7e17de5d4ff7
Reviewed-on: https://go-review.googlesource.com/c/go/+/392414
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-14 21:43:16 +00:00
Joe Tsai
91daaabd56
flag: add TextVar function
...
The TextVar function makes it easier to integrate the flag package
with any Go type that implements encoding.Text{Marshaler,Unmarshaler}.
Fixes #45754
Change-Id: Id23c37d59cf8c9699a7943a22ce27a45eb685c0f
Reviewed-on: https://go-review.googlesource.com/c/go/+/313329
Trust: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Joseph Tsai <joetsai@digital-static.net>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-10 16:56:17 +00:00
Carl Johnson
604140d931
net/url: add JoinPath, URL.JoinPath
...
Builds on CL 332209.
Fixes #47005
Change-Id: I82708dede05d79a196ca63f5a4e7cb5ac9a041ea
GitHub-Last-Rev: 51b735066egolang/go#50383
Reviewed-on: https://go-review.googlesource.com/c/go/+/374654
Reviewed-by: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-10 01:34:17 +00:00
Joe Tsai
ef92828bb9
api: update next.txt for binary.AppendByteOrder interface
...
CL 386017 added new API for encoding/binary package.
This file was accidentally not updated in the same CL.
Updates #50601
Change-Id: Iefeb596ba04b8c6576cf0fe42030f658a5848832
Reviewed-on: https://go-review.googlesource.com/c/go/+/389636
Trust: Joseph Tsai <joetsai@digital-static.net>
Run-TryBot: Joseph Tsai <joetsai@digital-static.net>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2022-03-03 17:04:24 +00:00
Bryan C. Mills
9cec77ac11
runtime/debug: replace (*BuildInfo).Marshal methods with Parse and String
...
Since a String method cannot return an error, escape fields that may
contain unsanitized values, and unescape them during parsing.
Add a fuzz test to verify that calling the String method on any
BuildInfo returned by Parse produces a string that parses to the same
BuildInfo. (Note that this doesn't ensure that String always produces
a parseable input: we assume that a user constructing a BuildInfo
provides valid paths and versions, so we don't bother to escape those.
It also doesn't ensure that ParseBuildInfo accepts all inputs that
ought to be valid.)
Fixes #51026
Change-Id: Ida18010ce47622cfedb1494060f32bd7705df014
Reviewed-on: https://go-review.googlesource.com/c/go/+/384154
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
2022-02-09 19:44:03 +00:00
Ian Lance Taylor
070951c5dc
constraints: remove package
...
It has moved to golang.org/x/exp/constraints. Perhaps it will move
back to the standard library in a future release.
For golang/go#45458
Fixes golang/go#50792
Change-Id: I93aa251a7afe7b329a3d3faadc0c5d6388b1f0e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/382460
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-03 03:13:33 +00:00
Robert Griesemer
b37c6e1547
go/types, types2: delete TypeList.String
...
This method is unused and was not discussed in the API
proposals. Note that all error output goes through the
local sprintf which handles arguments specially.
Fixes #50760 .
Change-Id: Iae66b0253cc0ece037d3d280951dc2d223c119fb
Reviewed-on: https://go-review.googlesource.com/c/go/+/381634
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2022-01-28 22:21:55 +00:00
Than McIntosh
8314544bd6
debug/dwarf: fix problems with handling of bit offsets for bitfields
...
This patch reworks the handling of the DWARF DW_AT_bit_offset and
DW_AT_data_bit_offset attributes to resolve problems arising from
a previous related change (CL 328709).
In CL 328709 the DWARF type reader was updated to look for and use
the DW_AT_data_bit_offset attribute for structure fields, handling
the value of the attribute in the same way as for DW_AT_bit_offset.
This caused problems for clients, since the two attributes have very
different semantics.
This CL effectively reverts CL 328709 and moves to a scheme in which
we detect and report the two attributes separately/independently.
This patch also corrects a problem in the DWARF type reader in the
code that detects and fixes up the type of struct fields corresponding
to zero-length arrays; the code in question was testing the
DW_AT_bit_offset attribute value but assuming DW_AT_data_bit_offset
semantics, meaning that it would fail to fix up cases such as
typedef struct another_struct {
unsigned short quix;
int xyz[0];
unsigned x:1;
long long array[40];
} t;
The code in question has been changed to avoid using BitOffset and
instead consider only ByteOffset and BitSize.
Fixes #50685 .
Updates #46784 .
Change-Id: Ic15ce01c851af38ebd81af827973ec49badcab6f
Reviewed-on: https://go-review.googlesource.com/c/go/+/380714
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2022-01-28 20:07:54 +00:00
Cherry Mui
becaeea119
api: promote next to go1.18
...
Change-Id: Ifc61e67413e5e56afbd0d4954f0150303d1a3a27
Reviewed-on: https://go-review.googlesource.com/c/go/+/371755
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2021-12-14 17:43:51 +00:00
Josh Bleecher Snyder
d3f5dd5781
syscall: migrate new UDP send/recv API to internal/syscall/unix
...
CL 331490 and friends added new API to package syscall.
This was a mistake that we need to fix before Go 1.18 is released.
Change-Id: I697c9a4fa649d564822f585dc163df5ab9e5ae08
Reviewed-on: https://go-review.googlesource.com/c/go/+/361216
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2021-11-03 21:45:33 +00:00
Jay Conrod
a37bebc042
cmd/go: stamp VCS revision and uncommitted status into binaries
...
When the go command builds a binary, it will now stamp the current
revision from the local Git or Mercurial repository, and it will also
stamp whether there are uncommitted edited or untracked files. Only
Git and Mercurial are supported for now.
If no repository is found containing the current working directory
(where the go command was started), or if either the main package
directory or the containing module's root directory is outside the
repository, no VCS information will be stamped. If the VCS tool is
missing or returns an error, that error is reported on the main
package (hinting that -buildvcs may be disabled).
This change introduces the -buildvcs flag, which is enabled by
default. When disabled, VCS information won't be stamped when it would
be otherwise.
Stamped information may be read using 'go version -m file' or
debug.ReadBuildInfo.
For #37475
Change-Id: I4e7d3159e1c270d85869ad99f10502e546e7582d
Reviewed-on: https://go-review.googlesource.com/c/go/+/353930
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2021-10-14 18:44:37 +00:00
Jay Conrod
85a068fdf2
runtime/debug: add GoVersion to BuildInfo
...
BuildInfo now includes the version of Go used to build a binary, as
reported by runtime.Version() or 'go version'.
For #37475
Change-Id: Id07dda357dc70599d64a9202dab894c7288de1de
Reviewed-on: https://go-review.googlesource.com/c/go/+/353888
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2021-10-14 18:44:21 +00:00
Jay Conrod
434cdd0337
debug/buildinfo: new package with Read and ReadFile
...
These functions provide access to module information stamped into Go
binaries. In the future, they'll provide access to other information
(like VCS info).
These functions are added in a new package instead of runtime/debug
since they use binary parsing packages like debug/elf, which would
make runtime/debug an unacceptably heavy dependency. The types in
runtime/debug are still used; debug/buildinfo uses them via type
aliases.
This information is already available for the running binary through
debug.ReadBuildInfo and for other binaries with 'go version -m', but
until now, there hasn't been a way to get it for other binaries
without installing cmd/go.
This change copies most of the code in cmd/go/internal/version. A
later CL will migrate 'go version -m' to use this package.
For #37475
Fixes #39301
Change-Id: I0fbe0896e04f12ef81c6d79fb61b20daede86159
Reviewed-on: https://go-review.googlesource.com/c/go/+/353887
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2021-10-14 18:44:08 +00:00
Jay Conrod
765c9116be
cmd/go: move module build info formatting into runtime/debug
...
Previously, modload.PackageBuildInfo returned a string containing
information about modules used to build an executable. This string is
embedded in the binary and can be read with debug.ReadBuildInfo or
'go version -m'.
With this change, debug.BuildInfo now has a MarshalText method that
returns a string in the same format as modload.PackageBuildInfo.
Package.load now calls Package.setBuildInfo, which constructs a
debug.BuildInfo, formats it with MarshalText, then sets
Package.Internal.BuildInfo. This is equivalent to what
modload.PackageBuildInfo did.
modload.PackageBuildInfo is deleted, since it's no longer used.
For #37475
Change-Id: I5875a98cb64737637fec2a450ab2ffa7f1805707
Reviewed-on: https://go-review.googlesource.com/c/go/+/353886
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2021-10-14 18:43:59 +00:00
John Kelly
c8dd89ed3d
net/http: add Cookie.Valid method
...
The (*http.Cookie).String method used by SetCookie will silently discard
or sanitize any fields it deems invalid, making it difficult to tell
whether a cookie will be sent as expected.
This change introduces a new (*http.Cookie).Valid method which may be
used to check if any cookie fields will be discarded or sanitized prior
to calling (*http.Cookie).String.
Fixes #46370
Change-Id: I2db80078de190d267a9c675a9717c8be8acc8704
Reviewed-on: https://go-review.googlesource.com/c/go/+/338590
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Mui <cherryyz@google.com>
Trust: Damien Neil <dneil@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
2021-10-06 23:26:57 +00:00
Michael Pratt
2dc91a25f6
cmd/api: set architecture sizes when type checking
...
Otherwise the type checker defaults to amd64, which can break
type-checking for definitions using unsafe.Sizeof.
This has the side effect of changing the API output: constants with
different values across architectures (e.g., MaxInt) are now
individually listed per-arch. This actually makes the API file more
accurate, but does introduce a one-time discontinuity. These changes
have been integrated into the API files where the constants were added.
Change-Id: I4bbb0b7a7f405d3adda2d83869475c8bacdeb6a9
Reviewed-on: https://go-review.googlesource.com/c/go/+/353331
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
2021-10-04 20:20:20 +00:00
Jay Conrod
5abfd2379b
[dev.fuzz] all: merge master ( 65f0d24) into dev.fuzz
...
Conflicts:
- api/next.txt
- src/cmd/go/alldocs.go
- src/cmd/go/internal/test/test.go
Merge List:
+ 2021-09-08 65f0d24f7337c9552e06c8d4fe2adcd419f9c61212eb7331b938c2e08cbdcb9ccd494ba1a6540bf1409434d623054710ce4673a062c3e79581d891ab82142573471da64686f8fdc207242064bdad2011929572307950c69cc3a9c50d811c7af030043e37da790cccc5f5bdbf311cbab79dd362963218cc9c3fff213ac2b606739be6b5e33a50fe07f623063da9a01a3fbddcf354577480783558b023f4f0db68d92101f452903958d2f56640171914e581ec07ee81188661f12a4845257fbca8c6ffa221de6bc4636226020c2fa1938435d620a71c9a1decfff58fb8c7f09eeb137b69ddc17143b05173a27619a4528d1b2d794ca39133245be728dae3defb37e9c1d6fe2d90df91a85c224ec921ba66d62b685ec298d7b00b663109248a01010c269cb5716f004957976b1ad9244f8b6404d8d2496052aef05498ab7c904bf217910ed4ff9f69a44308065f380815a8aa6cfa6d58244eee019633195ae17609b50701acc2957bc92a463a22ceead3fe0dba08588e6036d01388b04f782aa42255d8b156773c014a9720f937d45328674fb79569d2b8420baf464591f49938a35c5c98c090ed54114969107e73ce08e2519ded6705191e0217e9d148d3d13d62c49a840b4292c91ae7ddc2353db4888a059afbf826671bd35fab05df4c625d882872496ba50bfd6fcea688859f3cd850f38d04055e0f8edbdcea51e223c2711e1c8224592ee433f56c5f0282428f397bc1185670ff4ae5717f337d1d5a687eeaf1faf9c7d8fe2dd7b770de62ba72b353f4e24599dd36ac2214fa1a9807906d5cd1b847dc0df6df17e13c8c9e1e442d98a4b4bcb2f09cd7175e9ba0b1bd580987cd58d15a75e0701f83a8c16cbb0b5117387637345b6e78d0f8c870ae2b2dc01ab93581e47daed59d172a891470fbf746121306d3144e0b1f6ef27d6a23b068152359fd605d1aaea2ded10d75a93920d6f208f118d145a5d384ebde607622e41c843342aa5f51b06cfe9b25437362ccec86fa510d248f4c0206608250141c9a5f0d821add61120c634caf9009a9899da7ccab58bdc1bef8a0b602daea1b7b38dd8e2556c3856d5221d0b306afa29d9aad7af29abccd8af4cd001b576df3aac4ae5afa555428d7a43e8912044550ab0e010817714ef371b30f32ef4cb2f7765fb177163bc81fa001a7a9377183d082efc0540368ecdc2c7072c003ef8294f2a039516a35e075124f0dedca7139eb1cc3f4acdea4f9f7220bc44220bc44a4c67f7e1667f7e16bcc2c60a99f72d350a66532d7e2e2ec2bc92759978362f88b6dc8e7eee5e265f153b6739b967a8017f7af80af22b503db2c2413c9e05fdcf7eb6a07fcf938369837791f8d4562dede83ef67ac5e6a7e95e6a7e9b86166b691b65d6bdae33e9770df2e18da6ff433d6a4f2620285d0ac64f6d704068fb6c21bf0bc4122f4158e88f64647bef6c596cf1d5d0fa5baf60d4723d667671ad4f2ebfe34bd2f002cb39de23549a393b523caf4108d4cc20ca109c13b64fc2f96e6099b819085e1fcf8857ed37b8dedf741b99dab0fde1c934b9754cdef1f105d863f89fec2f96e686f5b643811554a9f0cec29daa55b21d1e6798795ffb1cdf860dd1ff0554b53bd97763577bba460499cd70c69d830f98b6111eb8eeb1bff1dbe1a6934778157960d7f22540abf76fa34678c670a7f00ae236b9e3f883e3081f817da8486ced8b0aeec6dbfe0f457ecc7f0f1d8ea1da34fbb5c86667a6d64fed624386606029fe5c7f122baf2866956c7e354d9d1c1a14781ec457418b47586ee89225a29d7e5472b8fcc6143605d5e50c3db5d0c2840da19585826fa6416bde023bd6845965c96d816c5746e50991d2a8fff20ffebbcd146d398dcee007aade17439e087c9912780ab97d17dc023835ff47c16f67e31d643ab9aaf46ee5045477be80f2525112730a423eb39e49775e0574d00fcbc43bacbc334397007431374303446395de9e0d1ef70c92c2c9d6265074a40860e598e7da491e2e3b9039871726c7269d8fbec7a3bdc1799d6740f7d7370c85695a117322879d5c9687f2acf6aeda3de0f79805d38a352c2bd9ee2db8f0578ef39165ebd85a74a0fd73ead0c83e01e0c8b471db71b946e2543f88e18428e38aef24d8f7dddfcc02352a2a9a7b5133848488f0face1730a410f85b0c0e19d9e3291facf12b0d1f93001b0abf04012fea822b7b790a71aa304273d74d3deb2c35929ec74fb8291a935ea0fa8d39f151d1951afc9192a193337169c5eb16f6cd9349175ad8ff16c1990df9c5d8f5d213e157d3ac04a32e59a6406227d71a05a7d49a954ce8793a8742dcba7bb41d991e4e144661418228d2066177dec27168712d35035f84eddffe30a21631af58e20d1ba047edf56a919f17fff36d114702460cf8602281ed619f8aab1d1fcb99ff61acbd7fda8ee8b07e61d1445ab5c7a460a1c850768bbc9a0adf91d855a40100141c92f5ee1705da2010840ea8298e2f5fe489c86a7b9f135d98fc2b4ec8f4911a43df461b0fba64ef4efd206eb407b7d7d781802f932e173a192ef8ac411a1f37b070b61dc4577c88e3ff648d043c8ea8994002f6fca3d679c6554fcdc3c098c160d7972606a760d6c367aa57a968757c115e1f6717894cf806ed946313348dfddbab31162aae0adff3469b1c20a0a160d4d49c688e45cb2253c8041456759b2462d250043b450f4ebbdd3fc27eb50ff7eaabae84d58490972c0a95f1b51be89a4f996402eb4d68833bad1fc1265641e8bc2c798f3d7fecb20a620fd9f4c8ffb3baa4be75faa3e1fffeddfe9e2e1987b310d019340944d3cc84044ec4fa983601aedff64d3cc844d3cc8477446fd547a64ab8d3ec46fd5477e9f911ec446fd547d895805efc78e39634e7daed397fc1169095bb790e1677dfe5ad6dea23e9ca88ab59d812aaaf914d0e6d7d4f28a06eeb7899137d4c0ed26ac0888a8cd2d7308d747e70f34a92df740ba119e3ffb8579746c2e250cc957337cebd2c12fbf6aafe7e4cfa2f6da508624f3591f9c9d8530f5f79c47f9f1dce319ff9f4d6a8359ca3c6985cd57668b84ff7aeaad5c86507cc341ecd10a904712891547e2d43025ce2fa88eaf4d16bcfc8e0cbbba63b968f4f89e0ac72d689bd1817e41313924f2720d7dc417ea09d82689ed3a9fd99849c3b57af8bc081110867093285c89d15aac85ad5e110343e4a25e33d11e10ac78501b9c70546f6404fd45e267c2f78d538858c5b6c36dddf14908d01bbb5608dd5d6dadee759c5dcb5e2cea3cdf8b429e1b708c02600ec2a8b42de5fe769be1b730a26729e590cb64f96e738868a7d27a889119b01e775e9c3efc8f9a8ded3667d079880ab6209e5b51cf47dce0d090721218e050372489897473e21ea3596b4188bd92bb6d1a0630aef4077925e2b07ab8754029fe73f28dc5656f0888b71b193598b3e56234a305c3c19731a9156eeb40a68a7ee4c51e283991bd7faa3d54da07b8ca6e59ed0b8a9ccb253799012990b3b53e1dad47694b59eb90830699ae7bed50e667e3e9f0bb2d8e2ab05dd39eee0ed40e561d933fd0011dca553fd5b1b77ea94e5d3c552e970b1c83a69cef65a137089ffb9b7a85e00034480e3b11a27283d208f3e7571f6ff1d35d8ffa535dbdda2fe600b7b431b5ecbd811b546cc68638127552e9172af903261e7c079b6baaaff0c0dbca62fa8f00915f4f503e0a370fd4e47d74a47e40a14506fd520d5adedf54288535575300947cdfa95ae9eee0ed9eee0ed439473e493d18176baafd5b288a83dcffb39e0f461ce00a6ec0842c8acf63c272233d27c47cd10c1149b2205eab0ef05f5ceffac751e2e6bac8cf0f74e45d8f90f904cb14e673ec7ba8e796c933ff155970840e583ff3bfbb2885749c81fd53b37ce257147f3cd15e02ed37d2219960d6753fd4919e3274bb3db93f646125996b0dbc65ecaa681bfcb7c4c8aecaa6816bf1868f8296e849b791129b27c7e30dca2e2b0362b3dc0a0a2c577e0bf294c9f928f93186992dcdad9e6d956e1c502c017250012866bd8ea0914646ab94cdc65d32a244267e8c4798ec73052da5717ed8ceb133caa27e325c59798ec73798ec73519a627fcd3c45cb84f060473162a54c280127a7dfefca3e5c4455ba06495c16f57139c7a311baf65f4fdb45acd1fb7149b781f61f69d25598e9109e95aee20dff27d4e6836e82cdcc8350ad3f19e49e7b1e6a2cf233f4a97fe8c222fe4b1479573af5f718fa7a17f0ca83e48c0381f48c88f1b1b897970688bd5f6ba943c6a931673f0e4994e71fbc8f4e619e26569293d568e6e075ab361499efc8f4e6152d1d91551b73404127c30fc6d3d0b0ad6298cfe6726bf2667d4e7e714f448e82f875d73562f6f130febaeabf3b36b3d91e3a24cf7e66b7d419b4142f24d6d7f8458e796ac6d5f222f39ba2084a72be87b341ff0aac139e147c55b722a38ba5cab96f1b941943ad1ffa99c7c13ae432ccf95f17dd76b39959f449402bee369b85985d36a66190ecee650fc2117adf778e6fd9e9836fe318c4cd76fbbb521828091c624d152db7e12d43866db3e7f23a487c35f5c2fcde209e693a0f4198b5e25f50a6442e726ffce65979955155e9fe4f13404db98b8b9b5bfce6290e0a24f9eb2de3b296e5461810c8b7c1d7ed9e109dc93d8453e00eaa4e0f528e334f2fc0456b85a218b80941dbca6a69728ead87c1cc9f9c3d21a04e33354ff0e04c2e3a047326e8dd8bdf4a1f2a8087817c95f8e64fc05f0ea40c676511922a14ff33d3dc3a2b00a54bafe3e6cd30222b10d7ff0b60ddf42b465517053d1782744bfbfcd8f348a589e5faa8d84bd0324eb8fb70f1246a9f22e9265467a98589711dcfbd73ba331c783dc1480dcab98fd83c3c1d8d28a12ad271195059aed9ddab4085ce84f2ed30c31e69d945fc6e04acb8a7b92b1d70a137296ddf242fe132787d4f6d161e4296ddf2a93ce76298ee72ca44fe22118135150b0d2bf94fb8603ec8de24b47547d850860cb2cab9785267f402c5c59e11f5eb003a8b1ae11f5df2d67991fd381d5186a3bb4b000c00558e1f264879f74c65ca97a45501725032cb614c05a15b4844c9f54c96833e5ba4676c3675e5c42b6a95349ade6b298aa4da4f189912f075cd00499c61899b158ee9ea5369bac0c45d0eaadbad2ba3ff515dac279fbd611056ec34912f075ef39edefe1f35d86fd5f912f075b994cc69e0912f075047287c5e8066743f03eeb06dec18cc756125d0c426a18726a6482aea44204e30e5f266ed9c1e7d9eff838079beef03761ede02877688c838ef8ae82b379ba294e15b770899f7e1835d86a17eeb437ba92c0e0b80cb561aadb18f83fac21803ce1eb756689c9cb1b0f50b1cd505c353706c580ee1372b3127359d65578b83ad7e5b219e4711bf34711bf30e58767b87ab5ed56ea73e8b47cbc2ffef0206e3df21ff43d1b174b5fdb0b7ac080d0323b7d0e9e6e740fa3265fe1f503740ccfd19a53338fc45e800e0cf9d50953b96a5f7e84985fa6bbc669e294b8a49e3463852b76fd4b587da3e2e05af6e1dfa8fd861c4bb0847b081519271a935385e2386b64e6c75924956c81bfe6a1d27269d6901510ed4e361159c055f99b3fe2aba8861b907d20a04f60411b995f91a5d44ed5d1443ea0fcfe1527e3b797bb0cf71f7f92180c338c68942bcc2d4fd417b8cf87ed647b16d0942edc7502373ca3a84637f9a8f1b60284c0a9fe7c38d3df4198f85d53f1a517a45badb98364bac2de11cfb37f9a8f2493c72742f190a9280daee209c04475ad323773808dca3b2dddb09af1b8df00abc61bb55cc6687d9bdbf73c98ee4fc0c1bc8165256bc2a72a499c24eb691fdd620a0e3a3dea574ec1c6459be8303df970f4ab6565107b1fce6499732b90701a445dab66e59a19cceb493e177639c4e0c652fb62095c66e0541612b9743e6219c6a9077100dfcd859d903b06d626ba27bb16e82be844c076359e57da8e53c3f7f72a258d24c90a1533f7a3133dae9c01f98046fa043795854fe57bc2278aa251ace2a7900762c90096f445efeec53c4e5fb84d213a89f50d9a0b4890a8407a9bfd9b63f1295c104ee612e600fb8b346e1e74a867b0e9cae6681a6a4354b33d1b82d1685b12a85639a93072a079c58e399a4671954e72e5c028751bd6d89c90fb16d85891b29122f5e16d6804ecc2581b14fd720a88115ae198d6237e441bc6e50f4f111b6fc4d01a8795f4475e58e14a9cf04aecfd5c29ec7a460526ee7451f661654f854fb41ab4b3c4b157c5d7a4cafad59efb0271ba2074440dd95a4e3db132ea56d298f95eaddd3a4121d7dd64d6f9d60cf785a8f6ee0420d3b5cf1ae5fc3679cd1687e6ea438bda85fdab5be8eeaf961c5f1b1c2f67fdb7c8683070132b911278f00eb00992954f11eadc93d5d1a522fe324858be0e9fb8aff4468e1cfb9ef6c5be1604a735ce06861888d47c462e32dd38618788245eab20747334ac0a86c10f174b0b2772ab80a4c56f083da32749c8e5304f72900d01b578612b37b713f5b350505daa9de78ac88e58bddde700c40cb4a0774d46381b2ccfb0ce8dfcf4b6dc48ebcb3927cb5f0c97219a38212707201d55e6370e39cdc0e982127077c8a5be2d67497e57a392f26adc2321395952075991dca0112c23294d6b3a5be3eaee24c072c94dc4e001a8d9e246a5570be692399fbaaa94e4f5a85bad388744bde614651564cf7f5f6943298c749ac46beeed0ac8e6dfe1b3193a886a165ffc74ad5d3090a17c99862c40878e4e32fab145bcd6e9df446655246f99ad7592ab424410fa4c75b298149a9152175e2f5734d2b5287955f034f9b46026480d06ba2d6a2caeb55b4310acd6b1e4430bb1c947e4f31e9ba0750b628bd325e413de49868525a40fab19f370ff5ff965a008a92e8165d39a1d4b5f37faf3b9c054f413795c618e99a10d6b36ca38cdce85bdfc790964ae49a99e728fed36b7d7bdd3c1d502a19848b58e47397cb0113a36b1cdeaef3c7b9811581498a48327fcc52fdd1f38c5c5a9e69589e32dbdf7b876def6caa9cfdf7750c123cdf8b2e4b79949fdc2cb529a8d2b435117db1f48e8add58ad36b359c3639918d16633dc8b09e4003463ff8e7abefdaac9d1a2bdd227255222580e9a1604b10e4c547f32f4f58d922f5ece3b1417955d15188583a2a66ea522bc546de5d1aca5ec2c1b53b398c99e5db43963f33b03b06df0ee7fa1ec056244e6da1661371e99e9a6e014c68edd1fea4b2a04bc54bb927f82ecf23daeda34ed6317e73b7f7d1cd7b95748d1b74fd54ae8b0c6c9e1c58bc5c1e119d48f22ec51155dc0e5415770d7a637cc7ceea5851608577e05d48f6d9f6f4c50721cdadcaf785addf642742678e0844acfc8ae26b45113b18b2d372e5b1120fac78d2b4cb6cc626e89c2616a81e063dd7d928460a10e0a1f94f3fb42fb705d21db1d193cb1a398cf0fccbfbb1c33243076da64cfe0250497211244e1727b3ee6102d15ad61aff5468efd5e2f382c5dd5f7240d6d00caed2001232a02117775d1a5cd89b8c36bdfff112feff66248ea3f6f12972bb69347d24a701bd60646c2966ae272fb79f6955ec92ae885d990b6e72605fc9e64cc98c81562d99f81b22480cff3fc8b5779140cd7c1d3bbc0059b03f208f1ac99c7dd3e305d690a8c3077f03f4d8f39200b0370d1e293b2303ed590e51c3fa51c9a29daf3cca8204f65d394cd2b3efcb909b848146dc2c16f95
2021-09-09 09:23:26 -07:00
Josh Bleecher Snyder
2a19333716
net: reduce allocations for UDP send/recv on Windows
...
This brings the optimizations added in CLs 331489 and 331490 to Windows.
Updates #43451
Change-Id: I75cf520050325d9eb5c2785d6d8677cc864fcac8
Reviewed-on: https://go-review.googlesource.com/c/go/+/331511
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2021-08-16 23:57:10 +00:00
Josh Bleecher Snyder
9c5eb16f6c
net: reduce allocation size in ReadFromUDP
...
Switch to concrete types. Bring your own object to fill in.
Allocate just enough for the IP byte slice.
The allocation is now just 4 bytes for IPv4,
which puts it in the tiny allocator, which is much faster.
name old time/op new time/op delta
WriteToReadFromUDP-8 13.7µs ± 1% 13.4µs ± 2% -2.49% (p=0.000 n=10+10)
name old alloc/op new alloc/op delta
WriteToReadFromUDP-8 32.0B ± 0% 4.0B ± 0% -87.50% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
WriteToReadFromUDP-8 1.00 ± 0% 1.00 ± 0% ~ (all equal)
Windows is temporarily stubbed out.
Updates #43451
Change-Id: Ief506f891b401d28715d22dce6ebda037941924e
Reviewed-on: https://go-review.googlesource.com/c/go/+/331490
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
2021-08-16 23:57:02 +00:00
Josh Bleecher Snyder
d9349175ad
net: remove allocation from UDPConn.WriteTo
...
Duplicate some code to avoid an interface.
name old time/op new time/op delta
WriteToReadFromUDP-8 6.38µs ±20% 5.59µs ±10% -12.38% (p=0.001 n=10+9)
name old alloc/op new alloc/op delta
WriteToReadFromUDP-8 64.0B ± 0% 32.0B ± 0% -50.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
WriteToReadFromUDP-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=10+10)
Windows is temporarily stubbed out.
Updates #43451
Change-Id: Ied15ff92268c652cf445836e0446025eaeb60cc9
Reviewed-on: https://go-review.googlesource.com/c/go/+/331489
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2021-08-16 23:54:32 +00:00
Ian Lance Taylor
48c88f1b1b
reflect: add Value.CanConvert
...
For #395
For #46746
Change-Id: I4bfc094cf1cecd27ce48e31f92384cf470f371a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/334669
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
2021-07-21 19:25:48 +00:00
Russ Cox
877688c838
testing: add TB.Setenv
...
For #41260 and #46688 .
Change-Id: I6f42742cc3234a90003136ae8798a6b0e1291788
Reviewed-on: https://go-review.googlesource.com/c/go/+/326790
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-07-01 18:35:33 +00:00
Nigel Tao
d19a53338f
image: add Uniform.RGBA64At and Rectangle.RGBA64At
...
These types already implemented the Image interface. They should also
implement the RGBA64Image interface (new in Go 1.17)
Updates #44808
Change-Id: I9a2b13e305997088ae874efb95ad9e1648f94812
Reviewed-on: https://go-review.googlesource.com/c/go/+/331570
Trust: Nigel Tao <nigeltao@golang.org>
Run-TryBot: Nigel Tao <nigeltao@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2021-06-30 02:00:49 +00:00
Michael Anthony Knyszek
Russ Cox
Bryan Mills
Carl Johnson
Ian Lance Taylor
Joe Tsai
Roland Shoemaker
Eli Bendersky
Dmitri Shuralyov
Xiaodong Liu
Than McIntosh
Emmanuel T Odeke
Patrick Gundlach
Robert Griesemer
Cherry Mui
Josh Bleecher Snyder
Jay Conrod
John Kelly
Michael Pratt
Nigel Tao