Jay Conrod
51ca5706ab
[dev.fuzz] cmd/go: in 'go test' don't allow multiple packages with -fuzz
...
Until we have a system for managing load across multiple fuzz targets
in multiple test executables, we'll only support fuzzing one target in
one package at a time. Users can still run multiple 'go test -fuzz'
commands concurrently, but this may overwhelm some systems unless
-parallel and -p are set carefully.
For #46312
Change-Id: If84c58d1b3e60498ce955eae5ad4d52100dbd4b7
Reviewed-on: https://go-review.googlesource.com/c/go/+/350156
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-09-20 18:42:32 +00:00
Katie Hockman
24e25afff4
[dev.fuzz] Revert "[dev.fuzz] testing: convert seed corpus values where possible"
...
This reverts commit 413c125da3golang/go#45593
Change-Id: I79bab24979d7e4c294e6cb6455d4c7729d6a0efb
Reviewed-on: https://go-review.googlesource.com/c/go/+/350251
Trust: Katie Hockman <katie@golang.org>
Trust: Joe Tsai <joetsai@digital-static.net>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Joe Tsai <joetsai@digital-static.net>
2021-09-20 17:18:57 +00:00
Katie Hockman
5e9c1fedb6
[dev.fuzz] internal/fuzz: warn if fuzzing begins with empty corpus
...
Fixes golang/go#46219
Change-Id: I7b32707d490c046d15324a3d297ec8d9f45b6e36
Reviewed-on: https://go-review.googlesource.com/c/go/+/350269
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-20 16:59:51 +00:00
Katie Hockman
5ed7dd0650
[dev.fuzz] internal/fuzz: rework default test behavior before fuzzing
...
This change refactors some of the code to support skipping a run
of the seed corpus by the go command before runFuzzing occurs.
Previously, the go command would run all seed corpus for all targets
that match the provided `run` argument. This will be redundant when
fuzzing a target. Now, the seed corpus is only run by targets other than
the one that's about to be fuzzed, and the worker handles running and
reporting issues with the seed corpus.
Part of the logic that needed close inspection is what to do if a
failure occurs during a testing-only or coverage-only fail. If the input
is already in the seed corpus, the fuzzing engine shouldn't add it. If
the input is currently in the cache, then it should be written to
testdata. In all cases, if an error occurs, we need to report this to
the user with enough information for them to debug it.
This uncovered some issues with our code when fuzzing without
instrumentation, and when -run=None was provided. There are some logic
fixes in this change, and some small refactors.
Fixes golang/go#48327
Fixes golang/go#48296
Change-Id: I9ce2be0219c5b09277ddd308df8bc5a46d4558fa
Reviewed-on: https://go-review.googlesource.com/c/go/+/349630
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-16 13:37:34 +00:00
Jay Conrod
4304cf62e9
[dev.fuzz] testing: fix internal error exit condition for fuzz workers
...
A fuzz worker process should exit with fuzzWorkerExitCode (70) if it
encounters an internal error.
This should generally only happen due to an I/O error on the worker
side. I can't think of a way to write a realistic test case for
this. test_fuzz_io_error.txt triggers an I/O error on the coordinator
side, which is similar.
Change-Id: I40d2e9aaf422e5ed925debcf7a152c252c3a6984
Reviewed-on: https://go-review.googlesource.com/c/go/+/349993
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-09-15 20:08:50 +00:00
Katie Hockman
f53b61d387
[dev.fuzz] internal: fuzzing output adjustments
...
Print the elapsed time as a nicely formatted duration, and
make small adjustments to the command line output while fuzzing.
Fixes golang/go#48132
Change-Id: Id95f84c0939171a777448c444d9b87d7af26b654
Reviewed-on: https://go-review.googlesource.com/c/go/+/349970
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-15 19:11:17 +00:00
Katie Hockman
739a42c199
[dev.fuzz] testing: adjust -fuzz multiple match stdout
...
Fixes golang/go#48131
Change-Id: I40ff130c849dffe38363ddc0282e93ceb74ae140
Reviewed-on: https://go-review.googlesource.com/c/go/+/349969
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-15 18:52:34 +00:00
Jay Conrod
c8dfa306ba
[dev.fuzz] testing: F.Setenv plus various fixes and revisions
...
I spent some time looking through all the changes we've made to
testing and cmd/go/... on the dev.fuzz branch. CL 348469 shows those
differences. This CL fixes comments, TODOs, and simplifies code in a
few places. It also implements F.Setenv.
Change-Id: I6fd7ef5fbd0bb6055e38d56cb42bddcf6f4ffdaf
Reviewed-on: https://go-review.googlesource.com/c/go/+/349109
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-09-10 21:28:48 +00:00
Katie Hockman
17f62c0ac3
[dev.fuzz] internal/fuzz: fix bug for -fuzzminimizetime of zero
...
Updates golang/go#48321
Change-Id: Ib35388f17580f1244a6eae4e5879f8329b6b44ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/349090
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-10 20:17:28 +00:00
Katie Hockman
d106089fa6
[dev.fuzz] internal/fuzz: write a newline to the end of a corpus file
...
If someone manually adds/alters a corpus file to add
extra spacing or remove the final newline, the file
can still be decoded. However, this change ensures that
the fuzzing engine correctly writes the final newline.
Fixes golang/go#48130
Change-Id: Ib5556d4a6e4e0bfd9bc2edab357b7c25bedfd176
Reviewed-on: https://go-review.googlesource.com/c/go/+/349055
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-10 19:27:54 +00:00
Katie Hockman
363f2f3df9
[dev.fuzz] testing: allow -fuzzminimizetime to be 0
...
Fixes golang/go#48321
Change-Id: I1547379eb7a703f7f3c4594d27833eb3587796a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/349089
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-10 17:46:52 +00:00
Katie Hockman
b38e853d04
[dev.fuzz] testing: move corpus from testdata/corpus to testdata/fuzz
...
Fixes golang/go#48128
Change-Id: I04deb17226ff5d5dfcbe408fe089f400d4d3836f
Reviewed-on: https://go-review.googlesource.com/c/go/+/349053
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-10 15:20:44 +00:00
Katie Hockman
213d9f9a38
[dev.fuzz] internal/fuzz: improve warning message when not instrumented
...
Change-Id: I005f66c965014b699de7e22750f417b28a32c03f
Reviewed-on: https://go-review.googlesource.com/c/go/+/349052
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-10 15:20:38 +00:00
Katie Hockman
7c648e2acb
[dev.fuzz] internal/fuzz: avoid incorrect bytes modification during minimization
...
During minimization, the "canonical inputs" (vals) are updated
as viable minimized values are found. Previously, these bytes
could be changed later during minimization. This patch updates
the minimization code to revert the bytes back when a candidate
doesn't pass the minimization checks.
Another approach was in CL 340630 which would make a new allocation
each time a candidate was attempted. This will get very expensive
very quickly, as minimization can run several thousand times for every
new crash and every newly discovered interesting input.
Credit to Steven Johnstone (steven.james.johnstone@gmail.com ) for the
"single_bytes" test which was added to minimize_test.go.
Fixes golang/go#47587
Change-Id: Ibd12f73458ed812bab7d3f1d4118854a54fc4d0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/348610
Trust: Katie Hockman <katie@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-09 17:28:03 +00:00
Jay Conrod
5abfd2379b
[dev.fuzz] all: merge master ( 65f0d24) into dev.fuzz
...
Conflicts:
- api/next.txt
- src/cmd/go/alldocs.go
- src/cmd/go/internal/test/test.go
Merge List:
+ 2021-09-08 65f0d24f7337c9552e06c8d4fe2adcd419f9c61212eb7331b938c2e08cbdcb9ccd494ba1a6540bf1409434d623054710ce4673a062c3e79581d891ab82142573471da64686f8fdc207242064bdad2011929572307950c69cc3a9c50d811c7af030043e37da790cccc5f5bdbf311cbab79dd362963218cc9c3fff213ac2b606739be6b5e33a50fe07f623063da9a01a3fbddcf354577480783558b023f4f0db68d92101f452903958d2f56640171914e581ec07ee81188661f12a4845257fbca8c6ffa221de6bc4636226020c2fa1938435d620a71c9a1decfff58fb8c7f09eeb137b69ddc17143b05173a27619a4528d1b2d794ca39133245be728dae3defb37e9c1d6fe2d90df91a85c224ec921ba66d62b685ec298d7b00b663109248a01010c269cb5716f004957976b1ad9244f8b6404d8d2496052aef05498ab7c904bf217910ed4ff9f69a44308065f380815a8aa6cfa6d58244eee019633195ae17609b50701acc2957bc92a463a22ceead3fe0dba08588e6036d01388b04f782aa42255d8b156773c014a9720f937d45328674fb79569d2b8420baf464591f49938a35c5c98c090ed54114969107e73ce08e2519ded6705191e0217e9d148d3d13d62c49a840b4292c91ae7ddc2353db4888a059afbf826671bd35fab05df4c625d882872496ba50bfd6fcea688859f3cd850f38d04055e0f8edbdcea51e223c2711e1c8224592ee433f56c5f0282428f397bc1185670ff4ae5717f337d1d5a687eeaf1faf9c7d8fe2dd7b770de62ba72b353f4e24599dd36ac2214fa1a9807906d5cd1b847dc0df6df17e13c8c9e1e442d98a4b4bcb2f09cd7175e9ba0b1bd580987cd58d15a75e0701f83a8c16cbb0b5117387637345b6e78d0f8c870ae2b2dc01ab93581e47daed59d172a891470fbf746121306d3144e0b1f6ef27d6a23b068152359fd605d1aaea2ded10d75a93920d6f208f118d145a5d384ebde607622e41c843342aa5f51b06cfe9b25437362ccec86fa510d248f4c0206608250141c9a5f0d821add61120c634caf9009a9899da7ccab58bdc1bef8a0b602daea1b7b38dd8e2556c3856d5221d0b306afa29d9aad7af29abccd8af4cd001b576df3aac4ae5afa555428d7a43e8912044550ab0e010817714ef371b30f32ef4cb2f7765fb177163bc81fa001a7a9377183d082efc0540368ecdc2c7072c003ef8294f2a039516a35e075124f0dedca7139eb1cc3f4acdea4f9f7220bc44220bc44a4c67f7e1667f7e16bcc2c60a99f72d350a66532d7e2e2ec2bc92759978362f88b6dc8e7eee5e265f153b6739b967a8017f7af80af22b503db2c2413c9e05fdcf7eb6a07fcf938369837791f8d4562dede83ef67ac5e6a7e95e6a7e9b86166b691b65d6bdae33e9770df2e18da6ff433d6a4f2620285d0ac64f6d704068fb6c21bf0bc4122f4158e88f64647bef6c596cf1d5d0fa5baf60d4723d667671ad4f2ebfe34bd2f002cb39de23549a393b523caf4108d4cc20ca109c13b64fc2f96e6099b819085e1fcf8857ed37b8dedf741b99dab0fde1c934b9754cdef1f105d863f89fec2f96e686f5b643811554a9f0cec29daa55b21d1e6798795ffb1cdf860dd1ff0554b53bd97763577bba460499cd70c69d830f98b6111eb8eeb1bff1dbe1a6934778157960d7f22540abf76fa34678c670a7f00ae236b9e3f883e3081f817da8486ced8b0aeec6dbfe0f457ecc7f0f1d8ea1da34fbb5c86667a6d64fed624386606029fe5c7f122baf2866956c7e354d9d1c1a14781ec457418b47586ee89225a29d7e5472b8fcc6143605d5e50c3db5d0c2840da19585826fa6416bde023bd6845965c96d816c5746e50991d2a8fff20ffebbcd146d398dcee007aade17439e087c9912780ab97d17dc023835ff47c16f67e31d643ab9aaf46ee5045477be80f2525112730a423eb39e49775e0574d00fcbc43bacbc334397007431374303446395de9e0d1ef70c92c2c9d6265074a40860e598e7da491e2e3b9039871726c7269d8fbec7a3bdc1799d6740f7d7370c85695a117322879d5c9687f2acf6aeda3de0f79805d38a352c2bd9ee2db8f0578ef39165ebd85a74a0fd73ead0c83e01e0c8b471db71b946e2543f88e18428e38aef24d8f7dddfcc02352a2a9a7b5133848488f0face1730a410f85b0c0e19d9e3291facf12b0d1f93001b0abf04012fea822b7b790a71aa304273d74d3deb2c35929ec74fb8291a935ea0fa8d39f151d1951afc9192a193337169c5eb16f6cd9349175ad8ff16c1990df9c5d8f5d213e157d3ac04a32e59a6406227d71a05a7d49a954ce8793a8742dcba7bb41d991e4e144661418228d2066177dec27168712d35035f84eddffe30a21631af58e20d1ba047edf56a919f17fff36d114702460cf8602281ed619f8aab1d1fcb99ff61acbd7fda8ee8b07e61d1445ab5c7a460a1c850768bbc9a0adf91d855a40100141c92f5ee1705da2010840ea8298e2f5fe489c86a7b9f135d98fc2b4ec8f4911a43df461b0fba64ef4efd206eb407b7d7d781802f932e173a192ef8ac411a1f37b070b61dc4577c88e3ff648d043c8ea8994002f6fca3d679c6554fcdc3c098c160d7972606a760d6c367aa57a968757c115e1f6717894cf806ed946313348dfddbab31162aae0adff3469b1c20a0a160d4d49c688e45cb2253c8041456759b2462d250043b450f4ebbdd3fc27eb50ff7eaabae84d58490972c0a95f1b51be89a4f996402eb4d68833bad1fc1265641e8bc2c798f3d7fecb20a620fd9f4c8ffb3baa4be75faa3e1fffeddfe9e2e1987b310d019340944d3cc84044ec4fa983601aedff64d3cc844d3cc8477446fd547a64ab8d3ec46fd5477e9f911ec446fd547d895805efc78e39634e7daed397fc1169095bb790e1677dfe5ad6dea23e9ca88ab59d812aaaf914d0e6d7d4f28a06eeb7899137d4c0ed26ac0888a8cd2d7308d747e70f34a92df740ba119e3ffb8579746c2e250cc957337cebd2c12fbf6aafe7e4cfa2f6da508624f3591f9c9d8530f5f79c47f9f1dce319ff9f4d6a8359ca3c6985cd57668b84ff7aeaad5c86507cc341ecd10a904712891547e2d43025ce2fa88eaf4d16bcfc8e0cbbba63b968f4f89e0ac72d689bd1817e41313924f2720d7dc417ea09d82689ed3a9fd99849c3b57af8bc081110867093285c89d15aac85ad5e110343e4a25e33d11e10ac78501b9c70546f6404fd45e267c2f78d538858c5b6c36dddf14908d01bbb5608dd5d6dadee759c5dcb5e2cea3cdf8b429e1b708c02600ec2a8b42de5fe769be1b730a26729e590cb64f96e738868a7d27a889119b01e775e9c3efc8f9a8ded3667d079880ab6209e5b51cf47dce0d090721218e050372489897473e21ea3596b4188bd92bb6d1a0630aef4077925e2b07ab8754029fe73f28dc5656f0888b71b193598b3e56234a305c3c19731a9156eeb40a68a7ee4c51e283991bd7faa3d54da07b8ca6e59ed0b8a9ccb253799012990b3b53e1dad47694b59eb90830699ae7bed50e667e3e9f0bb2d8e2ab05dd39eee0ed40e561d933fd0011dca553fd5b1b77ea94e5d3c552e970b1c83a69cef65a137089ffb9b7a85e00034480e3b11a27283d208f3e7571f6ff1d35d8ffa535dbdda2fe600b7b431b5ecbd811b546cc68638127552e9172af903261e7c079b6baaaff0c0dbca62fa8f00915f4f503e0a370fd4e47d74a47e40a14506fd520d5adedf54288535575300947cdfa95ae9eee0ed9eee0ed439473e493d18176baafd5b288a83dcffb39e0f461ce00a6ec0842c8acf63c272233d27c47cd10c1149b2205eab0ef05f5ceffac751e2e6bac8cf0f74e45d8f90f904cb14e673ec7ba8e796c933ff155970840e583ff3bfbb2885749c81fd53b37ce257147f3cd15e02ed37d2219960d6753fd4919e3274bb3db93f646125996b0dbc65ecaa681bfcb7c4c8aecaa6816bf1868f8296e849b791129b27c7e30dca2e2b0362b3dc0a0a2c577e0bf294c9f928f93186992dcdad9e6d956e1c502c017250012866bd8ea0914646ab94cdc65d32a244267e8c4798ec73052da5717ed8ceb133caa27e325c59798ec73798ec73519a627fcd3c45cb84f060473162a54c280127a7dfefca3e5c4455ba06495c16f57139c7a311baf65f4fdb45acd1fb7149b781f61f69d25598e9109e95aee20dff27d4e6836e82cdcc8350ad3f19e49e7b1e6a2cf233f4a97fe8c222fe4b1479573af5f718fa7a17f0ca83e48c0381f48c88f1b1b897970688bd5f6ba943c6a931673f0e4994e71fbc8f4e619e26569293d568e6e075ab361499efc8f4e6152d1d91551b73404127c30fc6d3d0b0ad6298cfe6726bf2667d4e7e714f448e82f875d73562f6f130febaeabf3b36b3d91e3a24cf7e66b7d419b4142f24d6d7f8458e796ac6d5f222f39ba2084a72be87b341ff0aac139e147c55b722a38ba5cab96f1b941943ad1ffa99c7c13ae432ccf95f17dd76b39959f449402bee369b85985d36a66190ecee650fc2117adf778e6fd9e9836fe318c4cd76fbbb521828091c624d152db7e12d43866db3e7f23a487c35f5c2fcde209e693a0f4198b5e25f50a6442e726ffce65979955155e9fe4f13404db98b8b9b5bfce6290e0a24f9eb2de3b296e5461810c8b7c1d7ed9e109dc93d8453e00eaa4e0f528e334f2fc0456b85a218b80941dbca6a69728ead87c1cc9f9c3d21a04e33354ff0e04c2e3a047326e8dd8bdf4a1f2a8087817c95f8e64fc05f0ea40c676511922a14ff33d3dc3a2b00a54bafe3e6cd30222b10d7ff0b60ddf42b465517053d1782744bfbfcd8f348a589e5faa8d84bd0324eb8fb70f1246a9f22e9265467a98589711dcfbd73ba331c783dc1480dcab98fd83c3c1d8d28a12ad271195059aed9ddab4085ce84f2ed30c31e69d945fc6e04acb8a7b92b1d70a137296ddf242fe132787d4f6d161e4296ddf2a93ce76298ee72ca44fe22118135150b0d2bf94fb8603ec8de24b47547d850860cb2cab9785267f402c5c59e11f5eb003a8b1ae11f5df2d67991fd381d5186a3bb4b000c00558e1f264879f74c65ca97a45501725032cb614c05a15b4844c9f54c96833e5ba4676c3675e5c42b6a95349ade6b298aa4da4f189912f075cd00499c61899b158ee9ea5369bac0c45d0eaadbad2ba3ff515dac279fbd611056ec34912f075ef39edefe1f35d86fd5f912f075b994cc69e0912f075047287c5e8066743f03eeb06dec18cc756125d0c426a18726a6482aea44204e30e5f266ed9c1e7d9eff838079beef03761ede02877688c838ef8ae82b379ba294e15b770899f7e1835d86a17eeb437ba92c0e0b80cb561aadb18f83fac21803ce1eb756689c9cb1b0f50b1cd505c353706c580ee1372b3127359d65578b83ad7e5b219e4711bf34711bf30e58767b87ab5ed56ea73e8b47cbc2ffef0206e3df21ff43d1b174b5fdb0b7ac080d0323b7d0e9e6e740fa3265fe1f503740ccfd19a53338fc45e800e0cf9d50953b96a5f7e84985fa6bbc669e294b8a49e3463852b76fd4b587da3e2e05af6e1dfa8fd861c4bb0847b081519271a935385e2386b64e6c75924956c81bfe6a1d27269d6901510ed4e361159c055f99b3fe2aba8861b907d20a04f60411b995f91a5d44ed5d1443ea0fcfe1527e3b797bb0cf71f7f92180c338c68942bcc2d4fd417b8cf87ed647b16d0942edc7502373ca3a84637f9a8f1b60284c0a9fe7c38d3df4198f85d53f1a517a45badb98364bac2de11cfb37f9a8f2493c72742f190a9280daee209c04475ad323773808dca3b2dddb09af1b8df00abc61bb55cc6687d9bdbf73c98ee4fc0c1bc8165256bc2a72a499c24eb691fdd620a0e3a3dea574ec1c6459be8303df970f4ab6565107b1fce6499732b90701a445dab66e59a19cceb493e177639c4e0c652fb62095c66e0541612b9743e6219c6a9077100dfcd859d903b06d626ba27bb16e82be844c076359e57da8e53c3f7f72a258d24c90a1533f7a3133dae9c01f98046fa043795854fe57bc2278aa251ace2a7900762c90096f445efeec53c4e5fb84d213a89f50d9a0b4890a8407a9bfd9b63f1295c104ee612e600fb8b346e1e74a867b0e9cae6681a6a4354b33d1b82d1685b12a85639a93072a079c58e399a4671954e72e5c028751bd6d89c90fb16d85891b29122f5e16d6804ecc2581b14fd720a88115ae198d6237e441bc6e50f4f111b6fc4d01a8795f4475e58e14a9cf04aecfd5c29ec7a460526ee7451f661654f854fb41ab4b3c4b157c5d7a4cafad59efb0271ba2074440dd95a4e3db132ea56d298f95eaddd3a4121d7dd64d6f9d60cf785a8f6ee0420d3b5cf1ae5fc3679cd1687e6ea438bda85fdab5be8eeaf961c5f1b1c2f67fdb7c8683070132b911278f00eb00992954f11eadc93d5d1a522fe324858be0e9fb8aff4468e1cfb9ef6c5be1604a735ce06861888d47c462e32dd38618788245eab20747334ac0a86c10f174b0b2772ab80a4c56f083da32749c8e5304f72900d01b578612b37b713f5b350505daa9de78ac88e58bddde700c40cb4a0774d46381b2ccfb0ce8dfcf4b6dc48ebcb3927cb5f0c97219a38212707201d55e6370e39cdc0e982127077c8a5be2d67497e57a392f26adc2321395952075991dca0112c23294d6b3a5be3eaee24c072c94dc4e001a8d9e246a5570be692399fbaaa94e4f5a85bad388744bde614651564cf7f5f6943298c749ac46beeed0ac8e6dfe1b3193a886a165ffc74ad5d3090a17c99862c40878e4e32fab145bcd6e9df446655246f99ad7592ab424410fa4c75b298149a9152175e2f5734d2b5287955f034f9b46026480d06ba2d6a2caeb55b4310acd6b1e4430bb1c947e4f31e9ba0750b628bd325e413de49868525a40fab19f370ff5ff965a008a92e8165d39a1d4b5f37faf3b9c054f413795c618e99a10d6b36ca38cdce85bdfc790964ae49a99e728fed36b7d7bdd3c1d502a19848b58e47397cb0113a36b1cdeaef3c7b9811581498a48327fcc52fdd1f38c5c5a9e69589e32dbdf7b876def6caa9cfdf7750c123cdf8b2e4b79949fdc2cb529a8d2b435117db1f48e8add58ad36b359c3639918d16633dc8b09e4003463ff8e7abefdaac9d1a2bdd227255222580e9a1604b10e4c547f32f4f58d922f5ece3b1417955d15188583a2a66ea522bc546de5d1aca5ec2c1b53b398c99e5db43963f33b03b06df0ee7fa1ec056244e6da1661371e99e9a6e014c68edd1fea4b2a04bc54bb927f82ecf23daeda34ed6317e73b7f7d1cd7b95748d1b74fd54ae8b0c6c9e1c58bc5c1e119d48f22ec51155dc0e5415770d7a637cc7ceea5851608577e05d48f6d9f6f4c50721cdadcaf785addf642742678e0844acfc8ae26b45113b18b2d372e5b1120fac78d2b4cb6cc626e89c2616a81e063dd7d928460a10e0a1f94f3fb42fb705d21db1d193cb1a398cf0fccbfbb1c33243076da64cfe0250497211244e1727b3ee6102d15ad61aff5468efd5e2f382c5dd5f7240d6d00caed2001232a02117775d1a5cd89b8c36bdfff112feff66248ea3f6f12972bb69347d24a701bd60646c2966ae272fb79f6955ec92ae885d990b6e72605fc9e64cc98c81562d99f81b22480cff3fc8b5779140cd7c1d3bbc0059b03f208f1ac99c7dd3e305d690a8c3077f03f4d8f39200b0370d1e293b2303ed590e51c3fa51c9a29daf3cca8204f65d394cd2b3efcb909b848146dc2c16f95
2021-09-09 09:23:26 -07:00
Jay Conrod
f4f137a143
[dev.fuzz] internal/fuzz: only reconstruct inputs when needed on RPC return
...
If the fuzz RPC finds no error and no new coverage, there's no point
in reconstructing the last value.
If the minimize RPC does not succeed in minimizing, either because the
error can't be reproduced, or new coverage can't be reproduced, or a
new error is found with the input, don't marshal or unmarshal the
input. Just use the original.
Change-Id: I3b0f89b8656a2b36066d82efefac0fff4a61fbee
Reviewed-on: https://go-review.googlesource.com/c/go/+/347233
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-09-08 19:40:25 +00:00
Katie Hockman
e9674e553c
[dev.fuzz] internal/fuzz: fix panic when marshaling data
...
The coordinator needs to marshal data that was provided
via f.Add. However, it was also attempting to marshal data
that was in testdata, which was not needed,
and was causing a panic. This change fixes this.
Fixes golang/go#48228
Change-Id: I1256c5a287b5a09d2f8cca59beb0f0fc06cc3554
Reviewed-on: https://go-review.googlesource.com/c/go/+/348381
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-08 19:16:20 +00:00
Michael Matloob
65f0d24f73
cmd/go: print offending -mod value in workspace mode
...
Workspace mode only allows -mod to be set to 'readonly'. When returning
the error for other values of -mod, specify the the value in the error
so it's easier to see what's going on when the go command is invoked
through another tool.
For #45713 , #48186
Change-Id: I3ba206a71c7a20c18aeccfa48f3c9dc935a180a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/347593
Trust: Michael Matloob <matloob@golang.org>
Trust: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
2021-09-08 18:48:02 +00:00
Michael Matloob
37c9552e06
cmd/go: improve the creation and editing of go.work files
...
This change changes go.work files so that directory paths are clearly
distinguished from module paths by either being rooted absolute paths or
starting with '.' or '..' path elements if they are relative paths.
go mod initwork now checks that the go.work file doesn't already exist
before creating it, and gomod initwork and gomod editwork look up the
module path corresponding to a directory and write it to the directory
directive's comment.
For #45713
Change-Id: I6983779059b7de6fc83d359280ceffb263f6b641
Reviewed-on: https://go-review.googlesource.com/c/go/+/347591
Trust: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-08 18:47:32 +00:00
Robert Findley
c8d4fe2adc
go/types: temporarily pin the Checker to Interface during checking
...
While type checking expressions involving interface types, it is
possible that their type set is used before delayed actions are
processed. As a result, computeInterfaceTypeSet is called with a nil
checker, and errors in the interface type definition result in panics
(see #48234 ).
To avoid the panics, store a *Checker on Interface for use in between
checking of the interface type expression and processing of delayed
actions.
Fixes #48234
Change-Id: I5509bc1c01b55edac52446b9e075fbe8fcc01874
Reviewed-on: https://go-review.googlesource.com/c/go/+/348371
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-09-08 17:35:45 +00:00
Robert Findley
d419f9c612
go/types: spell out 'Type' in type parameter APIs
...
As discussed on the go/types proposal (#47916 ), we should spell out the
word 'Type', rather than using 'T'.
Change-Id: I5f51255eedc07fea61f909b7ecb3093a7fab765e
Reviewed-on: https://go-review.googlesource.com/c/go/+/348376
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 16:59:47 +00:00
Robert Findley
12eb7331b9
go/ast: rename TParams fields to TypeParams
...
As discussed in the ast proposal (#47781 ), there's not really a strong
reason to avoid spelling out 'Type'.
Change-Id: I0ba1bf03b112ea60509a78a89a050a302779d9d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/348375
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 16:59:04 +00:00
Robert Findley
38c2e08cbd
go/types: move NewTypeParam off of Checker
...
This aligns with the API proposal.
Change-Id: I9967a317196392ffa5ddbe5391d7aba5f6e7bad2
Reviewed-on: https://go-review.googlesource.com/c/go/+/347561
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-09-08 16:32:00 +00:00
Robert Findley
cb9ccd494b
go/types: move typeHash to environment.go
...
This is a pure code move, with no other changes.
Change-Id: Id31f1f960d3208dc614556de89bf39b7ca77df3a
Reviewed-on: https://go-review.googlesource.com/c/go/+/347560
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-09-08 16:31:42 +00:00
Robert Findley
a1a6540bf1
go/types: implement deduplication of instances using the Environment
...
Implement deduplication of type instances via the Environment by
recording a map of unique IDs for *Named types. This avoids an issue
with the existing type hash, where qualified names alone were not
sufficient to differentiate two *Named types that have the same fully
qualified name but which are distinct pointers. It also allows us to
drop the scope accounting for local types.
A subtle bug is also fixed in subst.go, where the instance t was passed
to typeHash rather than t.orig.
Change-Id: I85639ccc1c9bfee470babd2fc85375484c8ed0b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/344390
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-09-08 16:31:21 +00:00
Bryan C. Mills
409434d623
cmd/go/internal/modload: scan dependencies of root paths when raising version limits in editRequirements
...
Fixes #47979
Change-Id: I1d9d854cda1378e20c70e6c6789b77e42e467ca7
Reviewed-on: https://go-review.googlesource.com/c/go/+/347290
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-09-08 16:19:36 +00:00
Robert Griesemer
054710ce46
cmd/compile/internal/types2: reduce number of delayed functions (optimization)
...
Rather than create and delay execution of a closure for each type parameter
in a type parameter list, just create one per type parameter list.
While at it, inline the small amount of code for getting the type constraint
and remove the respective function.
Change-Id: I49a00ff0a7b7e43eb53992dd7dbfac25ff23b42c
Reviewed-on: https://go-review.googlesource.com/c/go/+/348018
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2021-09-08 15:51:14 +00:00
Robert Griesemer
73a062c3e7
cmd/compile/internal/types2: handle recursive type parameter constraints
...
Check type constraints after the respective type parameter list
has been associated with a parameterized type so that recursive
type parameter constraints "see" a parameterized type.
Fixes #45550 .
Fixes #47796 .
Change-Id: Iac74610ca017a78013820624230c857395506aff
Reviewed-on: https://go-review.googlesource.com/c/go/+/348090
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2021-09-08 15:51:08 +00:00
Dmitri Shuralyov
9581d891ab
cmd/pprof: update vendored github.com/google/pprof
...
Pull in the latest published version of github.com/google/pprof
that is available at this time in the Go 1.18 development cycle.
Done with:
go get -d github.com/google/pprof@latest
go mod tidy
go mod vendor
For #36905 .
Change-Id: Ib25aa38365ec70a0bed2a8a6527e5823ab9f9ded
Reviewed-on: https://go-review.googlesource.com/c/go/+/348410
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
2021-09-08 15:36:36 +00:00
Michael Munday
8214257347
test/codegen: fix package name for test case
...
The codegen tests are currently skipped (see #48247 ). The test
added in CL 346050 did not compile because it was in the main
package but did not contain a main function. Changing the package
to 'codegen' fixes the issue.
Updates #48247 .
Change-Id: I0a0eaca8e6a7d7b335606d2c76a204ac0c12e6d5
Reviewed-on: https://go-review.googlesource.com/c/go/+/348392
Trust: Michael Munday <mike.munday@lowrisc.org>
Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 14:51:40 +00:00
Michael Munday
1da64686f8
test/codegen: fix compilation of bitfield tests
...
The codegen tests are currently skipped (see #48247 ) and the
bitfield tests do not actually compile due to a duplicate function
name (sbfiz5) added in CL 267602. Renaming the function fixes the
issue.
Updates #48247 .
Change-Id: I626fd5ef13732dc358e73ace9ddcc4cbb6ae5b21
Reviewed-on: https://go-review.googlesource.com/c/go/+/348391
Trust: Michael Munday <mike.munday@lowrisc.org>
Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2021-09-08 14:51:31 +00:00
Michael Munday
fdc2072420
test/codegen: remove broken riscv64 test
...
This test is not executed by default (see #48247 ) and does not
actually pass. It was added in CL 346689. The code generation
changes made in that CL only change how instructions are assembled,
they do not actually affect the output of the compiler. This test
is unfortunately therefore invalid and will never pass.
Updates #48247 .
Change-Id: I0c807e4a111336e5a097fe4e3af2805f9932a87f
Reviewed-on: https://go-review.googlesource.com/c/go/+/348390
Trust: Michael Munday <mike.munday@lowrisc.org>
Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 14:51:22 +00:00
Dmitri Shuralyov
64bdad2011
all: update vendored golang.org/x/tools
...
Now that issue #48124 is resolved, ran the
following commands inside the cmd module:
go get -d golang.org/x/tools@36045662144327e4475f9d356f49ab32ce730049 # main branch
go mod tidy
go mod vendor
For #36905 .
Updates #48124 .
Change-Id: I9dc736c2c5256f7d9e80fd9c52c6725ecf0b8001
Reviewed-on: https://go-review.googlesource.com/c/go/+/348409
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
2021-09-08 14:25:12 +00:00
Paul E. Murphy
9295723079
cmd/link: rework .TOC. handling for ppc64le
...
Setup .TOC. to point to the same place for all objects. Today, the linker
assumes all call relocations can use the local function entry point of
imported object files. This requires a consistent pointer across all
objects.
This intentionally computes the .TOC. pointer in all linking configurations.
In some cases the .TOC. is not used today (e.g linking position-dependent go
only code). It is harmless and simple to compute in all cases, so just
do it for easier maintenance.
Notably, .TOC. is used in some cases when static linking is requested on
ppc64le/linux:
* Position-independent C code using a PC-rel relocation against .TOC.. cgo
generated C object files are usually compiled PIC even if the go binary
itself is not.
* Anything which causes PLT stub generation. The stubs always generate
a .TOC. relative relocation.
* The race detector. Today, this links in an externally compiled archive which
contains position-independent object files.
Similarly, position-independent linking is always punted to the external
linker on ppc64 today.
Updates #21961
Fixes #15409
Change-Id: Ifd8294b9249e16ba8b92eaf876d15d162f9c61fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/304458
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
2021-09-08 11:57:03 +00:00
Joel Sing
50c69cc3a9
cmd/link/internal/riscv64,cmd/internal/obj/riscv: make error messages consistent
...
Be consistent with both style/wording and formatting of error messages.
Change-Id: I23013d904333a67a8f17dd364bb5015f54f419c0
Reviewed-on: https://go-review.googlesource.com/c/go/+/345050
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2021-09-08 06:59:06 +00:00
Joel Sing
c50d811c7a
cmd/interna/obj/riscv: use obj.REG_NONE rather than 0
...
No functional change, but makes the code consistent and more readable.
Change-Id: I33db681fe0ed501842755f27b6e7843cdc8877cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/345049
Trust: Joel Sing <joel@sing.id.au>
Trust: Meng Zhuo <mzh@golangcn.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Meng Zhuo <mzh@golangcn.org>
2021-09-08 06:58:13 +00:00
Joel Sing
f030043e37
cmd/internal/obj/riscv: simplify machine code output
...
Use cursym.WriteInt rather than building up a slice of bytes and then writing them
out via PutUint32. This also allows for variable instruction sizes, which will be
needed when support for compressed (2 byte length) instructions is added.
Change-Id: I17c9ffa52d27c91a24e161317e3db28e224804ae
Reviewed-on: https://go-review.googlesource.com/c/go/+/344460
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2021-09-08 06:56:06 +00:00
Joel Sing
da790cccc5
cmd/internal/obj/riscv: absorb rewriteMOV into instruction generation
...
Replace the now poorly named rewriteMOV function with a markRelocs function,
absorbing the MOV validation into the instruction generation code.
Change-Id: I6ae94553f7f300862c40310343ef0be8f44a4b0f
Reviewed-on: https://go-review.googlesource.com/c/go/+/344459
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2021-09-08 06:38:19 +00:00
Joel Sing
f5bdbf311c
cmd/internal/obj/riscv: simplify rewriteMOV
...
Rewrite and simplify the rewriteMOV function in preparation for eliminating it
entirely. Improve some error messages in the process.
Change-Id: Id9a77be5174d46cc23651930c2e9068ee6555690
Reviewed-on: https://go-review.googlesource.com/c/go/+/344458
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 05:32:14 +00:00
Keith Randall
bab79dd362
reflect: add back signaling NaN test
...
I was a little too agressive in CL 258957 (removing 387 support) in
removing a signaling NaN test that should probably still exist.
I should have just removed the 387 skip, not the entire test.
Change-Id: I97ca53f190eb0de00e43b96629b2cae677e7dacb
Reviewed-on: https://go-review.googlesource.com/c/go/+/348209
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-09-08 00:34:17 +00:00
Ian Lance Taylor
963218cc9c
reflect: correct typoo in comment
...
Change-Id: Ic3c69906a8afde63278f173df0427b1c460c9f3e
Reviewed-on: https://go-review.googlesource.com/c/go/+/348189
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-08 00:02:45 +00:00
Dan Scales
3fff213ac2
cmd/compile: add CONVIFACE nodes needed in generic code due to assignments
...
Added new function earlyTransformAssign() to add needed CONVIFACE nodes
due to assignments in generic functions.
Fixes #48049
Change-Id: I7cd9cee6ecf34ed2ef0743d1b17645b9f520fa00
Reviewed-on: https://go-review.googlesource.com/c/go/+/347914
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-09-07 23:27:08 +00:00
Keith Randall
b606739be6
reflect: add test for passing float32 signaling NaNs
...
Update #40724
Change-Id: I110cdb7c4a2c5db6b85ca951143430555261abf3
Reviewed-on: https://go-review.googlesource.com/c/go/+/348017
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-09-07 23:10:23 +00:00
Josh Bleecher Snyder
b5e33a50fe
reflect: rename MapIter method receiver variable from it to iter
...
This is easier to use in documentation.
Adjust the existing documentation that worked around the unfortunate name.
Change-Id: Ia4b7793ab94dfd7fb3968ee983be56cc38c30ec3
Reviewed-on: https://go-review.googlesource.com/c/go/+/347769
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-09-07 23:09:28 +00:00
Josh Bleecher Snyder
07f623063d
reflect: add MapIter.Reset
...
This allows callers to do (amortized) allocation-free iteration
over many maps.
Fixes #46293
Change-Id: I3aa6134dd00da35b508bd1e3b487332a871a3673
Reviewed-on: https://go-review.googlesource.com/c/go/+/321891
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-09-07 23:09:06 +00:00
Dan Scales
a9a01a3fbd
cmd/compile: remove now-unneeded SetHasTParam() for cached ptr element
...
We had code in NewPtr() to set the HasTParam/HasShape flag as needed for
the cached ptr element if it wasn't set correctly based on its Elem.
This was causing the race mentioned in the issue.
But that setting code is no longer needed, as long as we call
SetRParams() soon after calling NewIncompleteNamedType(), before
creating/translating the underlying type (which we do). The
HasTParam/HasShape attribute can only come from setting of rparams or a
direct typeparam/shape somewhere in the underlying type, both of which
don't depend on recursion, etc. (as long as the rparams are set early).
Added a check that HasTParam/HasShape are set correctly for the cached
pointer/slice elems in NewPtr() and NewSlice().
Fixes #48191
Change-Id: Ide7d82efb77ae97901e75b2e6c65bd1bfc25e0ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/348089
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-09-07 22:23:36 +00:00
korzhao
dcf3545774
encoding/gob: optimize decoding of slice
...
In CL 345572, we used the reflect.Value.SetLen method to avoid
extra memory allocation for reflect.Value.Slice.
This also applies to function decodeSlice
name old time/op new time/op delta
DecodeStringsSlice-12 96.5µs ±12% 63.0µs ± 8% -34.68% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
DecodeStringsSlice-12 89.3kB ± 0% 65.3kB ± 0% -26.89% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
DecodeStringsSlice-12 3.18k ± 0% 2.18k ± 0% -31.47% (p=0.000 n=10+10)
Change-Id: Ifdb43716cc90a265962dec022704a5571f447fd8
Reviewed-on: https://go-review.googlesource.com/c/go/+/347533
Reviewed-by: Joe Tsai <joetsai@digital-static.net>
Reviewed-by: Rob Pike <r@golang.org>
Trust: Joe Tsai <joetsai@digital-static.net>
Run-TryBot: Joe Tsai <joetsai@digital-static.net>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-07 21:39:06 +00:00
Dan Scales
80783558b0
cmd/compile: make sure imported instantiated types have their methods created
...
We should be putting a newly instantiated imported type in
Instantiate/doInst onto the instTypeList, so its methods/dictionaries
are instantiated. To do this, we needed a more general way to add a
type to instTypeList, so add NeedInstType(), analogous to
NeedRuntimeType(). This has the extra advantage that now all types
created by the type substituter are added to instTypeList without any
extra code, which was easy to forget. doInst() now correctly calls
NeedInstType().
This is a bit aggressive, since a fully instantiated type in a generic
function/method may never be used, if the generic method is never
instantiated in the local package. But it should be fairly uncommon for
a generic method to mention a fully instantiated type (but it does
happen in this bug).
Fixes both cases mentioned in the bug.
Fixed #48185
Change-Id: I19b5012dfac17e306c8005f8595a648b0ab280d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/347909
Trust: Dan Scales <danscales@google.com>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-09-07 20:37:05 +00:00
Ruslan Andreev
23f4f0db68
cmd/compile: add prefetch intrinsic support
...
This CL provide new intrinsics to emit prefetch instructions for AMD64
and ARM64 platforms:
Prefetch - prefetches data from memory address to cache;
PrefetchStreamed - prefetches data from memory address, with a hint
that this data is being streamed.
This patch also provides prefetch calls pointed by RSC inside scanobject
and greyobject of GC mark logic.
Performance results provided by Michael:
https://perf.golang.org/search?q=upload:20210901.9
Benchmark parameters:
tree2 -heapsize=1000000000 -cpus=8
tree -n=18
parser
peano
Benchmarks AMD64 (Xeon - Cascade Lake):
name old time/op new time/op delta
Tree2-8 36.1ms ± 6% 33.4ms ± 5% -7.65% (p=0.000 n=9+9)
Tree-8 326ms ± 1% 324ms ± 1% -0.44% (p=0.006 n=9+10)
Parser-8 2.75s ± 1% 2.71s ± 1% -1.47% (p=0.008 n=5+5)
Peano-8 63.1ms ± 1% 63.0ms ± 1% ~ (p=0.730 n=9+9)
[Geo mean] 213ms 207ms -2.45%
Benchmarks ARM64 (Kunpeng 920):
name old time/op new time/op delta
Tree2-8 50.3ms ± 8% 44.1ms ± 5% -12.24% (p=0.000 n=10+9)
Tree-8 494ms ± 1% 493ms ± 1% ~ (p=0.684 n=10+10)
Parser-8 3.99s ± 1% 3.93s ± 1% -1.37% (p=0.016 n=5+5)
Peano-8 84.4ms ± 0% 84.1ms ± 1% ~ (p=0.068 n=8+10)
[Geo mean] 302ms 291ms -3.67%
Change-Id: I43e10bc2f9512dc49d7631dd8843a79036fa43d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/328289
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-07 20:27:30 +00:00
zikaeroh
d92101f452
cmd/compile: resolve TODO in inl.go
...
If the condition is a bool constant, there's no need to walk both
branches.
Passes toolstash -cmp.
Change-Id: I4ee5e3553ce07c2213efba0d33d869b4a1b57783
Reviewed-on: https://go-review.googlesource.com/c/go/+/347911
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-09-07 19:39:04 +00:00
Jay Conrod
Katie Hockman
Michael Matloob
Robert Findley
Bryan C. Mills
Robert Griesemer
Dmitri Shuralyov
Michael Munday
Paul E. Murphy
Joel Sing
Keith Randall
Ian Lance Taylor
Dan Scales
Josh Bleecher Snyder
korzhao
Ruslan Andreev
zikaeroh