Matthew Dempsky
f153b6739b
cmd/compile: use typecheck.InitUniverse in unit tests
...
Rather than ad hoc setting up the universe, just initialize it
properly.
Change-Id: I18484b952321f55eb3e1e48fd383068a4ee75f66
Reviewed-on: https://go-review.googlesource.com/c/go/+/345475
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-27 00:36:19 +00:00
Matthew Dempsky
967a8017f7
cmd/compile: move types init code into package types
...
This moves the package types setup code from package typecheck into
package types itself. This is a prereq for making types.Type more
opaque, because some unit tests depend on being able to init the basic
universal types.
A few notable details of this CL:
1. Creating the builtin types requires being able to create the
ir.Name/ir.OTYPE that represents it, but package types can't depend on
package ir. So we add a callback function to handle creating the
ir.Name.
2. This CL moves ir.Pkgs.Unsafe to types.UnsafePkg. Package unsafe is
part of the language, not like the other ir.Pkgs packages that are
purely implementation details.
3. This CL also moves typecheck.FakeRecv to types.FakeRecv, addressing
an outstanding TODO.
Change-Id: I64de04ce82fbcd1bb59f547e2eea3cda52d89429
Reviewed-on: https://go-review.googlesource.com/c/go/+/345474
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-08-26 22:37:54 +00:00
Robert Griesemer
af80af22b5
cmd/compile/internal/types2: do not declare new methods on instantiated types
...
Report an error if an alias is used to declare a method on an
instantiated type.
Also, when resolving the receiver type, don't use asNamed to
avoid premature expansion of the type.
Fixes #47968 .
Change-Id: Ie5acc4cfb1944deaaeeaee98707f31e256f8ef5e
Reviewed-on: https://go-review.googlesource.com/c/go/+/345472
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-26 20:39:56 +00:00
Robert Griesemer
03db2c2413
cmd/compile/internal/types2: implement TypeList.String (debugging support)
...
Change-Id: Iaa203def3dac94a7d5ff6120e89315c3d7977ee1
Reviewed-on: https://go-review.googlesource.com/c/go/+/345471
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-26 20:39:50 +00:00
Dan Scales
c9e05fdcf7
cmd/compile: fix reference to generic type needed by crawler
...
This problem happens when you create a new local type that uses an
imported generic type (maybe just by instantiating it), and then that
local type needed to be included as part of an export. In that case, the
imported generic type is does not have a declaration in the local
package, so it is not necessarily created in types1, so the
crawler/export doesn't work.
To fix this issue, we just need to add a call to g.obj() for the base
generic type, to make sure that it will exist if needed later in the
compilation or for the crawler during export.
Fixes #47514
Change-Id: Ie756578f07ad0007de8a88ae909cf7534a22936e
Reviewed-on: https://go-review.googlesource.com/c/go/+/345411
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
2021-08-26 20:18:58 +00:00
Matthew Dempsky
eb6a07fcf9
cmd/compile: unexport Type.Vargen
...
This field is only used outside of packages types in two places, and
they follow the same pattern. So this CL creates a Type.Setvargen
function that they can use instead, so that Type.Vargen can be
unexported.
A bit clumsy, but it works for now.
Change-Id: I7b4f33fac635e2464df2fbc0607ab40902f6f09f
Reviewed-on: https://go-review.googlesource.com/c/go/+/345469
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-26 19:34:58 +00:00
Matthew Dempsky
3836983779
cmd/compile/internal/types: unexport Type.Extra
...
Not used outside of package types anymore. Let's keep it that.
Change-Id: I69b464ac94edaacd219da4210f7b8618e2beaf70
Reviewed-on: https://go-review.googlesource.com/c/go/+/345413
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
2021-08-26 19:34:52 +00:00
Matthew Dempsky
1f8d4562de
cmd/compile: change typecheck.iscmp into ir.Op.IsCmp
...
Change-Id: If89089cbd79b7ff030d856df3a7e6b7862c0f4ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/345412
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-26 19:07:27 +00:00
Michael Matloob
de83ef67ac
[dev.cmdgo] all: merge master ( 5e6a7e9) into dev.cmdgo
...
Merge List:
+ 2021-08-26 5e6a7e9b86166b691b65d6bdae33e9770df2e18da6ff433d6a4f2620285d0ac64f6d704068fb6c21bf0bc4122f4158e88f64647bef6c596cf1d5d0fa5baf60d4723d667671ad4f2ebfe34bd2f002cb3908d4cc20ca099b819085e1fcf8857ed37b8dedf741b99dab0fde1c934b9754cdef1f105d863f89fe
2021-08-26 15:04:42 -04:00
Dan Kortschak
5e6a7e9b86
embed: remove reference to global variables in docs
...
Refering to variable is both redundant since package scope is used, and
incorrect since global variables are not described in the spec.
Change-Id: Ib08a9f072fc800ee36549f758b68167d8f044878
Reviewed-on: https://go-review.googlesource.com/c/go/+/344214
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-26 18:26:42 +00:00
Robert Griesemer
166b691b65
cmd/compile/internal/types2: remove need for instance (struct)
...
instance was only used to hold the instantiation position for
lazy instantiation (and encode the fact that we have a lazy
instantiation). Just use a (pointer to a) syntax.Pos instead.
We could use a syntax.Pos (no pointer) and rely on the fact
that we have a known position (or fake position, if need be)
to indicate lazy instantiation. But using a pointer leads to
a smaller Named struct.
Change-Id: I441a839a125f453ad6c501de1ce499b72a2f67a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/345177
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-26 17:19:04 +00:00
Robert Griesemer
d6bdae33e9
cmd/compile/internal/types2: address some TODOs (cleanup)
...
- Address some easy TODOs.
- Remove some TODOs that are not correct anymore or are unimportent.
- Simplify some code on the way.
Change-Id: I4d20de3725b3a735022afe022cbc002b2798936d
Reviewed-on: https://go-review.googlesource.com/c/go/+/345176
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-26 17:18:58 +00:00
vinckr
770df2e18d
crypto/tls: fix typo in PreferServerCipherSuites comment
...
Fixing a typo, Deprected -> Deprecated.
Change-Id: Ie0ccc9a57ae6a935b4f67154ac097dba4c3832ec
GitHub-Last-Rev: 57337cc1bfgolang/go#47745
Reviewed-on: https://go-review.googlesource.com/c/go/+/342791
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2021-08-26 12:19:23 +00:00
Cuong Manh Le
a6ff433d6a
cmd/go: pass -gcflags after other flags generated by the go command
...
Otherwise, any gc flags set by user using "-gcflags" won't have effect.
Fixes #47682
Change-Id: Icd365577cba1f64f6c7b8320d0c9019de9f062f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/344909
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-08-26 02:06:43 +00:00
Robert Griesemer
4f2620285d
cmd/compile/internal/types2: fix type set printing and add test
...
Change-Id: I44ca1f889b041467d5febacaf6037cfd75859175
Reviewed-on: https://go-review.googlesource.com/c/go/+/344873
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-25 23:44:02 +00:00
Robert Griesemer
0ac64f6d70
cmd/compile/internal/types2: rename IsMethodSet to IsConstraint (cleanup)
...
Invert the boolean result to match the new name.
Change-Id: Ide6c649ed8ac3a5d263640309960e61a005c886e
Reviewed-on: https://go-review.googlesource.com/c/go/+/344872
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-25 23:43:58 +00:00
Robert Griesemer
4068fb6c21
cmd/compile: always accept 1.18 syntax but complain if not 1.18
...
This CL configures the parser to always accept 1.18 syntax
(type parameters, type instantiations, interface elements),
even when -lang is set to an earlier release.
Instead, the type checker looks for 1.18 operations and
complains if the language version is set to an earlier
release.
Doing these checks during type checking is necessary because it
it is possible to write "generic" code using pre-1.18 syntax;
for instance, an imported generic function may be implicitly
instantiated (as in imported.Max(2, 3)), or an imported constraint
interface may be embedded in an "ordinary" interface.
Fixes #47818 .
Change-Id: I83ec302b3f4ba7196c0a4743c03670cfb901310d
Reviewed-on: https://go-review.googlesource.com/c/go/+/344871
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-25 23:43:53 +00:00
Robert Griesemer
bf0bc4122f
go/types, types2: don't re-evaluate context string for each function argument (optimization)
...
Change-Id: Ie1b4d5b64350ea42484adea14df84cacd1d2653b
Reviewed-on: https://go-review.googlesource.com/c/go/+/344576
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-25 23:43:42 +00:00
Robert Griesemer
4158e88f64
cmd/compile/internal/syntax: fix position of type parameter field
...
Change-Id: I8bca01b935301e7bd4efa55ed21921dbf31a75b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/344575
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-25 23:43:41 +00:00
Robert Griesemer
647bef6c59
go/types: implement NewTypeList and use it instead of composite literals
...
Also, simplify a bit of code in predicates.go.
This is a backport of changes in CL 344615 that were made in addition
to the changes of the original CL 343933; it brings go/types in sync
with types2.
Change-Id: I14cd4d4704d29894d0fbb8d129744d65e332ad22
Reviewed-on: https://go-review.googlesource.com/c/go/+/344570
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-25 23:43:40 +00:00
Jake Ciolek
6cf1d5d0fa
cmd/compile: generic SSA rules for simplifying 2 and 3 operand integer arithmetic expressions
...
This applies the following generic integer addition/subtraction transformations:
x - (x + y) = -y
(x - y) - x = -y
y + (x - y) = x
y + (z + (x - y) = x + z
There's over 40 unique functions matching in Go. Hits 2 funcs in the runtime itself:
runtime.stackfree()
runtime.runqdrain()
Go binary size reduced by 0.05% on Linux x86_64.
StackCopy bench (perflocked Cascade Lake x86):
name old time/op new time/op delta
StackCopyPtr-8 87.3ms ± 1% 86.9ms ± 0% -0.45% (p=0.000 n=20+20)
StackCopy-8 77.6ms ± 1% 77.0ms ± 0% -0.76% (p=0.000 n=20+20)
StackCopyNoCache-8 2.28ms ± 2% 2.26ms ± 2% -0.93% (p=0.008 n=19+20)
test/bench/go1 benchmarks (perflocked Cascade Lake x86):
name old time/op new time/op delta
BinaryTree17-8 1.88s ± 1% 1.88s ± 0% ~ (p=0.373 n=15+12)
Fannkuch11-8 2.31s ± 0% 2.35s ± 0% +1.52% (p=0.000 n=15+14)
FmtFprintfEmpty-8 26.6ns ± 0% 26.6ns ± 0% ~ (p=0.081 n=14+13)
FmtFprintfString-8 48.6ns ± 0% 50.0ns ± 0% +2.86% (p=0.000 n=15+14)
FmtFprintfInt-8 56.9ns ± 0% 54.8ns ± 0% -3.70% (p=0.000 n=15+15)
FmtFprintfIntInt-8 90.4ns ± 0% 88.8ns ± 0% -1.78% (p=0.000 n=15+15)
FmtFprintfPrefixedInt-8 104ns ± 0% 104ns ± 0% ~ (p=0.905 n=14+13)
FmtFprintfFloat-8 148ns ± 0% 144ns ± 0% -2.19% (p=0.000 n=14+15)
FmtManyArgs-8 389ns ± 0% 390ns ± 0% +0.35% (p=0.000 n=12+15)
GobDecode-8 3.90ms ± 1% 3.88ms ± 0% -0.49% (p=0.000 n=15+14)
GobEncode-8 2.73ms ± 0% 2.73ms ± 0% ~ (p=0.425 n=15+14)
Gzip-8 169ms ± 0% 168ms ± 0% -0.52% (p=0.000 n=13+13)
Gunzip-8 24.7ms ± 0% 24.8ms ± 0% +0.61% (p=0.000 n=15+15)
HTTPClientServer-8 60.5µs ± 6% 60.4µs ± 7% ~ (p=0.595 n=15+15)
JSONEncode-8 6.97ms ± 1% 6.93ms ± 0% -0.69% (p=0.000 n=14+14)
JSONDecode-8 31.2ms ± 1% 30.8ms ± 1% -1.27% (p=0.000 n=14+14)
Mandelbrot200-8 3.87ms ± 0% 3.87ms ± 0% ~ (p=0.652 n=15+14)
GoParse-8 2.65ms ± 2% 2.64ms ± 1% ~ (p=0.202 n=15+15)
RegexpMatchEasy0_32-8 45.1ns ± 0% 45.9ns ± 0% +1.68% (p=0.000 n=14+15)
RegexpMatchEasy0_1K-8 140ns ± 0% 139ns ± 0% -0.44% (p=0.000 n=15+14)
RegexpMatchEasy1_32-8 40.9ns ± 3% 40.5ns ± 0% -0.88% (p=0.000 n=15+13)
RegexpMatchEasy1_1K-8 215ns ± 1% 220ns ± 1% +2.27% (p=0.000 n=15+15)
RegexpMatchMedium_32-8 783ns ± 7% 738ns ± 0% ~ (p=0.361 n=15+15)
RegexpMatchMedium_1K-8 24.1µs ± 6% 23.4µs ± 6% -2.94% (p=0.004 n=15+15)
RegexpMatchHard_32-8 1.10µs ± 1% 1.09µs ± 1% -0.40% (p=0.006 n=15+14)
RegexpMatchHard_1K-8 33.0µs ± 0% 33.0µs ± 0% ~ (p=0.535 n=12+14)
Revcomp-8 354ms ± 0% 353ms ± 0% -0.23% (p=0.002 n=15+13)
Template-8 42.0ms ± 1% 41.8ms ± 2% -0.37% (p=0.023 n=14+15)
TimeParse-8 181ns ± 0% 180ns ± 1% -0.18% (p=0.014 n=12+13)
TimeFormat-8 240ns ± 0% 242ns ± 1% +0.69% (p=0.000 n=12+15)
[Geo mean] 35.2µs 35.1µs -0.43%
name old speed new speed delta
GobDecode-8 197MB/s ± 1% 198MB/s ± 0% +0.49% (p=0.000 n=15+14)
GobEncode-8 281MB/s ± 0% 281MB/s ± 0% ~ (p=0.419 n=15+14)
Gzip-8 115MB/s ± 0% 115MB/s ± 0% +0.52% (p=0.000 n=13+13)
Gunzip-8 786MB/s ± 0% 781MB/s ± 0% -0.60% (p=0.000 n=15+15)
JSONEncode-8 278MB/s ± 1% 280MB/s ± 0% +0.69% (p=0.000 n=14+14)
JSONDecode-8 62.3MB/s ± 1% 63.1MB/s ± 1% +1.29% (p=0.000 n=14+14)
GoParse-8 21.9MB/s ± 2% 22.0MB/s ± 1% ~ (p=0.205 n=15+15)
RegexpMatchEasy0_32-8 709MB/s ± 0% 697MB/s ± 0% -1.65% (p=0.000 n=14+15)
RegexpMatchEasy0_1K-8 7.34GB/s ± 0% 7.37GB/s ± 0% +0.43% (p=0.000 n=15+15)
RegexpMatchEasy1_32-8 783MB/s ± 2% 790MB/s ± 0% +0.88% (p=0.000 n=15+13)
RegexpMatchEasy1_1K-8 4.77GB/s ± 1% 4.66GB/s ± 1% -2.23% (p=0.000 n=15+15)
RegexpMatchMedium_32-8 41.0MB/s ± 7% 43.3MB/s ± 0% ~ (p=0.360 n=15+15)
RegexpMatchMedium_1K-8 42.5MB/s ± 6% 43.8MB/s ± 6% +3.07% (p=0.004 n=15+15)
RegexpMatchHard_32-8 29.2MB/s ± 1% 29.3MB/s ± 1% +0.41% (p=0.006 n=15+14)
RegexpMatchHard_1K-8 31.1MB/s ± 0% 31.1MB/s ± 0% ~ (p=0.495 n=12+14)
Revcomp-8 718MB/s ± 0% 720MB/s ± 0% +0.23% (p=0.002 n=15+13)
Template-8 46.3MB/s ± 1% 46.4MB/s ± 2% +0.38% (p=0.021 n=14+15)
[Geo mean] 205MB/s 206MB/s +0.57%
Change-Id: Ibd1afdf8b6c0b08087dcc3acd8f943637eb95ac0
Reviewed-on: https://go-review.googlesource.com/c/go/+/344930
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
2021-08-25 19:45:20 +00:00
Joe Tsai
5baf60d472
bytes, strings: optimize Trim for single byte cutsets
...
Using the latest version of all modules known by the module proxy,
we determine that for all Trim usages (and related functionality):
* 76.6% have cutsets of len=1, and
* 13.4% have cutsets of len=2.
Given that a vast majority of usages only have a cutset of len=1,
we should more heavily optimize for that situation.
Previously, there was some optimization for cutsets of len=1,
but it's within the internal makeCutsetFunc function.
This is sub-optimal as it incurs an allocation in makeCutsetFunc
for the closure over that single byte.
This CL removes special-casing of one-byte cutsets from makeCutsetFunc
and instead distributes it directly in Trim, TrimRight, and TrimLeft.
Whether we should distribute the entire ASCII cutset logic into Trim
is a future CL that should be discussed and handled separately.
The evidence for multibyte cutsets is not as obviously compelling.
name old time/op new time/op delta
bytes/TrimByte-4 84.1ns ± 2% 7.5ns ± 1% -91.10% (p=0.000 n=9+7)
strings/TrimByte-4 86.2ns ± 3% 8.3ns ± 1% -90.33% (p=0.000 n=9+10)
Fixes #46446
Change-Id: Ia0e31a8384c3ce111ae35465605bcec45df2ebec
Reviewed-on: https://go-review.googlesource.com/c/go/+/323318
Trust: Joe Tsai <joetsai@digital-static.net>
Run-TryBot: Joe Tsai <joetsai@digital-static.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-25 19:29:15 +00:00
korzhao
3d667671ad
cmd/compile: fix function contains no TParam in generic function
...
Fixes #47948
Change-Id: I446a9548265d195ae4d88aff6b1361474d1b6214
Reviewed-on: https://go-review.googlesource.com/c/go/+/344910
Trust: Alexander Rakoczy <alex@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-25 19:06:16 +00:00
korzhao
4f2ebfe34b
cmd/compile: allow embed into any byte slice type
...
Fixes #47735
Change-Id: Ia21ea9a67f36a3edfef1b299ae4f3b00c306cd68
Reviewed-on: https://go-review.googlesource.com/c/go/+/342851
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
2021-08-25 18:31:07 +00:00
korzhao
d2f002cb39
time/format: avoid growslice in time.String()/time.GoString()
...
Pre-allocate the slice of buf with enough capacity
to avoid growslice calls.
benchmark old ns/op new ns/op delta
BenchmarkTimeString-4 493 409 -17.12%
BenchmarkTimeGoString-4 309 182 -41.30%
benchmark old allocs new allocs delta
BenchmarkTimeString-4 5 3 -40.00%
BenchmarkTimeGoString-4 4 1 -75.00%
benchmark old bytes new bytes delta
BenchmarkTimeString-4 152 128 -15.79%
BenchmarkTimeGoString-4 248 80 -67.74%
Change-Id: I64eabe2ab0b3d4a846453c2e8e548a831d720b8c
Reviewed-on: https://go-review.googlesource.com/c/go/+/343971
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
2021-08-25 18:27:41 +00:00
Michael Matloob
de23549a39
[dev.cmdgo] cmd/go: fix calls to modFileGoVersion to pass in modFile
...
Before this change, we were arbitrarily picking a module to get the Go
version from in calls to modFileGoVersion. We now pass in the modFile to
modFileGoVersion when we have the file. Most of the calls were to get
the goVersion argument for commitRequirements, so now we have
commitRequirements call modFileGoVersion on the modFile directly
One of the calls to commitRequirements (when running go mod tidy with
a different Go version) passed in a new go version to update the file
to. Now, the modFile is updated before calling commitRequirements.
For the remaining cases of modFileGoVersion, it's replaced by a call to
the new (*MainModuleSet).GoVersion function, which either returns the go
version on the workspace file (in workspace mode) or the version of the
single go.mod file.
Change-Id: Ie88c3ca76c7f29ffc4faa16bb76f6cb7eccb5029
Reviewed-on: https://go-review.googlesource.com/c/go/+/344749
Trust: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-08-25 17:23:06 +00:00
Michael Matloob
3b523caf41
[dev.cmdgo] cmd/go: clean up TODOWorkspaces instances
...
Address some of the easier todos to address and remove the todos that
have already been done and redundant todos.
For #45713
Change-Id: I3fe4393168b10c6e005325258d9701713c92e9e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/344491
Trust: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2021-08-25 17:02:15 +00:00
wdvxdr
08d4cc20ca
cmd/compile: fix stencil call expression.
...
Fixes : #47878
Change-Id: I369350813726fd518b4eab2b98f43bf031a6dee6
Reviewed-on: https://go-review.googlesource.com/c/go/+/344210
Reviewed-by: Dan Scales <danscales@google.com>
Trust: Dan Scales <danscales@google.com>
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-08-25 16:37:31 +00:00
Michael Matloob
109c13b64f
[dev.cmdgo] all: merge master ( c2f96e6) into dev.cmdgo
...
src/cmd/go/testdata/script/work.txt and
src/cmd/go/testdata/script/work_edit.txt were updated so the want files
specified go1.18 as that's what go mod initwork will produce under Go
1.18.
Conflicts:
- src/cmd/go.mod
- src/cmd/go.sum
- src/cmd/go/internal/modload/init.go
- src/cmd/go/internal/work/init.go
- src/cmd/vendor/golang.org/x/tools/go/ast/astutil/rewrite.go
- src/cmd/vendor/golang.org/x/tools/internal/typeparams/notypeparams.go
- src/cmd/vendor/golang.org/x/tools/internal/typeparams/typeparams.go
- src/cmd/vendor/modules.txt
- src/cmd/vet/testdata/print/print.go
Merge List:
+ 2021-08-24 c2f96e686f5b643811554a9f0cec29daa55b21d1e6798795ffb1cdf860dd1ff0554b53bd97763577bba460499cd70c69d830f98b6111eb8eeb1bff1dbe1a6934778157960d7f22540abf76fa34678c670a7f00ae236b9e3f883e3081f817da8486ced8b0aeec6dbfe0f457ecc7f0f1d8ea1da34fbb5c86667a6d64fed624386606029fe5c7f122baf2866956c7e354d9d1c1a14781ec457418b47586ee89225a29d7e5472b8fcc6143605d5e50c3db5d0c2840da19585826fa6416bde023bd6845965c96d816c5746e50991d2a8fff20ffebbcd146d398dcee007aade17439e087c9912780ab97d17dc023835ff47c16f67e31d643ab9aaf46ee5045477be80f2525112730a423eb39e49775e0574d00fcbc43bacbc334397007431374303446395de9e0d1ef70c92c2c9d6265074a40860e598e7da491e2e3b9039871726c7269d8fbec7a3bdc1799d6740f7d7370c85695a117322879d5c9687f2acf6aeda3de0f79805d38a352c2bd9ee2db8f0578ef39165ebd85a74a0fd73ead0c83e01e0c8b471db71b946e2543f88e18428e38aef24d8f7dddfcc02352a2a9a7b5133848488f0face1730a410f85b0c0e19d9e3291facf12b0d1f93001b0abf04012fea822b7b790a71aa304273d74d3deb2c35929ec74fb8291a935ea0fa8d39f151d1951afc9192a193337169c5eb16f6cd9349175ad8ff16c1990df9c5d8f5d213e157d3ac04a32e59a6406227d71a05a7d49a954ce8793a8742dcba7bb41d991e4e144661418228d2066177dec27168712d35035f84eddffe30a21631af58e20d1ba047edf56a919f17fff36d114702460cf8602281ed619f8aab1d1fcb99ff61acbd7fda8ee8b07e61d1445ab5c7a460a1c850768bbc9a0adf91d855a40100141c92f5ee1705da2010840ea8298e2f5fe489c86a7b9f135d98fc2b4ec8f4911a43df461b0fba64ef4efd206eb407b7d7d781802f932e173a192ef8ac411a1f37b070b61dc4577c88e3ff648d043c8ea8994002f6fca3d679c6554fcdc3c098c160d7972606a760d6c367aa57a968757c115e1f6717894cf806ed946313348dfddbab31162aae0adff3469b1c20a0a160d4d49c688e45cb2253c8041456759b2462d250043b450f4ebbdd3fc27eb50ff7eaabae84d58490972c0a95f1b51be89a4f996402eb4d68833bad1fc1265641e8bc2c798f3d7fecb20a620fd9f4c8ffb3baa4be75faa3e1fffeddfe90d019340944d3cc84044ec4fa983601aedff64d3cc844d3cc8477446fd547a64ab8d3ec46fd5477e9f911ec446fd547d895805efc78e39634e7dae095bb790e1677dfe5ad6dea23e9ca88ab59d812ad7d4f28a06eeb7899137d4c0ed26ac0888a8cd2d7308d747e70f34a92df740ba119e3ffb8579746c2e250cc957337cebd2c12fbf6aafe7e4cfa2f6da508624f3591f9c9d8530f5f79c47f9f1dce319ff9f4d6a8359ca3c6985cd57668b84ff7aeaad5c86507cc341ecd10a904712891547e2d48eaf4d16bc63b968f4f89e0ac72d689bd1817e41313924f2720d7dc417ea09d82689ed3a9fd99849c3b57af8bc081110867093285c89d15aac85ad5e110343e4a25e33d11e10ac78501b9c70546f6404fd45e267c2f78d538858c5b6c36dddf14908d01bbb5608dd5d6dadee759c5dcb5e2cea3cdf8b429e1b708c02600ec2a8b42de5fe769be1b730a26729e590cb64f96e738868a7d27a889119b01e775e9c3efc8f9a8ded3667d079880ab6209e5b51cf47dce0d090721218e050372489897473e21ea3596b4188bd92bb6d1a0630aef4077925e2b07ab8754029fe73f28dc5656f0888b71b193598b3e56234a305c3c19731a9156eeb40a68a7ee4c51e283991bd7faa3d54da07b8ca6e59ed0b8a9ccb257bed50e667e3e9f0bb2d40e561d933fd0011dca553fd5b1b77ea94e5d3c5b7a85e00034480e3b11a27283d208f3e7571f6ff1d35d8ffa535dbdda2fe600b7b431b5ecbd811b546cc68638127552e9172af903261e7c079b6baaaff0c0dbca62fa8f00915f4f503e0a370fd4e47d74a47e40a14506fd520d5adedf542885355753009473e493d18e00a6ec084c751e2e6ba5d8f90f904cb14e673ec37d2219960d6753fd4919e3274bb3db93f646125996b0dbc65ecaa681bfcb7c4c8ab27c7e30dca2e2b0362b3dc0a0a2c577e0bf294c9f928f93186992dcdad9e6d956e1c502c017250012866bd8ea4cdc65d32a244267e8c4798ec73d8ceb133caa27e325c59798ec735cb84f060473162a54c280127a7dfefca3e5c4455ba06495c16f57139c7a311baf65f4b7149b781f61f69d25598e9109e95aee20dff27d4e6836e82cdcc8350ad3f19e49e7b1e6a2cf233f4a97fe8c222fe4b1479573af5f718fa7a17f0ca8897970688bd5f6ba943c6a931673f0e4994e71fbc8f4e61c6d3d0b0ad6bf2667d4e7e714f448e82f875d73562f6f130febaeabf3b36b3d91e3a24cf7e66b7d419b4142f24d6d7f8458e796ac6d5f222f39ba2084a72be87b341ff0aac139e147c55b722a38ba5cab96f1b941943ad1ffa99c7c13ae432ccf95f17dd76b39959f49b85985d36df778e6fd9e9836fe318c4cd76fbbb521828091c624d152db7e12d43866db3e7f23a487c35f5c2fcde209e693a0f4198b5e25f50a6442e726ffce65979955155e9fe4f13404db98b8b9b5bfce6290e0a24f9eb2de3b296e5461810c8b7c1d7ed9e109dc93d8453e00e334f2fc0456b85a218b84ff0e04c2e3a047326e8dd8bdf4a1f2a8087817c95f8e64fc05f0ea40c676511922a14ff33d3dc3ae3e6cd30222b10d7ff0b5517053d1782744bfbfce5faa8d84bd0324eb8fb70f1246a9f22e92654671c783dc1480dcab98fd83c3c1d8d28a12ad271195059aed9ddf2ed30c31e69d945fc6e04acb8a7b92b1d70a137296ddf242fe132787d4f6d161e418135150b0d2bf94fb8603ec8de24b47547d850860cb2cab9785267f402cc65ca97a45501725032cb614c05a15b4844c9f544676c3675e5c42b6a95349ade6b298cd00499c61899b158ee9ea5369bac0c45d0eaadbad2ba3ff515dac279fbd611056ec34912f075ef39edefe1f35d86fd5f912f075b994cc69e06dec18cc75a18726a6482aea44204e30e5f266ed9c1e7d9eff838079beef9ba294e15b0e0b80cb561aadb18f83fac21803ce1eb756689c9cb1b0f50b1cd505c353706c580ee1372b312735ad7e5b219e4711bf38767b87ab5b47cbc2ffef0206e3df21ff43d1b174b5fdb0b7af503740ccf6a5f7e84985fa6bbc669dfa8fd861c64e6c75924f99b3fe2aba8861b907d20a04f60411b995f91a5d44ed5d1443ea0fcfe1527e3b797bb0cf71f7f92180c338c68942bcc2d4fd417b8cf87ed647b16d0942edc7502373ca3a84637f9a8f1b60284c0a9fe7c38d3df4198f85d53f1a517a45badb98364bac2de11cfb37f9a8f2493c72742f190a9280daee209c04475ad323773808dca3b2dddb09af1b8df00abc61bb55cc6687d9bdbf73c98ee4fc0c1bc8165256bc2a72a499c24eb691fdd620a0e3a3dea574ec1c6459be8303df970f4ab6565107b1fce6499732b90701a445dab66e59a19cceb493e177639c4e0c652fb62095c66e0541612b9743e6219c6a9077100dfcd859d903b06d626ba27bb16e82be844c076359e57da8e53c3f7f72a258d24c90a1533f7a3133dae9c01f98046fa043795854fe57bc2278aa251ace2a7900762c90096f445efeec53c4e5fb84d213a89f50d9a0b4890a8407a9bfd9b63f1295c104ee612e600fb8b346e1e74a867b0e9cae6681a6a4354b33d1b82d1685b12a85639a93072a079c58e399a4671954e72e5c028751bd6d89c90fb16d85891b29122f5e16d6804ecc2581b14fd720a88115ae198d6237e441bc6e50f4f111b6fc4d01a8795f4475e58e14a9cf04aecfd5c29ec7a460526ee7451f661654f854fb41ab4b3c4b157c5d7a4cafad59efb0271ba2074440dd95a4e3db132ea56d298f95eaddd3a4121d7dd64d6f9d60cf785a8f6ee0420d3b5cf1ae5fc3679cd1687e6ea438bda85fdab5be8eeaf961c5f1b1c2f67fdb7c8683070132b911278f00eb00992954f11eadc93d5d1a522fe324858be0e9fb8aff4468e1cfb9ef6c5be1604a735ce06861888d47c462e32dd38618788245eab20747334ac0a86c10f174b0b2772ab80a4c56f083da32749c8e5304f72900d01b578612b37b713f5b350505daa9de78ac88e58bddde700c40cb4a0774d46381b2ccfb0ce8dfcf4b6dc48ebcb3927cb5f0c97219a38212707201d55e6370e39cdc0e982127077c8a5be2d67497e57a392f26adc2321395952075991dca0112c23294d6b3a5be3eaee24c072c94dc4e001a8d9e246a5570be692399fbaaa94e4f5a85bad388744bde614651564cf7f5f6943298c749ac46beeed0ac8e6dfe1b3193a886a165ffc74ad5d3090a17c99862c40878e4e32fab145bcd6e9df446655246f99ad7592ab424410fa4c75b298149a9152175e2f5734d2b5287955f034f9b46026480d06ba2d6a2caeb55b4310acd6b1e4430bb1c947e4f31e9ba0750b628bd325e413de49868525a40fab19f370ff5ff965a008a92e8165d39a1d4b5f37faf3b9c054f413795c618e99a10d6b36ca38cdce85bdfc790964ae49a99e728fed36b7d7bdd3c1d502a19848b58e47397cb0113a36b1cdeaef3c7b9811581498a48327fcc52fdd1f38c5c5a9e69589e32dbdf7b876def6caa9cfdf7750c123cdf8b2e4b79949fdc2cb529a8d2b435117db1f48e8add58ad36b359c3639918d16633dc8b09e4003463ff8e7abefdaac9d1a2bdd227255222580e9a1604b10e4c547f32f4f58d922f5ece3b1417955d15188583a2a66ea522bc546de5d1aca5ec2c1b53b398c99e5db43963f33b03b06df0ee7fa1ec056244e6da1661371e99e9a6e014c68edd1fea4b2a04bc54bb927f82ecf23daeda34ed6317e73b7f7d1cd7b95748d1b74fd54ae8b0c6c9e1c58bc5c1e119d48f22ec51155dc0e5415770d7a637cc7ceea5851608577e05d48f6d9f6f4c50721cdadcaf785addf642742678e0844acfc8ae26b45113b18b2d372e5b1120fac78d2b4cb6cc626e89c2616a81e063dd7d928460a10e0a1f94f3fb42fb705d21db1d193cb1a398cf0fccbfbb1c33243076da64cfe0250497211244e1727b3ee6102d15ad61aff5468efd5e2f382c5dd5f7240d6d00caed2001232a02117775d1a5cd89b8c36bdfff112feff66248ea3f6f12972bb69347d24a701bd60646c2966ae272fb79f6955ec92ae885d990b6e72605fc9e64cc98c81562d99f81b22480cff3fc8b5779140cd7c1d3bbc0059b03f208f1ac99c7dd3e305d690a8c3077f03f4d8f39200b0370d1e293b2303ed590e51c3fa51c9a29daf3cca8204f65d394cd2b3efcb909b84814
2021-08-25 11:31:59 -04:00
Dan Scales
099b819085
cmd/compile: fix CheckSize() calculation for -G=3 and stencils
...
Because the Align/Width of pointer types are always set when created,
CalcSize() never descends past a pointer. Therefore, we need to do
CheckSize() at every level when creating type. We need to do this for
types creates by types2-to-types1 conversion and also by type
substitution (mostly for stenciling). We also need to do
Defer/ResumeCheckSize() at the top level in each of these cases to deal
with potentially recursive types.
These changes fix issue #47929 and also allow us to remove the
special-case CheckSize() call that causes the problem for issue #47901 .
Fixes #47901
Fixes #47929
Change-Id: Icd8192431c145009cd6df2f4ade6db7da0f4dd3e
Reviewed-on: https://go-review.googlesource.com/c/go/+/344829
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
2021-08-25 15:30:19 +00:00
Ian Lance Taylor
e1fcf8857e
test: add test that caused gofrontend compiler crash
...
Updates https://gcc.gnu.org/PR101994
Change-Id: I50dcb90e315792efd7d83b496034ad33b5f199e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/343874
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-08-25 03:13:06 +00:00
Ian Lance Taylor
d37b8dedf7
test: add test case that gofrontend miscompiled
...
For #47771
Change-Id: I99dfdd48def756bde68445b50741afd6d86b6cf2
Reviewed-on: https://go-review.googlesource.com/c/go/+/344169
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-08-25 03:12:43 +00:00
Kir Kolyshkin
41b99dab0f
os/user: don't skip TestLookupGroup if supported
...
CL 37664 implemented this functionality, yet the tests were skipped.
Introduce and use additional variable groupListImplemented to
distinguish between these cases and enable TestLookupGroup for
supported configurations (which looks like all but plan9).
Change-Id: Iabaa7f08b4551dc67e67bdb6e715f15bb20d6218
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/330751
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
2021-08-25 03:07:54 +00:00
Cuong Manh Le
de1c934b97
cmd/compile: fix checkptr false positive for (*[Big]T)(ptr)[:n:n] pattern
...
The checkptr instrumentation is currently inserted before slice
operation has validated that n <= Big. So instead of panic, checkptr
have false positive throws.
To fix this, just insert the checkptr instrumentation after the bound
checking during SSA generation.
Fixes #46938
Change-Id: I9dbf84441c711842ccc883f3654ca8766ac696d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/343972
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-25 01:57:42 +00:00
Josh Bleecher Snyder
54cdef1f10
reflect: add MapIter.SetKey and MapIter.SetValue
...
These augment the existing MapIter.Key and MapIter.Value methods.
The existing methods return new Values.
Constructing these new Values often requires allocating.
These methods allow the caller to bring their own storage.
The naming is somewhat unfortunate, in that the spec
uses the word "element" instead of "value",
as do the reflect.Type methods.
In a vacuum, MapIter.SetElem would be preferable.
However, matching the existing methods is more important.
Fixes #32424
Fixes #46131
Change-Id: I19c4d95c432f63dfe52cde96d2125abd021f24fa
Reviewed-on: https://go-review.googlesource.com/c/go/+/320929
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
2021-08-24 22:23:12 +00:00
Keith Randall
5d863f89fe
cmd/compile: simplify bad conversion check
...
Now that we're using OCONVIDATA(x) everywhere we formerly used
OIDATA(OCONVIFACE(x)), there should be no OCONVIFACE operations that
take a shape type.
Change-Id: I4fb056456c60481c6dfe7bc111fca6223567e6a8
Reviewed-on: https://go-review.googlesource.com/c/go/+/344577
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 22:10:11 +00:00
Keith Randall
c2f96e686f
cmd/compile: mark ODYNAMICDOTTYPE as an expression that can panic
...
Fixes #47924
Change-Id: I4325b3c4ed9d369d9ea778478285436e1b2ab08a
Reviewed-on: https://go-review.googlesource.com/c/go/+/344571
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 18:31:34 +00:00
Dan Scales
5b64381155
cmd/compile: fix naming of types inside instantiations
...
Issues 47713 and 47877 were both due to problems with the names used for
instantiated functions/methods, which must be in sync with the names
used by types2.
- Switched to using NameString() for writing out type arguments in
instantiation names. This ensures that we are always adding the
package to type names even for the local package. Previously, we were
explicitly adding the package name for local packages, but that
doesn't handle the case when the local type is embedded inside a
pointer or slice type. By switching to NameString(), we fix #47713 .
- types1 and types2 write out 'interface {' differently (vs.
'interface{') and we were already handling that. But we needed to add
similar code to handle 'struct {' vs 'struct{'. This fixes issue
#47877 .
While fixing these bugs, I also moved some duplicated code (which
include some of the changes above) into a common function addTargs(). I
also moved InstType() name to subr.go, and renamed: MakeInstName ->
MakeFuncInstSym and MakeDictName -> MakeDictSym.
Also removed a couple of ".inst..inst." prefix checks which are
irrelvant now, since we don't add ".inst." anymore to function
instantiations.
Fixes #47713
Fixes #47877
Fixes #47922
Change-Id: I19e9a073451f3ababd8ec31b6608cd79ba8cba36
Reviewed-on: https://go-review.googlesource.com/c/go/+/344613
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
2021-08-24 18:30:13 +00:00
Matthew Dempsky
4a9f0cec29
cmd/compile: change irgen to generate exprs/stmts after decls processed
...
This CL changes irgen to wait until all top-level declarations have
been processed before constructing any expressions or statements that
reference them. This is the same approach that typecheck used.
Mechanically, it splits varDecl and funcDecl (the two top-level
declarations that can generate/contain code) into a part that runs
immediately for constructing the ir.ONAME, and then a separate task
that runs later to handle the code.
It also adds an exprStmtOK flag to indicate when it's actually safe to
start constructing (non-trivial) expressions and statements.
Fixes #47928 .
Change-Id: I51942af6823aa561d341e2ffc1142948da025fa2
Reviewed-on: https://go-review.googlesource.com/c/go/+/344649
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 18:02:21 +00:00
crazycomputer
daa55b21d1
cmd/link: guarantee "section .debug_gdb_scripts" is always "$GOROOT/src/runtime/runtime-gdb.py".
...
to guarantee the "section .debug_gdb_scripts" is always "$GOROOT/src/runtime/runtime-gdb.py" , a check for package name is needed when search "runtime/proc.go".
Fixes #47881
Change-Id: Ib471314ca1a6777f625b488e5ae3790457540ef9
Reviewed-on: https://go-review.googlesource.com/c/go/+/344229
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
2021-08-24 16:55:17 +00:00
Robert Griesemer
e6798795ff
cmd/compile/internal/types2: use TypeList in the Inferred struct
...
This is a port of CL 343934 from go/types with the necessary
adjustments to the compiler.
Change-Id: I810144e6e2eb2bc8fa0d34dc206403c993cbbe7a
Reviewed-on: https://go-review.googlesource.com/c/go/+/344616
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 16:36:59 +00:00
Robert Griesemer
b1cdf860dd
cmd/compile/internal/types2: use a TypeList type to hold type arguments
...
This is a port of CL 343933 from go/types with the necessary
adjustments in the compiler.
With this CL type parameters and type lists are now held in
TParamList and TypeList data types which don't expose the
internal representation.
Change-Id: I6d60881b5db995dbc04ed3f4a96e8b5d41f83969
Reviewed-on: https://go-review.googlesource.com/c/go/+/344615
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 16:36:55 +00:00
Robert Griesemer
1ff0554b53
cmd/compile/internal/types2: use []*TypeParam rather than []*TypeName for type param lists
...
This is a port of CL 343932 from go/types, with the necessary adjustments
to the compiler.
This change improves type safety slightly, avoids many internal type
assertions, and simplifies some code paths.
Change-Id: Ie9c4734814f49cd248927152d7b3264d3578428c
Reviewed-on: https://go-review.googlesource.com/c/go/+/344614
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 16:36:48 +00:00
Robert Griesemer
bd97763577
cmd/compile/internal/types2: use an opaque environment for Instantiate
...
This is a port of CL 343930 from go/types, adjusted to work for
the compiler: here Environment carries a *Checker, if available.
Change-Id: I44544fad7da870fa0c02832baa6abd2909d50304
Reviewed-on: https://go-review.googlesource.com/c/go/+/344612
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-08-24 16:36:47 +00:00
Robert Griesemer
bba460499c
cmd/compile/internal/types2: don't export TypeSet
...
For now don't export TypeSet in the interest of
keeping the types2 API surface small(er).
This is a clean port of CL 341289 from go/types.
Change-Id: I50c747629f25472f2ec5ba59d7f543ee3c1c423b
Reviewed-on: https://go-review.googlesource.com/c/go/+/344610
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-24 16:36:46 +00:00
korzhao
d70c69d830
embed: document the maximum file size supported
...
Fixes #47627
Change-Id: Ia1edfb6249863ab055fab68a35666bc2bdf21dcb
Reviewed-on: https://go-review.googlesource.com/c/go/+/341689
Reviewed-by: Jay Conrod <jayconrod@google.com>
Trust: Michael Matloob <matloob@golang.org>
2021-08-24 15:55:38 +00:00
subham sarkar
f98b6111eb
go/token: match the implementation of index selection with sort.Search
...
name old time/op new time/op delta
SearchInts-8 15.5ns ± 2% 13.7ns ± 4% -11.87% (p=0.008 n=5+5)
(see CL 36332 for the original change to sort.Search)
Change-Id: If452818185b92b8b3548b066f475e493d604ea29
GitHub-Last-Rev: 32dd3cffa6golang/go#47293
Reviewed-on: https://go-review.googlesource.com/c/go/+/335809
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Robert Griesemer <gri@golang.org>
Trust: Than McIntosh <thanm@google.com>
2021-08-24 15:52:22 +00:00
Dan Scales
8eeb1bff1d
cmd/compile: reuse same node for global dictionaries
...
Change stencil.go:getDictionaryValue() and reflect.go:getDictionary() to
reuse any existing name node that has been created for the needed global
dictionary. Otherwise, these functions may set the Def on a specific
dictionary sym to two different name nodes, which means the first node
will not satisfy the invariant 'n.Sym().Def.(*ir.Name) == n' (which is
the assertion in this issue).
Fixes #47896
Change-Id: I1e7ae1efd077a83c7878b4342feb6d28d52476cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/344609
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
2021-08-24 00:01:29 +00:00
Dan Scales
be1a693477
cmd/compile: fixes for non-constant Sizeof/Alignof/Offsetof
...
Includes Robert's suggested fix in validate.go to not fail on
non-constant alignof/offsetof/sizeof calls. Further changes to wait on
transforming these calls until stenciling time, when we can call
EvalConst() to evaluate them once all the relevant types are known.
Added a bunch of new tests for non-constant Sizeof/Alignof/Offsetof.
Fixes #47716
Change-Id: I469af888eb9ce3a853124d919eda753971009b3e
Reviewed-on: https://go-review.googlesource.com/c/go/+/344250
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
2021-08-23 22:55:34 +00:00
Martin Möhrmann
8157960d7f
all: replace runtime SSE2 detection with GO386 setting
...
When GO386=sse2 we can assume sse2 to be present without
a runtime check. If GO386=softfloat is set we can avoid
the usage of SSE2 even if detected.
This might cause a memcpy, memclr and bytealg slowdown of Go
binaries compiled with softfloat on machines that support
SSE2. Such setups are rare and should use GO386=sse2 instead
if performance matters.
On targets that support SSE2 we avoid the runtime overhead of
dynamic cpu feature dispatch.
The removal of runtime sse2 checks also allows to simplify
internal/cpu further by removing handling of the required
feature option as a followup after this CL.
Change-Id: I90a853a8853a405cb665497c6d1a86556947ba17
Reviewed-on: https://go-review.googlesource.com/c/go/+/344350
Trust: Martin Möhrmann <martin@golang.org>
Run-TryBot: Martin Möhrmann <martin@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-08-23 21:22:58 +00:00
Matthew Dempsky
Robert Griesemer
Dan Scales
Michael Matloob
Dan Kortschak
vinckr
Cuong Manh Le
Jake Ciolek
Joe Tsai
korzhao
wdvxdr
Ian Lance Taylor
Kir Kolyshkin
Josh Bleecher Snyder
Keith Randall
crazycomputer
subham sarkar
Martin Möhrmann