Filippo Valsorda
ed1f812cef
[dev.boringcrypto] all: merge commit 9d0819b27c (CL 314609) into dev.boringcrypto
...
There used to be two BoringCrypto-specific behaviors related to cipher
suites in crypto/tls:
1. in FIPS-only mode, only a restricted set of AES ciphers is allowed
2. NOT in FIPS-only mode, AES would be prioritized over ChaCha20 even if
AES hardware was not available
The motivation of (2) is unclear, and BoringSSL doesn't have equivalent
logic. This merge drops (2), and keeps (1). Note that the list of
FIPS-only ciphers does not have priority semantics anymore, but the
default logic still sorts them the same way as they used to be.
Change-Id: I50544011085cfa2b087f323aebf5338c0bd2dd33
2021-05-13 12:59:22 -04:00
Katie Hockman
ad1b6f3ee0
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: If0c5d89cf730007d05918e60e56a0e1b5afaa118
Reviewed-on: https://go-review.googlesource.com/c/go/+/318389
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2021-05-10 15:42:14 +00:00
Ian Lance Taylor
862ddb37b4
runtime: rename walltime1 to walltime
...
Change-Id: Iec9de5ca56eb68d524bbaa0668515dbd09ad38a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/314770
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
2021-04-29 14:15:04 +00:00
Russ Cox
a6d3dc40c4
misc/cgo/testso, misc/cgo/testsovar: fix for Windows
...
At least in mingw-clang it is not permitted to just name a .dll
on the command line. You must name the corresponding import
library instead, even though the dll is used when the executable
is run.
This fixes misc/cgo/testso and misc/cgo/testsovar on windows/arm64.
Change-Id: I516b6ccba2fe3a9ee2c01e710a71850c4df8522f
Reviewed-on: https://go-review.googlesource.com/c/go/+/312046
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2021-04-23 21:48:41 +00:00
Russ Cox
19470dc535
misc/cgo/test: do not redeclare exported Go functions
...
An exported Go function like
//export F
func F() {}
gets declared in _cgo_export.h as something like
extern void F(void);
The exact declaration varies by operating system.
In particular, Windows adds __declspec(dllimport).
Clang on Windows/ARM64 rejects code that contains
conflicting declarations for F, like:
extern void F(void);
extern void __declspec(dllimport) F(void);
This means that F must not be declared separately from _cgo_export.h:
any code that wants to refer to F must use #include "_cgo_export.h".
Unfortunately, the cgo prologue itself (the commented code before import "C")
cannot include "_cgo_export.h", because that file is itself produced from the
cgo Go sources and therefore cannot be a dependency of the cgo Go sources.
This CL rewrites misc/cgo/test to avoid redeclaring exported functions.
Most of the time, this is not a significant problem: just move the code
that needs the header into a .c file, perhaps with a wrapper exposed
to the cgo Go sources.
The one case that is potentially problematic is f7665, which is part of
the test for golang.org/issue/7665. That bug report explicitly identified
a bug in referring to the C name for an exported function in the same
Go source file as it was exported function. That is now impossible,
at least on Windows/ARM64, so the test is modified a bit and possibly
does not test what the original bug was. But the original bug should
be long gone: that part of the compiler has been rewritten.
Change-Id: I0d14d9336632f0e5e3db4273d9d32ef2cca0298d
Reviewed-on: https://go-review.googlesource.com/c/go/+/312029
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2021-04-23 21:42:52 +00:00
Filippo Valsorda
11061407d6
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: I1f87576622e2286ae9bc8cd19745d80d7860b293
Reviewed-on: https://go-review.googlesource.com/c/go/+/312295
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-04-21 18:41:50 +00:00
David Chase
34620364cb
runtime, cgo/test: improve debugging output
...
tests that run commands should log their actions in a
shell-pasteable way.
Change-Id: Ifeee88397047ef5a76925c5f30c213e83e535038
Reviewed-on: https://go-review.googlesource.com/c/go/+/309770
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2021-04-13 23:56:27 +00:00
Brad Fitzpatrick
13a4e8c41c
all: simplify the spelling of Linux
...
The prefix didn't help clarify anything.
Change-Id: I897fd4022ce9df42a548b15714e4b592618ca547
Reviewed-on: https://go-review.googlesource.com/c/go/+/309573
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2021-04-13 13:56:21 +00:00
Naman Gera
52bf14e0e8
all: fix spellings
...
This follows the spelling choices that the Go project has made for English words.
https://github.com/golang/go/wiki/Spelling
Change-Id: Ie7c586d2cf23020cb492cfff58c0831d2d8d3a78
GitHub-Last-Rev: e16a32cd22golang/go#45442
Reviewed-on: https://go-review.googlesource.com/c/go/+/308291
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
2021-04-10 01:46:41 +00:00
Ian Lance Taylor
554d2c4f06
reflect: panic on New of go:notinheap type
...
For #42076
Fixes #45451
Change-Id: I69646226d3480d5403205412ddd13c0cfc2c8a53
Reviewed-on: https://go-review.googlesource.com/c/go/+/308970
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2021-04-09 23:54:31 +00:00
Changkun Ou
972e883925
runtime/cgo: add Handle for managing (c)go pointers
...
A non-trivial Cgo program may need to use callbacks and interact with
go objects per goroutine. Because of the rules for passing pointers
between Go and C, such a program needs to store handles to associated
Go values. This often causes much extra effort to figure out a way to
correctly deal with: 1) map collision; 2) identifying leaks and 3)
concurrency.
This CL implements a Handle representation in runtime/cgo package, and
related methods such as Value, Delete, etc. which allows Go users can
use a standard way to handle the above difficulties.
In addition, the CL allows a Go value to have multiple handles, and the
NewHandle always returns a different handle compare to the previously
returned handles. In comparison, CL 294670 implements a different
behavior of NewHandle that returns a unique handle when the Go value is
referring to the same object.
Benchmark:
name time/op
Handle/non-concurrent-16 487ns ± 1%
Handle/concurrent-16 674ns ± 1%
Fixes #37033
Change-Id: I0eadb9d44332fffef8fb567c745246a49dd6d4c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/295369
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
2021-04-06 23:39:42 +00:00
wolf1996
d5b9dc1317
cmd/cgo: pass end position info for C function arguments.
...
Pass information about original end position for c function arguments
processed in pointer checking generated code.
Fixes #42580
Change-Id: Ic8a578168362f0ca6055064dbbea092ad37477a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/269760
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
2021-04-05 19:29:17 +00:00
KimMachineGun
a040ebeb98
all: update references to symbols moved from io/ioutil to io
...
Update references missed in CL 263142.
For #41190
Change-Id: I778760a6a69bd0440fec0848bdef539c9ccb4ee1
GitHub-Last-Rev: dda42b09ffgolang/go#42874
Reviewed-on: https://go-review.googlesource.com/c/go/+/273946
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
2021-04-05 17:51:15 +00:00
Filippo Valsorda
b397e0c028
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: I24409a5661489f96153f71f20412460c8fc4bf1c
Reviewed-on: https://go-review.googlesource.com/c/go/+/303953
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2021-03-23 23:14:40 +00:00
Cherry Zhang
7a1e963058
cmd/compile, cmd/link: dynamically export writable static tmps
...
Static tmps are private to a package, but with plugins a package
can be shared among multiple DSOs. They need to have a consistent
view of the static tmps, especially for writable ones. So export
them. (Read-only static tmps have the same values anyway, so it
doesn't matter. Also Mach-O doesn't support dynamically exporting
read-only symbols anyway.)
Fixes #44956 .
Change-Id: I921e25b7ab73cd5d5347800eccdb7931e3448779
Reviewed-on: https://go-review.googlesource.com/c/go/+/301793
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-03-16 23:14:54 +00:00
Prajwal Koirala
de2b27dee7
all: run gofmt
...
Fixes #44980
Change-Id: Icef35319d1582d8367c8911e15d11b0224957327
GitHub-Last-Rev: 2113e97e83golang/go#45005
Reviewed-on: https://go-review.googlesource.com/c/go/+/301632
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
2021-03-15 21:49:19 +00:00
Filippo Valsorda
128cecc70b
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: Ibaf5108b9bac7a6eff2d43f6d222607e987d13a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/300691
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2021-03-15 19:21:50 +00:00
John Bampton
8e725f8452
all: use HTML5 br tags
...
In HTML5 br tags don't need a closing slash
Change-Id: Ic53c43faee08c5b1267daa9a02cc186b1c255ca1
GitHub-Last-Rev: 6522081169golang/go#44283
Reviewed-on: https://go-review.googlesource.com/c/go/+/292370
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
2021-03-13 03:38:42 +00:00
Ian Lance Taylor
73eb27bd3b
misc/cgo/testcarchive: don't use == for string equality in C code
...
For https://gcc.gnu.org/PR99553
Change-Id: I29a7fbfd89963d4139bc19af99330d70567938ea
Reviewed-on: https://go-review.googlesource.com/c/go/+/300993
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
2021-03-13 03:16:55 +00:00
fanzha02
3a3b8164fd
cmd/dist: refactor test constraints for misc/cgo/testsantizers
...
Currently, the cmd/dist runs test cases in misc/cgo/testsantizers only
when memeory sanitizer is supported, but the tsan tests in
misc/cgo/testsanitizers do not require support for -msan option, which
makes tsan tests can not be run on some unsupported -msan option platforms.
Therefore, this patch moves the test constraints from cmd/dist to
msan_test.go, so that the tsan tests in misc/cgo/testsanitizers
can be run on any system where the C compiler supports -fsanitize=thread
option.
Change-Id: I779c92eedd0270050f1a0b1a69ecce50c3712bc9
Reviewed-on: https://go-review.googlesource.com/c/go/+/297774
Trust: fannie zhang <Fannie.Zhang@arm.com>
Run-TryBot: fannie zhang <Fannie.Zhang@arm.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2021-03-11 05:38:13 +00:00
Filippo Valsorda
5e2f5a38c4
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: I091f7be19c4c01a0c878783335bea2e1724c85b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/296989
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-03-10 21:36:24 +00:00
John Bampton
2b0e29f516
docs: fix case of GitHub
...
Change `Github` to `GitHub`
Change-Id: I514e8dc9a19182fcf9fcf5bc1b5fbff253c1a947
GitHub-Last-Rev: 7124c7058egolang/go#44260
Reviewed-on: https://go-review.googlesource.com/c/go/+/291950
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-03-05 02:35:21 +00:00
Cherry Zhang
a655208c9e
cmd/link: handle types as converted to interface when dynlink
...
When using plugins, a type (whose value) may be pass to a plugin
and get converted to interface there, or vice versa. We need to
treat the type as potentially converted to interface, and retain
its methods.
Should fix #44586 .
Change-Id: I80dd35e68baedaa852a317543ccd78d94628d13b
Reviewed-on: https://go-review.googlesource.com/c/go/+/296709
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-02-26 16:27:08 +00:00
Filippo Valsorda
03cd666173
[dev.boringcrypto] all: merge master ( 5b76343) into dev.boringcrypto
...
Change-Id: I52c5b317a97c7723a7c077ae3cdfdc756fd3a1cf
2021-02-24 15:49:21 +01:00
Tamir Duberstein
a671e33c6d
all: use more precise build tags
...
s/!gccgo/gc/ in files which use gc-syntax assembly.
Change-Id: Ifdadb62edd1210ebc70e7cd415648b752afaf067
Reviewed-on: https://go-review.googlesource.com/c/go/+/269957
Reviewed-by: Than McIntosh <thanm@google.com>
Trust: David Chase <drchase@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>
2021-02-23 19:55:03 +00:00
Russ Cox
01f05d8ff1
runtime: unify asmcgocall and systemstack traceback setup
...
Both asmcgocall and systemstack need to save the calling Go code's
context for use by traceback, but they do it differently.
Systemstack's appraoch is better, because it doesn't require a
special case in traceback.
So make them both use that.
While we are here, the fake mstart caller in systemstack is
no longer needed and can be removed.
(traceback knows to stop in systemstack because of the writes to SP.)
Also remove the fake mstarts in sys_windows_*.s.
And while we are there, fix the control flow guard code in sys_windows_arm.s.
The current code is using pointers to a stack frame that technically is gone
once we hit the RET instruction. Clearly it's working OK, but better not to depend
on data below SP being preserved, even for just a few instructions.
Store the value we need in other registers instead.
(This code is only used for pushing a sigpanic call, which does not
actually return to the site of the fault and therefore doesn't need to
preserve any of the registers.)
This CL is part of a stack adding windows/arm64
support (#36439 ), intended to land in the Go 1.17 cycle.
This CL is, however, not windows/arm64-specific.
It is cleanup meant to make the port (and future ports) easier.
Change-Id: Id1e3ef5e54f7ad786e4b87043f2626eba7c3bbd9
Reviewed-on: https://go-review.googlesource.com/c/go/+/288799
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2021-02-19 00:02:06 +00:00
Russ Cox
0f210b75f9
[dev.boringcrypto] all: merge master ( 2f0da6d) into dev.boringcrypto
...
Manual edits in src/cmd/compile/internal/reflectdata/reflect.go
to keep build working.
Merge List:
+ 2021-02-17 2f0da6d9e270c37ee7d084825599dcd3cd4830add3cd4830ad03cea563d15faf941b8fb049c7a5faf941df0ed55da46ab7696c94334c2358a1ae78cfbf34dd96f3da9d2f6d28aae26b0098504c73f1004a7cb316530f2617f353e111455e0215315f5f0d23c9dbb0cb3415154626ef0812730641e36aa33d72fd412852ce7c21266c27093d0b81efb7ec4a7e9b4b948060fa49bd2baa6c75dced1fd9a8863ff0e93eff0e93ea31249da7ec02864d4f1c6b26ceae85a8930c2c9a68e5b08e6d5ced8079096f59703d53e2e9c9683597168d6a49a50a620677081c58fcf7ed493363ccffe0ac989cf3c48d1503ba813958f13c11d15c171bc9d6f45feccea4e21b52dc725bfb3c618e3c15bd50449de66a19018537b0dfb177f2e60c00f5622f9e1ccbc5d7dc538881901853098ed3e4afa12a21de9ec73724d0720b3b54cd94d474516afebed8fa84772ba946351d5a2397a46a10ae79c2fd4287cc6de59f263de211014120b819f4552d5cb2822bc451b5770afd67f33348869086d8f401d7e5a24bfc7418e6de491c6eea923b0c1f76efca94abfca94ab3ab98f8454a731426a571b732e789f4fbca6999e27c0b6cfea63426e29aa15a6ac91e460c44361140c068058edc39c8bd8010ff41bb49b878725a642c2d4b068cafb5376518d77faca22bddf2667e08ba8c00f2ff5c9435334caf18a5a5e2c9688cfa01943aff9e8364c6cd176b36156c8fbfbdcf5cdf0da1bf210f70e2980f797f168d9b636feafef7dad5eae48634a234df1d5e14632e5e4a0cdde3bf0f7c9cf263e9f77ce8b318624bf0f7c9d78deaf29a8a8ad2ca26a52a51921fa5be6b6d107f77eaaf28cae96a276363b3d85c69a0b54514c6b286f5e79f470cabffc199d6de8443f3b6a4739ccc5be9612a832#42637 is fixed
+ 2021-01-25 8ee3d3983854b251f5425a76c3d548ff82cc971a044f937a73063c72f06d9456804b634f5d97a9897655c61cd99385ff4d05d6fab3266ee8b158f48badc5fa851e1819a8d25c39e4fb5eb21b31e483a778ff50fa2cef9b5447e0a81d280dab3e5adab3e5affea1b53d85dab268b60774ec4051763d7ece3a7b1750cba0506fcf10e69f17ec1b94526511def3d40b07b0235609e2b4f1fea59f43a9e07b3c2f11ba5b953d1feca9b186e4d70d5a8a2265fb46e2e2e9d93d40895e36d95ca91380d7e71c01ad5248f59a22970d8b6cb268a4664475fd9a391cdd19a6db6b639f036844db213c3905e91760d736f6ecf4ebf10092cb157cf3d2d155d1ae803d18fc6c6e243ce71dbe28e5abc5928bda4f4a824f2d635c0575e35e509423d50d53ccb2e90688ca5774a5a5d047c91a6c61debffd979fed39d281a2f825c5424a4212c0e54f5c603c0fdbab0798355a8fbb0d2d422f38fb6c6113db0bb44c835f91690ffa1ead6e7e0fa38aad99a5db11ac87845d14f9e3027c682859ff93fe6482b9cae70088956fc4b17ce2a8383dba0e8a92fa78e5aabcdb6de9423445a956a0e909ab3b67abfdc9b1445ac8682a1d21769f83418b83ec9470162f54198b04dbb386c735e7bb5075a5251deae0b59703a875137f14537e6e54ab523fc510ff196c3e84b7a698c73f4be7af23f9e125ccd10eeb330020dc84e8a06f620c86b999c3913579589135b9c66601d9b79e53bbc73232d08f6aa28d3e069734fd482df97983249a44763004255a5ab24689983ac4b0867eb31d999cd6d4673728c41b999ad4861707a8c8c1370e918f2abd24f3b79a19481acbd9acf6f3a341352fd401d6ad88b4db432f9ffb11cc90e7a51ecd5b74d2dfba76567bc2665def2c1195acd8121b12ee55ba7bb4d2a0445bf57f48405381ea89adf3759309029fc3b4c7093a7fd84c6e46c9c26d7ffb950cf4d46c8b2efa990b59bfc18e346ee9b118a2cd6f3a54e46192b9875125886cf4bd62508339118f6a9acbb36598c65646fefad1dc856728118e0ae65c543f3c0c5afc4fb732afcc9436c6513bca5ab241938e04304f769ffcae97717133a9ccd2d795d92f8add32cab1202183ee4d32249b54bd1ccce29ec21a8f34091414b5b79b55088d6bfa90aaca7d7cee66d4cbe60cffa4ca6da2d3b7d7df81a158194787e906cfc9658bee934c668b25c6d2131704a63e1e13ce6d0b0d004983cb05a0aa6a9821838832fd43831f44fb69c67cad1b85e7c05781f4f0e9126b37b15d954a9d9adea477365c5ed7e09783cbc09aa950c407eb626409d1c28ca67a969eef49cfa6b01fb2af9ef24e40c14ad89705e087290b4154b7a30fd528848fc44cf0fa907a4bfdc7f2e6dab048d36a6bf44da317067d655d80a590a2bb1b6c95c257c426c9a5b1747756e3f2538033c02f2d4b4e683dd58676051544a031987958a23ea3bfa97ba48f67ad695416fad9a8b5287d556698479ed1577779ece345aa696ddbc75efd68e6fa4f683a4474cdfd0f1d2129c4b8fd3440cdfd22df9905dfbcff80c677fd81a3e68fe1197654477b04906095ce805d1420d0991b86ed301733bb0ae2e032f2178c667db2f0d99def5b451693af710c1a899a6cf9b67f76a5499851bac882ab3d14489958b7ed3e780b4de16bb4a71c95d2f83e0f6616f5816624cd850aa7c60c37babc97bb5cf3c87fa6b3e1ec97fd0620c674dd0523d525ae9ea272e5ece40cb4d4ae6f30c95048171fc6f22333801cdc6282ad3083f8e34c44a7c4a5ec920160ec59b197d525c613c02d289da2b33e6acbae4fcc4629f6a51de563715b303f370b75fb4fd945588207569dac4e1d7813976136be027fda7ec3a3f098a6490b9137f0d2e063383b5c74af8afb8216a5f3bd59a0d3bdafb0d822ecf52b841ed9772e130a59d26603ffbc4458c066c67677541676d794b81c98548e1104c215c4fa9e6c973198d135ce1c4850f732f8c910de8eafd98a4f335f4201d781391282018b68a65e4f293d8531d9a1f67d5396b6c2e7ce24d2f3d052785c691c24b1d0fe66f082cc8b7d927b248b30740818038bfb1164044448db7e2fecdfb96f07e1ad1502b3c7230c99cbb7a49d0b239cb9eeed291bcd1d64e4cea98a73030b0d19018e8f153f082b0ee31267f82e1addade2cce18ebfb49e987a592b356589802502663c96c2ee737f138df6b3d8a3cb06b3f04d964abe4895ab4c001fd2d05c86c34d2f420de65151e504dfb5d91a8fbc82f03b1de454eef5f071ab0a14c0ced54062e575fd6ff0a0256ba99a8b9693d7627dac0de3748527a1895d665c4c6dfb29ee309255aead4957892440308ffd7f9d373720e14d667341f6f27d29be0fd6ba1c8a269cf39089f6d03cde88ab0b0d98283d1d1099c91223331fc0cec741b0447c9fb4ebacc32ea124c9fb4eb0a2c40934b33d280e7fd1ee51ba53f5c2572f168ed23b12c6dc087c8f5356abc06a354bcc0aa9b4709acb28c96be8c8610e47003512cde10a2755361e6a301af2cb714d27c4c2239b6147120a306b2451c8bc7e4d925794cfeca0a5cb4898a77d06915ac14d6cff874c474e8f681eff1a523c8ab0e999c170224836e28ac085ce6ecfe31a3b036b832153a999140bb0baf683ca8e17164e8438a5779bcb95819cf653c984d9769abbe2771089b44b4e2b55b58018f4626cc7c02d139cd0e12f2de7866470c45313bf45ffb0cb7044c76be2a24e4e8f1e139f27aba226510b9cb63b8dae652a4ac9740851bacaf1778c28a98fcf318123520f3b72db2ff33f5e44aeedc9f8040328c3b66088e1415d089c384e881ebe64c8bece5024396563dd67b13d0742fec2ded4389ae3d5ba5fe64298a4aa55d4e54b846740c17fbf9bbbd6ed4ac6a6317bf6efa3d4a4f6d2834f8f7fde0d2b50114af2a0444dfc7333f4a997543292578fbbe3aa5ae70b85c6fa06894b365a4db102b2b0f01e17f85abda2618ba318d56c1ef4e7a6b90575e16f512708b5091d038981092d71731bb54038129bb1917b685a322fe43d6467824c7cdc84a15b412dc2f4d38e2d74b705f8ac237032a508840c675046cb8a6e3298300ddf4c2d66f642305d93ef849f16620f465a25a3fd1dfea898a4b0663cd862ed48dfa2b2dc033390d9ad48906a6d576e3cc5c56f278b9a8a4a617383377fd06794da4adea6d94a442f5b1a3974c81343ce3a828746ec57be10af7c4e89f38323face61ccca8fa58be734ea8ce37e41107e17b46c582b76429eb09c5241e520267975dc4764d8846aae451b6b38fd0a02371b0541d8e61a6b14305527f61341a3decde508c1c67b58e381b0b2e012d0dc341fe891a9376d3d3fb37f6a64f6dc31985d91666ce0d20e52eed0f40d29226d2b3351f6e5522c882d422dc83baa56b783ad94b1107333270aba8f24cb6c64b6db6889f465c2b5f1980efb924f1b0a44cb63bc23b545eae8fd519b837b35cc550c494406644090af83c5e2d278bfeb5627a4dc30db6032dd0c854a2f8e016fa06d960bae9b442df231496cfde501b76d5fbc48d6275952dbf2fc8cffbb31c753436db970e20a1c8943a6ad9c91cab0dadcec658f6c1a98ab0e2d6362d01c159b8c27255863722da46b7ad6596c476d783e74402de0af3b1b724374f85961889ba6806ea2b8c54cbb4a37bd9370155cca813904a62829fb17dfa43d3b25f3c1508ce2605c5b158c9dd131a79742f39aef5964dd6bdcc640e8392cec6c4a8c50cdb2d8e98d345851719c0e2db0517f9a2bc2bcac0ba6707cc155931974d90b199e9ce10c94af26e885df27312d4c95565a1b5eed89826c5967e5283b2a578166be9379f8a84de4480dc30b99ea3b1646b6e70e3bb75f51c645133b03e1c3d9cb84c84bedf60be1515dbd2e8e449ab3d854adbb5aa2b6644725c3ffd118f2df7e81d855b30fe4b9df26d7a80d1b44c6457fcf5b994c989a3f504199ecfcae31478bde3a435d4569197e21cfadf0dc735806450837588ffcb2b67b7ddabccc386bd05a84cb51d7d72c2980aa0c37a32a1833b78b427be5b635e4b8084eb7ceba06bacb307b807f5a3196c9351bc2f38cbdc9a837e99b0e8a2c95b1369d5862a2058bac21beb5e054047e81135be76e30fc10fcd0c0dc682cdda2991c2e58768ae15b59b8916d48932733d421c519b156fc5246fa5e7507cba70d57d0c0dc682c00e57277905a3b6796cdda54dfb6a178e442ea79f26f227f6664bc656aed48838c35dc2d0258d495ecc8d15bc5ec5f349b2205ddb879c7ac38af2f3d3d913a92665984ea719710240b9d6bc32140fa940433845ad1c769d393dec10b0ad62842e46f4ae077a71e005715085f897473e796cb00cf7aa585ac8cd35e00bd6f84993e904826abb6c2283d65413d1408d26ccc7fca39aa057430266af420e251864b933ce97bba50b16f9de5212d385a2f4ef78b09c9ae3bfba6265ffa275f3cdd4a52c2a56ca23a45fea17c5e2fcef37aa5e4e263a6f08b39f2311462ab2d6ff998edecff7628ea4da41fb3f8dadfc80bc1f5978a0958a36ba090fdf3741bdf7c45f3b646d49a5a11adfa0ecf7696330f9f27287b41ad4dec99ffa68716a02bc814cd18b7f67b75d25fc192af567c9b6b1ca27f688d18c0c6de5d8d1fd2b436d95d4f42a9b76b7b192f33cf848dff6ddaa45e12fd4bd6abf298cfae1a3378094e7685ef1ad40869fcedf0001e88671b84aabb01e5c6463e204eaef981b5e84b27bec5c4bd0b747465ae15ac5d862f638a89f6106d195d420809ab08be3d8b40b5b09dbc6913171787efcd79a3d5ce150c65a2f31765f4ec2faec193279e2c294c214ccae5da18df524ce0a7cea6358d35455db94346e69bcb84d831c90252cfd84d91f77ca2f8926994fd7cf0ff6d4a6788e33f6ecb40f5bc4d554481ad6eb64481ad6eb6ef603bead541f3af9d044d0d9c2c5cc26aead50cacb4d1cef141ab6689ed048debb22484e2bd611f331b8b479726b66fd60beb3086e5a83c240f5d179dc2350d8c756661c82ab9365488f0df68e01b68259fd8adbb1d3baf20dc18573aea3c6e583d65abd166ef6876750b3729dc92629097649e0e43d84d4a6b4fd139484449c6411308f11897f6dcc975f77d72951229e8de596f04ba2adc21e86826287c6bc22bc745c3ee6132a6984f9d54e41dfd11a32c928e2106327c65dcd15c72742c05e3bc015423a15bc767d732276dae48fb0b88a9e2f9ad4af2decf30668e3a598f96f3fb72441abb12fc97228b732ad9e37597f7f0357c5768785fd949e4bd7b144ed4f76965b01ea27dc5d909fbc754f25241c50c7a8c06d5928847deb30c7a8044e1047302bd762eda346a48a1a51898d902791b509ea6364a5ef7342596daf93ef07b113f5a97514b78e59bb1f7c47eac7db03fd4917472676f0a45eda19c925edac306fd6d0b5e58ae43be012efc67f29264067a41cb3f84ad258bbd8294d066c02645060dcc7d6ea8c72a4488817eed73f36ff3ce010b3359f5fdac5dadd45938b5498d8d5371e73697b710cb674b5c13c31540364c4d048194cd5ba1c3f290ff2824d4b30bb6115dd696b943a48335693d037f5b0ec1a6acb4f3d52f6ab63db7f724ae76f6e962ee1b51294ad3072b8383b194b5151f64ef84881f399b5d14d4a14e7bf6d4bcfaeca58c041a4e4c3405082c90d501df2febf50968d2d5993e56bad13b0ae3b7cb74869e2957b997700baf8b38367d098ed834ecec860932dc2118d70a33a40bc7233dd063f2eea4c1dc92c732e901782cf560db4f63e0a1f886954d5246f423d616b135455fff0e31f71506d730ba798093f016172dbe60b1253293062e0e5ce61e1fa5903bb34b0aaf69c167635a6ee75aef80ca9ef65ff1374bc5f6f45fd7974c31d0141fa337adf2e58c6d424c174a7ba6b641f0dcf426a860706a28437546f4c906608406f2e186b8778f2db14cd3b2ef159db21948c00b6eda3957ad0d0e0a872a76c68745b130e3de852f3e189931296f81322b91911c7650aa931642cd78b5
2021-02-17 16:43:48 -05:00
Filippo Valsorda
1aea1b199f
[dev.boringcrypto] misc/boring: support codereview.cfg in merge.sh
...
Change-Id: I90f218cdfca6d9b86b1e8961b33fa2e63f799624
Reviewed-on: https://go-review.googlesource.com/c/go/+/290172
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2021-02-12 15:34:46 +00:00
Dmitri Shuralyov
d4f73546c8
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: I23ae197662c681cb91f17b28d0a259f56c2392d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/290133
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2021-02-05 21:42:51 +00:00
Cherry Zhang
98f8454a73
cmd/link: don't decode type symbol in shared library in deadcode
...
In the linker's deadcode pass we decode type symbols for
interface satisfaction analysis. When linking against Go shared
libraries, the type symbol may come from a shared library, so it
doesn't have data in the current module being linked, so we cannot
decode it. We already have code to skip DYNIMPORT symbols. However,
this doesn't actually work, because at that point the type symbols'
names haven't been mangled, whereas they may be mangled in the
shared library. So the symbol definition (in shared library) and
reference (in current module) haven't been connected.
Skip decoding type symbols of type Sxxx (along with DYNIMPORT)
when linkShared.
Note: we cannot skip all type symbols, as we still need to mark
unexported methods defined in the current module.
Fixes #44031 .
Change-Id: I833d19a060c94edbd6fc448172358f9a7d760657
Reviewed-on: https://go-review.googlesource.com/c/go/+/288496
Trust: Cherry Zhang <cherryyz@google.com>
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
2021-02-02 16:00:58 +00:00
Roland Shoemaker
cf8ed7cca4
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: Iae94f521ded21e60db435806c7cb0eb13e3b2f2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/285072
Trust: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2021-01-20 22:37:56 +00:00
Filippo Valsorda
f22137d785
[dev.boringcrypto] misc/boring: add -trust and roland@ to merge.sh and release.sh
...
Change-Id: Ic52948d0a0f353760b186c83df8648650457e965
Reviewed-on: https://go-review.googlesource.com/c/go/+/285032
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2021-01-20 20:10:30 +00:00
Cherry Zhang
ed301733bb
misc/cgo/testcarchive: remove special flags for Darwin/ARM
...
The original Darwin/ARM port is gone. For ARM64, it works fine
without the flags on macOS/ARM64. Remove the flags.
Change-Id: I9cc00c49dd71376dd9c52abb78c2d8cec656b3db
Reviewed-on: https://go-review.googlesource.com/c/go/+/280157
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-12-30 22:39:59 +00:00
Cherry Zhang
0ae2e032f2
misc/cgo/test: enable TestCrossPackageTests on darwin/arm64
...
Somehow I missed that one. It works fine.
Change-Id: I0b1286bf1e6a8f40b9f3f114f49b3034079e0b85
Reviewed-on: https://go-review.googlesource.com/c/go/+/280156
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-12-30 22:39:48 +00:00
Daniel Martí
780b4de16b
misc/ios: fix wording for command line instructions
...
A typo was made, which I noticed while looking through the recent master
commits.
Change-Id: Ieed5d6664a1f3ff5892d59abf194963b44ef0e55
Reviewed-on: https://go-review.googlesource.com/c/go/+/280454
Trust: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-12-29 21:49:26 +00:00
Cherry Zhang
f83e0f6616
misc/ios: add to README how to build ios executables
...
Updates #43371 , #43343 .
Change-Id: I19386269245f2c20345c6cac7560089b8223e9f9
Reviewed-on: https://go-review.googlesource.com/c/go/+/280153
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-12-29 20:34:36 +00:00
Filippo Valsorda
e5c7bd0efa
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Change-Id: I5059f2fa82db549c684b083202f1415511b86ce7
Reviewed-on: https://go-review.googlesource.com/c/go/+/277372
Reviewed-by: Roland Shoemaker <roland@golang.org>
Trust: Filippo Valsorda <filippo@golang.org>
2020-12-12 17:04:22 +00:00
Cherry Zhang
07cba70d57
cmd/compile, runtime: use __msan_memmove for moving data, split msanread to fields
...
Currently, for data moving, we generate an msanread of the source,
followed by an msanwrite of the destination. msanread checks
the source is initialized.
This has a problem: if the source is an aggregate type containing
alignment paddings, the padding bytes may not be thought as
initialized by MSAN. If we copy the aggregate type by value, if
it counts as a read, MSAN reports using uninitialized data. This
CL changes it to use __msan_memmove for data copying, which tells
MSAN to propagate initialized-ness but not check for it.
Caveat: technically __msan_memmove is not a public API of MSAN,
although the C compiler does generate direct calls to it.
Also, when instrumenting a load of a struct, split the
instrumentation to fields, instead of generating an msanread for
the whole struct. This skips padding bytes, which may not be
considered initialized in MSAN.
Fixes #42820 .
Change-Id: Id861c8bbfd94cfcccefcc58eaf9e4eb43b4d85c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/270859
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
2020-12-03 15:40:11 +00:00
Roland Shoemaker
906d6e362b
[dev.boringcrypto] all: merge master into dev.boringcrypto
...
Change-Id: Iba19903f0565b11c648e1fa6effc07b8f97dc322
2020-11-18 10:55:34 -08:00
Katie Hockman
95ceba18d3
[dev.boringcrypto] crypto/hmac: merge up to 2a206c7 and skip test
...
TestNonUniqueHash will not work on boringcrypto because
the hash.Hash that sha256 provides is noncomparable.
Change-Id: Ie3dc2d5d775953c381674e22272cb3433daa1b31
2020-11-18 13:38:14 -05:00
Dmitri Shuralyov
0985c1bd2d
[dev.boringcrypto] all: merge master into dev.boringcrypto
...
Change-Id: I0596a40722bf62952bd2eba85ccf3f104de589e4
2020-11-17 18:32:51 -05:00
Filippo Valsorda
af814af6e7
[dev.boringcrypto] misc/boring: add new releases to RELEASES file
...
Fixes #42589
Change-Id: Ieba62381d6561d4803448c123ce1f1d5980b8a76
Reviewed-on: https://go-review.googlesource.com/c/go/+/269762
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2020-11-16 15:36:33 +00:00
Cherry Zhang
86954d5246
cmd/compile: mark plugin-exported types as used in interface
...
Plugin exports symbols as interfaces. Mark their types as used in
interfaces, so their methods will be kept alive by the linker.
Fixes #42579 .
Change-Id: If1b5aacc21510c20c25f88bb131bca61db6f1d56
Reviewed-on: https://go-review.googlesource.com/c/go/+/269819
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
2020-11-13 22:01:37 +00:00
Austin Clements
f423d616b1
cmd/cgo: fix initialization of empty argument types
...
CL 258938 changed the way C to Go calls work such that they now
construct a C struct on the C side for the arguments and space for the
results. Any pointers in the result space must be zeroed, so we just
zero the whole struct.
However, C makes it surprisingly hard to robustly zero any struct
type. We had used a "{0}" initializer, which works in the vast
majority of cases, but fails if the type is empty or effectively
empty.
This CL fixes this by changing how the cgo tool zero-initializes the
argument struct to be more robust.
Fixes #42495 .
Change-Id: Id1749b9d751e59eb7a02a9d44fec0698a2bf63cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/269337
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-11-13 15:15:15 +00:00
Ian Lance Taylor
062e0e5ce6
cmd/go, cmd/cgo: don't let bogus symbol set cgo_ldflag
...
A hand-edited object file can have a symbol name that uses newline and
other normally invalid characters. The cgo tool will generate Go files
containing symbol names, unquoted. That can permit those symbol names
to inject Go code into a cgo-generated file. If that Go code uses the
//go:cgo_ldflag pragma, it can cause the C linker to run arbitrary
code when building a package. If you build an imported package we
permit arbitrary code at run time, but we don't want to permit it at
package build time. This CL prevents this in two ways.
In cgo, reject invalid symbols that contain non-printable or space
characters, or that contain anything that looks like a Go comment.
In the go tool, double check all //go:cgo_ldflag directives in
generated code, to make sure they follow the existing LDFLAG restrictions.
Thanks to Imre Rad / https://www.linkedin.com/in/imre-rad-2358749b for
reporting this.
Fixes CVE-2020-28367
Change-Id: Ia1ad8f3791ea79612690fa7d26ac451d0f6df7c1
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/895832
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/269658
Trust: Katie Hockman <katie@golang.org>
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
2020-11-12 20:58:06 +00:00
Andrew G. Morgan
f2e58c6d42
syscall: improve TestSetuidEtc() /proc/ parsing against races
...
TestSetuidEtc() was failing sporadically on linux-ppc64. From the
three https://build.golang.org/ logs, it looked like the logged
errors could be associated with threads dying, but proc reads
were, in some way, racing with their demise.
Exploring ways to increase thread demise, revealed that races
of this type can happen on non-ppc64 systems, and that
os.IsNotExist(err) was not a sufficient error condition test
for a thread's status file disappearing. This change includes a
fix for that to.
The actual issue on linux-ppc64 appears to be tied to PID reaping
and reuse latency on whatever the build test environment is for
linux-ppc64-buildlet. I suspect this can happen on any linux
system, however, especially where the container has a limited PID
range.
The fix for this, limited to the test (the runtime syscall support
is unchanged), is to confirm that the Pid for the interrogated
thread's /proc/<TID>/status file confirms that it is still
associated with the test-process' PID.
linux-ppc64-buildlet:
go/bin/go test syscall -run=TestSetuidEtc -count=10000
ok syscall 104.285s
Fixes #42462
Change-Id: I55c84ab8361003570a405fa52ffec4949bf91113
Reviewed-on: https://go-review.googlesource.com/c/go/+/268717
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
2020-11-11 20:49:53 +00:00
Filippo Valsorda
f42bd50779
[dev.boringcrypto] crypto/internal/boring: update BoringCrypto module to certificate 3678
...
Replace the chroot scaffolding with Docker, which brings its own caching
and works on macOS.
Fixes #40188
Change-Id: I5c96417932e952cbaf1e2991d131c1d5dd7d9921
Reviewed-on: https://go-review.googlesource.com/c/go/+/263997
Reviewed-by: Katie Hockman <katie@golang.org>
Trust: Filippo Valsorda <filippo@golang.org>
2020-11-05 17:59:43 +00:00
Joel Sing
393f2bb067
cmd/dist,cmd/go,runtime: add support for cgo on linux/riscv64
...
Fixes #36641
Change-Id: I51868d83ce341d78d33b221d184c5a5110c60d14
Reviewed-on: https://go-review.googlesource.com/c/go/+/263598
Trust: Joel Sing <joel@sing.id.au>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-11-03 12:59:51 +00:00
Richard Musiol
7be8358f70
misc/wasm: check type of argument to Go.run
...
This results in a nicer error message if the argument to Go.run is
omitted or of the wrong type.
Fixes #37000
Change-Id: I7f36d007f41a79b2cea1cebf5cce127786341202
Reviewed-on: https://go-review.googlesource.com/c/go/+/266117
Trust: Richard Musiol <neelance@gmail.com>
Run-TryBot: Richard Musiol <neelance@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-11-02 13:02:40 +00:00
Quim Muntal
e463c28cc1
cmd/link: avoid exporting all symbols on windows buildmode=pie
...
Marking one functions with __declspec(dllexport) forces mingw to
create .reloc section without having to export all symbols.
See https://insights.sei.cmu.edu/cert/2018/08/when-aslr-is-not-really-aslr---the-case-of-incorrect-assumptions-and-bad-defaults.html for more info.
This change cuts 73kb of a "hello world" pie binary.
Updates #6853
Fixes #40795
Change-Id: I3cc57c3b64f61187550bc8751dfa085f106c8475
Reviewed-on: https://go-review.googlesource.com/c/go/+/264459
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Austin Clements <austin@google.com>
2020-11-02 00:46:44 +00:00
Filippo Valsorda
Katie Hockman
Ian Lance Taylor
Russ Cox
David Chase
Brad Fitzpatrick
Naman Gera
Changkun Ou
wolf1996
KimMachineGun
Cherry Zhang
Prajwal Koirala
John Bampton
fanzha02
Tamir Duberstein
Dmitri Shuralyov
Roland Shoemaker
Daniel Martí
Austin Clements
Andrew G. Morgan
Joel Sing
Richard Musiol
Quim Muntal