Russ Cox
36c5c5bf40
cc: disallow ... argument unless NOSPLIT is set.
...
check that NOSPLIT functions don't use too much stack.
correct some missing NOSPLITs in the runtime library.
Fixes bug reported in
https://groups.google.com/group/golang-nuts/t/efff68b73941eccf
R=ken2
CC=golang-dev
https://golang.org/cl/236041
2010-03-04 15:34:25 -08:00
Charles L. Dorian
6b80a5fa6d
math: added ilogb, logb, remainder, tests and special conditions
...
Also added expm1_386 and remainder_386; shortened exp_386
R=rsc
CC=golang-dev
https://golang.org/cl/217109
2010-03-03 18:17:13 -08:00
Russ Cox
e53f7d8993
net: put [ ] around IPv6 addresses for Dial
...
Update #538 .
R=r
CC=golang-dev
https://golang.org/cl/229045
2010-03-03 17:30:39 -08:00
Russ Cox
74b131c0ab
net: fix nil deref in testTimeout when Dial fails
...
Pointed out by Scott Schwartz.
Fixes #637 .
R=scotts
CC=golang-dev
https://golang.org/cl/225042
2010-03-03 17:30:29 -08:00
Russ Cox
f1550482fa
gc: fix imported and not used message - show path
...
R=ken2
CC=golang-dev
https://golang.org/cl/229046
2010-03-03 17:23:47 -08:00
Rob Pike
90367756bb
encoding/binary: fix error reporting bug
...
R=rsc
CC=golang-dev
https://golang.org/cl/224096
2010-03-03 12:35:16 -08:00
Stephen Ma
3b82f295b4
net: fix network timeout boundary condition.
...
Fixes #472 .
R=golang-dev
CC=golang-dev
https://golang.org/cl/223108
2010-03-03 18:43:36 +11:00
Stephen Ma
b73e592ed1
net: correct DNS configuration
...
Set defaults to the same values as various C DNS resolver libraries.
Use the timeout value from the configuration.
Fixes #632 .
R=rsc
CC=golang-dev
https://golang.org/cl/223094
2010-03-03 15:25:26 +11:00
Ken Thompson
7d4b1e4c0d
more on type complex.
...
getting close.
R=rsc
CC=golang-dev
https://golang.org/cl/224105
2010-03-02 18:32:11 -08:00
Robert Griesemer
305f5433f3
gofmt: fix alignment of multi-line var declarations
...
- gofmt -w src misc
R=rsc, r
CC=golang-dev
https://golang.org/cl/223101
2010-03-02 17:23:07 -08:00
Andrew Gerrand
adf1e4c5fd
http: corrected comment for Response.GetHeader.
...
Fixes #622 .
R=rsc
CC=golang-dev
https://golang.org/cl/224084
2010-03-03 08:53:22 +11:00
Robert Griesemer
f44fa9b4c7
gofmt: experiment: align values in map composites where possible
...
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
https://golang.org/cl/223076
2010-03-02 13:46:51 -08:00
Andrey Mirtchovski
1f3222a57b
strings.Bytes -> []byte for documentation example, src/pkg/* comments, and htmlgen.go
...
R=rsc, adg
CC=golang-dev
https://golang.org/cl/224087
2010-03-02 11:18:22 +11:00
Andrew Gerrand
6d0f1fedbf
gotest: set $AS to $GOBIN/$AS
...
May address issue 624.
R=rsc
CC=golang-dev
https://golang.org/cl/223083
2010-02-28 21:49:06 -08:00
Stephen Ma
a627d61d5d
Count utf8 runes, not bytes when determining string width. Note
...
that pad() still counts bytes, but it's currently only used for
1 byte runes.
Fixes #612 .
R=r
CC=golang-dev
https://golang.org/cl/217064
2010-02-28 21:15:56 +11:00
Russ Cox
fe746055a2
testing/benchmark: paranoia - make sure n always grows
...
R=wcn
CC=golang-dev
https://golang.org/cl/223075
2010-02-26 17:18:43 -08:00
Raif S. Naffah
ef531c2b57
crypto/blowfish: new package
...
R=rsc
CC=golang-dev
https://golang.org/cl/217116
2010-02-26 15:24:46 -08:00
Robert Griesemer
059bc2742a
go/parser cleanup: remove some state by writing more functional code
...
R=rsc
CC=golang-dev
https://golang.org/cl/223071
2010-02-26 14:50:12 -08:00
Russ Cox
bc6878331a
8g: fix out of register bug in byte(x) code
...
R=ken2
CC=golang-dev
https://golang.org/cl/223070
2010-02-26 14:21:52 -08:00
Ian Lance Taylor
e6443f6255
Add -r option to 6l/8l/5l.
...
This permits more flexibility with cgo and swig in cases where
the program is run on a machine other than the one on which it
is built. Rather than storing the absolute path to the shared
library in the DT_NEEDED entry, we can store just the name,
and let the dynamic linker find it using DT_RUNPATH or the
LD_LIBRARY_PATH environment variable.
R=rsc
CC=golang-dev
https://golang.org/cl/223068
2010-02-26 14:03:52 -08:00
Russ Cox
ba50599e46
8g: make a[byte(x)] truncate x
...
R=ken2
CC=golang-dev
https://golang.org/cl/223069
2010-02-26 13:15:29 -08:00
Robert Griesemer
9520a68268
go/scanner: the position of '\n's chars must be the last position of the current line
...
Background: This didn't matter until recently, because '\n' don't appear as token starts
in source code and thus the exact position was irrelevant (and set as was easiest in the
code). With auto semicolon insertion, a virtual semicolon may be inserted when a '\n' is
seen. The position of the semicolon is the position of the '\n'. Without this fix, these
semicolons appeared on the next line instead of the line where they were inserted. This
affected the association of comments to declarations in the parser. As a result, some
lead comments where considered line comments, not collected in the ast, and not shown in
godoc pages. (This affected only godoc pages, not gofmt-formatted programs).
Fixes #592 .
R=rsc
CC=golang-dev
https://golang.org/cl/224068
2010-02-26 11:23:12 -08:00
Micah Stetson
8c5404746f
Fix a couple of bugs referencing data values in template.
...
Adds tests and fixes for two cases that fail with the current release.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/217115
2010-02-26 18:39:43 +11:00
Russ Cox
8fbd5f8a82
use []byte("abc") in place of []byte{'a', 'b', 'c'}
...
R=gri
CC=golang-dev
https://golang.org/cl/223059
2010-02-25 16:43:43 -08:00
Robert Griesemer
d177539877
go/printer, gofmt: align comments in multi-line expression lists
...
- gofmt -w src misc
- improves several lists and fixes minor degradation introduced
with the fix for issue 628
- removed some dead code (stringList)
R=rsc
CC=golang-dev
https://golang.org/cl/223058
2010-02-25 16:07:55 -08:00
Russ Cox
9750adbbad
strings: delete Runes, Bytes
...
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
https://golang.org/cl/224062
2010-02-25 16:01:29 -08:00
Robert Griesemer
dfaa6eaa76
tabwriter: make use of new []byte() conversion
...
R=rsc
CC=golang-dev
https://golang.org/cl/224063
2010-02-25 15:54:12 -08:00
Russ Cox
3910161307
gc: implement []int(string) and []byte(string)
...
R=ken2
CC=golang-dev
https://golang.org/cl/224060
2010-02-25 15:11:07 -08:00
Stephen Weinberg
b86c0b0c4a
Fix small typo in net package.
...
R=rsc
CC=golang-dev
https://golang.org/cl/224061
2010-02-25 14:49:14 -08:00
Robert Griesemer
dbe0b57012
go/printer, gofmt: correct indentation after certain /*-style comments
...
- applied gofmt to src and misc
Note: This fix improved formatting of src/pkg/math/all_test.go but leads
to a degradation in src/pkg/exp/4s/xs.go. The latter happened to "work"
before accidentally. Fixing the alignment in that case in general will
be a separate CL.
Fixes #628 .
R=rsc
CC=golang-dev
https://golang.org/cl/223054
2010-02-25 13:47:16 -08:00
Robert Griesemer
e0d5177dd7
tabwriter: indicate section breaks if Debug flag is set
...
R=rsc
CC=golang-dev
https://golang.org/cl/224057
2010-02-25 13:26:55 -08:00
Ian Lance Taylor
bada653f4d
Use consistent types in .h file and .c file.
...
R=rsc
CC=golang-dev
https://golang.org/cl/224053
2010-02-25 10:13:09 -08:00
Robert Griesemer
859e4d51c3
strings: remove a couple of redundant tests
...
(per suggestion from Heresy.Mc@gmail.com )
R=rsc
CC=golang-dev
https://golang.org/cl/223052
2010-02-25 10:02:39 -08:00
Kevin Ballard
20834d644f
path: Fix bug in Match with non-greedy stars
...
path.Match() errors out when testing "*x" against "xxx"
because it matches the star non-greedily. Ensure that
the last chunk consumes the rest of the name.
R=r, rsc
CC=golang-dev
https://golang.org/cl/223050
2010-02-25 09:15:52 -08:00
Rob Pike
24ee7f799c
%q in fmt: if the object is a Stringer, use String() to get the value to quote.
...
R=rsc
CC=golang-dev
https://golang.org/cl/224051
2010-02-25 17:29:37 +11:00
Robert Griesemer
d5248c4a96
go/scanner: support for complex (imaginary) constants
...
R=rsc
CC=golang-dev
https://golang.org/cl/223044
2010-02-24 17:06:40 -08:00
Ian Lance Taylor
7c99dcbdf9
Install runtime.h and cgocall.h.
...
This permits cgo generated code to use these header files even
if the Go sources are not around.
R=rsc
CC=golang-dev
https://golang.org/cl/224045
2010-02-24 17:00:25 -08:00
Robert Griesemer
ef0be41e20
go/ast: streamline representation of field lists
...
- always include position information about opening/closing parens/braces
- replace uses of []*ast.Field with *ast.FieldList
Fixes #473 .
R=rsc
CC=golang-dev
https://golang.org/cl/223043
2010-02-24 16:17:11 -08:00
Russ Cox
78961ed961
path: add Match
...
R=eridius, r, rog
CC=golang-dev
https://golang.org/cl/217088
2010-02-24 16:11:14 -08:00
Russ Cox
37666561b2
http: fix handling of Close, use Close in http.Post
...
default to HTTP/1.1
R=petar-m
CC=golang-dev
https://golang.org/cl/224041
2010-02-24 15:13:39 -08:00
Robert Griesemer
1be05bbe1e
gofmt: don't print ()'s around function-typed results (not needed anymore)
...
- add extra test cases to go/printer tests
- apply gofmt to src and misc
R=rsc
CC=golang-dev
https://golang.org/cl/223041
2010-02-24 13:24:37 -08:00
Robert Griesemer
228903c5da
go/printer: use general comment intersperse mechanism everywhere
...
- remove several TODOs
- as a side-effect, comment stylers are now used always and comments
will be properly colored in godoc pkg documentation pages (and not
only when looking at source text)
R=rsc
CC=golang-dev
https://golang.org/cl/222041
2010-02-24 11:06:46 -08:00
Mark Zavislak
6a0af8e118
crypto package documentation fix
...
Replaces stale references to modes.go.
R=golang-dev, agl, rsc
CC=golang-dev
https://golang.org/cl/218071
2010-02-23 12:01:09 -08:00
Rob Pike
38202de114
goyacc: fix handling of / and comments in goyacc
...
Fixes #618 .
R=rsc
CC=golang-dev
https://golang.org/cl/217094
2010-02-23 16:00:14 +11:00
Russ Cox
8ba5c5593f
runtime: work around Linux kernel bug in futex
...
Fixes #420 .
R=r
CC=golang-dev
https://golang.org/cl/218065
2010-02-22 20:45:36 -08:00
Russ Cox
5c2197ac8f
net: disable UDP server test
...
has been flaking on various architectures.
not sure why, but doesn't seem to be Go's fault.
Fixes #617 .
R=r
CC=golang-dev
https://golang.org/cl/217093
2010-02-22 20:38:56 -08:00
Charles L. Dorian
78e918ccba
math: add lgamma; in-line special cases of acosh, nextafter
...
Added lgamma.go, tests and special cases.
R=rsc
CC=golang-dev
https://golang.org/cl/217060
2010-02-22 17:12:48 -08:00
Nigel Tao
2ac3df210b
Fix xgb/example.go typo.
...
R=adg
CC=golang-dev
https://golang.org/cl/210047
2010-02-23 11:54:57 +11:00
Robert Griesemer
b0fba898ef
go/printer (gofmt): remove more residue from semicolon transition
...
minor unrelated cleanups
R=rsc
CC=golang-dev
https://golang.org/cl/217086
2010-02-22 15:41:59 -08:00
Petar Maymounkov
39e91f8858
http: use RawURL in Request.Write
...
R=rsc
CC=golang-dev
https://golang.org/cl/217066
2010-02-22 15:39:30 -08:00
Michael Hoisie
1a37656b7a
xml: treat bool as value in Unmarshal
...
R=rsc
CC=golang-dev
https://golang.org/cl/218050
2010-02-22 15:21:13 -08:00
Petar Maymounkov
e465ad3cbd
http: fix bug in Post
...
R=rsc
CC=golang-dev
https://golang.org/cl/217059
2010-02-22 14:46:59 -08:00
Sergei Skorobogatov
7870672c7f
json: fix quoted strings in Marshal
...
R=rsc
CC=golang-dev
https://golang.org/cl/217047
2010-02-22 14:32:40 -08:00
Robert Griesemer
22e960547f
scanner: match go/scanner and disallow NUL character;
...
also check for illegal UTF-8 sequences
R=rsc
CC=golang-dev
https://golang.org/cl/218061
2010-02-22 14:21:59 -08:00
Michael Hoisie
0485a999ff
http request URI should never be empty
...
R=rsc, adg
CC=golang-dev
https://golang.org/cl/217071
2010-02-21 19:49:43 -08:00
Ken Thompson
458b53ea7d
all done except -
...
complex divide
float(complex) conversion
8g 5g etc
tests
R=rsc
CC=golang-dev
https://golang.org/cl/218044
2010-02-21 17:51:39 -08:00
Russ Cox
ed13d39972
gc: minor const simplifications
...
R=ken2
CC=golang-dev
https://golang.org/cl/217069
2010-02-21 11:18:09 -08:00
Ken Thompson
f59cb49a5a
fixed bug in mpconst float multiply by 0.
...
more complex -- constants, variables and print.
R=rsc
CC=golang-dev
https://golang.org/cl/217061
2010-02-19 20:42:50 -08:00
Timo Savola
4f8a000e17
websocket: fix binary frame size decoding
...
R=ukai, rsc
CC=golang-dev
https://golang.org/cl/166074
2010-02-19 18:40:09 -08:00
Robert Griesemer
989ef60509
go/ast: use a slice instead of a linked list for the list of comments
...
(this will simplify some further changes)
removed several TODOs
R=rsc
CC=golang-dev
https://golang.org/cl/216059
2010-02-19 17:03:09 -08:00
Robert Griesemer
aaec61555a
godoc: fix path resolution for command-line one more time (sigh...)
...
R=rsc
CC=golang-dev
https://golang.org/cl/217058
2010-02-19 16:23:19 -08:00
Robert Griesemer
8e714aab2b
- removed exp/parser (support for old semicolon syntax)
...
- go/ast: removed StringList (not needed anymore)
- go/ast: changed import path and field list tag to a single string
- updated all dependencies
R=rsc
CC=golang-dev
https://golang.org/cl/217056
2010-02-19 16:01:31 -08:00
Robert Griesemer
cf743c1be6
godoc: make commandline use work again
...
R=rsc
CC=golang-dev
https://golang.org/cl/216054
2010-02-19 11:41:48 -08:00
Petar Maymounkov
1480ce373e
http: unified body transfer (read & write) logic in http.Request/Response.
...
Compliance issue addressed here: POST requests carrying form data are required
to use "identity" transfer encoding by common nginx and apache server configurations,
e.g. wordpress.com (and many others). So, Request needed to be able to send
non-chunked encodings.
Thus, Request is extended to support identity and chunked encodings, like
Response. Since the Read() and Write() logic are shared by both (and are
quite long), it is exported in a separate file transfer.go.
R=rsc
CC=golang-dev
https://golang.org/cl/217048
2010-02-19 08:38:40 -08:00
Petar Maymounkov
8d9c2b2eab
http: add Pending method to ServerConn, ClientConn
...
R=rsc
CC=golang-dev
https://golang.org/cl/216052
2010-02-19 08:21:21 -08:00
Adam Langley
32c3c95339
crypto/x509: support certificate creation.
...
R=rsc
CC=golang-dev
https://golang.org/cl/212041
2010-02-19 10:55:41 -05:00
Petar Maymounkov
55828cee94
http: add DumpRequest, DumpResponse, for debugging
...
R=rsc
CC=golang-dev
https://golang.org/cl/206050
2010-02-19 07:51:51 -08:00
Petar Maymounkov
d26e204514
http: persistent connection objects
...
R=rsc
CC=golang-dev
https://golang.org/cl/203051
2010-02-18 23:38:21 -08:00
Petar Maymounkov
e3b94edc03
http: do not edit Response.ContentLength in Response.Write
...
R=rsc
CC=golang-dev
https://golang.org/cl/207061
2010-02-18 23:38:17 -08:00
Russ Cox
80a14df122
gc: double-initialization
...
R=ken2
CC=golang-dev
https://golang.org/cl/217044
2010-02-18 23:33:57 -08:00
Kai Backman
c0aac20e20
combined pchw and embedded into tiny. added section on arm to README
...
R=rsc
CC=golang-dev
https://golang.org/cl/194151
2010-02-18 23:33:21 -08:00
Charles L. Dorian
c3fa32c747
math: add Cbrt and Sincos; x87 versions of Sincos, Frexp, Ldexp
...
Added special condition and benchmarks for Cbrt, Sincos. Took Frexp and Ldexp out of bits.go.
R=rsc
CC=golang-dev
https://golang.org/cl/206084
2010-02-18 23:33:15 -08:00
Evan Shaw
4af0a58ea9
8a/8l: Added FCMOVcc instructions
...
Thanks to Charles Dorian for the help.
R=rsc
CC=Charlie Dorian, golang-dev
https://golang.org/cl/207049
2010-02-18 23:33:06 -08:00
Amrut Joshi
d8675d25e5
xml: allow unquoted attribute values in non-Strict mode
...
HTML4 standard supports unquoted attibute values in certain cases
(http://www.w3.org/TR/REC-html40/intro/sgmltut.html#h-3.2.2 ).
R=rsc
CC=golang-dev
https://golang.org/cl/207095
2010-02-18 23:32:55 -08:00
Fumitoshi Ukai
2161e3e23e
http: avoid server crash on malformed client request
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/206079
2010-02-18 18:32:40 -08:00
Russ Cox
c2dea2196c
exec: add dir argument to Run.
...
fix, test MergeWithStdout
R=r
CC=golang-dev
https://golang.org/cl/214046
2010-02-18 18:32:33 -08:00
Russ Cox
4589c34580
gc: fix this morning's bug fix
...
R=ken2
CC=golang-dev
https://golang.org/cl/216043
2010-02-18 18:31:13 -08:00
Ken Thompson
fc010adcd7
complex constant multiply and divide
...
R=rsc
CC=golang-dev
https://golang.org/cl/217041
2010-02-18 17:55:11 -08:00
Robert Griesemer
d17ffb9753
godoc: path cleanups, fixed a race condition, initial support for a menu on pages
...
R=rsc
CC=adg, golang-dev
https://golang.org/cl/215050
2010-02-18 17:40:50 -08:00
Dean Prichard
86b0ea6447
sync: allow to work on armv5
...
asm_arm.s was using ldrex which does not work
on armv5. Tested on Sheevaplug.
R=rsc, kaib
CC=golang-dev
https://golang.org/cl/214049
2010-02-18 15:37:16 -08:00
Ken Thompson
713e3e1541
more complex - constants
...
import and export
R=rsc
CC=golang-dev
https://golang.org/cl/214050
2010-02-18 14:46:28 -08:00
Russ Cox
1734cb02e7
gc: recursive interface embedding
...
Fixes #287 .
R=ken2
CC=golang-dev
https://golang.org/cl/215048
2010-02-18 11:15:36 -08:00
Russ Cox
cf015fd0b8
5g/8g: fix build
...
R=ken2
CC=golang-dev
https://golang.org/cl/215042
2010-02-17 22:41:04 -08:00
Ken Thompson
33d6a260c1
new types complex, complex64 and complex128
...
only front-end compiler work.
best to do thin in 3 steps
1. frontend
2. backend
3. lib
R=rsc
CC=golang-dev
https://golang.org/cl/214042
2010-02-17 22:08:30 -08:00
Robert Griesemer
cd72f77f23
apply gofmt to src and misc
...
R=rsc
CC=golang-dev
https://golang.org/cl/213041
2010-02-17 15:46:46 -08:00
Robert Griesemer
1cf6fdf8a1
gofmt: make sure certain 2-line comments are stable
...
under repeated application of gofmt
R=agl, agl1
CC=golang-dev
https://golang.org/cl/212046
2010-02-17 15:41:26 -08:00
Russ Cox
fb5506600f
8g: respect ullman numbers in float comparison
...
Fixes #602 .
R=ken2
CC=golang-dev
https://golang.org/cl/212045
2010-02-17 15:28:45 -08:00
Rob Pike
7b76175a1c
time.Ticker: fix bug arising when all tickers are dead.
...
thanks to yglgogo for analysis.
Fixes #593 .
R=rsc
CC=golang-dev
https://golang.org/cl/210044
2010-02-18 09:55:29 +11:00
Nigel Tao
3dc04f4a22
Add Src and Over draw operators.
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/207096
2010-02-17 14:34:51 +11:00
Russ Cox
7b5789b584
gc: undo attempt at fixing recursive interface embedding
...
Fixes #582 .
Update #287
Status: Accepted
Bug fix was too intrusive; undo and reopen issue.
R=ken2
CC=golang-dev
https://golang.org/cl/209044
2010-02-16 17:44:15 -08:00
Robert Griesemer
855986d54f
go/scanner: comply with spec changes (do not allow NUL chars)
...
and complain about illegal UTF-8 code sequences
R=rsc
CC=golang-dev
https://golang.org/cl/209043
2010-02-16 17:39:44 -08:00
Russ Cox
401062f720
gc: fix build (signed char bug)
...
R=ken2
CC=golang-dev
https://golang.org/cl/210043
2010-02-16 17:30:33 -08:00
Russ Cox
cfff862862
gc: disallow NUL byte, catch more invalid UTF-8, test
...
R=ken2, ken3
CC=golang-dev
https://golang.org/cl/209041
2010-02-16 16:47:39 -08:00
Russ Cox
04d9c8853b
runtime: fix bug in Caller documentation
...
R=r
CC=golang-dev
https://golang.org/cl/207110
2010-02-16 16:11:11 -08:00
Robert Griesemer
db9a9662a1
godoc: updated documentation
...
R=r
CC=golang-dev
https://golang.org/cl/207112
2010-02-16 15:36:55 -08:00
Rob Pike
7db472fd34
The prefix optimization applies only to the first iteration.
...
Fixes #596 .
R=rsc
CC=golang-dev
https://golang.org/cl/206101
2010-02-17 08:49:00 +11:00
Robert Griesemer
ca075494a6
godoc: initialize vars depending on flags after parsing the flags.
...
R=rsc
CC=golang-dev
https://golang.org/cl/206109
2010-02-16 12:49:41 -08:00
Robert Griesemer
ffd0961313
godoc: fix initialization issue
...
R=rsc
CC=golang-dev
https://golang.org/cl/207111
2010-02-16 11:54:12 -08:00
Giles Lean
5aa3a8de6d
syscall: make signature of Umask on OS X, FreeBSD match Linux.
...
R=rsc
CC=golang-dev
https://golang.org/cl/207071
2010-02-16 11:43:25 -08:00
Giles Lean
0b4d8c19af
cc: use "cpp" anywhere in path, not "/bin/cpp"
...
R=rsc
CC=golang-dev
https://golang.org/cl/206077
2010-02-16 11:32:41 -08:00
Robert Griesemer
5883c6ef1f
godoc support for directories outside $GOROOT
...
Example use: godoc -path=/home/user1:/home/build/foo -http=:6666
will start a local godoc that maps urls starting with /pkg/user1 or
/pkg/foo to the respective roots specified in the path.
Missing: Handling of overlapping package directories, multiple
packages per directory.
R=rsc
CC=golang-dev
https://golang.org/cl/206078
2010-02-16 11:20:55 -08:00
Robert Griesemer
85498cbcdd
remove assumption that all files belonging to a package are in the same directory:
...
- adjust ast.Package node and doc.PackageDoc correspondingly
- introduce parser.ParseFiles
R=rsc
CC=golang-dev
https://golang.org/cl/207087
2010-02-16 11:20:25 -08:00
Robert Griesemer
2f816d5b73
Don't print ()'s around a range clause's expression.
...
Fixes #605 .
R=rsc
CC=golang-dev
https://golang.org/cl/207108
2010-02-16 10:19:51 -08:00
Russ Cox
e7fc5c2789
gc: test & fix handling of very long string constants
...
R=ken2
CC=golang-dev
https://golang.org/cl/207106
2010-02-16 10:16:24 -08:00
Ian Lance Taylor
115066fd14
Fix printing of named floating point types.
...
Try to avoid infinite recursion if String fails due to
printing a bad type.
Add test for String method with named basic types.
R=r
CC=golang-dev
https://golang.org/cl/207102
2010-02-15 22:42:49 -08:00
Robert Griesemer
fba50ee5ed
update gofmt test script
...
R=adg
CC=golang-dev
https://golang.org/cl/207088
2010-02-12 15:28:11 -08:00
Russ Cox
58d5d6f34f
http: clarify ServeHTTP return
...
Fixes #580 .
R=adg
CC=golang-dev
https://golang.org/cl/207086
2010-02-12 14:27:44 -08:00
Russ Cox
5ab8f00bf8
gc: diagnose invalid array bounds
...
Fixes #587 .
R=ken2
CC=golang-dev
https://golang.org/cl/207085
2010-02-12 13:59:02 -08:00
Russ Cox
9f77e7ea3c
runtime: dummy gettime for mingw/386.
...
Fixes #598 .
R=adg
CC=golang-dev
https://golang.org/cl/206089
2010-02-12 12:49:16 -08:00
Robert Griesemer
a75ebe192e
correct meaning of "absolute" and "relative"
...
(implementation was swapped)
R=adg
CC=golang-dev, rsc
https://golang.org/cl/207069
2010-02-11 13:59:10 -08:00
Robert Griesemer
a91fa9d52e
Steps towards more flexible godoc:
...
The Mapping object implements a flexible
mapping of relative to absolute paths and
vice versa.
R=rsc
CC=golang-dev
https://golang.org/cl/206067
2010-02-11 10:01:03 -08:00
Kai Backman
494bcc80e4
stop the 5c optimizer from clobbering extern static registers.
...
R=rsc, ken2
CC=golang-dev
https://golang.org/cl/204064
2010-02-10 22:42:05 -08:00
Russ Cox
22a7f2a14d
runtime: delete MHeapMapCache, which is useless
...
because free needs to mark the block as freed to
coordinate with the garbage collector.
(in C++ free can blindly put the block on the free list,
no questions asked, so the cache saves some work.)
R=iant
CC=golang-dev
https://golang.org/cl/206069
2010-02-10 21:23:08 -08:00
Nigel Tao
fc8e3d4004
exp/draw test.
...
R=rsc
CC=golang-dev
https://golang.org/cl/203062
2010-02-11 13:38:16 +11:00
Petar Maymounkov
c27c3aa6d8
Added tests for http.Request/Response.Write()
...
R=rsc
CC=golang-dev
https://golang.org/cl/199070
2010-02-10 17:29:03 -08:00
Russ Cox
c312d0e0ca
net: use slightly less predictable dns request id
...
not trying to be secure, just not repetitive
(sending with the same id repeatedly makes
some resolvers stop replying.)
eventually we'll replace this with linking against
the system's native resolver.
R=p
CC=golang-dev
https://golang.org/cl/207051
2010-02-10 16:35:35 -08:00
Russ Cox
66cdc699b2
arm: fix build on android
...
R=kaib
CC=golang-dev
https://golang.org/cl/206059
2010-02-10 15:01:02 -08:00
Russ Cox
fb94be55dc
runtime: tighten garbage collector
...
* specialize sweepspan as sweepspan0 and sweepspan1.
* in sweepspan1, inline "free" to avoid expensive mlookup.
R=iant
CC=golang-dev
https://golang.org/cl/206060
2010-02-10 14:59:39 -08:00
Russ Cox
991a968f44
runtime: do not zero blocks on free (this time for sure!)
...
R=iant
CC=golang-dev
https://golang.org/cl/207054
2010-02-10 11:31:00 -08:00
Alex Brainman
3b1a71862e
8l: pe executable building code changed to include import table for kernel32.dll functions
...
Fixes #586 .
R=rsc
CC=golang-dev
https://golang.org/cl/203060
2010-02-10 00:47:52 -08:00
Russ Cox
1ca39fb1fd
gc: fix mkopnames and color grep interaction
...
Fixes #406 .
R=adg
CC=golang-dev
https://golang.org/cl/207053
2010-02-10 00:44:43 -08:00
Russ Cox
f9f66b97e2
ld: unused variable
...
R=adg
CC=golang-dev
https://golang.org/cl/207050
2010-02-10 00:44:22 -08:00
Charles L. Dorian
aee1434193
math: add Exp2; 386 FPU versions of Exp2 and Log1p
...
Added tests and benchmarks for Exp2 (special cases same
as Exp). Log1p also enhances speed of inverse hyperbolics.
R=rsc
CC=golang-dev
https://golang.org/cl/206058
2010-02-10 00:06:41 -08:00
Russ Cox
f25586a306
runtime: garbage collection + malloc performance
...
* add bit tracking finalizer status, avoiding getfinalizer lookup
* add ability to allocate uncleared memory
R=iant
CC=golang-dev
https://golang.org/cl/207044
2010-02-10 00:00:12 -08:00
Michael Hoisie
0cba5fc051
mime: new package, use in http
...
R=rsc
CC=golang-dev
https://golang.org/cl/186160
2010-02-09 20:47:45 -08:00
Petar Maymounkov
c5287ecb9c
http: protect io.WriteString in Request/Response.Write with error checking,
...
since they were causing a silent program exit (too many EPIPE's).
R=rsc
CC=golang-dev
https://golang.org/cl/204062
2010-02-09 17:42:51 -08:00
Ken Thompson
d4ad8e8ce3
bug fix in 6c/8c/5c mis-aligned
...
function arguments.
R=rsc
CC=golang-dev
https://golang.org/cl/206054
2010-02-09 17:26:04 -08:00
Russ Cox
2b4a9fa176
fix NaCl build for latest runtime changes
...
R=iant
CC=golang-dev
https://golang.org/cl/206052
2010-02-09 16:56:22 -08:00
Russ Cox
de90a7d4aa
runtime: fix FreeBSD build
...
stab in the dark but plausible: the kernel does try to
return time zone information.
http://fxr.watson.org/fxr/source/kern/kern_time.c?v=FREEBSD8#L421
R=iant
CC=golang-dev
https://golang.org/cl/206053
2010-02-09 16:54:51 -08:00
Charles L. Dorian
c465331262
math: add functions Log2, Nextafter, Fdim, Fmax, Fmin
...
Add functions, tests and benchmarks. Fix typos in comments
in expm1 and hypot_386. Fix Acosh domain error in benchmark
test.
R=rsc
CC=golang-dev
https://golang.org/cl/204069
2010-02-09 13:33:12 -08:00
Evan Shaw
baea3e946d
8a/8l: Added CMOVcc instructions
...
R=rsc
CC=golang-dev
https://golang.org/cl/204067
2010-02-09 13:33:07 -08:00
Russ Cox
d3be2e3e0a
add simple garbage collector benchmarks to dashboard
...
R=agl1
CC=golang-dev
https://golang.org/cl/207043
2010-02-09 13:33:00 -08:00
Fazlul Shahriar
96476b4c3e
make units compile
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/206044
2010-02-09 13:20:22 -08:00
Russ Cox
62d627f0bc
runtime: allow arbitrary return type in SetFinalizer.
...
finalize chan, to free OS X semaphore inside Lock.
os: finalize File, to close fd.
Fixes #503 .
R=ken2
CC=golang-dev
https://golang.org/cl/204065
2010-02-08 21:41:54 -08:00
Russ Cox
9e2c9bb0ca
gc: fix method expression bug
...
R=ken2
CC=golang-dev
https://golang.org/cl/206043
2010-02-08 21:40:35 -08:00
Russ Cox
e4f06812c5
runtime: instrument malloc + garbage collector.
...
add simple garbage collection benchmark.
R=iant
CC=golang-dev
https://golang.org/cl/204053
2010-02-08 14:32:22 -08:00
Andrew Gerrand
b4fb00b69b
*l/*c: add -V flag to display version number
...
R=rsc
CC=golang-dev
https://golang.org/cl/204044
2010-02-08 09:46:53 -08:00
Evan Shaw
abe6a5b0f7
testing: Fix comment typo
...
R=iant, rsc
CC=golang-dev
https://golang.org/cl/204068
2010-02-07 23:11:54 -08:00
Adam Langley
d5841cac45
encoding/pem: add marshalling support.
...
R=rsc
CC=golang-dev
https://golang.org/cl/203043
2010-02-07 15:22:36 -05:00
Russ Cox
87915b6565
runtime: introduce MemStatsType
...
R=ken2
CC=golang-dev
https://golang.org/cl/204061
2010-02-07 01:20:44 -08:00
Kai Backman
ebf32c5868
fix comment
...
R=rsc
CC=golang-dev
https://golang.org/cl/203053
2010-02-06 21:59:46 -08:00
Nigel Tao
48cdb63baa
draw.Draw fast paths for a nil mask (and RGBA dst).
...
Averaged times (in microseconds) for drawing an 800x600 rectangle
are listed below. The summary is: around a 100x improvement.
draw.Draw call times were typically linear in the number of pixels
touched (i.e. drawing an 800x600 rectangle took 100x as much time as
drawing an 80x60 rectangle).
Before this change, there was only the general-but-slow code path.
When drawing any src with a 50%-opaque mask: 237300 us
When drawing any src with a nil mask: 50100 us
After this change, the 50%-opaque mask case is unchanged.
For an *image.RGBA dst and nil mask and...
...a uniform color (i.e. an image.ColorImage) src: 282 us
...another *image.RGBA src: 615 us.
For the curious, an intermediate implementation detected the special
cases but used simple nested for loops instead of the built-in copy
function. The respective times (compared to 282 and 615 for the
final implementation, or 50100 for the original) were 3110 and 3573.
Times were measured with 8g/8l on my laptop. I haven't tried gccgo
or other architectures.
R=r, rsc
CC=golang-dev
https://golang.org/cl/201048
2010-02-06 15:57:19 +11:00
Petar Maymounkov
4fdab85178
http: sort header keys when writing Response or Request to wire
...
R=rsc
CC=golang-dev
https://golang.org/cl/203050
2010-02-05 18:32:02 -08:00
Ken Thompson
ce85868a00
bug in const float divide
...
R=rsc
CC=golang-dev
https://golang.org/cl/204042
2010-02-05 15:18:32 -08:00
Charles L. Dorian
072b560ee6
math: Atan2 special cases and tests; atan2_386
...
Added special cases, tests and benchmarks for Atan2;
added 386 FPU version of Atan2.
R=rsc
CC=golang-dev
https://golang.org/cl/201068
2010-02-05 14:55:19 -08:00
Rob Pike
cd2ecfb7b3
Ugly hack to provide some mechanism for printing documentation about
...
Go source outside $GOROOT.
If the argument is a path starting with / or ., disregard $GOROOT.
Also, disable the check for package name matching the directory,
which is counterproductive in this case.
Apologies for the violence to the code but we need some help documenting
Go code outside the standard repository.
R=gri
CC=golang-dev
https://golang.org/cl/201064
2010-02-06 08:53:46 +11:00
Adam Langley
95e08bde44
asn1: Fixes and additions to marshalling
...
Marshalling:
* Fixes several silly bugs.
* Support the RawContents type.
* Support the RawValue type.
* Recurse into nested interface{}.
Both directions:
* Better handling of SETs. You can now tag an element in a
structure with "set" to get the correct tag for serialisation.
* For types that aren't in a structure, you can now name them
with "SET" on the end.
* SETs are no longer implicitly treated as SEQUENCEs.
R=rsc
CC=golang-dev
https://golang.org/cl/201049
2010-02-05 05:42:02 -05:00
Adam Langley
5d827fac39
crypto/tls: typo fix
...
R=rsc
CC=golang-dev
https://golang.org/cl/201047
2010-02-05 05:39:49 -05:00
Stephen Weinberg
bc43cc3db0
path: make Join variadic
...
R=rsc, r
CC=golang-dev
https://golang.org/cl/198049
2010-02-05 02:39:33 -08:00
Dean Prichard
0e47c75f60
5a/6a/8a/5c/6c/8c: remove fixed-size arrays for -I and -D options
...
R=rsc
CC=golang-dev
https://golang.org/cl/198044
2010-02-05 01:40:58 -08:00
Charles L. Dorian
04217ee54e
math: special cases for Modf, Frexp and Ldexp; added Modf_386
...
Also moved Modf from bits.go into modf.go and added timing tests.
R=rsc
CC=golang-dev
https://golang.org/cl/202042
2010-02-05 00:41:30 -08:00
Rob Pike
2d7dc0e70c
handle nils safely in Printf.
...
add some tests for erroneous formats.
R=rsc
CC=golang-dev
https://golang.org/cl/201058
2010-02-05 11:23:25 +11:00
Joe Poirier
987e1198db
Added mingw specific build stubs.
...
R=rsc
CC=golang-dev
https://golang.org/cl/198071
2010-02-04 13:09:09 -08:00
Christopher Wedgwood
1e66428d59
time: Sleep through interruptions
...
R=rsc
CC=golang-dev
https://golang.org/cl/202043
2010-02-04 13:09:02 -08:00
Christopher Wedgwood
b655fa8d1d
FreeBSD: Kill only takes pid & signal
...
Cosmetic fix. The FreeBSD system call only takes two
arguments.
http://fxr.watson.org/fxr/source/kern/kern_sig.c?im=bigexcerpts#L1678
R=dho, rsc
CC=golang-dev
https://golang.org/cl/202051
2010-02-04 13:08:54 -08:00
Andrew Gerrand
8ec9ffc742
6l: move mapped symbol table lower in memory
...
Allows binary to run on some Linux system.
Fix for issue 365.
R=rsc
CC=golang-dev
https://golang.org/cl/199096
2010-02-04 12:46:11 -08:00
Nigel Tao
4e2035bdc2
In draw.Draw, separate the source-point and mask-point.
...
This lets you draw text (i.e. with mask = a font image) with
sources that aren't uniform colors.
R=r, rsc
CC=golang-dev
https://golang.org/cl/193067
2010-02-04 21:21:32 +11:00
Russ Cox
f2317d3ec1
syscall: on freebsd, darwin, give Kill same signature as on linux
...
R=r, cw
CC=golang-dev
https://golang.org/cl/201043
2010-02-04 02:06:08 -08:00
Nigel Tao
ea344e123a
Add named colors (e.g. image.Blue), suitable for exp/draw.
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/198066
2010-02-04 20:25:37 +11:00
Petar Maymounkov
15da069a37
http: use ChunkWriter in Request.Write
...
R=rsc
CC=golang-dev
https://golang.org/cl/196079
2010-02-04 00:23:01 -08:00
Christopher Wedgwood
43d2e59a81
os/signal: send SIGCHLDs to Incoming
...
R=rsc
CC=golang-dev
https://golang.org/cl/199082
2010-02-03 23:24:28 -08:00
Kai Backman
2f1a321d4f
search for runtime.a in the package path instead of hardcoding
...
the location. remove last remnants of broken -l flag.
R=rsc
CC=golang-dev
https://golang.org/cl/201042
2010-02-03 22:31:38 -08:00
Russ Cox
c2cb0d70d5
arm: toss make-arm.bash
...
R=kaib
CC=golang-dev
https://golang.org/cl/199094
2010-02-03 20:46:37 -08:00
Rob Pike
2bcca5d951
Add RFC822 formats as named constants.
...
Make sure to print a time zone when formatting even if none is defined.
Add a comment introducing lookupTimezone (not lookupTimeZone).
Fixes isse 577.
R=rsc
CC=golang-dev
https://golang.org/cl/196090
2010-02-04 15:39:27 +11:00
Russ Cox
3a295ab704
debug/gosym: fix test for new 6l
...
TBR=r
CC=golang-dev
https://golang.org/cl/199091
2010-02-03 16:53:19 -08:00
Russ Cox
33e396a4a7
finalizers; merge package malloc into package runtime
...
R=r, cw
CC=golang-dev
https://golang.org/cl/198085
2010-02-03 16:31:34 -08:00
Russ Cox
00f4c6a1b5
ld: include main and runtime in the library loop
...
Fixes #585 .
R=r
CC=golang-dev
https://golang.org/cl/195075
2010-02-03 16:30:45 -08:00
Andrey Mirtchovski
4a9a0056c1
sort: fix comment typo
...
R=rsc
CC=golang-dev
https://golang.org/cl/198084
2010-02-02 23:01:21 -08:00
Russ Cox
8b8c103b2b
fix build - misc ... vs ...T fixes
...
TBR=r
CC=golang-dev
https://golang.org/cl/198081
2010-02-02 18:19:27 -08:00
Russ Cox
8bef7fdc39
bug252: make ... vs ...T crossing an error, at least for now
...
R=r
CC=golang-dev
https://golang.org/cl/199066
2010-02-02 15:00:13 -08:00
Russ Cox
44898c7b76
gc: bug250, bug251 - recursive interface types
...
Fixes #287 .
R=ken2
CC=golang-dev
https://golang.org/cl/199057
2010-02-01 23:58:49 -08:00
Nigel Tao
a3372bd655
New image.A type, to represent anti-aliased font glyphs.
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/199052
2010-02-02 18:38:04 +11:00
Russ Cox
674458e1c4
gc: bug246
...
R=ken2
CC=golang-dev
https://golang.org/cl/198057
2010-02-01 23:05:15 -08:00
Russ Cox
b13b80e555
math: change Cosh test to close, not veryclose (needed on some x86 chips)
...
R=r
CC=Charlie Dorian, golang-dev
https://golang.org/cl/199054
2010-02-01 22:46:37 -08:00
Charles L. Dorian
a0690b69da
math: add functions; update tests and special cases
...
Added special cases to comments for asin.go and fabs.go.
Added Trunc() to floor.go and floor_386.s. Fixed formatting
error in hypot_386.s Added new functions Acosh, Asinh,
Atanh, Copysign, Erf, Erfc, Expm1, and Log1p. Added
386 FPU version of Fmod. Added tests, benchmarks, and
precision to expected results in all_test.go. Edited
makefile so it all compiles.
R=rsc
CC=golang-dev
https://golang.org/cl/195052
2010-02-01 22:21:40 -08:00
Russ Cox
0bd41e2ff0
gc: bug242
...
R=ken2
CC=golang-dev
https://golang.org/cl/198053
2010-02-01 22:18:51 -08:00
Robert Griesemer
75187e5ca3
update printer tests to use new syntax
...
R=rsc
CC=golang-dev
https://golang.org/cl/198048
2010-02-01 17:51:55 -08:00
Russ Cox
2a5d30fbe7
io: revised Pipe implementation
...
* renamed channels to say what gets sent
* use channel closed status instead of racy check of boolean
R=nigeltao_golang
CC=golang-dev
https://golang.org/cl/196065
2010-02-01 17:43:15 -08:00
Rob Pike
5db5f68d96
allow any scalar type in xml.Unmarshal.
...
Fixes #574 .
R=rsc
CC=golang-dev
https://golang.org/cl/196056
2010-02-02 11:53:10 +11:00
Russ Cox
45515011cc
gc: final ...T bug for the day
...
R=ken2
CC=golang-dev
https://golang.org/cl/199046
2010-02-01 16:22:16 -08:00
Robert Griesemer
f7e2266ce6
Corrected broken assertion.
...
Fixes #571 .
R=rsc
CC=golang-dev
https://golang.org/cl/198045
2010-02-01 16:14:22 -08:00
Robert Griesemer
e37495368c
don't report a couple of meaningless errors in command-line mode
...
R=rsc
CC=golang-dev
https://golang.org/cl/199045
2010-02-01 16:13:58 -08:00
Rob Pike
d2fc5d68da
Change type of Printf's args to ... interface{}
...
R=rsc
CC=golang-dev
https://golang.org/cl/197043
2010-02-02 10:53:37 +11:00
Russ Cox
1f11ece67f
nacl: fix build, finally fixed 8l convergence bug
...
R=r
CC=golang-dev
https://golang.org/cl/199042
2010-02-01 15:20:19 -08:00
Petar Maymounkov
0d8797bf73
http: test for ReadReqeust
...
R=rsc, rsc1
CC=golang-dev
https://golang.org/cl/195068
2010-02-01 11:23:38 -08:00
Russ Cox
bea730d1f9
gc: ... T corner cases
...
more to come, but should suffice for Printf work.
R=ken2
CC=golang-dev
https://golang.org/cl/197044
2010-02-01 10:49:24 -08:00
Russ Cox
68796b0270
gc: add ... T, rework plain ...
...
No longer a distinct type; now a property of func types.
R=ken2
CC=golang-dev
https://golang.org/cl/197042
2010-02-01 00:25:59 -08:00
Rob Pike
20195bbe61
Fix redirection if the page is in a subdirectory.
...
Fixes buggy links in the devel subdirectory.
Code from rsc; tested by me.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/197041
2010-02-01 17:17:25 +11:00
Nigel Tao
5647e604f7
Check gzip strings for NUL elements, since they are NUL-terminated
...
on the wire.
R=rsc
CC=golang-dev
https://golang.org/cl/194146
2010-01-30 12:21:51 +11:00
Nigel Tao
af7e0f1bdd
Add a GZIP test for the empty payload.
...
R=rsc, r
CC=golang-dev
https://golang.org/cl/194131
2010-01-30 11:54:39 +11:00
Petar Maymounkov
84f9b70280
http: increase header line limit, let req.Host override req.URL.Host
...
Fixes #566 .
R=rsc
CC=golang-dev
https://golang.org/cl/194074
2010-01-29 16:51:42 -08:00
Rob Pike
d6ee49a119
fix bug in tick
...
Fixes #576 .
R=rsc, rog
CC=golang-dev
https://golang.org/cl/196061
2010-01-29 13:10:33 -08:00
Devon H. O'Dell
4ffbff14b3
math: Change veryclose to close for Sinh and Exp tests.
...
Fixes #550 .
R=rsc
CC=eds, golang-dev, jtomaschke
https://golang.org/cl/196063
2010-01-29 12:54:05 -08:00
Russ Cox
05f26366e5
two minor build fixes
...
Fixes #572 .
Fixes #570 .
R=r
CC=golang-dev
https://golang.org/cl/194134
2010-01-28 18:18:40 -08:00
Rob Pike
16ddb6c538
move comment on StringHeader to fix godoc output.
...
R=rsc, ken2
CC=golang-dev
https://golang.org/cl/196055
2010-01-29 12:43:46 +11:00
Russ Cox
6039a414ae
io: fix nil Write bug in Pipe
...
R=nigeltao_golang
CC=golang-dev
https://golang.org/cl/194132
2010-01-28 17:38:51 -08:00
Ken Thompson
d7a5ccf36e
added StringHeader to reflect
...
R=rsc
CC=golang-dev
https://golang.org/cl/194133
2010-01-28 17:14:29 -08:00
Dean Prichard
77053797e0
avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c
...
R=rsc
CC=golang-dev
https://golang.org/cl/194099
2010-01-28 16:11:38 -08:00
Nigel Tao
c9150003a9
gzip deflater (i.e., writer).
...
Also, the unused Inflater.eof field was removed.
It has been unused since revision aaa0b24538.
"introduce os.EOF and io.ErrUnexpectedEOF. remove io.ErrEOF."
http://code.google.com/p/go/source/diff?spec=svnaaa0b24538ed1e3e54cbbfdd030a3c35785e74c5&r=aaa0b24538ed1e3e54cbbfdd030a3c35785e74c5&format=side&path=/src/pkg/compress/gzip/gunzip.go
R=rsc
CC=golang-dev
https://golang.org/cl/194122
2010-01-29 11:00:05 +11:00
Russ Cox
288c1c83d9
gc: tweak error messages, avoid internalization settings in bison
...
R=r
CC=golang-dev
https://golang.org/cl/194129
2010-01-28 15:57:44 -08:00