1
0
mirror of https://github.com/golang/go synced 2024-09-30 16:28:32 -06:00
go/internal/lsp
Rebecca Stambler 58eba7e750 internal/lsp: refactor go.mod diagnostics to simplify the API
Currently, diagnostics for modules that are missing from the go.mod
appear in the Go files in which those modules are imported. As a result,
the diagnostics were previously calculated as part of the Go file
diagnostic calculations. This is convoluted and required passing around
an extra map.

This CL puts that logic in the ModTidyHandle where it belongs.
The diagnostics for the Go files are combined from the multiple sources.

Also, added a skipped test for golang/go#39784, since this CL was
originally intended to be a fix for that issue...

Change-Id: Ic0f9aa235dcd56ea131a2339de9801346f715415
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242579
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-16 22:50:03 +00:00
..
analysis internal/lsp: extract highlighted selection to variable 2020-07-07 21:12:28 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
cmd internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp/regtest: use a common directory for regtest sandboxes 2020-07-09 18:15:24 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
mod internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
protocol internal/lsp: bring lsp protocol stubs up to date 2020-06-11 18:15:06 +00:00
regtest internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
testdata internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
tests internal/lsp: fix rename with Windows line endings 2020-07-10 04:00:52 +00:00
code_action.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
command.go internal/lsp: refactor generate code lens code 2020-07-16 13:43:19 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: watch go.{mod,sum} files, as well as Go files 2020-07-13 01:13:07 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
lsp_test.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
progress.go internal/lsp: refactor generate code lens code 2020-07-16 13:43:19 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00