mirror of
https://github.com/golang/go
synced 2024-11-05 11:36:10 -07:00
ecd3fc4348
We use file identities pervasively throughout gopls. Prior to this change, the identity is the modification date of an unopened file, or the hash of an opened file. That means that opening a file changes its identity, which causes unnecessary churn in the cache. Unfortunately, there isn't an easy way to fix this. Changing the cache key to something else, such as the modification time, means that we won't unify cache entries if a change is made and then undone. The approach here is to read files eagerly in GetFile, so that we know their hashes immediately. That resolves the churn, but means that we do a ton of file IO at startup. Incidental changes: Remove the FileSystem interface; there was only one implementation and it added a fair amount of cruft. We have many other places that assume os.Stat and such work. Add direct accessors to FileHandle for URI, Kind, and Version. Most uses of (FileHandle).Identity were for stuff that we derive solely from the URI, and this helped me disentangle them. It is a *ton* of churn, though. I can revert it if you want. Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
39 lines
1.1 KiB
Go
39 lines
1.1 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
|
|
"golang.org/x/tools/internal/event"
|
|
"golang.org/x/tools/internal/lsp/debug/tag"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
)
|
|
|
|
func (s *Server) documentHighlight(ctx context.Context, params *protocol.DocumentHighlightParams) ([]protocol.DocumentHighlight, error) {
|
|
snapshot, fh, ok, err := s.beginFileRequest(ctx, params.TextDocument.URI, source.Go)
|
|
if !ok {
|
|
return nil, err
|
|
}
|
|
rngs, err := source.Highlight(ctx, snapshot, fh, params.Position)
|
|
if err != nil {
|
|
event.Error(ctx, "no highlight", err, tag.URI.Of(params.TextDocument.URI))
|
|
}
|
|
return toProtocolHighlight(rngs), nil
|
|
}
|
|
|
|
func toProtocolHighlight(rngs []protocol.Range) []protocol.DocumentHighlight {
|
|
result := make([]protocol.DocumentHighlight, 0, len(rngs))
|
|
kind := protocol.Text
|
|
for _, rng := range rngs {
|
|
result = append(result, protocol.DocumentHighlight{
|
|
Kind: kind,
|
|
Range: rng,
|
|
})
|
|
}
|
|
return result
|
|
}
|