1
0
mirror of https://github.com/golang/go synced 2024-11-18 13:04:46 -07:00
go/internal/lsp/testdata
Rebecca Stambler 58eba7e750 internal/lsp: refactor go.mod diagnostics to simplify the API
Currently, diagnostics for modules that are missing from the go.mod
appear in the Go files in which those modules are imported. As a result,
the diagnostics were previously calculated as part of the Go file
diagnostic calculations. This is convoluted and required passing around
an extra map.

This CL puts that logic in the ModTidyHandle where it belongs.
The diagnostics for the Go files are combined from the multiple sources.

Also, added a skipped test for golang/go#39784, since this CL was
originally intended to be a fix for that issue...

Change-Id: Ic0f9aa235dcd56ea131a2339de9801346f715415
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242579
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-16 22:50:03 +00:00
..
lsp internal/lsp: always show signature as the top line in hover 2020-07-13 23:52:42 +00:00
missingdep internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
missingtwodep internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
unused internal/lsp: plumb fillstruct through analysis 2020-06-15 21:22:08 +00:00
upgradedep internal/lsp: plumb fillstruct through analysis 2020-06-15 21:22:08 +00:00