1
0
mirror of https://github.com/golang/go synced 2024-11-05 14:46:11 -07:00
go/internal/lsp/source
Rebecca Stambler 58eba7e750 internal/lsp: refactor go.mod diagnostics to simplify the API
Currently, diagnostics for modules that are missing from the go.mod
appear in the Go files in which those modules are imported. As a result,
the diagnostics were previously calculated as part of the Go file
diagnostic calculations. This is convoluted and required passing around
an extra map.

This CL puts that logic in the ModTidyHandle where it belongs.
The diagnostics for the Go files are combined from the multiple sources.

Also, added a skipped test for golang/go#39784, since this CL was
originally intended to be a fix for that issue...

Change-Id: Ic0f9aa235dcd56ea131a2339de9801346f715415
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242579
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-16 22:50:03 +00:00
..
code_lens.go internal/lsp: clean up the code lens code 2020-07-16 13:43:26 +00:00
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
completion_format.go internal/lsp/source: speed up completion candidate formatting 2020-07-01 04:11:22 +00:00
completion_keywords.go internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_statements.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: extract highlighted selection to variable 2020-07-07 21:12:28 +00:00
deep_completion.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
diagnostics.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
extract.go internal/lsp: extract highlighted selection to variable 2020-07-07 21:12:28 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format_test.go internal/lsp: avoid panic caused by assuming file ends with newline 2020-07-14 19:07:37 +00:00
format.go internal/lsp: avoid panic caused by assuming file ends with newline 2020-07-14 19:07:37 +00:00
highlight.go internal/lsp/source: support highlight of switch statements 2020-06-19 02:36:21 +00:00
hover.go internal/lsp: always show signature as the top line in hover 2020-07-13 23:52:42 +00:00
identifier.go internal/lsp: fix error in CL 242457 2020-07-16 17:41:35 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
options.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
references.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
rename_check.go internal/lsp: add changeMethods logic to rename check 2020-07-13 19:50:33 +00:00
rename.go internal/lsp: add changeMethods logic to rename check 2020-07-13 19:50:33 +00:00
signature_help.go internal/lsp/source: speed up completion candidate formatting 2020-07-01 04:11:22 +00:00
source_test.go internal/lsp/source: speed up completion candidate formatting 2020-07-01 04:11:22 +00:00
symbols.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
types_format.go internal/lsp/source: handle nil pointer in newBuiltinSignature 2020-07-15 19:52:07 +00:00
util.go internal/lsp/source: speed up completion candidate formatting 2020-07-01 04:11:22 +00:00
view.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00