qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 06:38:00 -07:00
Code Releases Activity
4,596 Commits 58 Branches 402 Tags 522 MiB
14a74378f4
Commit Graph

3132 Commits

Author SHA1 Message Date
Russ Cox
91cf0af181 ld: move interpreter string into first block of ELF file 
necessary on freebsd.

R=r, dho
CC=golang-dev
https://golang.org/cl/157069
 2009-11-18 13:51:05 -08:00
Rob Pike
7518613430 slicecopy was always using 16 (sizeof slice) for the size instead of size of element. 
R=rsc
CC=ken2, golang-dev
https://golang.org/cl/156083
 2009-11-18 13:43:48 -08:00
Adam Langley
ef8f483c60 net: remove race condition on Close. 
Previously a netFd could be queued for reading/writing in the channel,
but close(2)'ed before pollServer got to it. In this case, the kernel
would consider the descriptor closed and the attempt to add it to the
epoll set would fail and panic.

This patch makes Close a roundtrip to the pollServer, although the
actual close(2) still occurs elsewhere to avoid blocking the
pollServer.

Fixes #143.

R=rsc
CC=golang-dev
https://golang.org/cl/152130
 2009-11-18 13:18:34 -08:00
Eden Li
652bb7c2be Mangle C struct fields that happen to be named after Go keywords by prefixing them with _. Collisions with existing fields are resolved by prefixing the new Go identifier with _ until it matches nothing else in the struct. 
Fixes #36.

R=rsc
https://golang.org/cl/157061
 2009-11-18 09:59:10 -08:00
Russ Cox
a274099340 big: implement 386 assembly routines 
7x speedup on big and crypto/rsa unit tests.
also dropped useAsm in favor of making the
asm stubs jump to the Go versions.

R=agl1
CC=golang-dev, gri
https://golang.org/cl/157062
 2009-11-18 09:54:51 -08:00
William Josephson
4c0f262a2d Remove unnecessary execute bits. 
R=rsc
https://golang.org/cl/156077
 2009-11-18 09:19:29 -08:00
William Josephson
72e7444ad4 Missing flags for FreeBSD shared link as used by cgo in default build. 
R=rsc
https://golang.org/cl/157065
 2009-11-18 09:18:51 -08:00
Devon H. O'Dell
659780b643 Add an intptr type to runtime; needed in FreeBSD 
In thread.c, we need to cast to whatever the native
size of intptr is on the system, but we only have
uintptr available. They're the same size, but can't
do signed casts without this one :).

R=rsc
CC=golang-dev
https://golang.org/cl/156073
 2009-11-18 09:11:39 -08:00
Devon H. O'Dell
b3f538a4fd FreeBSD/i386 work 
This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.

R=rsc
https://golang.org/cl/157055
 2009-11-17 23:58:51 -08:00
Eden Li
2115f514d0 cgo no longer translates function args that are void* into 
unsafe.Pointer.
Fixes #254.

R=rsc
https://golang.org/cl/157060
 2009-11-17 23:42:21 -08:00
Russ Cox
744d5ae48a runtime: add ARM memmove 
R=ken2
https://golang.org/cl/156063
 2009-11-17 22:54:20 -08:00
Russ Cox
ed0beea27b copy tweaks 
* move memmove to arch-specific subdirectories
  * add memmove for arm
  * add copyright notices marking them as copied from Inferno

R=ken2
https://golang.org/cl/156061
 2009-11-17 22:16:55 -08:00
Rob Pike
ea5cc6c021 add a test for %+v in nested structures. 
threw in an embedded one for good measure.

R=rsc
CC=golang-dev
https://golang.org/cl/157058
 2009-11-17 22:14:34 -08:00
Ken Thompson
01c2de0c15 allow copy to be used without a return value 
R=rsc
https://golang.org/cl/156060
 2009-11-17 22:00:59 -08:00
Russ Cox
41554e2528 runtime: two trivial but important bug fixes 
R=r
https://golang.org/cl/156059
 2009-11-17 22:00:30 -08:00
Ken Thompson
948f3e77e1 bug in copy 
R=rsc
https://golang.org/cl/156056
 2009-11-17 20:44:35 -08:00
Ken Thompson
c4606d05da install copy predefined 
did not test 386, but should work
shouldnt matter if copy is not used

R=rsc
https://golang.org/cl/156055
 2009-11-17 20:41:44 -08:00
Adam Langley
a8ba40823c crypto/rsa: add PKCS#1 v1.5 signature support. 
R=rsc
CC=golang-dev
https://golang.org/cl/156051
 2009-11-17 18:21:47 -08:00
Adam Langley
80b7f6a8d4 asn1: 
* add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

R=rsc
CC=golang-dev
https://golang.org/cl/156047
 2009-11-17 18:09:41 -08:00
Russ Cox
1dbd3c8d3d reflect: document that PkgPath and Name return 
empty string for unnamed types.

Fixes #249.

R=r
https://golang.org/cl/156052
 2009-11-17 16:03:14 -08:00
Russ Cox
849e6f99b8 http: do not crash accessing r.Form if ParseForm fails 
Fixes #233.

R=dsymonds1
https://golang.org/cl/154179
 2009-11-17 14:45:10 -08:00
Russ Cox
4dfd7fdde5 runtime: do not create new threads during malloc. 
the signal handling stack is a different size than
	the normal stack, so it cannot be allocated using
	the backup stack allocator.

Fixes #250.

R=agl1
CC=golang-dev
https://golang.org/cl/157044
 2009-11-17 14:42:08 -08:00
Ken Thompson
26b55e44d9 fix botch 
R=rsc
https://golang.org/cl/157046
 2009-11-17 14:11:50 -08:00
Ken Thompson
8a6da2f6a0 change a n^2 algorithm in 
data initialization to n*log(n)

R=rsc
https://golang.org/cl/158041
 2009-11-17 13:59:38 -08:00
Rob Pike
6240b0110a improve documentation of runtime. there was no mention of types. 
R=rsc
CC=golang-dev
https://golang.org/cl/157042
 2009-11-17 11:44:15 -08:00
Aron Nopanen
c51ee432d1 Make non-errored RPC calls return 'nil' error to caller. 
Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.

This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.

Tests updated to check error return in success cases.

R=r, rsc
https://golang.org/cl/154159
 2009-11-17 11:29:02 -08:00
Sergio Luis O. B. Correia
bae4f5085e cmd/cc: Fix -I switch to handle a path with blankspaces correctly 
Currently, -I switch can't deal with a path containing spaces.
This commit simplify setinclude(), by removing the special case
of a string that had spaces. After this change, setinclude() will
merely add the given directories to the include path, if it does
not yet exist, and this approach works.

Will be needed for solving issue 115.

R=agl1, rsc, iant2, r
https://golang.org/cl/155059
 2009-11-17 09:02:47 -08:00
Russ Cox
b4586a7429 math: fix argument names in Atan2 
(error introduced converting from arg1, arg2)

Fixes #220.

R=r
https://golang.org/cl/156041
 2009-11-17 08:39:56 -08:00
Russ Cox
c0e1ccf3ff Make.pkg: have "make coverage" invoke 6cov with correct binary 
Fixes #239.

R=r
https://golang.org/cl/154176
 2009-11-17 08:39:26 -08:00
Russ Cox
6e788e0f0f net: enforce timeouts for ReadFrom/WriteTo 
Fixes #153.

R=r
https://golang.org/cl/154177
 2009-11-17 08:39:17 -08:00
Russ Cox
a65bf95dd8 syscall: use correct pointer in recvfrom/sendto. 
linux/386 stack trace: use 32-bit hex.

Fixes #159.

R=r
https://golang.org/cl/154178
 2009-11-17 08:39:04 -08:00
Devon H. O'Dell
0489a260da FreeBSD-specific porting work. 
cgo/libmach remain unimplemented. However, compilers, runtime,
and packages are 100%. I still need to go through and implement
missing syscalls (at least make sure they're all listed), but
for all shipped functionality, this is done. Ship! ;)

R=rsc, VenkateshSrinivas
https://golang.org/cl/152142
 2009-11-17 08:20:58 -08:00
Rob Pike
30b1b9a36a Rework gobs to fix bad bug related to sharing of id's between encoder and decoder side. 
Fix is to move all decoder state into the decoder object.

Fixes #215.

R=rsc
CC=golang-dev
https://golang.org/cl/155077
 2009-11-16 23:32:30 -08:00
Rob Pike
50c04132ac fix bug causing empty strings to be become non-nil errors on client side of rpc connection. 
R=rsc
CC=golang-dev
https://golang.org/cl/155078
 2009-11-16 23:32:16 -08:00
Russ Cox
597b2a91a6 runtime: make signal handler work on 386 
R=r
https://golang.org/cl/154171
 2009-11-16 17:51:47 -08:00
Russ Cox
1ee83f851d gc: change "can we const evaluate this" from blacklist to whitelist 
R=ken2
https://golang.org/cl/155074
 2009-11-16 17:40:47 -08:00
Russ Cox
44e51fad28 6l: fix divide by zero in glibc linker. 
repeats 8l change http://code.google.com/p/go/source/detail?r=7594e16b5cf9

Fixes #179.

R=iant
https://golang.org/cl/154145
 2009-11-16 17:40:03 -08:00
Adam Langley
1cdfe9fa28 unsafe: documentation typo. 
Fixes #236.

R=r
CC=golang-dev
https://golang.org/cl/155072
 2009-11-16 15:39:04 -08:00
Robert Griesemer
e86afaf456 Don't emit line tags when source code is printed as part of 
package documentation using templates. The line tag interferes
with the anchor tag introduces by the template.

This fixes an an issue where some headers lost their ability
to link to the respective source code.

R=rsc
https://golang.org/cl/154166
 2009-11-16 14:26:29 -08:00
David Symonds
affcfe5a75 Add some primitive type aliases to exp/iterable and define Iter on them. 
R=rsc
https://golang.org/cl/155065
 2009-11-16 13:39:59 -08:00
David G. Andersen
37f71e8ad6 An asked-for-in #go-nuts extension to quickly create a repeated 
copy of a string or a byte array.
        strings.Repeat("-", 50)
	bytes.Repeat(b, 99)

R=rsc
https://golang.org/cl/155063
 2009-11-16 12:40:01 -08:00
Kai Backman
c3cf8d663a s/AJMP/AB/ to fix build breakage. 
R=rsc
https://golang.org/cl/155069
 2009-11-16 11:58:28 -08:00
Russ Cox
ef46a9ddac gc: fix up floating point NaN comparisons 
Fixes #167.

R=ken2
https://golang.org/cl/155062
 2009-11-15 17:24:14 -08:00
Adam Langley
391e082ca9 crypto/md5: fix comment typo. 
Fixes #210.

R=rsc
CC=golang-dev
https://golang.org/cl/155057
 2009-11-15 14:00:46 -08:00
Russ Cox
39f64bed52 godefs: avoid gcc 4'isms in command line. 
Fixes #97.

R=r
https://golang.org/cl/155054
 2009-11-15 12:57:39 -08:00
Russ Cox
cc3524fb06 makefiles: use correct gcc order in case --as-needed is in use. 
Suggested by eostapets.
Fixes #141.

R=r
https://golang.org/cl/155049
 2009-11-15 12:57:28 -08:00
Russ Cox
0238fd836f cgo: arrange for English error messages 
Fixes #21.

R=r
https://golang.org/cl/155048
 2009-11-15 12:57:21 -08:00
Russ Cox
091191336a runtime: avoid crash in Caller 
Fixes #176.

R=r
https://golang.org/cl/154146
 2009-11-15 12:57:15 -08:00
Russ Cox
a338231526 gc: five bug fixes, one better error. 
* check for struct literal assignment to private fields.
* record, fix crash involving parallel map assignment.
* avoid infinite recursion in exportassignok.
* make floating point bounds check precise.
* avoid crash on invalid receiver.

* add context to error about implicit assignment.

Fixes #86.
Fixes #88.
Fixes #158.
Fixes #174.
Fixes #201.
Fixes #204.

R=ken2
https://golang.org/cl/154144
 2009-11-15 12:57:09 -08:00
Russ Cox
a967f57d19 http.URLEscape: escape all bytes required by RFC 2396 
Fixes #125.

R=r
https://golang.org/cl/154143
 2009-11-15 12:56:50 -08:00
Russ Cox
2a6bb2c63e gotest: show the test file pattern in "no test files" error 
Fixes #190.

R=r
https://golang.org/cl/154142
 2009-11-15 12:56:39 -08:00
Rob Pike
27779dd6cb fix bug in bytes.Map and add test cases for Map in both strings and bytes packages. 
thanks to ulrik.sverdrup for the test case.

Fixes #191.

R=rsc
CC=golang-dev
https://golang.org/cl/155056
 2009-11-15 12:07:27 -08:00
Russ Cox
b18bee948e cc: drop redundant strcpy 
Fixes #192.

R=ken2
https://golang.org/cl/155047
 2009-11-15 00:00:05 -08:00
Russ Cox
139a053733 cc: eliminate two fixed-size buffers 
Fixes bug 168.
Alternative to https://golang.org/cl/152143.

R=ken2
https://golang.org/cl/155042
 2009-11-14 23:25:55 -08:00
Kai Backman
529216fa83 complain if GOARCH != arm. fix build break caused by gomake 
introduction.

R=rsc
https://golang.org/cl/152109
 2009-11-14 23:08:22 -08:00
Adam Langley
ad05d29103 crypto/rsa: handle the case of non-coprime blinds. 
We are dealing with the multiplicative group ℤ/pqℤ. Multiples of
either p or q are not members of the group since they cannot have an
inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.)

With p and q of typical size (> 512 bits), the probability of a random
blind [1..pq-1] being a multiple of p or q is negligible. However, in
the unit tests, much smaller sizes are used and the event could occur.

This change checks the result of the ext GCD and deals with this case.

It also increases the size of p and q in the unit test as a large
number of the keys selected were p, q = 227,169.

R=rsc
CC=golang-dev
https://golang.org/cl/154141
 2009-11-14 20:38:00 -08:00
Devon H. O'Dell
553be8427e Build changes to support work on the BSDs. 
This does still contain some FreeBSD-specific bits, but
it's a pain to do partial diffs.

R=rsc
https://golang.org/cl/152138
 2009-11-14 15:29:09 -08:00
Môshe van der Sterre
a54684f8da encoding/binary: implemented the Write function 
The ByteOrder.Put* methods are already available, this change uses
them to implement the Write function.

R=golang-dev, agl1, rsc, r
https://golang.org/cl/152141
 2009-11-14 14:42:22 -08:00
Russ Cox
4b13d1b9b5 gc: do not try to constant-evaluate (interface{})("bar") 
Fixes #183.

R=ken
https://golang.org/cl/154139
 2009-11-14 14:14:27 -08:00
Rob Pike
0263103a05 move evaluation of null-matching instructions one iteration earlier. 
performance hit of about 20% but more intuitive results for submatches.
we need a good regexp package at some point.

Fixes #110.

R=rsc
CC=golang-dev
https://golang.org/cl/152131
 2009-11-14 12:23:24 -08:00
Abhinav Gupta
bad9738be6 xml: Fixed CDATA parsing. 
Fixes #128.

R=r, rsc
https://golang.org/cl/154126
 2009-11-14 11:46:09 -08:00
Russ Cox
933d1850ce typos 
Fixes #171.
Fixes #172.

R=agl1
https://golang.org/cl/154136
 2009-11-14 10:28:53 -08:00
David Titarenco
aebae2577a Created new Conn.Flush() public method so the fd pipeline can be drained arbitrarily by the user. 
Commented both flush methods so people know what they are looking at.

This is a necessary fix for streaming and long polling HTTP services.
Fixes #93.

R=r, rsc, david.titarenco
https://golang.org/cl/154099
 2009-11-13 18:06:47 -08:00
Nigel Tao
75829b3c51 Remove unnecessary int(h) casts in image.go. 
R=rsc
https://golang.org/cl/154125
 2009-11-13 17:40:20 -08:00
Adam Langley
a070722340 json: minor comment fix. 
I screwed up and didn't write one of the code review changes to disk
before submitting.

TBR=rsc

R=rsc
https://golang.org/cl/154122
 2009-11-13 14:59:04 -08:00
Rob Pike
f9919ba323 Explain why 
-flag true
does not work although
	-flag=true
does.

Fixes #139.

R=iant
CC=golang-dev
https://golang.org/cl/154118
 2009-11-13 13:15:18 -08:00
Adam Langley
bccc337084 json: allow one to unmarshal a top-level JSON array. 
Fixies issue 114.

R=rsc
CC=golang-dev
https://golang.org/cl/154121
 2009-11-13 13:00:45 -08:00
Russ Cox
e7b8f5faca path.TestWalk: disable error case if root 
(chmod 0 doesn't cause errors for root)

Fixes #22.

R=gri
https://golang.org/cl/152120
 2009-11-13 11:34:33 -08:00
Adam Langley
87bc9b53fd json: fix addressing of slice indexes that are multiples of 8. 
Fixes #147.

R=rsc
CC=golang-dev
https://golang.org/cl/152123
 2009-11-13 11:29:13 -08:00
Adam Langley
3f7a32405d runtime: warn about SELinux based mmap failures on Linux. 
SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.

This patch prints a warning on Linux when mmap fails with EACCES.

R=rsc
CC=golang-dev
https://golang.org/cl/152086
 2009-11-13 10:08:51 -08:00
Russ Cox
593ccd1d44 yet another attempt to avoid conflicts with 
<stdio.h>, which we weren't even #including

R=r
https://golang.org/cl/154108
 2009-11-12 23:38:48 -08:00
Rob Pike
845276ae68 remove dead code from test 
R=rsc
CC=golang-dev
https://golang.org/cl/152118
 2009-11-12 23:35:45 -08:00
Rob Pike
00093011e6 sudo.bash tries to install acid and db, which don't exist any more 
R=rsc
CC=golang-dev
https://golang.org/cl/152117
 2009-11-12 23:19:12 -08:00
Robert Griesemer
511772c888 Remove -align flag from gofmt. 
(Making it work correctly with -spaces is a bit of work and the output
won't make much sense as it is intended as input to tabwriter.)
Fixes #100.

R=rsc
https://golang.org/cl/154102
 2009-11-12 18:26:45 -08:00
Kai Backman
a23746ea65 fix style nit ignored in previous cl 
R=rsc
https://golang.org/cl/152110
 2009-11-12 16:12:28 -08:00
Kai Backman
6a48aab747 add support for pre arm v6 cas. set GOARM=5 to enable. 
R=rsc
https://golang.org/cl/154101
 2009-11-12 15:23:23 -08:00
Russ Cox
b0c7d68052 os.TestSeek: use a smaller but still 64-bit seek offset. 
Might fix issue 91.

R=r
https://golang.org/cl/152108
 2009-11-12 14:55:04 -08:00
Rob Pike
ce0a4bae41 produce helpful error when gotest doesn't find a Makefile 
Fixes #117.

R=rsc, agl1
CC=golang-dev
https://golang.org/cl/152107
 2009-11-12 14:28:45 -08:00
Adam Langley
454c621d91 exp/draw: correct Makefile. 
Thanks to Allister Macleod

Fixes #112.

R=rsc
CC=golang-dev
https://golang.org/cl/152102
 2009-11-12 13:55:20 -08:00
Russ Cox
6634e3432d cc, ld: fix more gcc 4.3 -O2 compile bugs 
same as https://golang.org/cl/152088
in more files.

Fixes #83.

R=r, r1
https://golang.org/cl/152091
 2009-11-12 00:22:45 -08:00
Kai Backman
6dbd142951 add cache flushing call after generating closure. 
go/test: passes 88% (306/347)

R=rsc
https://golang.org/cl/152089
 2009-11-11 23:23:11 -08:00
Russ Cox
e5636d6e27 avoid seg fault when return type is unknown 
Fixes #80.

R=ken
https://golang.org/cl/154079
 2009-11-11 22:20:05 -08:00
Russ Cox
8b95720918 gopack: work around gcc bug in hash function 
Fixes #48.  (this time for sure!)

R=r, r1
https://golang.org/cl/152088
 2009-11-11 22:19:58 -08:00
David Symonds
9e829c42d6 Fix capitalisation of "Git". 
R=rsc
https://golang.org/cl/154071
 2009-11-11 17:31:28 -08:00
Robert Griesemer
23843fa49e vector: s/Element/interface{}/ 
Fixes #74.

R=rsc
https://golang.org/cl/154073
 2009-11-11 17:25:51 -08:00
Adam Langley
3b092fec36 json: support \u escaping in strings 
Fixes #73.

R=rsc
CC=golang-dev
https://golang.org/cl/154072
 2009-11-11 17:13:14 -08:00
Russ Cox
ae3341476d cgo: add more information about gcc output parsing failures 
R=r
https://golang.org/cl/152084
 2009-11-11 16:58:27 -08:00
Russ Cox
c3343ef62c fix BUFSIZ redeclaration warnings 
R=r
https://golang.org/cl/152085
 2009-11-11 16:33:23 -08:00
Russ Cox
2cda46dc82 fix TestRemoveAll again (tested as root this time). 
Fixes #22.

R=r
https://golang.org/cl/154069
 2009-11-11 15:48:38 -08:00
Adam Langley
2643f742a5 make.bash: detect and warn about SELinux policy that crashes us. 
The default SELinux policy on Fedora 12 (at least) disallows stack
pages to be +x. This causes all binaries written by 6g/6l to segfault
immedately. The 'true' way to fix this issue is to mark binaries with
the correct type. However, that assumes that 6l is going to detect
SELinux, figure out the correct type for the current distribution and
set the type (without libselinux).

For now we'll warn users and point them towards the way to enable
execstack for the whole system.

http://code.google.com/p/go/issues/detail?id=47

R=rsc
CC=golang-dev
http://codereview.prom.corp.google.com/1026041
 2009-11-11 15:02:15 -08:00
Russ Cox
f07a9e43e8 os test: do not use symlink > 255 bytes. 
Fixes #62.

R=r
https://golang.org/cl/152080
 2009-11-11 14:52:29 -08:00
Russ Cox
ae39a1d8ec cc: correct handling of allocn(0, 1, d) 
Fixes #29.

R=r
https://golang.org/cl/152076
 2009-11-11 14:52:21 -08:00
Russ Cox
d38630fe3d gotest: add LC_ALL=C 
R=r
https://golang.org/cl/154067
 2009-11-11 14:52:15 -08:00
Russ Cox
e9ac56fb99 getc/ungetc in assemblers; BUFSIZ everywhere. 
Fixes #67.

R=r
https://golang.org/cl/154068
 2009-11-11 14:52:08 -08:00
Russ Cox
a174987a7c two gopack nits. 
1. allocate an extra byte for use by write.
2. throw away the code trying to translate
   uid and gid to names.  i suspect it of causing
   seg faults in some situations, and it is
   not needed by the compilers.

Fixes #48.  (I hope.)

R=r
https://golang.org/cl/152077
 2009-11-11 14:48:33 -08:00
Adam Langley
9188b1f000 Revert make.bash which slipped into the previous revision. 
R=rsc
http://codereview.prom.corp.google.com/1024051
 2009-11-11 13:30:47 -08:00
Adam Langley
1941855730 Reland a112249da741, this time with missing file. 2009-11-11 13:21:37 -08:00
Russ Cox
8c3d2f015b avoid clash with stdio's getc, ungetc. 
Fixes #50.

R=r
https://golang.org/cl/154064
 2009-11-11 13:08:35 -08:00
Russ Cox
8515a9f4e2 log test: don't assume a fixed set of letters for $GOROOT 
Fixes #27.

R=r
https://golang.org/cl/152075
 2009-11-11 13:07:46 -08:00
Russ Cox
ed86d0e70a roll back 3985: build is broken 
TBR=agl1
CC=golang-dev
https://golang.org/cl/154065
 2009-11-11 12:54:52 -08:00
Adam Langley
af1fa43a81 big: 
Turn methods that don't store the result in their receiver into
    functions in order to preserve the convention.
  Re-jig Exp and Div by moving their guts into nat.go.
  Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.

R=gri
CC=go-dev
http://codereview.prom.corp.google.com/1024038
 2009-11-11 12:34:46 -08:00
Russ Cox
384932589d work with GNU Make 3.80 
Fixes #30.

R=r1, r
https://golang.org/cl/154061
 2009-11-11 12:00:50 -08:00
Russ Cox
7932950844 gc: increase maximum path size in getwd from 100 to 1000. 
Fixes #31.

To try the fix before the next release:
	hg pull -u

R=r1, r
https://golang.org/cl/154058
 2009-11-11 12:00:41 -08:00
Russ Cox
1971e1bd21 os: do not test error case of TestRemoveAll when root 
Fixes #22.

R=r1, r
https://golang.org/cl/152073
 2009-11-11 12:00:34 -08:00
Russ Cox
364e564e3d use fully qualified names for hash interfaces 
Fixes #38.

R=r1, r
https://golang.org/cl/152072
 2009-11-11 12:00:15 -08:00
Adam Langley
5281869fac gopack: convert long to time_t before taking a pointer. 
Fixes #40.

R=rsc, r1
CC=golang-dev
https://golang.org/cl/154057
 2009-11-11 11:19:33 -08:00
Russ Cox
cd0cbd3ed2 lib9: rip out platform specific code that breaks on pclinuxos 
R=r
CC=golang-dev
https://golang.org/cl/154049
 2009-11-10 23:42:21 -08:00
Russ Cox
fe1e49241c update old comment: things are much better now 
R=r
https://golang.org/cl/152057
 2009-11-10 19:59:22 -08:00
Russ Cox
9604f7b009 gotest: avoid problems with grepping for · 
Fixes #7.

R=r
CC=golang-dev
https://golang.org/cl/154043
 2009-11-10 19:56:32 -08:00
Russ Cox
9ff712ecd1 make.bash: check $PATH indirectly via which quietgcc 
R=agl1
CC=golang-dev
https://golang.org/cl/152056
 2009-11-10 19:20:34 -08:00
Russ Cox
2d70d60392 sanity check environment variables better. 
Fixes #12.

R=agl1
CC=golang-dev
https://golang.org/cl/152055
 2009-11-10 19:12:22 -08:00
Russ Cox
92a9ddf0fa net: fix error for connect to /etc/ on some systems 
R=agl1
CC=golang-dev
https://golang.org/cl/152051
 2009-11-10 18:27:26 -08:00
Russ Cox
d6c388616b test for invalid $GOBIN setting before trying to build 
R=r
CC=golang-dev
https://golang.org/cl/153049
 2009-11-10 18:00:48 -08:00
Russ Cox
e23f75b3c4 net: disable more ipv6 tests 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153050
 2009-11-10 18:00:27 -08:00
Russ Cox
b4a8b353c4 net: disable ipv6 test if we know kernel won't take it. 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153048
 2009-11-10 17:47:38 -08:00
Russ Cox
9dba695692 net: disable dns error test 
some dns resolvers (opendns, for example)
are willing to make up results for any name.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
 2009-11-10 17:39:01 -08:00
Russ Cox
484f46daea net: fix dns bug reported on irc. 
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.

tested by tossing domain and search lines from /etc/resolv.conf

Fixes #2.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
 2009-11-10 17:09:33 -08:00
Robert Griesemer
9e0d2fa89b better code for a copy loop 
R=rsc
https://golang.org/cl/152046
 2009-11-10 15:33:59 -08:00
Ken Thompson
c90d392ce3 spell it with an "e" 
R=rsc
http://go/go-review/1025037
 2009-11-10 15:05:15 -08:00
Robert Griesemer
b27f05f63b minor adjustments to package comments for better synopsis. 
R=rsc
CC=r
http://go/go-review/1026038
 2009-11-10 10:55:53 -08:00
Russ Cox
b351113b50 make regexp comment not a package comment 
R=r
http://go/go-review/1025036
 2009-11-10 09:36:48 -08:00
Russ Cox
cb94b60cfb allow user agent to mention Go. 
R=r
http://go/go-review/1024046
 2009-11-10 09:10:08 -08:00
Russ Cox
da776791c4 drop output from nilptr tests; 
too hard to make it the same everywhere.
still checking for non-zero exit status though.

disable core files while running tests

R=r
http://go/go-review/1026037
 2009-11-09 23:11:36 -08:00
Robert Griesemer
3d668c1b5d - minor cleanups 
- better debugging support
- gofmt -l src misc | wc -l is 0

R=rsc
http://go/go-review/1024042
 2009-11-09 22:30:07 -08:00
Robert Griesemer
3bb0032cd6 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)

R=rsc, r
http://go/go-review/1024041
 2009-11-09 21:23:52 -08:00
Robert Griesemer
baba292998 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
	- applied gofmt -w misc src
	- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1026036
 2009-11-09 21:13:17 -08:00
Robert Griesemer
1698934194 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1024040
 2009-11-09 21:09:34 -08:00
Russ Cox
9f42ccb781 error rewording suggested by robert. 
update comment.

R=ken
http://go/go-review/1025031
 2009-11-09 15:25:18 -08:00
Robert Griesemer
92743615fb TBR: 
fix typo that prevented function bodies from being indexed (ouch!)

R=rsc
http://go/go-review/1024035
 2009-11-09 14:44:16 -08:00
Robert Griesemer
40621d5c0d remove semis after statements in one-statement statement lists 
R=rsc, r
http://go/go-review/1025029
 2009-11-09 12:07:39 -08:00
Russ Cox
18ccbc69f8 tweak documentation of commands 
so that first sentence is better for cmd page.

live at http://r45:3456/cmd/

R=gri, r
http://go/go-review/1024034
 2009-11-09 11:45:15 -08:00
Robert Griesemer
81672e79e4 - rename Context to exprContext to remove it from public interface 
(and to match the style of declContext)

R=rsc
http://go/go-review/1024033
 2009-11-09 10:37:36 -08:00
Robert Griesemer
53f485813e fix for nodeSize computation, used to determine if 
a node fits on one line:
- for purposes of measuring the node size in text,
  don't generate html or use a styler that could
  generate html as it will lead to overly large
  sizes

A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.

This change causes no difference to the gofmt formatting
of any files in src or misc.

R=rsc
http://go/go-review/1026034
 2009-11-09 09:34:55 -08:00
Robert Griesemer
aae64f8c81 - exit godoc w/o crashing if negative tabwidth is provided 
- minor related cleanups

R=rsc
http://go/go-review/1025026
 2009-11-08 23:42:00 -08:00
Robert Griesemer
d731dc8e72 Addressing issue brought up by dsymonds: 
- When providing alternative spellings to a query, do not
  prefix it with a package qualifier as the suggestion may
  not have any results. Correctly filtering is quite a bit
  of work, and clicking the alternative spelling will always
  also show the qualified hits if they exist (but also others).
  Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
  package documentation.
- Experimented with excluding main packages and test files
  from index with inconclusive results. Code is present and
  can be enabled by changing a flag in the source. This needs
  some more work.

R=rsc
CC=r, dsymonds
http://go/go-review/1026033
 2009-11-08 23:34:08 -08:00
Russ Cox
71983af4a1 bug212, bug213. 
R=ken
http://go/go-review/1026032
 2009-11-08 23:22:06 -08:00
Rob Pike
e02f2b51c5 delete a pointless todo in all_test.go. 
address one in rpc/client.go

R=rsc
CC=go-dev
http://go/go-review/1026030
 2009-11-08 21:57:59 -08:00
Robert Griesemer
c532940ecf improved sentence extraction: 
- don't forget first periods
- look at capitalization of last char before periods

R=rsc
http://go/go-review/1024027
 2009-11-08 21:48:51 -08:00
Russ Cox
ed6eb5b577 a nagging inconsistency: capitalization of 
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.

R=r
CC=go-dev
http://go/go-review/1024026
 2009-11-08 21:46:20 -08:00
Russ Cox
830813f019 assorted cleanup 
R=r, iant
CC=go-dev
http://go/go-review/1025024
 2009-11-08 21:08:27 -08:00
Rob Pike
ceb6031ecd delete TODO now that compiler is better at % 
adjust an inconsistency in reflect/type.go's package comment

R=rsc
http://go/go-review/1026029
 2009-11-08 20:45:39 -08:00
Robert Griesemer
7837dbfcb8 use grouping instead of colors to show non-global search hits: 
- introduced a new run per file containing all spots belonging
  to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization

R=rsc
http://go/go-review/1026028
 2009-11-08 20:17:04 -08:00
Robert Griesemer
e8b580c9aa fix sentence extraction 
R=rsc
http://go/go-review/1026027
 2009-11-08 18:19:06 -08:00
Robert Griesemer
202ede1240 - properly align package synopses 
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks

R=rsc
http://go/go-review/1024024
 2009-11-08 16:47:32 -08:00
Rob Pike
40a7db3ee9 add top-level package comments for net, reflect, malloc. 
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.

R=gri, rsc
CC=go-dev
http://go/go-review/1026026
 2009-11-08 15:57:25 -08:00
Robert Griesemer
56b4515740 added package documentation 
R=r, rsc
http://go/go-review/1025023
 2009-11-08 15:04:30 -08:00
Robert Griesemer
a011480ff3 TBR 
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)

R=rsc
http://go/go-review/1024021
 2009-11-08 00:51:08 -08:00
Robert Griesemer
89d0e2dbe3 - better support for text files: show them nicely formatted 
instead of serving them raw
- path-related cleanups

R=rsc
http://go/go-review/1026021
 2009-11-08 00:40:43 -08:00
Robert Griesemer
1a9805adcb - avoid division-by-zero crash in tabwriter 
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing

R=rsc
http://go/go-review/1026022
 2009-11-07 23:59:24 -08:00
Robert Griesemer
642caacfa3 - added link to sources 
- renamed listing.html -> dirList.html
  (there is a dirs.html already, it should probably have a better name, too)

R=rsc
http://go/go-review/1025020
 2009-11-07 21:24:48 -08:00
Robert Griesemer
171ef39949 nice directory listings 
R=rsc
http://go/go-review/1026020
 2009-11-07 21:12:46 -08:00
Vish Subramanian
379150c210 Add flags of type float to the flag package. 
R=r, rsc
http://go/go-review/1026011
 2009-11-07 15:52:27 -08:00
Robert Griesemer
1ac60ddd10 - support to extract one-line package synopsis for package listings 
- formatting in dirs.html is crude, needs better html (open to suggestions),
  but shows the synopsis
- many package comments should probably be adjusted such that the first
  sentence is more concise

R=rsc, iant
http://go/go-review/1025014
 2009-11-07 13:17:53 -08:00
Robert Griesemer
3317697df4 - blank before opening { for multi-line composite literals (as preferred by r) 
- blank padding around composite literal contents for a less dense look
  (most if not all composite literals were written in that style before gofmt
  ran through them)
- corresponding (internal) flag: compositeLitBlank

- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis

- the number of changes in nodes.go is huge because of the removed semis;
  hg mail requires that I gofmt the file before

With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.

R=rsc, r
http://go/go-review/1025015
 2009-11-07 13:01:52 -08:00
David Symonds
6ea866c04b Typo fixes. 
R=rsc
CC=go-dev
http://go/go-review/1026014
 2009-11-06 18:43:57 -08:00
Ken Thompson
0eb2a79ff3 8g optimizer 
R=rsc
http://go/go-review/1025011
 2009-11-06 16:51:49 -08:00
Robert Griesemer
832ce7c1d2 format composite literal types that are "short" struct type literals 
on one line for a more compact representation of some composite Literals

R=rsc
http://go/go-review/1025008
 2009-11-06 16:34:19 -08:00
Robert Griesemer
a05a5465c8 - application of gofmt with one-line composite literal structs enabled 
- this CL is dependent on CL 1025008

R=r, rsc
http://go/go-review/1025009
 2009-11-06 16:33:53 -08:00
Robert Griesemer
368f8cbc75 - fine-tuning of one-line func heuristic (nodes.go) 
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)

R=r, rsc
CC=go-dev
http://go/go-review/1026006
 2009-11-06 14:24:38 -08:00
Robert Griesemer
5873598a97 updated godoc documentation 
R=r
http://go/go-review/1026007
 2009-11-06 14:00:49 -08:00
Kai Backman
fd7d803535 fix argument order bug for float 
R=rsc
http://go/go-review/1025006
 2009-11-06 13:51:17 -08:00
Kai Backman
de663b2d6b with rsc: argsize rounding to 8 smashes stack data on 32bit machines. 
R=rsc
http://go/go-review/1024011
 2009-11-06 13:50:58 -08:00
Adam Langley
db4e48ece9 big: fix carry error, add test case. 
crypto/x509: reenable tests.

R=gri
CC=go-dev
http://go/go-review/1026004
 2009-11-06 11:36:21 -08:00
Robert Griesemer
56eca9daed minor fixups by gofmt 
R=agl
http://go/go-review/1024009
 2009-11-06 11:00:06 -08:00
Adam Langley
ecf0690c01 crypto/x509: build fix for 32-bit 
TBR=rsc

R=rsc
CC=go-dev
http://go/go-review/1024007
 2009-11-06 09:23:40 -08:00
Adam Langley
17021f48f3 Fix add-back division test so that it triggers the add-back case on 
both 64 and 32 bit platforms.

Also, uncomment some tests that were still commented out from
debugging.

R=gri, rsc
CC=go-dev
http://go/go-review/1026003
 2009-11-06 09:05:19 -08:00
Kai Backman
52c549fc9b make 5g executables run on android/arm hardware. change OABI 
usage to EABI.

        go/test: passes 85% (296/347) on random android phone.

R=rsc
http://go/go-review/1024003
 2009-11-05 22:53:08 -08:00
Robert Griesemer
054354ebd4 gofmt src/cmd/goyacc 
(with this change: gofmt -l src/cmd/ | wc
is 0 0 0)

R=ken, rsc
http://go/go-review/1024005
 2009-11-05 22:29:29 -08:00
Robert Griesemer
79284cae32 gofmt'ed src/cmd 
R=rsc
http://go/go-review/1024004
 2009-11-05 22:25:46 -08:00
Robert Griesemer
07b6becc88 - fix elf.go manually so it is idempotent for gofmt 
- with this change, `gofmt -l src/pkg | wc` is 0

R=rsc
http://go/go-review/1025002
 2009-11-05 22:05:43 -08:00
Robert Griesemer
7151d2337b missing piece gofmt'ed in reflect 
R=r, rsc
http://go/go-review/1025001
 2009-11-05 18:27:30 -08:00
Robert Griesemer
45cba57e89 gofmt'ed more stragglers 
R=rsc
http://go/go-review/1019004
 2009-11-05 18:26:16 -08:00
Robert Griesemer
48b3156908 gofmt'ed big 
R=agl
http://go/go-review/1022003
 2009-11-05 18:25:23 -08:00
Robert Griesemer
7e92eedced gofmt'ed various stragglers 
R=rsc
http://go/go-review/1022002
 2009-11-05 18:24:53 -08:00
Robert Griesemer
183edddb9d gofmt'ed more stragglers 
(now down to a handfull of files in pkg)

R=rsc
http://go/go-review/1019006
 2009-11-05 18:24:24 -08:00
Robert Griesemer
0ea9dd815a gofmt the last outstanding files in src/pkg 
- added a list of issues to printer/nodes.go

R=rsc
http://go/go-review/1024002
 2009-11-05 18:14:47 -08:00
Robert Griesemer
39fd52d3a0 gofmt'ed missing regexp file 
(one-line functions will be re-established once we have all
formatted uniformly)

R=r
http://go/go-review/1023004
 2009-11-05 17:35:40 -08:00
Robert Griesemer
38006946e6 manual fix for better gofmt result 
R=r
http://go/go-review/1019005
 2009-11-05 17:27:02 -08:00
Robert Griesemer
8cd2e76404 - gofmt'ing of some stragglers, now with correct comment indentation 
in special cases
- re-gofmt'ing of some files that are now improved

R=r, rsc
http://go/go-review/1023003
 2009-11-05 17:02:55 -08:00
Robert Griesemer
6c13f8f10e fix a comment formatting bug: 
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
  see separate CL (it fixes the same issue in those files)

R=rsc
http://go/go-review/1023002
 2009-11-05 17:02:29 -08:00
Adam Langley
fa57417dbd crypto/tls (part 6/5) 
Results of running gofmt again.

R=rsc
CC=go-dev
http://go/go-review/1022006
 2009-11-05 16:59:39 -08:00
Adam Langley
eb48f83ae2 crypto/tls (part 5/5) 
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)

Add entries to the Makefile.

R=rsc
CC=go-dev
http://go/go-review/1022005
 2009-11-05 16:44:02 -08:00
Adam Langley
950f2637c2 crypto/tls (part 4/5) 
R=rsc
CC=go-dev
http://go/go-review/1019002
 2009-11-05 16:43:29 -08:00
Robert Griesemer
10242e806f gofmt'ed parts of go 
R=rsc
http://go/go-review/1023001
 2009-11-05 15:58:28 -08:00
Adam Langley
65063bc61d big: add Div, Mod, Exp, GcdExt and several other fixes. 
R=gri, rsc
CC=go-dev
http://go/go-review/1017036
 2009-11-05 15:55:41 -08:00
Adam Langley
5e598c55dc crypto/tls (part 3) 
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)

R=rsc
CC=r
http://go/go-review/1018032
 2009-11-05 15:44:32 -08:00
Robert Griesemer
d3d3accdb7 gofmt-ify io, json, runtime, encoding 
R=rsc
http://go/go-review/1017056
 2009-11-05 15:37:55 -08:00
Robert Griesemer
441e775dad gofmt'ed godefs 
R=rsc
http://go/go-review/1020001
 2009-11-05 15:35:53 -08:00
Robert Griesemer
6a4940ee23 gofmt'ed debug 
(excluding debug/gosym/symtab.go which has a small issue)

R=rsc
http://go/go-review/1019001
 2009-11-05 15:35:02 -08:00
Robert Griesemer
6f762f5410 gofmt'ed 6l 8l cgo 
R=r
http://go/go-review/1020002
 2009-11-05 15:33:26 -08:00
Robert Griesemer
b8d88a9913 gofmt-ify strings, template 
R=r
http://go/go-review/1018064
 2009-11-05 15:12:37 -08:00
Robert Griesemer
f65e42d039 gofmt-ify gob 
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)

R=r
http://go/go-review/1016056
 2009-11-05 14:53:42 -08:00
Russ Cox
790c9b59d6 codereview: new commands 
* clpatch
	* download
	* submit, on behalf of clpatch

stir hgpatch to fix a few bugs

R=r
CC=go-dev
http://go/go-review/1016051
 2009-11-05 14:44:57 -08:00
Robert Griesemer
9786b3f1bd gofmt-ify 4s, iterable 
R=rsc
http://go/go-review/1016055
 2009-11-05 14:43:03 -08:00
Robert Griesemer
2a89915485 gofmt-ify draw 
R=rsc
http://go/go-review/1017055
 2009-11-05 14:42:28 -08:00
Robert Griesemer
9e48df682c gofmt-ify eval 
R=rsc
http://go/go-review/1016054
 2009-11-05 14:41:56 -08:00
Robert Griesemer
d2af73136e gofmt-ify ogle 
R=rsc
http://go/go-review/1016053
 2009-11-05 14:30:18 -08:00
Robert Griesemer
6238964d7b gofmt-ify nacl 
R=rsc
http://go/go-review/1018062
 2009-11-05 14:29:38 -08:00
Robert Griesemer
77334b988c gofmt-ify reflect 
- the single line structs can be fixed in another round

R=rsc
http://go/go-review/1016052
 2009-11-05 14:23:20 -08:00
Robert Griesemer
666afa1c02 2nd attempt: no noIndent for string lists 
- slightly better output in general
- extra indentation where we could do without
  (however that seems better for now that not having the indentation
  where it is needed)
- no information is lost, so a future better approach can fix these
  places up again

R=rsc
http://go/go-review/1017050
 2009-11-05 14:03:56 -08:00
Ken Thompson
18cb960f3e forgot a piece of debugging 
in previous change

R=rsc
http://go/go-review/1017052
 2009-11-05 13:05:07 -08:00
Ken Thompson
505fd760a2 same speedup as 6l 
R=rsc
http://go/go-review/1016050
 2009-11-05 12:47:22 -08:00
Robert Griesemer
bd4f94057f gofmt-ify syscall 
(replacement for CL 1018053)

R=r
http://go/go-review/1017047
 2009-11-05 10:55:57 -08:00
Robert Griesemer
30c7088c95 gofmt-ify template, time, unsafe, flag, fmt 
(replacement for CLs 1017039, 1017041, 1017040, 1018054)

R=r
http://go/go-review/1018060
 2009-11-05 09:40:28 -08:00
Russ Cox
1329012a23 new command hgpatch, for use by codereview extension 
R=r
http://go/go-review/1018059
 2009-11-05 09:27:19 -08:00
Robert Griesemer
3630bfbe9f gofmt-ify math, expvar, exp/spacewar 
R=rsc
http://go/go-review/1018061
 2009-11-05 09:08:08 -08:00
Robert Griesemer
e57acdca4d gofmt-ify parts of xml 
R=rsc
http://go/go-review/1017049
 2009-11-05 08:59:03 -08:00
Robert Griesemer
12dbd06f0a gofmt-ify encoding 
R=rsc
http://go/go-review/1017048
 2009-11-05 08:55:18 -08:00
Robert Griesemer
ed494c6398 gofmt-ify sort, sync 
R=rsc
http://go/go-review/1018057
 2009-11-04 23:25:29 -08:00
Robert Griesemer
314b358ab7 gofmt-ify strconv 
(and remove an empty line at the end of a file)

R=rsc
http://go/go-review/1017046
 2009-11-04 23:20:49 -08:00
Robert Griesemer
5d37705416 gofmt-ify net 
R=rsc
http://go/go-review/1017045
 2009-11-04 23:16:46 -08:00
Robert Griesemer
7df45566db gofmt-ify image 
R=rsc
http://go/go-review/1017044
 2009-11-04 22:52:28 -08:00
Robert Griesemer
ca2a69ea06 gofmt-ify hash, http 
(gofmt will be able to re-align map entries as in http nicely,
eventually)

R=rsc
http://go/go-review/1018055
 2009-11-04 22:45:59 -08:00
Robert Griesemer
b16e6ab148 gofmt-ify tabwriter 
R=rsc
http://go/go-review/1017042
 2009-11-04 22:26:48 -08:00
Robert Griesemer
1fede304ff more comment formatting: 
- preserve (some) indentation of comment text for /*-style comments
  even if the first comment line does not contain any text that might
  suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
  (this will not introduce a lot of changes since comments of this
  kind - until now - were not changed with respect to indentation)

R=rsc
http://go/go-review/1016047
 2009-11-04 22:07:13 -08:00
Robert Griesemer
841c18a95a gofmt-ify unicode 
R=r
http://go/go-review/1018051
 2009-11-04 21:39:55 -08:00
Kai Backman
55ba9d6a2c fixing (badly) linux_arm syscall. 
R=rsc
http://go/go-review/1017037
 2009-11-04 21:34:54 -08:00
Robert Griesemer
601ee4807b - add a blank before the opening { for multi-line composites 
(request by r)
- feature temporarily disabled

R=rsc
CC=r
http://go/go-review/1018052
 2009-11-04 21:15:47 -08:00
Robert Griesemer
398f220d5b gofmt-ify os 
R=r
http://go/go-review/1017034
 2009-11-04 20:42:40 -08:00
Ken Thompson
9c7535432a speed up 6l 
hopefully no change

R=rsc
http://go/go-review/1017035
 2009-11-04 18:17:57 -08:00
Russ Cox
cc1a979272 package patch 
R=r
http://go/go-review/1018043
 2009-11-04 17:55:06 -08:00
Robert Griesemer
5fca0bca61 gofmt-ify compress 
R=rsc
http://go/go-review/1016045
 2009-11-04 17:10:18 -08:00
Robert Griesemer
b6d0a22dc5 gofmt-ify ebnf 
R=r
http://go/go-review/1018050
 2009-11-04 17:05:01 -08:00
Robert Griesemer
646a2c5a42 gofmt-ify bufio 
R=rsc
http://go/go-review/1018049
 2009-11-04 17:04:21 -08:00
Robert Griesemer
03678f7417 gofmt-ify asn1 
R=rsc
http://go/go-review/1018047
 2009-11-04 17:03:08 -08:00
Robert Griesemer
517ebbb24a gofmt-ify src/pkg/archive 
R=rsc
http://go/go-review/1018046
 2009-11-04 17:02:47 -08:00
Robert Griesemer
eabcc981c5 gofmt-ify crypto 
R=agl
CC=rsc
http://go/go-review/1017032
 2009-11-04 17:02:30 -08:00
Robert Griesemer
2ce57ec10a gofmt-ify src/pkg/go (excluding printer directory due to pending CL, 
and parser.go and scanner_test.go which have minor formatting issues)

R=rsc
http://go/go-review/1016042
 2009-11-04 17:02:05 -08:00
Robert Griesemer
26c3f6c18d rename testfiles from .go -> .orig so that they won't be 
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)

R=rsc
http://go/go-review/1018045
 2009-11-04 16:50:13 -08:00
Robert Griesemer
688a6ff71d gofmt-ify bytes 
R=r
http://go/go-review/1016044
 2009-11-04 16:49:28 -08:00
Robert Griesemer
789b31a416 better placement of /*-style comments interspersed with code on one line 
R=rsc
http://go/go-review/1017030
 2009-11-04 15:33:28 -08:00
Russ Cox
5d436b9def bytes.SplitAfter and strings.SplitAfter 
most common usage is:

	lines := strings.SplitAfter(text, "\n", 0)

R=r
http://go/go-review/1018042
 2009-11-04 15:19:30 -08:00
Russ Cox
3de3af512d doc doc doc 
R=r
http://go/go-review/1016039
 2009-11-04 15:17:36 -08:00
Rob Pike
56cba8855e panic can't print interfaces well so use err.String() 
R=rsc
http://go/go-review/1016041
 2009-11-04 15:13:16 -08:00
Robert Griesemer
2f792d32be - always format blocks with closing } on a new line, even if empty 
- at the moment this also affects single-line function declarations
  because we have disabled them at the moment (but not single-line
  function literals)

R=rsc
http://go/go-review/1016040
 2009-11-04 13:31:20 -08:00
Rob Pike
98ac4c6e65 stylistic issues in a couple of cmd docs 
R=rsc
http://go/go-review/1017028
 2009-11-04 13:13:17 -08:00
Rob Pike
0d3dd3c950 document godoc and gofmt 
R=rsc
http://go/go-review/1018036
 2009-11-04 11:33:43 -08:00
Robert Griesemer
4bb0271a12 remove reference to /home/r 
R=rsc
http://go/go-review/1018039
 2009-11-04 11:15:19 -08:00
Robert Griesemer
6dbf7aa129 - complete html-escaping also in printer.go 
R=rsc
http://go/go-review/1017027
 2009-11-04 10:59:25 -08:00
Robert Griesemer
c8c3f1d5de - respect source line breaks in grouped declarations 
- made ast.Spec nodes implement Node interface
- added extra test cases

R=rsc
http://go/go-review/1016038
 2009-11-04 10:58:54 -08:00
Robert Griesemer
524ade9a58 fix bufio test case 
R=rsc
http://go/go-review/1018038
 2009-11-04 10:58:30 -08:00
Russ Cox
d441d545a9 two more regexp tweaks 
TBR=r
http://go/go-review/1016037
 2009-11-04 08:34:31 -08:00
Russ Cox
af2bc8f986 allow "no such host" and also "no answer from server"; 
seems to help on snow leopard.

TBR=r
http://go/go-review/1018035
 2009-11-04 08:30:53 -08:00
Rob Pike
56a38f25a7 document gotest 
R=rsc
CC=go-dev
http://go/go-review/1017026
 2009-11-03 23:06:16 -08:00
Robert Griesemer
467c726eec add " and ' to list of html-escaped chars 
R=rsc
http://go/go-review/1017025
 2009-11-03 22:52:10 -08:00
Rob Pike
796e29ebfc add goyacc to the build 
R=rsc
CC=go-dev
http://go/go-review/1018034
 2009-11-03 22:48:48 -08:00
Rob Pike
472576c615 make goyacc and units.y work again (minor tweaks). 
document goyacc a little.

R=rsc
CC=go-dev
http://go/go-review/1017024
 2009-11-03 22:38:43 -08:00
Rob Pike
701440043b document gopack. 
change string in usage message.

R=rsc
http://go/go-review/1017023
 2009-11-03 22:36:31 -08:00
Rob Pike
c6dd8c18f0 document ebnflint 
R=gri
http://go/go-review/1016034
 2009-11-03 22:19:56 -08:00
Rob Pike
3fa379e797 document the gc go compilers. 
fix the usage message.

R=rsc
CC=go-dev
http://go/go-review/1016033
 2009-11-03 22:00:36 -08:00
Robert Griesemer
4818d346b6 support for command documentation: 
- made package tree handler generic so it can work on any fs tree
- cleanups along the way

R=rsc
CC=r
http://go/go-review/1017020
 2009-11-03 19:40:26 -08:00
Rob Pike
dc62c66c73 more command documentation, including nm and prof 
R=rsc
http://go/go-review/1017022
 2009-11-03 17:46:35 -08:00
Adam Langley
93253a870c encoding/*: reverse the order of src, dst so that dst is first. 
R=rsc
CC=go-dev
http://go/go-review/1017021
 2009-11-03 17:32:08 -08:00
Adam Langley
1542520a4a crypto/tls (part 2) 
R=rsc
CC=go-dev
http://go/go-review/1018028
 2009-11-03 17:25:13 -08:00
Adam Langley
bcce2987e0 crypto/rsa: fix blinding when using a null random source. 
For testing it can be useful to use a null random source (one which
always returns zero) to remove non-determinism from the tests.
However, when performing RSA blinding, the random blind ends up being
zero and it's hard to reverse a multiplication by zero.

R=rsc
CC=go-dev
http://go/go-review/1018033
 2009-11-03 17:23:50 -08:00
Rob Pike
b5ab5d4f12 document the assemblers. 
add details about -d and -e flags in the loaders.

R=rsc
CC=go-dev
http://go/go-review/1018031
 2009-11-03 16:29:32 -08:00
Rob Pike
2bc63f2367 First steps at command documentation: C compilers and linkers. 
Each command gets a doc.go file for godoc to analyze. Its main
element is a package comment.

R=rsc
CC=go-dev
http://go/go-review/1018029
 2009-11-03 16:05:47 -08:00
Russ Cox
96ea081c04 6l -e: emit external ELF symbol table. 
enough to make nm and oprofile work.

R=r
http://go/go-review/1017016
 2009-11-03 14:20:37 -08:00
Robert Griesemer
c56b366c28 Note: This is an exact replica and replacement of CL 1018027 
(which I uploaded at home and thus can't upload from here).
CL 1018027 was reviewed.

- added comments to scope.go
- commented out some code that is not yet needed
  (and which showed up prominently in the documentation)

R=rsc
http://go/go-review/1017017
 2009-11-03 14:05:18 -08:00
Robert Griesemer
38512d090c - don't loose extra line breaks in struct/interface declarations 
- start new sections if a field/method declaration spans multiple lines;
  this avoids tabs from the previous line affecting the next field/method

R=rsc
http://go/go-review/1017015
 2009-11-03 13:40:11 -08:00
Adam Langley
4f2ec03416 Add testing/script. 
R=rsc, r
CC=go-dev
http://go/go-review/1016001
 2009-11-03 12:47:06 -08:00
Robert Griesemer
12f8660d4c use default styler when there is no other given 
(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)

R=rsc
http://go/go-review/1016031
 2009-11-03 10:00:57 -08:00
Rob Pike
929e27e3d5 fix build 
R=gri
http://go/go-review/1017014
 2009-11-02 23:06:48 -08:00
Robert Griesemer
be56b95770 - show recursive package directory structure in package pages 
- removed some underbars in section headings for better looks
- various minor tweaks

R=rsc
http://go/go-review/1018026
 2009-11-02 22:44:01 -08:00
Robert Griesemer
6e98b7f0b2 split printer.go into two files; it has become too large: 
- nodes.go implements ast node formatting
- printer.go implements the core printing functionality
  and public interface

No code changes except for updating the import clauses
and adding a top-level comment to nodes.go.

R=rsc
http://go/go-review/1016026
 2009-11-02 20:55:40 -08:00
Rob Pike
120d0b50c6 forgot to count newlines when scanning white space. 
also fix a error-printing bug in godoc.

R=gri
http://go/go-review/1016030
 2009-11-02 20:35:52 -08:00
Russ Cox
c83b838641 package net cleanup 
added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.

cleaned up LocalAddr/RemoteAddr methods - cache in netFD.

threw away various unused methods.

an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.

another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr().  (the Accept signature predates the
existence of that method.)

Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.

because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.

design comments welcome.

R=p
CC=go-dev, r
http://go/go-review/1018017
 2009-11-02 18:37:30 -08:00
Adam Langley
6e8184d8cd crypto/tls (part 1) 
Rather than drop everything into a single, huge review, I've included
some simple bits of code here.

R=rsc
CC=go-dev
http://go/go-review/1016029
 2009-11-02 18:25:20 -08:00
Russ Cox
6334b499e8 fix divide by zero in old glibc dynamic loader 
R=r
CC=iant
http://go/go-review/1018024
 2009-11-02 14:00:32 -08:00
Rob Pike
236a9de93f remove goroutines from template parsing. 
fix up one usage to take advantage.

R=rsc
CC=go-dev
http://go/go-review/1018023
 2009-11-02 13:09:31 -08:00
Ian Lance Taylor
f32cde88b6 Define constants for sizes of Sym structures. 
R=rsc, agl
http://go/go-review/1016028
 2009-11-02 12:53:06 -08:00
Adam Langley
72ec930fa7 Fix cgo for GCC 4.4 
Firstly, with -Werror, GCC switched to printing warnings starting
with "error:". Widening the string matches solves this as the messages
are otherwise unchanged.

Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all
the offsets and requires the relocation section for .debug_info to be
processed in order to result in valid DWARF data. Thus we add minimal
handling for relocation sections, which is sufficient for our needs.

BUG=1
Fixes #1.

R=rsc, iant
CC=go-dev
http://go/go-review/1017003
 2009-11-02 12:02:16 -08:00
Rob Pike
a82465103f use the new routine regexp.MustCompile to clean up some code that uses global regexps. 
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
 2009-11-02 11:37:52 -08:00
Rob Pike
cd82d490fc eliminate goroutine from testing/regexp too. 
R=rsc
CC=go-dev
http://go/go-review/1018021
 2009-11-02 11:24:47 -08:00
Adam Langley
ad67a86626 Split constant time functions into crypto/subtle. 
R=rsc
CC=go-dev
http://go/go-review/1018020
 2009-11-02 11:12:07 -08:00
Russ Cox
d00248980b do not emit USED for global x when compiling "_ = x;" 
R=ken@golang.org
CC=r
http://go/go-review/1018019
 2009-11-02 10:50:18 -08:00
Rob Pike
acc54b6c70 take goroutines out of regexp so they can be created 
during initialization.

R=rsc
CC=go-dev
http://go/go-review/1016023
 2009-11-02 10:08:22 -08:00
Robert Griesemer
49d295d592 - initial steps towards showing directory tree instead of 
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree

R=rsc
http://go/go-review/1018016
 2009-11-02 09:25:39 -08:00
Robert Griesemer
b67352110f - collect line comments for methods in interfaces 
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)

R=rsc, r
http://go/go-review/1016019
 2009-11-02 09:18:02 -08:00
Russ Cox
9dd2e1e30f nil pointer checks in 8g. 
fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.

R=ken@golang.org
CC=iant
http://go/go-review/1016022
 2009-11-01 21:04:16 -08:00
Rob Pike
4d310f2434 reverse the arguments to io.Copy so the destination is on the 
left, like an assignment, like strcpy, etc.

R=rsc
CC=go-dev
http://go/go-review/1016011
 2009-11-01 20:59:49 -08:00
Ian Lance Taylor
f4e3947ffe Permit the CC environment variable to include arguments 
(I should have tested the last change a bit more before
submitting).

R=rsc
http://go/go-review/1017011
 2009-11-01 16:29:33 -08:00
Ian Lance Taylor
fab7ae15ee Use the environment variable CC as the bootstrap compiler used 
to build 6g, 6l, etc.

R=rsc
CC=go-dev
http://go/go-review/1018015
 2009-11-01 16:13:37 -08:00
Robert Griesemer
b96ad80949 enable all (but one) test cases in test.sh that 
were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)

R=rsc
http://go/go-review/1018014
 2009-11-01 15:27:10 -08:00
Ian Lance Taylor
d8efcdcd52 These files were moved to encoding/base64. The directory was 
already removed from the Makefile.

R=rsc
http://go/go-review/1017006
 2009-11-01 15:04:46 -08:00
Russ Cox
35ace1d1f5 split ipsock.go, sock.go, and unixsock.go out of net.go 
prior to cleanup.  no changes, only moving.

remove dependencies on strconv and strings

R=r
http://go/go-review/1017010
 2009-11-01 11:15:34 -08:00
Russ Cox
fd1add2768 syscall cleanup. 
* rename PORT.sh -> mkall.sh (hopefully more obvious),
   change behavior: run commands by default.
 * pull more constants out of #defines automatically,
   instead of editing large lists by hand.
 * add Recvfrom, Sendto

add os.O_EXCL.

R=r
http://go/go-review/1017009
 2009-11-01 11:13:27 -08:00
Robert Griesemer
5223218307 don't update sync time if no files have changed 
(and thus avoid re-indexing after every sync attempt)

R=rsc
http://go/go-review/1016010
 2009-11-01 10:33:16 -08:00
Russ Cox
a64b69da9e os cleanup. 
dir_* and stat_* are just os specific,
not os+arch-specific.

R=r
http://go/go-review/1018010
 2009-11-01 09:37:13 -08:00
Russ Cox
7732d80ceb misc cleanup 
R=r
http://go/go-review/1016017
 2009-11-01 09:25:55 -08:00
Russ Cox
b72153310d allow unpacking of json map into Go map, 
now that reflection supports it.

R=r
http://go/go-review/1015008
 2009-11-01 05:49:07 -08:00
Russ Cox
bf991bb7df Make.pkg: add DEPS= support 
allow Makefiles using Make.pkg to specify a
list of directories that should be installed
before trying to build the package.
this is a stopgap for small package trees
maintained outside the standard tree.

R=r
http://go/go-review/1016012
 2009-11-01 05:43:26 -08:00
Rob Pike
63e668d2ad return "<nil>" when calling String() on a nil bytes.Buffer. 
R=rsc
CC=go-dev
http://go/go-review/1016005
 2009-10-31 13:28:22 -07:00
Ian Lance Taylor
b534eb462b Don't use fallthrough in a type switch. 
R=rsc
http://go/go-review/1018005
 2009-10-30 16:10:42 -07:00
Robert Griesemer
fb12ad063e fix build 
R=agl
CC=rsc
http://go/go-review/1016008
 2009-10-30 13:19:04 -07:00
Robert Griesemer
1e984cb913 improved comment formatting: 
- print comments line by line, strip common prefix but do not
  modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment

R=rsc
http://go/go-review/1017002
 2009-10-30 13:17:14 -07:00
Russ Cox
09f4261841 split godoc/godoc.go into godoc/godoc.go 
and godoc/main.go.

R=gri
CC=r
http://go/go-review/1017005
 2009-10-30 10:58:53 -07:00
Kai Backman
1d0b65d33f added missing sgen reverse character copy code. 
R=rsc
http://go/go-review/1018006
 2009-10-30 09:38:30 -07:00
Kai Backman
770b872752 clone and futex 
go/test: passes 99% (343/347)

R=rsc
http://go/go-review/1016004
 2009-10-29 21:21:14 -07:00
Adam Langley
09d68334cc Forgot to change quickcheck to quick in the Makefile. 
TBR=rsc

R=rsc
http://go/go-review/1017004
 2009-10-29 18:34:44 -07:00
Adam Langley
9e96f25fa2 Add RSA PKCS#1 v1.5 support. 
R=go-dev
APPROVED=rsc
DELTA=407  (400 added, 0 deleted, 7 changed)
OCL=36007
CL=36146
 2009-10-29 17:38:25 -07:00
Adam Langley
878d0e1efd Add a quickcheck package which is a little like the Haskell one of the same 
name.

R=rsc
APPROVED=rsc
DELTA=566  (566 added, 0 deleted, 0 changed)
OCL=35974
CL=36111
 2009-10-28 15:16:20 -07:00
Stephen Ma
74aa9dd55a Hack to make cgo's generated go code compile when there are no 
unsafe.Pointer references inside the C declarations.

R=go-dev
APPROVED=rsc
DELTA=1  (1 added, 0 deleted, 0 changed)
OCL=36063
CL=36063
 2009-10-26 21:21:53 -07:00
Rob Pike
449086eec9 Change Stat to Lstat in Readdir so we don't recur when someone symlinks "." 
R=rsc
CC=go-dev
http://go/go-review/1018003
 2009-10-29 10:53:37 -07:00
Adam Langley
b89d630977 Fix bug when sending via select. 
selfree maintains a cache of Select structures for several sizes. In
newselect, we'll use an entry from the cache if one is found. However,
the Scase structures corresponding to a send may have been allocated
for the wrong size. In this case we'll write off the end of the Scase
into random memory and, generally, read some amount of junk in the
receive.

This patch fixes the issue by removing the cache, on the advice of
rsc.

R=rsc
CC=go-dev
http://go/go-review/1016002
 2009-10-28 18:23:53 -07:00
Robert Griesemer
c54cb4cb4d - added missing formatters in templates 
- replaced deprecated use of </font> with </span> tag
- added html escaping to godoc formatters where missing
- enabled text format for package documentation

R=rsc
http://go/go-review/1017001
 2009-10-28 16:19:09 -07:00
Russ Cox
32e979c0de mysterious bug: runtime.acid wasn't getting rebuilt 
when switching architectures.

fix bug twice: make sure clean removes the file,
and generate into architecture-specific file names.

R=r
http://go/go-review/1013018
 2009-10-28 14:03:16 -07:00
Robert Griesemer
5a02eb65ef fix for long label names impacting column width of previous lines 
R=rsc
http://go/go-review/1013017
 2009-10-28 10:14:59 -07:00
Russ Cox
d2829faa7c files that are okay from the last gofmt round 
R=gri
http://go/go-review/1015011
 2009-10-27 22:47:54 -07:00
Kai Backman
58ee1f5d54 shift for non-64 bit integers. 
R=rsc
http://go/go-review/1015017
 2009-10-27 22:38:45 -07:00
Robert Griesemer
e3fd2e1ec6 godoc search bug fixes: 
- sort by package name (instead of package path) for results with snippets
- sort line numbers in results without snippets
- properly characterize package clauses
- experiment with a leaner look: no underlines for top-level godoc links in the left side bar

Still using colors to distinguish results. Next step.

R=rsc
http://go/go-review/1015016
 2009-10-27 16:08:12 -07:00
Robert Griesemer
32810a5ded code search for godoc: 
- added goroutine to automatically index in the background
- added handler for search requests
- added search box to top-level godoc template
- added search.html template for the display of search results
- changes to spec.go because of name conflicts
- added extra styles to style.css (for shorter .html files)

R=rsc
http://go/go-review/1014011
 2009-10-27 10:34:31 -07:00
Ian Lance Taylor
f529224039 Get the right sigaction struct for the 386 rt_sigaction system 
call.  This uses the header files from a 32-bit Ubuntu Hardy
system.

The use of _LOOSE_KERNEL_NAMES seems right.  The
-D__ARCH_SI_UID_T works around a bug which appears to be fixed
in later Linux versions.

R=rsc
http://go/go-review/1013015
 2009-10-26 22:49:08 -07:00
Kai Backman
1228112b50 bug162, large indices on nil references 
R=rsc
http://go/go-review/1013016
 2009-10-26 21:49:32 -07:00
Robert Griesemer
ae3c9992ae - gofmt-ify walk.go 
- fixed several bugs

R=rsc
http://go/go-review/1015015
 2009-10-26 19:21:13 -07:00
Robert Griesemer
5a75ac88c9 - indexing component for godoc 
R=rsc
http://go/go-review/1015014
 2009-10-26 18:32:51 -07:00
Adam Langley
569a1cd545 Add encoding/hex 
R=rsc
http://go/go-review/1015012
 2009-10-26 16:34:36 -07:00
Robert Griesemer
57035a9041 snippet generator for godoc search results 
R=rsc
http://go/go-review/1013014
 2009-10-26 15:47:56 -07:00
Kai Backman
5cc32a5348 fix defer. gave up on unified code for defer and go for now. 
R=rsc
http://go/go-review/1014010
 2009-10-26 08:02:19 -07:00
Kai Backman
dfeceddd3f make 5l ignore multiple defs, remove use of multiple 
defs from embed1 and gotest

R=rsc
http://go/go-review/1014009
 2009-10-25 11:59:58 -07:00
Kai Backman
9e99383df5 frame size > StackBig support 
R=rsc
http://go/go-review/1015010
 2009-10-25 11:51:48 -07:00
Kai Backman
6f91ba1b0f proper syscall convention for arm 
R=rsc
http://go/go-review/1015009
 2009-10-25 11:51:16 -07:00
Kai Backman
68d5c51287 fix conditional branch instructions for unsigned ints and 
float. fix sgen endianess in sgen character copying.

        go/test: passes 97% (336/345)

R=rsc
http://go/go-review/1015007
 2009-10-24 22:47:25 -07:00
Rob Pike
c91e89d539 remove reference to p4 in comment. 
R=gri
CC=rsc
http://go/go-review/1014008
 2009-10-24 14:27:49 -07:00
Kai Backman
f860bc0f4e fixed len/cap for chan. disable gc for now. 
go/test: passes 93% (323/345)

R=rsc
http://go/go-review/1015006
 2009-10-23 20:31:03 -07:00
Rob Pike
1726e81c00 publish Request.Write (rename from Request.write) 
R=rsc
CC=go-dev
http://go/go-review/1015003
 2009-10-23 14:19:47 -07:00
Kai Backman
b74fd8ecb1 fix build issue cause by transition to hg 
R=rsc
http://go/go-review/1013012
 2009-10-23 12:43:01 -07:00
Kai Backman
942d6590d9 one more argsize fix. we were copying with the correct 
alignment but not enough (duh).

R=rsc
APPROVED=rsc
DELTA=16  (13 added, 0 deleted, 3 changed)
OCL=36020
CL=36024
 2009-10-23 11:03:16 -07:00
Kai Backman
dec1ec34bf all of pkg now compiles, fixes a few more tests 
go/test: passes 90% (313/345)

R=rsc
APPROVED=rsc
DELTA=90  (83 added, 3 deleted, 4 changed)
OCL=36011
CL=36023
 2009-10-23 11:00:59 -07:00
Kai Backman
0af8e1045c fix off by 4 bug in morestack (lr again). remove storing of r0 
now that all arguments are passed on the stack.

go/test: passes 89% (310/345)

R=rsc
APPROVED=rsc
DELTA=33  (13 added, 14 deleted, 6 changed)
OCL=36009
CL=36022
 2009-10-23 10:59:31 -07:00
Kai Backman
a9e03ae52a fix broken code produced for ominus 
go/test: passes 89% (308/345)

R=rsc
APPROVED=rsc
DELTA=10  (5 added, 0 deleted, 5 changed)
OCL=36005
CL=36021
 2009-10-23 10:58:29 -07:00
Kai Backman
03bbfe6724 fix off by 4 in newproc arg copying. 
R=rsc
APPROVED=rsc
DELTA=4  (0 added, 0 deleted, 4 changed)
OCL=36001
CL=36004
 2009-10-22 13:31:52 -07:00
Robert Griesemer
34e8075259 fix computation of sync delay 
R=rsc
http://go/go-review/1013011
 2009-10-23 11:35:40 -07:00
Ian Lance Taylor
fd5fa4b301 Fix the sigaction declaration to match the system for Linux. 
I don't know whether Darwin needs a change here.

R=rsc
http://go/go-review/1013010
 2009-10-22 23:51:54 -07:00
Ian Lance Taylor
057f7d5b07 s/pc/PC/ in traceback output to match amd64. 
test/run expects to see "PC".

R=rsc
http://go/go-review/1015002
 2009-10-22 23:38:34 -07:00
Ian Lance Taylor
95499a27ea Fix printer_test.go to invoke Fprint as a method of cfg. 
This matches the change to printer.go in revision 3632.

R=gri
http://go/go-review/1015001
 2009-10-22 22:19:22 -07:00
Robert Griesemer
8f52a82169 - make printer interface easily extensible w/o breaking clients (in the future) 
- replacement for p4 CL 35999 (abandoned)

R=rsc
http://go/go-review/1012010
 2009-10-22 18:19:49 -07:00
Robert Griesemer
abc6ad427d minor changes to walk 
R=rsc
http://go/go-review/1012008
 2009-10-22 18:04:21 -07:00
Robert Griesemer
ba15bbe654 simple AST walking support 
R=rsc
http://go/go-review/1014006
 2009-10-22 16:35:53 -07:00
Rob Pike
8a20cfc009 fix build: no acid 
R=rsc
http://go/go-review/1014005
 2009-10-22 11:52:35 -07:00
Russ Cox
219fb02042 fix build after Mercurial move. 
various missing or incorrect files.

R=r
CC=go-dev
http://go/go-review/1014004
 2009-10-22 10:59:27 -07:00
Robert Griesemer
90cc4a5949 go/printer: 
- handle HTML tagging via (client-installable) Stylers

go/doc:
- basic styler support
- some factoring
- ready to contain the search code (but for now excluded)

doc/style.css:
- updated

doc/go_spec.css:
- cleanup: replace deprecated uses of <font> tag with <span> tag

R=rsc
DELTA=302  (160 added, 62 deleted, 80 changed)
OCL=35973
CL=35996
 2009-10-22 09:41:38 -07:00
Austin Clements
3040f067c3 Interface types, values, and type compiler. This does not yet 
implement any type checking or semantics for interfaces.

R=rsc
APPROVED=rsc
DELTA=305  (289 added, 10 deleted, 6 changed)
OCL=35889
CL=35995
 2009-10-22 08:59:18 -07:00
Rob Pike
c6e904d580 have http server in-line PDF files. 
add go course pdf files to doc/ for godoc to serve.
fix links to point to those files.

R=rsc
DELTA=7  (4 added, 0 deleted, 3 changed)
OCL=35972
CL=35981
 2009-10-21 19:52:11 -07:00
Adam Langley
a8a678fc2a Add SetValue(Value) to the Value interface. 
R=rsc
APPROVED=rsc
DELTA=172  (170 added, 0 deleted, 2 changed)
OCL=35969
CL=35980
 2009-10-21 19:51:27 -07:00
Rob Pike
f1b91263d8 fix typo/oversight: s/Title/ToTitle/. the comment was already correct 
R=rsc
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=35964
CL=35979
 2009-10-21 19:51:05 -07:00
Adam Langley
1d390cec1e Replace SliceReader with bytes.Buffer. 
R=r
APPROVED=r
DELTA=16  (0 added, 15 deleted, 1 changed)
OCL=35976
CL=35978
 2009-10-21 19:49:01 -07:00
Adam Langley
7d68093f93 Fix typo in documentation. 
R=r
APPROVED=r
DELTA=2  (1 added, 0 deleted, 1 changed)
OCL=35977
CL=35977
 2009-10-21 19:47:52 -07:00
Adam Langley
fd74a835bc Add initial x509 code. 
R=rsc
APPROVED=rsc
DELTA=659  (659 added, 0 deleted, 0 changed)
OCL=35932
CL=35975
 2009-10-21 17:53:50 -07:00
Kai Backman
c2eb89af92 change stack splitting comparisons from signed to unsigned (oversight) 
R=rsc
APPROVED=rsc
DELTA=9  (0 added, 0 deleted, 9 changed)
OCL=35911
CL=35952
 2009-10-21 09:44:23 -07:00
David Symonds
69fc06dfa1 Move usr/dsymonds/iterable to src/pkg/exp/iterable. 
Remove remainder of usr/dsymonds.

R=rsc,r
APPROVED=r
DELTA=685  (275 added, 409 deleted, 1 changed)
OCL=35810
CL=35933
 2009-10-20 14:10:22 -07:00
Robert Griesemer
f591591a28 remove superfluous tracing support 
R=rsc
DELTA=5  (0 added, 4 deleted, 1 changed)
OCL=35930
CL=35930
 2009-10-20 13:30:32 -07:00
Russ Cox
357b770def base64 -> encoding/base64 
base85 -> encoding/ascii85, encoding/git85
debug/binary -> encoding/binary

R=r
DELTA=3190  (1884 added, 1297 deleted, 9 changed)
OCL=35923
CL=35929
 2009-10-20 13:00:16 -07:00
Robert Griesemer
4213c22301 Updated and simplified gofmt. 
- operates on stdin, a single file, or all files in a file tree
- setting -w flag writes to (source) file instead of stdout
- setting -l flag lists files whose formatting has changed

R=rsc
DELTA=201  (102 added, 71 deleted, 28 changed)
OCL=35890
CL=35926
 2009-10-20 12:07:31 -07:00
Russ Cox
fcc4be8c65 Add base85, based on base64. 
Also add git version of base85,
which is what I really wanted but
didn't recognize as different until it
was too late.

R=austin
DELTA=980  (972 added, 4 deleted, 4 changed)
OCL=35580
CL=35921
 2009-10-20 09:04:09 -07:00
Russ Cox
60ff8cc86f address bug193 and add note to spec about it. 
R=ken
OCL=35920
CL=35920
 2009-10-20 08:27:14 -07:00
Russ Cox
02fd255a14 bug162, over and over 
R=ken
OCL=35919
CL=35919
 2009-10-20 08:03:43 -07:00
Kai Backman
dde4090372 removed tempalloc/tempfree and replaced with tempname 
go/test: passes 88% (304/345)

R=rsc
APPROVED=rsc
DELTA=67  (3 added, 54 deleted, 10 changed)
OCL=35910
CL=35910
 2009-10-19 22:47:25 -07:00
Russ Cox
fcb9387089 support for 5.out files 
R=kaib
DELTA=1262  (1247 added, 7 deleted, 8 changed)
OCL=35907
CL=35909
 2009-10-19 22:33:56 -07:00
Kai Backman
33a7bcf315 getcallerpc and setcallerpc 
go/test: passes 87% (303/345)

R=rsc
APPROVED=rsc
DELTA=19  (5 added, 6 deleted, 8 changed)
OCL=35903
CL=35906
 2009-10-19 21:58:16 -07:00
Russ Cox
a15648658f bug196 
R=ken
OCL=35905
CL=35905
 2009-10-19 21:10:29 -07:00
Russ Cox
62c4818ee0 bug136 
R=ken
OCL=35902
CL=35904
 2009-10-19 20:39:18 -07:00
Kai Backman
a15aa05ae2 first version of closures. test/closure doesn't yet pass. 
go/test: passes 87% (300/343)

R=rsc
APPROVED=rsc
DELTA=125  (125 added, 0 deleted, 0 changed)
OCL=35893
CL=35900
 2009-10-19 19:59:39 -07:00
Russ Cox
1be74762c1 bug169 
R=ken
OCL=35899
CL=35899
 2009-10-19 19:55:17 -07:00
Russ Cox
4c3a85d73a 6g bug fixes: 
* bug211
 * embedded interfaces with lowercase methods
 * var _ = f() at top level

R=ken
OCL=35898
CL=35898
 2009-10-19 19:27:40 -07:00
Russ Cox
8fffa1d698 bug190. 
also eliminate float80 dregs

R=ken
OCL=35894
CL=35896
 2009-10-19 18:47:37 -07:00
Robert Griesemer
e76cce1a6d support one-line functions 
R=rsc
DELTA=207  (160 added, 42 deleted, 5 changed)
OCL=35854
CL=35887
 2009-10-19 13:57:51 -07:00
Kai Backman
b4896b496e function literals 
go/test: passes 86% (297/343)

R=rsc
APPROVED=rsc
DELTA=14  (10 added, 1 deleted, 3 changed)
OCL=35881
CL=35884
 2009-10-19 12:44:08 -07:00
Russ Cox
21b41bec83 test and fix http redirect handling 
BUG=2197242
R=r
DELTA=16  (16 added, 0 deleted, 0 changed)
OCL=35878
CL=35882
 2009-10-19 12:10:14 -07:00
Adam Langley
4d4e885bd1 Add an RSA-OAEP implementation. 
R=rsc
APPROVED=rsc
DELTA=734  (734 added, 0 deleted, 0 changed)
OCL=35738
CL=35879
 2009-10-19 11:52:44 -07:00
Robert Griesemer
4adad657de directory tree walk w/ visitor per rsc's suggestion 
R=rsc,r
DELTA=193  (191 added, 0 deleted, 2 changed)
OCL=35849
CL=35877
 2009-10-19 11:48:04 -07:00
Kai Backman
8037e3ba5e fix arm build, add 64 bit cgen_asop 
R=rsc
APPROVED=rsc
DELTA=21  (21 added, 0 deleted, 0 changed)
OCL=35845
CL=35845
 2009-10-16 12:02:14 -07:00
Russ Cox
d5337e9829 fix linux build: 
i renamed sys to runtime but didn't remember this file.
(and the darwin build doesn't use it.)

TBR=r
OCL=35826
CL=35826
 2009-10-15 23:57:04 -07:00
Russ Cox
22a5c78f44 rename sys functions to runtime, 
because they are in package runtime.

another step to enforcing package boundaries.

R=r
DELTA=732  (114 added, 93 deleted, 525 changed)
OCL=35811
CL=35824
 2009-10-15 23:10:49 -07:00
Russ Cox
488ca3c7a6 move math out of runtime. 
a step toward enforcing package boundaries,
necessary to eliminate global package name space.

R=r
DELTA=581  (310 added, 271 deleted, 0 changed)
OCL=35805
CL=35823
 2009-10-15 23:09:22 -07:00
Robert Griesemer
738c58ca75 improved handling of expression lists 
R=rsc
DELTA=189  (118 added, 9 deleted, 62 changed)
OCL=35816
CL=35821
 2009-10-15 22:52:11 -07:00
Kai Backman
4f7aa31862 fix minor typo in float conversions 
R=rsc
APPROVED=rsc
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=35820
CL=35820
 2009-10-15 22:30:57 -07:00
Stephen Ma
f9e08759de Trivial documentation fix for func ListenAndServe(). 
R=go-dev
APPROVED=gri
DELTA=1  (1 added, 0 deleted, 0 changed)
OCL=35817
CL=35819
 2009-10-15 22:18:14 -07:00
Kai Backman
545dbd810c fix OINDEX address generation, leftover misunderstanding about 
how scale works on amd64/386

go/test: passes 85% (294/342)

R=rsc
APPROVED=rsc
DELTA=27  (26 added, 1 deleted, 0 changed)
OCL=35815
CL=35818
 2009-10-15 22:16:31 -07:00
Kai Backman
3f085e643d fix arm build 
R=rsc
APPROVED=rsc
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=35812
CL=35814
 2009-10-15 21:27:09 -07:00
Kai Backman
222a15c840 test/64bit.go passes but doesn't generate properly yet. 
R=rsc
APPROVED=rsc
DELTA=235  (98 added, 38 deleted, 99 changed)
OCL=35789
CL=35813
 2009-10-15 19:41:51 -07:00
Robert Griesemer
3f427bc9c8 update Make.deps 
R=rsc
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=35808
CL=35808
 2009-10-15 17:54:57 -07:00
Russ Cox
5bbd4c2f1b publish semacquire and semrelease for use by sync. 
more enforcing package boundaries

R=r
DELTA=46  (13 added, 15 deleted, 18 changed)
OCL=35806
CL=35806
 2009-10-15 17:46:53 -07:00
Robert Griesemer
b80d36d846 - implemented utility functions for directory reading/traversal 
- added tests

R=rsc
DELTA=62  (61 added, 1 deleted, 0 changed)
OCL=35788
CL=35802
 2009-10-15 16:34:05 -07:00
Russ Cox
4e4097d9d9 386 shift bug; wasn't zero-extending 16- and 8-bit counts 
+test

R=ken
OCL=35801
CL=35801
 2009-10-15 16:32:45 -07:00
Russ Cox
a75e347a21 do not migrate x to the heap because of *&x. 
R=ken
OCL=35799
CL=35799
 2009-10-15 16:03:01 -07:00
Austin Clements
049501ce4c Implement error handling on process monitor exit. Now, before 
sending any message to the monitor, the sender must check a
"ready" channel.  Before exiting, the monitor records its exit
error and closes this channel, ensuring that all later reads
from the ready channel will immediately return false.

Inspired by
http://chplib.wordpress.com/2009/09/30/poison-concurrent-termination/

R=rsc
APPROVED=rsc
DELTA=47  (27 added, 11 deleted, 9 changed)
OCL=35782
CL=35784
 2009-10-15 12:59:59 -07:00
Robert Griesemer
974b23f569 close file after use 
R=rsc
DELTA=1  (1 added, 0 deleted, 0 changed)
OCL=35778
CL=35780
 2009-10-15 12:04:13 -07:00
Dave Bort
3342574206 Define the new Rand and Source types to allow creating 
isolated sources of random values.

Add normal and exponential distributions.

Add some tests for the normal and exponential distributions.

R=rsc
APPROVED=rsc
DELTA=1005  (904 added, 80 deleted, 21 changed)
OCL=35501
CL=35779
 2009-10-15 11:46:37 -07:00
Russ Cox
18325313fb add exp/eval to pkg list 
update Make.deps.

fixes build

TBR=r
OCL=35777
CL=35777
 2009-10-15 11:05:23 -07:00
Russ Cox
98089b68a3 nacl demos 
R=r
DELTA=9147  (9147 added, 0 deleted, 0 changed)
OCL=35734
CL=35776
 2009-10-15 11:04:33 -07:00
Russ Cox
4113ca5fb1 explain exp 
R=r
DELTA=3  (3 added, 0 deleted, 0 changed)
OCL=35732
CL=35775
 2009-10-15 11:02:18 -07:00
Robert Griesemer
8c101739d9 - bug fix: must not insert indentation tabs into multi-line strings in RawFormat 
(always write tabwriter.Escape chars so formatting is driven correctly; but strip
  them again in the end if no tabwriter is used)
- added testcase for RawFormat printing

R=rsc
DELTA=227  (198 added, 6 deleted, 23 changed)
OCL=35772
CL=35774
 2009-10-15 10:41:07 -07:00
Robert Griesemer
8f8a393b40 bug fix: do not modify (string) literals in any way even if they 
contain tabs or line breaks

R=rsc
DELTA=57  (19 added, 12 deleted, 26 changed)
OCL=35749
CL=35770
 2009-10-15 09:29:31 -07:00
Robert Griesemer
b55e6d1ba5 permit escaped text segments which pass through tabwriter 
undisturbed and uninterpreted

R=rsc
DELTA=141  (82 added, 23 deleted, 36 changed)
OCL=35747
CL=35769
 2009-10-15 09:28:52 -07:00
Robert Griesemer
da829d6608 Work-around for factory function heuristic failure: 
only associate a couple of functions as factories
for os.Error.

Replaces CL 35628 (abandoned).

R=rsc
DELTA=35  (26 added, 0 deleted, 9 changed)
OCL=35754
CL=35768
 2009-10-15 09:24:19 -07:00
Rob Pike
a34dd7156b typo 
R=rsc
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=35743
CL=35762
 2009-10-15 00:27:40 -07:00
Kai Backman
b83549a7e6 cas 
R=rsc
APPROVED=rsc
DELTA=31  (1 added, 8 deleted, 22 changed)
OCL=35752
CL=35757
 2009-10-14 21:47:28 -07:00
Kai Backman
f72ea8eb76 LDREX and STREX 
R=rsc
APPROVED=rsc
DELTA=30  (30 added, 0 deleted, 0 changed)
OCL=35751
CL=35756
 2009-10-14 21:47:08 -07:00
Russ Cox
3ddb7daa97 fix build: 
avoid infinite loop when cd fails.

TBR=r
OCL=35750
CL=35750
 2009-10-14 18:29:33 -07:00