Josh Baum 1c1ec420e5 internal/lsp/source: move initial extract function logic to lsp/command ... In the previous implementation, the initial verification in lsp/command for whether extract function was relavant to the given range did not contain much of the initial logic for extract function. This meant that "canExtractFunction" produced many false positives (i.e. the lightbulb would appear when it should not have in VSCode). This CL moves more of the verification process from "extractFunction" (lsp/source) to "canExtractFunction" (lsp/command). Change-Id: If2683dc9ac3f4bfa8c3444418cf88edd8cbe73e6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245398 Run-TryBot: Josh Baum <joshbaum@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-29 16:09:07 +00:00
..
code_lens.go	internal/lsp: show compiler optimization decisions	2020-07-28 21:59:21 +00:00
command.go	internal/lsp/source: move initial extract function logic to lsp/command	2020-07-29 16:09:07 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
completion_format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
extract.go	internal/lsp/source: move initial extract function logic to lsp/command	2020-07-29 16:09:07 +00:00
folding_range.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
format_test.go	internal/lsp: handle bad formatting with CRLF line endings	2020-07-28 16:05:17 +00:00
format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
gc_annotations.go	internal/lsp: show compiler optimization decisions	2020-07-28 21:59:21 +00:00
highlight.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
hover.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
identifier_test.go	internal/lsp/source: add a unit test for searchForEnclosing	2020-07-28 18:51:24 +00:00
identifier.go	internal/lsp/source: add extra nil check in searchForEnclosing	2020-07-29 04:18:21 +00:00
implementation.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
options.go	internal/lsp: show compiler optimization decisions	2020-07-28 21:59:21 +00:00
references.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
rename_check.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
rename.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
signature_help.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
source_test.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
symbols.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
types_format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
util.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
view.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00
workspace_symbol.go	internal/lsp: remove PackageHandle	2020-07-28 17:35:25 +00:00