qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 16:08:36 -06:00
Code Releases Activity
1c1ec420e5
go/internal/lsp
History
Josh Baum 1c1ec420e5 internal/lsp/source: move initial extract function logic to lsp/command 
In the previous implementation, the initial verification in lsp/command
for whether extract function was relavant to the given range did not
contain much of the initial logic for extract function. This meant
that "canExtractFunction" produced many false positives (i.e. the
lightbulb would appear when it should not have in VSCode). This CL
moves more of the verification process from "extractFunction"
(lsp/source) to "canExtractFunction" (lsp/command).

Change-Id: If2683dc9ac3f4bfa8c3444418cf88edd8cbe73e6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/245398
Run-TryBot: Josh Baum <joshbaum@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-07-29 16:09:07 +00:00
..
analysis internal/lsp: allow narrower scope for convenience CodeActions 2020-07-27 23:36:28 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: remove uses of crypto/sha1 in gopls 2020-07-28 22:26:17 +00:00
cmd internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: correctly invalidate metadata for batched changes 2020-07-27 19:55:46 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp: remove uses of crypto/sha1 in gopls 2020-07-28 22:26:17 +00:00
mod internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
protocol internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
regtest internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: move initial extract function logic to lsp/command 2020-07-29 16:09:07 +00:00
testdata internal/lsp: support return statements in extract function 2020-07-28 16:04:03 +00:00
tests internal/lsp: support refactor.extract through commands 2020-07-27 19:25:51 +00:00
code_action.go internal/lsp: remove PackageHandle 2020-07-28 17:35:25 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: fix logged message for gc_details 2020-07-28 23:52:36 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: remove uses of crypto/sha1 in gopls 2020-07-28 22:26:17 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: check URIs of all workspace folders 2020-07-28 19:06:24 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: remove PackageHandle 2020-07-28 17:35:25 +00:00
lsp_test.go internal/lsp: remove PackageHandle 2020-07-28 17:35:25 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
server.go internal/lsp: show compiler optimization decisions 2020-07-28 21:59:21 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00