mirror of
https://github.com/golang/go
synced 2024-11-05 11:46:12 -07:00
1c1ec420e5
In the previous implementation, the initial verification in lsp/command for whether extract function was relavant to the given range did not contain much of the initial logic for extract function. This meant that "canExtractFunction" produced many false positives (i.e. the lightbulb would appear when it should not have in VSCode). This CL moves more of the verification process from "extractFunction" (lsp/source) to "canExtractFunction" (lsp/command). Change-Id: If2683dc9ac3f4bfa8c3444418cf88edd8cbe73e6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245398 Run-TryBot: Josh Baum <joshbaum@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typesinternal | ||
| xcontext | ||