Robert Griesemer
f65e42d039
gofmt-ify gob
...
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)
R=r
http://go/go-review/1016056
2009-11-05 14:53:42 -08:00
Russ Cox
790c9b59d6
codereview: new commands
...
* clpatch
* download
* submit, on behalf of clpatch
stir hgpatch to fix a few bugs
R=r
CC=go-dev
http://go/go-review/1016051
2009-11-05 14:44:57 -08:00
Robert Griesemer
9786b3f1bd
gofmt-ify 4s, iterable
...
R=rsc
http://go/go-review/1016055
2009-11-05 14:43:03 -08:00
Robert Griesemer
2a89915485
gofmt-ify draw
...
R=rsc
http://go/go-review/1017055
2009-11-05 14:42:28 -08:00
Robert Griesemer
9e48df682c
gofmt-ify eval
...
R=rsc
http://go/go-review/1016054
2009-11-05 14:41:56 -08:00
Robert Griesemer
d2af73136e
gofmt-ify ogle
...
R=rsc
http://go/go-review/1016053
2009-11-05 14:30:18 -08:00
Robert Griesemer
6238964d7b
gofmt-ify nacl
...
R=rsc
http://go/go-review/1018062
2009-11-05 14:29:38 -08:00
Robert Griesemer
77334b988c
gofmt-ify reflect
...
- the single line structs can be fixed in another round
R=rsc
http://go/go-review/1016052
2009-11-05 14:23:20 -08:00
Robert Griesemer
666afa1c02
2nd attempt: no noIndent for string lists
...
- slightly better output in general
- extra indentation where we could do without
(however that seems better for now that not having the indentation
where it is needed)
- no information is lost, so a future better approach can fix these
places up again
R=rsc
http://go/go-review/1017050
2009-11-05 14:03:56 -08:00
Rob Pike
f93ecca397
add a place-holder link for the hour-long video
...
R=rsc
CC=go-dev
http://go/go-review/1017054
2009-11-05 13:46:12 -08:00
Rob Pike
d5717d262a
update the text on the landing page.
...
R=agl, rsc
CC=go-dev
http://go/go-review/1017053
2009-11-05 13:39:00 -08:00
Ken Thompson
18cb960f3e
forgot a piece of debugging
...
in previous change
R=rsc
http://go/go-review/1017052
2009-11-05 13:05:07 -08:00
Ken Thompson
505fd760a2
same speedup as 6l
...
R=rsc
http://go/go-review/1016050
2009-11-05 12:47:22 -08:00
Adam Langley
51c1bd229b
godoc: style update.
...
R=r, rsc
CC=go-dev
http://go/go-review/1017051
2009-11-05 12:18:54 -08:00
Robert Griesemer
bd4f94057f
gofmt-ify syscall
...
(replacement for CL 1018053)
R=r
http://go/go-review/1017047
2009-11-05 10:55:57 -08:00
Robert Griesemer
30c7088c95
gofmt-ify template, time, unsafe, flag, fmt
...
(replacement for CLs 1017039, 1017041, 1017040, 1018054)
R=r
http://go/go-review/1018060
2009-11-05 09:40:28 -08:00
Russ Cox
1329012a23
new command hgpatch, for use by codereview extension
...
R=r
http://go/go-review/1018059
2009-11-05 09:27:19 -08:00
Robert Griesemer
3630bfbe9f
gofmt-ify math, expvar, exp/spacewar
...
R=rsc
http://go/go-review/1018061
2009-11-05 09:08:08 -08:00
Robert Griesemer
e57acdca4d
gofmt-ify parts of xml
...
R=rsc
http://go/go-review/1017049
2009-11-05 08:59:03 -08:00
Robert Griesemer
12dbd06f0a
gofmt-ify encoding
...
R=rsc
http://go/go-review/1017048
2009-11-05 08:55:18 -08:00
Russ Cox
9df7d6ef10
add -l flag to hg gofmt.
...
don't apply gofmt to non-go files during upload check.
R=r
http://go/go-review/1016048
2009-11-05 08:11:44 -08:00
Russ Cox
d8e0d9a778
add "hg gofmt" to run all modified files through gofmt.
...
add check before Upload, for now disabled by default,
that files do not change when run through gofmt.
enable by adding
[codereview]
force_gofmt = True
to .hgrc or .hg/hgrc.
add doc strings for a few more commands.
rename codereview-login to code-login
to make module doc visible.
R=r
CC=gri
http://go/go-review/1018056
2009-11-04 23:43:55 -08:00
Robert Griesemer
ed494c6398
gofmt-ify sort, sync
...
R=rsc
http://go/go-review/1018057
2009-11-04 23:25:29 -08:00
Robert Griesemer
314b358ab7
gofmt-ify strconv
...
(and remove an empty line at the end of a file)
R=rsc
http://go/go-review/1017046
2009-11-04 23:20:49 -08:00
Robert Griesemer
5d37705416
gofmt-ify net
...
R=rsc
http://go/go-review/1017045
2009-11-04 23:16:46 -08:00
Robert Griesemer
7df45566db
gofmt-ify image
...
R=rsc
http://go/go-review/1017044
2009-11-04 22:52:28 -08:00
Robert Griesemer
ca2a69ea06
gofmt-ify hash, http
...
(gofmt will be able to re-align map entries as in http nicely,
eventually)
R=rsc
http://go/go-review/1018055
2009-11-04 22:45:59 -08:00
Robert Griesemer
b16e6ab148
gofmt-ify tabwriter
...
R=rsc
http://go/go-review/1017042
2009-11-04 22:26:48 -08:00
Robert Griesemer
1fede304ff
more comment formatting:
...
- preserve (some) indentation of comment text for /*-style comments
even if the first comment line does not contain any text that might
suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
(this will not introduce a lot of changes since comments of this
kind - until now - were not changed with respect to indentation)
R=rsc
http://go/go-review/1016047
2009-11-04 22:07:13 -08:00
Rob Pike
7f534246c6
bumper for video
...
R=rsc
http://go/go-review/1017038
2009-11-04 21:56:33 -08:00
Robert Griesemer
841c18a95a
gofmt-ify unicode
...
R=r
http://go/go-review/1018051
2009-11-04 21:39:55 -08:00
Kai Backman
55ba9d6a2c
fixing (badly) linux_arm syscall.
...
R=rsc
http://go/go-review/1017037
2009-11-04 21:34:54 -08:00
Robert Griesemer
601ee4807b
- add a blank before the opening { for multi-line composites
...
(request by r)
- feature temporarily disabled
R=rsc
CC=r
http://go/go-review/1018052
2009-11-04 21:15:47 -08:00
Robert Griesemer
398f220d5b
gofmt-ify os
...
R=r
http://go/go-review/1017034
2009-11-04 20:42:40 -08:00
Ken Thompson
9c7535432a
speed up 6l
...
hopefully no change
R=rsc
http://go/go-review/1017035
2009-11-04 18:17:57 -08:00
Russ Cox
cc1a979272
package patch
...
R=r
http://go/go-review/1018043
2009-11-04 17:55:06 -08:00
Rob Pike
31053d4e47
add a final section with a complete example
...
R=rsc
CC=go-dev
http://go/go-review/1017033
2009-11-04 17:29:20 -08:00
Robert Griesemer
5fca0bca61
gofmt-ify compress
...
R=rsc
http://go/go-review/1016045
2009-11-04 17:10:18 -08:00
Robert Griesemer
b6d0a22dc5
gofmt-ify ebnf
...
R=r
http://go/go-review/1018050
2009-11-04 17:05:01 -08:00
Robert Griesemer
646a2c5a42
gofmt-ify bufio
...
R=rsc
http://go/go-review/1018049
2009-11-04 17:04:21 -08:00
Robert Griesemer
03678f7417
gofmt-ify asn1
...
R=rsc
http://go/go-review/1018047
2009-11-04 17:03:08 -08:00
Robert Griesemer
517ebbb24a
gofmt-ify src/pkg/archive
...
R=rsc
http://go/go-review/1018046
2009-11-04 17:02:47 -08:00
Robert Griesemer
eabcc981c5
gofmt-ify crypto
...
R=agl
CC=rsc
http://go/go-review/1017032
2009-11-04 17:02:30 -08:00
Robert Griesemer
2ce57ec10a
gofmt-ify src/pkg/go (excluding printer directory due to pending CL,
...
and parser.go and scanner_test.go which have minor formatting issues)
R=rsc
http://go/go-review/1016042
2009-11-04 17:02:05 -08:00
Robert Griesemer
26c3f6c18d
rename testfiles from .go -> .orig so that they won't be
...
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)
R=rsc
http://go/go-review/1018045
2009-11-04 16:50:13 -08:00
Robert Griesemer
688a6ff71d
gofmt-ify bytes
...
R=r
http://go/go-review/1016044
2009-11-04 16:49:28 -08:00
Robert Griesemer
789b31a416
better placement of /*-style comments interspersed with code on one line
...
R=rsc
http://go/go-review/1017030
2009-11-04 15:33:28 -08:00
Russ Cox
5d436b9def
bytes.SplitAfter and strings.SplitAfter
...
most common usage is:
lines := strings.SplitAfter(text, "\n", 0)
R=r
http://go/go-review/1018042
2009-11-04 15:19:30 -08:00
Russ Cox
3de3af512d
doc doc doc
...
R=r
http://go/go-review/1016039
2009-11-04 15:17:36 -08:00
Russ Cox
e414fda6d4
avoid infinite recursion in matcher.
...
after sync (or sync --local), clean up repository:
* look for and close CLs submitted on our behalf
* remove unmodified files from CLs
* warn about empty CLs
R=r
http://go/go-review/1017029
2009-11-04 15:17:01 -08:00
