Robert Griesemer
d9e2631b53
go/parser.ParseFiles: don't override error (to nil) if there is one
...
Also: Return first instead of last error as that seems more useful.
R=r
CC=golang-dev
https://golang.org/cl/1897050
2010-08-04 18:02:43 -07:00
Robert Griesemer
ed8c23149f
fix build: literal types cannot be parenthesized anymore
...
R=rsc
CC=golang-dev
https://golang.org/cl/1849055
2010-08-04 17:58:56 -07:00
Russ Cox
e473f42b2d
amd64: use segment memory for thread-local storage
...
Returns R14 and R15 to the available register pool.
Plays more nicely with ELF ABI C code.
In particular, our signal handlers will no longer crash
when a signal arrives during execution of a cgo C call.
Fixes #720 .
R=ken2, r
CC=golang-dev
https://golang.org/cl/1847051
2010-08-04 17:50:22 -07:00
Christian Himpel
3dc6c9e64d
misc/vim: highlight misspelled words only in comments
...
R=adg
CC=golang-dev
https://golang.org/cl/1915043
2010-08-05 10:31:00 +10:00
Robert Griesemer
03f42934c1
gofmt/go/parser: strengthen syntax checks
...
- don't allow parenthesized receiver base types or anonymous fields
- fixed a couple of other omissions
- adjusted gofmt test script
- removed several TODOs
R=rsc
CC=golang-dev
https://golang.org/cl/1897043
2010-08-04 17:21:02 -07:00
Alex Brainman
12576f9e70
goinstall: check for error from exec.*Cmd.Wait() before using its result
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/1923043
2010-08-04 17:18:57 -07:00
Christian Himpel
6b8ec5c572
cgo: generate correct multiple return value function invocations
...
Fixes #967 .
R=rsc
CC=golang-dev
https://golang.org/cl/1855051
2010-08-04 17:15:04 -07:00
Russ Cox
3f16c5cee1
A+C: fix email address
...
R=adg
CC=golang-dev
https://golang.org/cl/1856052
2010-08-04 17:14:51 -07:00
Robert Griesemer
a6449b66a4
gofmt: make code more readable by avoiding redeclaration
...
R=r
CC=golang-dev
https://golang.org/cl/1910045
2010-08-03 23:39:01 -07:00
Scott Lawrence
99aab8bacb
bytes: added test case for explode with blank string.
...
Tests for the equivalent of the strings.explode("") panic bug (issue 980).
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/1850052
2010-08-04 13:33:24 +10:00
Anthony Martin
2db4c3d779
json: object members must have a value
...
R=rsc
CC=golang-dev
https://golang.org/cl/1847050
2010-08-03 17:05:00 -07:00
Russ Cox
3ab7830d7d
A+C: Anthony Martin, Christian Himpel (individual CLA)
...
R=adg
CC=golang-dev
https://golang.org/cl/1689061
2010-08-03 17:04:54 -07:00
Nigel Tao
27e249049e
bufio: introduce Peek.
...
I'll leave whether or not this obsoletes UnreadByte for a future CL.
R=r, rsc
CC=golang-dev
https://golang.org/cl/1912042
2010-08-04 09:44:02 +10:00
Rob Pike
e45b58fe96
os: change the type of permissions argument for Open etc. to uint32.
...
Besides being more correct, it protects against people accidentally
exchanging the permission and open mode arguments to Open.
R=rsc
CC=golang-dev
https://golang.org/cl/1904045
2010-08-04 08:34:52 +10:00
Tarmigan Casebolt
1badb46313
websocket: correct challenge response
...
Tested against latest Chrome.
R=ukai, rsc
CC=golang-dev
https://golang.org/cl/1743053
2010-08-03 14:34:44 -07:00
Kai Backman
d0b913fe37
bikeshed: only output bug when we have a regression
...
R=rsc
CC=golang-dev
https://golang.org/cl/1897046
2010-08-03 13:09:16 -07:00
Russ Cox
5960f835ca
CONTRIBUTORS: Rietveld alias for brad@danga.com
...
R=adg
CC=bradfitz, golang-dev
https://golang.org/cl/1715060
2010-08-03 13:04:02 -07:00
Peter Mundy
12befd063b
os: Null device
...
R=rsc, cw
CC=golang-dev
https://golang.org/cl/1854042
2010-08-03 13:03:50 -07:00
Kai Backman
311973ea56
arm: remove old qemu dependency from gotest
...
R=rsc
CC=golang-dev
https://golang.org/cl/1678063
2010-08-03 13:03:40 -07:00
Russ Cox
d4af41f5bb
test/run: diff old new
...
R=r, iant
CC=golang-dev
https://golang.org/cl/1907046
2010-08-03 13:01:28 -07:00
Adam Langley
7748a7f159
crypto/x509: unwrap Subject Key Identifier
...
RFC 5280, 4.2.1.2 says:
SubjectKeyIdentifier ::= KeyIdentifier
KeyIdentifier ::= OCTET STRING
Previously, we were failing to unwrap the second level of OCTET STRING
encoding.
Fixes #993 .
R=rsc
CC=golang-dev
https://golang.org/cl/1917044
2010-08-03 12:26:48 -04:00
Russ Cox
3f19d8ae8d
gc: empty select
...
R=ken2
CC=golang-dev
https://golang.org/cl/1871057
2010-08-03 01:07:57 -07:00
Russ Cox
585eae3bce
gc: bug301
...
Fixes #990 .
R=ken2
CC=golang-dev
https://golang.org/cl/1742055
2010-08-03 01:07:40 -07:00
Russ Cox
c6cb303a8a
gc: bug299, bug300
...
R=ken2
CC=golang-dev
https://golang.org/cl/1731057
2010-08-03 00:53:32 -07:00
Russ Cox
b91c70ad52
A+C: Tarmigan Casebolt
...
R=adg
CC=golang-dev, tarm
https://golang.org/cl/1923041
2010-08-03 00:36:44 -07:00
Russ Cox
9bac9d23d3
gc: index bounds tests and fixes
...
move constant index checking to front end
x[2:1] is a compile-time error now too
R=ken2
CC=golang-dev
https://golang.org/cl/1848056
2010-08-03 00:26:02 -07:00
Scott Lawrence
0cd8777255
strings: fix Split("", "", -1)
...
Fixes #980 .
Made it return an empty array, rather than crash.
Added relevant test cases to strings.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/1914041
2010-08-03 13:35:14 +10:00
Rob Pike
b6c2bf7127
Add Scott Lawrence to C&A
...
R=adg
CC=golang-dev
https://golang.org/cl/1899044
2010-08-03 13:27:50 +10:00
Alex Brainman
a79a9098da
syscall: make sure go error numbers do not clash with windows system errors
...
R=rsc
CC=golang-dev
https://golang.org/cl/1857049
2010-08-03 12:04:41 +10:00
Andrew Gerrand
5443bbe292
builder: update script so it doesn't create tar-bombs
...
R=rsc
CC=golang-dev
https://golang.org/cl/1857048
2010-08-03 11:06:18 +10:00
Nigel Tao
244b6583b7
image: introduce Gray and Gray16 types, and remove the named colors
...
except for Black and White.
R=rsc
CC=golang-dev, mpl, r
https://golang.org/cl/1903049
2010-08-03 10:57:53 +10:00
Rob Pike
3f5966dcc0
io: consolidate multi_reader and multi_writer into a single file, multi.go
...
R=rsc
CC=golang-dev
https://golang.org/cl/1860046
2010-08-03 08:04:33 +10:00
Nigel Tao
55badd474b
image/png: use image-specific methods for checking opacity.
...
R=rsc
CC=golang-dev, mpl
https://golang.org/cl/1894047
2010-08-02 09:52:15 +10:00
Bill Neubauer
6d37724c15
websocket: fix bug involving spaces in header keys
...
R=rsc, ukai
CC=golang-dev
https://golang.org/cl/1669056
2010-07-30 12:27:03 -07:00
Russ Cox
1c4d380b80
CONTRIBUTORS: add wcn@google.com alias to match with code review
...
R=wcn
CC=golang-dev
https://golang.org/cl/1902043
2010-07-30 12:26:50 -07:00
Russ Cox
68b0a87966
runtime: do not fall through in SIGBUS/SIGSEGV
...
Faults beyond the first page are not expected
and should fail loudly. They are not subject to recover.
R=r
CC=golang-dev
https://golang.org/cl/1915042
2010-07-30 11:32:55 -07:00
Kai Backman
a0368180a7
arm: disable another flaky test.
...
these tests work fine on n1 and gumstix. it's unclear
why they keep failing on the godashboard build.
R=rsc
CC=golang-dev
https://golang.org/cl/1664056
2010-07-30 12:33:40 +03:00
Kai Backman
c44f95ff48
fix build
...
R=rsc
CC=golang-dev
https://golang.org/cl/1913042
2010-07-30 10:53:26 +03:00
Kai Backman
8d76a15122
arm: bugfixes (stack clobbering, indices)
...
also changed zerodivide to output "BUG"
R=rsc
CC=golang-dev
https://golang.org/cl/1871055
2010-07-30 10:37:51 +03:00
Kai Backman
96ad9adef3
arm: add gdb support to android launcher script
...
R=rsc
CC=golang-dev
https://golang.org/cl/1742050
2010-07-30 10:35:07 +03:00
Andrew Gerrand
fdbff04a94
tag release.2010-07-29
...
R=rsc
CC=golang-dev
https://golang.org/cl/1896044
2010-07-30 15:18:55 +10:00
Andrew Gerrand
b5d84bb0cf
release.2010-07-29
...
R=rsc
CC=golang-dev
https://golang.org/cl/1907045
2010-07-30 14:48:30 +10:00
Andrew Gerrand
3402c5e8fe
misc/builder: support for uploading tarballs to googlecode
...
R=rsc
CC=golang-dev
https://golang.org/cl/1784042
2010-07-30 14:00:59 +10:00
Joe Poirier
b57ffae094
cov and prof: implement windows version (just function stubs and build mods)
...
R=brainman, rsc
CC=golang-dev
https://golang.org/cl/1676054
2010-07-30 11:47:11 +10:00
Robert Griesemer
500425ac7b
bug300: literal types must not be parenthesized
...
( This CL is dependent on acceptance of
https://golang.org/cl/1913041/show )
R=go-dev
CC=golang-dev
https://golang.org/cl/1860045
2010-07-29 18:14:49 -07:00
Robert Griesemer
07cc6440dc
go_spec: don't allow parens around the literal type of composite literals
...
Background: The current spec is imprecise with respect to the parsing ambiguity
for composite literals: It says that the ambiguity arises when the TypeName form
of the LiteralType is used. The following code:
if (B) {} ...
is not using the TypeName form (but the parenthesized TypeName form) and thus
could be interpreted as:
if ((B){}) ...
instead of
if B {} ...
Both compilers and gofmt choose the latter interpretation. One could fix the
spec by making the clause regarding the parsing ambiguity more precise ("...using
the _possibly parenthesized_ TypeName form of the LiteralType..."). The alternative
(chosen here) is to simply disallow parenthesized literal types. Except for a single
test case (test/parentype.go) there appears to be no Go code under $GOROOT containing
parenthesized literal types. Furthermore, parentheses are never needed around a
literal type for correct parsing.
R=golang-dev
CC=golang-dev
https://golang.org/cl/1913041
2010-07-29 18:13:41 -07:00
Andrew Gerrand
bab711b184
doc: update front page and go_learning.html
...
This is a stop-gap change to give more current information visibility
before a more thorough reorganization.
R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/1902042
2010-07-30 10:36:13 +10:00
Yuusei Kuwana
c21e2f3925
mime: add AddExtensionType
...
For example:
mime.AddExtensionType(".m3u8", "application/x-mpegURL")
mime.AddExtensionType(".ts", "video/MP2T")
R=rsc, rsc1
CC=golang-dev
https://golang.org/cl/1698046
2010-07-29 14:12:04 -07:00
Russ Cox
2ef1c6e2fc
A+C: Yuusei Kuwana (individual CLA)
...
R=r
CC=golang-dev
https://golang.org/cl/1871054
2010-07-29 13:49:01 -07:00
Robert Griesemer
bc0a1c61f7
scanner: better comment
...
R=rsc
CC=golang-dev
https://golang.org/cl/1900044
2010-07-29 13:02:27 -07:00