qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 08:44:39 -07:00
Code Releases Activity
4,152 Commits 58 Branches 402 Tags 522 MiB
4aaf948f90
Commit Graph

2795 Commits

Author SHA1 Message Date
Russ Cox
c3343ef62c fix BUFSIZ redeclaration warnings 
R=r
https://golang.org/cl/152085
 2009-11-11 16:33:23 -08:00
Russ Cox
2cda46dc82 fix TestRemoveAll again (tested as root this time). 
Fixes #22.

R=r
https://golang.org/cl/154069
 2009-11-11 15:48:38 -08:00
Adam Langley
2643f742a5 make.bash: detect and warn about SELinux policy that crashes us. 
The default SELinux policy on Fedora 12 (at least) disallows stack
pages to be +x. This causes all binaries written by 6g/6l to segfault
immedately. The 'true' way to fix this issue is to mark binaries with
the correct type. However, that assumes that 6l is going to detect
SELinux, figure out the correct type for the current distribution and
set the type (without libselinux).

For now we'll warn users and point them towards the way to enable
execstack for the whole system.

http://code.google.com/p/go/issues/detail?id=47

R=rsc
CC=golang-dev
http://codereview.prom.corp.google.com/1026041
 2009-11-11 15:02:15 -08:00
Russ Cox
f07a9e43e8 os test: do not use symlink > 255 bytes. 
Fixes #62.

R=r
https://golang.org/cl/152080
 2009-11-11 14:52:29 -08:00
Russ Cox
ae39a1d8ec cc: correct handling of allocn(0, 1, d) 
Fixes #29.

R=r
https://golang.org/cl/152076
 2009-11-11 14:52:21 -08:00
Russ Cox
d38630fe3d gotest: add LC_ALL=C 
R=r
https://golang.org/cl/154067
 2009-11-11 14:52:15 -08:00
Russ Cox
e9ac56fb99 getc/ungetc in assemblers; BUFSIZ everywhere. 
Fixes #67.

R=r
https://golang.org/cl/154068
 2009-11-11 14:52:08 -08:00
Russ Cox
a174987a7c two gopack nits. 
1. allocate an extra byte for use by write.
2. throw away the code trying to translate
   uid and gid to names.  i suspect it of causing
   seg faults in some situations, and it is
   not needed by the compilers.

Fixes #48.  (I hope.)

R=r
https://golang.org/cl/152077
 2009-11-11 14:48:33 -08:00
Adam Langley
9188b1f000 Revert make.bash which slipped into the previous revision. 
R=rsc
http://codereview.prom.corp.google.com/1024051
 2009-11-11 13:30:47 -08:00
Adam Langley
1941855730 Reland a112249da741, this time with missing file. 2009-11-11 13:21:37 -08:00
Russ Cox
8c3d2f015b avoid clash with stdio's getc, ungetc. 
Fixes #50.

R=r
https://golang.org/cl/154064
 2009-11-11 13:08:35 -08:00
Russ Cox
8515a9f4e2 log test: don't assume a fixed set of letters for $GOROOT 
Fixes #27.

R=r
https://golang.org/cl/152075
 2009-11-11 13:07:46 -08:00
Russ Cox
ed86d0e70a roll back 3985: build is broken 
TBR=agl1
CC=golang-dev
https://golang.org/cl/154065
 2009-11-11 12:54:52 -08:00
Adam Langley
af1fa43a81 big: 
Turn methods that don't store the result in their receiver into
    functions in order to preserve the convention.
  Re-jig Exp and Div by moving their guts into nat.go.
  Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.

R=gri
CC=go-dev
http://codereview.prom.corp.google.com/1024038
 2009-11-11 12:34:46 -08:00
Russ Cox
384932589d work with GNU Make 3.80 
Fixes #30.

R=r1, r
https://golang.org/cl/154061
 2009-11-11 12:00:50 -08:00
Russ Cox
7932950844 gc: increase maximum path size in getwd from 100 to 1000. 
Fixes #31.

To try the fix before the next release:
	hg pull -u

R=r1, r
https://golang.org/cl/154058
 2009-11-11 12:00:41 -08:00
Russ Cox
1971e1bd21 os: do not test error case of TestRemoveAll when root 
Fixes #22.

R=r1, r
https://golang.org/cl/152073
 2009-11-11 12:00:34 -08:00
Russ Cox
364e564e3d use fully qualified names for hash interfaces 
Fixes #38.

R=r1, r
https://golang.org/cl/152072
 2009-11-11 12:00:15 -08:00
Adam Langley
5281869fac gopack: convert long to time_t before taking a pointer. 
Fixes #40.

R=rsc, r1
CC=golang-dev
https://golang.org/cl/154057
 2009-11-11 11:19:33 -08:00
Russ Cox
cd0cbd3ed2 lib9: rip out platform specific code that breaks on pclinuxos 
R=r
CC=golang-dev
https://golang.org/cl/154049
 2009-11-10 23:42:21 -08:00
Russ Cox
fe1e49241c update old comment: things are much better now 
R=r
https://golang.org/cl/152057
 2009-11-10 19:59:22 -08:00
Russ Cox
9604f7b009 gotest: avoid problems with grepping for · 
Fixes #7.

R=r
CC=golang-dev
https://golang.org/cl/154043
 2009-11-10 19:56:32 -08:00
Russ Cox
9ff712ecd1 make.bash: check $PATH indirectly via which quietgcc 
R=agl1
CC=golang-dev
https://golang.org/cl/152056
 2009-11-10 19:20:34 -08:00
Russ Cox
2d70d60392 sanity check environment variables better. 
Fixes #12.

R=agl1
CC=golang-dev
https://golang.org/cl/152055
 2009-11-10 19:12:22 -08:00
Russ Cox
92a9ddf0fa net: fix error for connect to /etc/ on some systems 
R=agl1
CC=golang-dev
https://golang.org/cl/152051
 2009-11-10 18:27:26 -08:00
Russ Cox
d6c388616b test for invalid $GOBIN setting before trying to build 
R=r
CC=golang-dev
https://golang.org/cl/153049
 2009-11-10 18:00:48 -08:00
Russ Cox
e23f75b3c4 net: disable more ipv6 tests 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153050
 2009-11-10 18:00:27 -08:00
Russ Cox
b4a8b353c4 net: disable ipv6 test if we know kernel won't take it. 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153048
 2009-11-10 17:47:38 -08:00
Russ Cox
9dba695692 net: disable dns error test 
some dns resolvers (opendns, for example)
are willing to make up results for any name.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
 2009-11-10 17:39:01 -08:00
Russ Cox
484f46daea net: fix dns bug reported on irc. 
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.

tested by tossing domain and search lines from /etc/resolv.conf

Fixes #2.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
 2009-11-10 17:09:33 -08:00
Robert Griesemer
9e0d2fa89b better code for a copy loop 
R=rsc
https://golang.org/cl/152046
 2009-11-10 15:33:59 -08:00
Ken Thompson
c90d392ce3 spell it with an "e" 
R=rsc
http://go/go-review/1025037
 2009-11-10 15:05:15 -08:00
Robert Griesemer
b27f05f63b minor adjustments to package comments for better synopsis. 
R=rsc
CC=r
http://go/go-review/1026038
 2009-11-10 10:55:53 -08:00
Russ Cox
b351113b50 make regexp comment not a package comment 
R=r
http://go/go-review/1025036
 2009-11-10 09:36:48 -08:00
Russ Cox
cb94b60cfb allow user agent to mention Go. 
R=r
http://go/go-review/1024046
 2009-11-10 09:10:08 -08:00
Russ Cox
da776791c4 drop output from nilptr tests; 
too hard to make it the same everywhere.
still checking for non-zero exit status though.

disable core files while running tests

R=r
http://go/go-review/1026037
 2009-11-09 23:11:36 -08:00
Robert Griesemer
3d668c1b5d - minor cleanups 
- better debugging support
- gofmt -l src misc | wc -l is 0

R=rsc
http://go/go-review/1024042
 2009-11-09 22:30:07 -08:00
Robert Griesemer
3bb0032cd6 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)

R=rsc, r
http://go/go-review/1024041
 2009-11-09 21:23:52 -08:00
Robert Griesemer
baba292998 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
	- applied gofmt -w misc src
	- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1026036
 2009-11-09 21:13:17 -08:00
Robert Griesemer
1698934194 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1024040
 2009-11-09 21:09:34 -08:00
Russ Cox
9f42ccb781 error rewording suggested by robert. 
update comment.

R=ken
http://go/go-review/1025031
 2009-11-09 15:25:18 -08:00
Robert Griesemer
92743615fb TBR: 
fix typo that prevented function bodies from being indexed (ouch!)

R=rsc
http://go/go-review/1024035
 2009-11-09 14:44:16 -08:00
Robert Griesemer
40621d5c0d remove semis after statements in one-statement statement lists 
R=rsc, r
http://go/go-review/1025029
 2009-11-09 12:07:39 -08:00
Russ Cox
18ccbc69f8 tweak documentation of commands 
so that first sentence is better for cmd page.

live at http://r45:3456/cmd/

R=gri, r
http://go/go-review/1024034
 2009-11-09 11:45:15 -08:00
Robert Griesemer
81672e79e4 - rename Context to exprContext to remove it from public interface 
(and to match the style of declContext)

R=rsc
http://go/go-review/1024033
 2009-11-09 10:37:36 -08:00
Robert Griesemer
53f485813e fix for nodeSize computation, used to determine if 
a node fits on one line:
- for purposes of measuring the node size in text,
  don't generate html or use a styler that could
  generate html as it will lead to overly large
  sizes

A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.

This change causes no difference to the gofmt formatting
of any files in src or misc.

R=rsc
http://go/go-review/1026034
 2009-11-09 09:34:55 -08:00
Robert Griesemer
aae64f8c81 - exit godoc w/o crashing if negative tabwidth is provided 
- minor related cleanups

R=rsc
http://go/go-review/1025026
 2009-11-08 23:42:00 -08:00
Robert Griesemer
d731dc8e72 Addressing issue brought up by dsymonds: 
- When providing alternative spellings to a query, do not
  prefix it with a package qualifier as the suggestion may
  not have any results. Correctly filtering is quite a bit
  of work, and clicking the alternative spelling will always
  also show the qualified hits if they exist (but also others).
  Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
  package documentation.
- Experimented with excluding main packages and test files
  from index with inconclusive results. Code is present and
  can be enabled by changing a flag in the source. This needs
  some more work.

R=rsc
CC=r, dsymonds
http://go/go-review/1026033
 2009-11-08 23:34:08 -08:00
Russ Cox
71983af4a1 bug212, bug213. 
R=ken
http://go/go-review/1026032
 2009-11-08 23:22:06 -08:00
Rob Pike
e02f2b51c5 delete a pointless todo in all_test.go. 
address one in rpc/client.go

R=rsc
CC=go-dev
http://go/go-review/1026030
 2009-11-08 21:57:59 -08:00
Robert Griesemer
c532940ecf improved sentence extraction: 
- don't forget first periods
- look at capitalization of last char before periods

R=rsc
http://go/go-review/1024027
 2009-11-08 21:48:51 -08:00
Russ Cox
ed6eb5b577 a nagging inconsistency: capitalization of 
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.

R=r
CC=go-dev
http://go/go-review/1024026
 2009-11-08 21:46:20 -08:00
Russ Cox
830813f019 assorted cleanup 
R=r, iant
CC=go-dev
http://go/go-review/1025024
 2009-11-08 21:08:27 -08:00
Rob Pike
ceb6031ecd delete TODO now that compiler is better at % 
adjust an inconsistency in reflect/type.go's package comment

R=rsc
http://go/go-review/1026029
 2009-11-08 20:45:39 -08:00
Robert Griesemer
7837dbfcb8 use grouping instead of colors to show non-global search hits: 
- introduced a new run per file containing all spots belonging
  to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization

R=rsc
http://go/go-review/1026028
 2009-11-08 20:17:04 -08:00
Robert Griesemer
e8b580c9aa fix sentence extraction 
R=rsc
http://go/go-review/1026027
 2009-11-08 18:19:06 -08:00
Robert Griesemer
202ede1240 - properly align package synopses 
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks

R=rsc
http://go/go-review/1024024
 2009-11-08 16:47:32 -08:00
Rob Pike
40a7db3ee9 add top-level package comments for net, reflect, malloc. 
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.

R=gri, rsc
CC=go-dev
http://go/go-review/1026026
 2009-11-08 15:57:25 -08:00
Robert Griesemer
56b4515740 added package documentation 
R=r, rsc
http://go/go-review/1025023
 2009-11-08 15:04:30 -08:00
Robert Griesemer
a011480ff3 TBR 
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)

R=rsc
http://go/go-review/1024021
 2009-11-08 00:51:08 -08:00
Robert Griesemer
89d0e2dbe3 - better support for text files: show them nicely formatted 
instead of serving them raw
- path-related cleanups

R=rsc
http://go/go-review/1026021
 2009-11-08 00:40:43 -08:00
Robert Griesemer
1a9805adcb - avoid division-by-zero crash in tabwriter 
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing

R=rsc
http://go/go-review/1026022
 2009-11-07 23:59:24 -08:00
Robert Griesemer
642caacfa3 - added link to sources 
- renamed listing.html -> dirList.html
  (there is a dirs.html already, it should probably have a better name, too)

R=rsc
http://go/go-review/1025020
 2009-11-07 21:24:48 -08:00
Robert Griesemer
171ef39949 nice directory listings 
R=rsc
http://go/go-review/1026020
 2009-11-07 21:12:46 -08:00
Vish Subramanian
379150c210 Add flags of type float to the flag package. 
R=r, rsc
http://go/go-review/1026011
 2009-11-07 15:52:27 -08:00
Robert Griesemer
1ac60ddd10 - support to extract one-line package synopsis for package listings 
- formatting in dirs.html is crude, needs better html (open to suggestions),
  but shows the synopsis
- many package comments should probably be adjusted such that the first
  sentence is more concise

R=rsc, iant
http://go/go-review/1025014
 2009-11-07 13:17:53 -08:00
Robert Griesemer
3317697df4 - blank before opening { for multi-line composite literals (as preferred by r) 
- blank padding around composite literal contents for a less dense look
  (most if not all composite literals were written in that style before gofmt
  ran through them)
- corresponding (internal) flag: compositeLitBlank

- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis

- the number of changes in nodes.go is huge because of the removed semis;
  hg mail requires that I gofmt the file before

With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.

R=rsc, r
http://go/go-review/1025015
 2009-11-07 13:01:52 -08:00
David Symonds
6ea866c04b Typo fixes. 
R=rsc
CC=go-dev
http://go/go-review/1026014
 2009-11-06 18:43:57 -08:00
Ken Thompson
0eb2a79ff3 8g optimizer 
R=rsc
http://go/go-review/1025011
 2009-11-06 16:51:49 -08:00
Robert Griesemer
832ce7c1d2 format composite literal types that are "short" struct type literals 
on one line for a more compact representation of some composite Literals

R=rsc
http://go/go-review/1025008
 2009-11-06 16:34:19 -08:00
Robert Griesemer
a05a5465c8 - application of gofmt with one-line composite literal structs enabled 
- this CL is dependent on CL 1025008

R=r, rsc
http://go/go-review/1025009
 2009-11-06 16:33:53 -08:00
Robert Griesemer
368f8cbc75 - fine-tuning of one-line func heuristic (nodes.go) 
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)

R=r, rsc
CC=go-dev
http://go/go-review/1026006
 2009-11-06 14:24:38 -08:00
Robert Griesemer
5873598a97 updated godoc documentation 
R=r
http://go/go-review/1026007
 2009-11-06 14:00:49 -08:00
Kai Backman
fd7d803535 fix argument order bug for float 
R=rsc
http://go/go-review/1025006
 2009-11-06 13:51:17 -08:00
Kai Backman
de663b2d6b with rsc: argsize rounding to 8 smashes stack data on 32bit machines. 
R=rsc
http://go/go-review/1024011
 2009-11-06 13:50:58 -08:00
Adam Langley
db4e48ece9 big: fix carry error, add test case. 
crypto/x509: reenable tests.

R=gri
CC=go-dev
http://go/go-review/1026004
 2009-11-06 11:36:21 -08:00
Robert Griesemer
56eca9daed minor fixups by gofmt 
R=agl
http://go/go-review/1024009
 2009-11-06 11:00:06 -08:00
Adam Langley
ecf0690c01 crypto/x509: build fix for 32-bit 
TBR=rsc

R=rsc
CC=go-dev
http://go/go-review/1024007
 2009-11-06 09:23:40 -08:00
Adam Langley
17021f48f3 Fix add-back division test so that it triggers the add-back case on 
both 64 and 32 bit platforms.

Also, uncomment some tests that were still commented out from
debugging.

R=gri, rsc
CC=go-dev
http://go/go-review/1026003
 2009-11-06 09:05:19 -08:00
Kai Backman
52c549fc9b make 5g executables run on android/arm hardware. change OABI 
usage to EABI.

        go/test: passes 85% (296/347) on random android phone.

R=rsc
http://go/go-review/1024003
 2009-11-05 22:53:08 -08:00
Robert Griesemer
054354ebd4 gofmt src/cmd/goyacc 
(with this change: gofmt -l src/cmd/ | wc
is 0 0 0)

R=ken, rsc
http://go/go-review/1024005
 2009-11-05 22:29:29 -08:00
Robert Griesemer
79284cae32 gofmt'ed src/cmd 
R=rsc
http://go/go-review/1024004
 2009-11-05 22:25:46 -08:00
Robert Griesemer
07b6becc88 - fix elf.go manually so it is idempotent for gofmt 
- with this change, `gofmt -l src/pkg | wc` is 0

R=rsc
http://go/go-review/1025002
 2009-11-05 22:05:43 -08:00
Robert Griesemer
7151d2337b missing piece gofmt'ed in reflect 
R=r, rsc
http://go/go-review/1025001
 2009-11-05 18:27:30 -08:00
Robert Griesemer
45cba57e89 gofmt'ed more stragglers 
R=rsc
http://go/go-review/1019004
 2009-11-05 18:26:16 -08:00
Robert Griesemer
48b3156908 gofmt'ed big 
R=agl
http://go/go-review/1022003
 2009-11-05 18:25:23 -08:00
Robert Griesemer
7e92eedced gofmt'ed various stragglers 
R=rsc
http://go/go-review/1022002
 2009-11-05 18:24:53 -08:00
Robert Griesemer
183edddb9d gofmt'ed more stragglers 
(now down to a handfull of files in pkg)

R=rsc
http://go/go-review/1019006
 2009-11-05 18:24:24 -08:00
Robert Griesemer
0ea9dd815a gofmt the last outstanding files in src/pkg 
- added a list of issues to printer/nodes.go

R=rsc
http://go/go-review/1024002
 2009-11-05 18:14:47 -08:00
Robert Griesemer
39fd52d3a0 gofmt'ed missing regexp file 
(one-line functions will be re-established once we have all
formatted uniformly)

R=r
http://go/go-review/1023004
 2009-11-05 17:35:40 -08:00
Robert Griesemer
38006946e6 manual fix for better gofmt result 
R=r
http://go/go-review/1019005
 2009-11-05 17:27:02 -08:00
Robert Griesemer
8cd2e76404 - gofmt'ing of some stragglers, now with correct comment indentation 
in special cases
- re-gofmt'ing of some files that are now improved

R=r, rsc
http://go/go-review/1023003
 2009-11-05 17:02:55 -08:00
Robert Griesemer
6c13f8f10e fix a comment formatting bug: 
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
  see separate CL (it fixes the same issue in those files)

R=rsc
http://go/go-review/1023002
 2009-11-05 17:02:29 -08:00
Adam Langley
fa57417dbd crypto/tls (part 6/5) 
Results of running gofmt again.

R=rsc
CC=go-dev
http://go/go-review/1022006
 2009-11-05 16:59:39 -08:00
Adam Langley
eb48f83ae2 crypto/tls (part 5/5) 
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)

Add entries to the Makefile.

R=rsc
CC=go-dev
http://go/go-review/1022005
 2009-11-05 16:44:02 -08:00
Adam Langley
950f2637c2 crypto/tls (part 4/5) 
R=rsc
CC=go-dev
http://go/go-review/1019002
 2009-11-05 16:43:29 -08:00
Robert Griesemer
10242e806f gofmt'ed parts of go 
R=rsc
http://go/go-review/1023001
 2009-11-05 15:58:28 -08:00
Adam Langley
65063bc61d big: add Div, Mod, Exp, GcdExt and several other fixes. 
R=gri, rsc
CC=go-dev
http://go/go-review/1017036
 2009-11-05 15:55:41 -08:00
Adam Langley
5e598c55dc crypto/tls (part 3) 
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)

R=rsc
CC=r
http://go/go-review/1018032
 2009-11-05 15:44:32 -08:00
Robert Griesemer
d3d3accdb7 gofmt-ify io, json, runtime, encoding 
R=rsc
http://go/go-review/1017056
 2009-11-05 15:37:55 -08:00
Robert Griesemer
441e775dad gofmt'ed godefs 
R=rsc
http://go/go-review/1020001
 2009-11-05 15:35:53 -08:00
Robert Griesemer
6a4940ee23 gofmt'ed debug 
(excluding debug/gosym/symtab.go which has a small issue)

R=rsc
http://go/go-review/1019001
 2009-11-05 15:35:02 -08:00
Robert Griesemer
6f762f5410 gofmt'ed 6l 8l cgo 
R=r
http://go/go-review/1020002
 2009-11-05 15:33:26 -08:00
Robert Griesemer
b8d88a9913 gofmt-ify strings, template 
R=r
http://go/go-review/1018064
 2009-11-05 15:12:37 -08:00
Robert Griesemer
f65e42d039 gofmt-ify gob 
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)

R=r
http://go/go-review/1016056
 2009-11-05 14:53:42 -08:00
Russ Cox
790c9b59d6 codereview: new commands 
* clpatch
	* download
	* submit, on behalf of clpatch

stir hgpatch to fix a few bugs

R=r
CC=go-dev
http://go/go-review/1016051
 2009-11-05 14:44:57 -08:00
Robert Griesemer
9786b3f1bd gofmt-ify 4s, iterable 
R=rsc
http://go/go-review/1016055
 2009-11-05 14:43:03 -08:00
Robert Griesemer
2a89915485 gofmt-ify draw 
R=rsc
http://go/go-review/1017055
 2009-11-05 14:42:28 -08:00
Robert Griesemer
9e48df682c gofmt-ify eval 
R=rsc
http://go/go-review/1016054
 2009-11-05 14:41:56 -08:00
Robert Griesemer
d2af73136e gofmt-ify ogle 
R=rsc
http://go/go-review/1016053
 2009-11-05 14:30:18 -08:00
Robert Griesemer
6238964d7b gofmt-ify nacl 
R=rsc
http://go/go-review/1018062
 2009-11-05 14:29:38 -08:00
Robert Griesemer
77334b988c gofmt-ify reflect 
- the single line structs can be fixed in another round

R=rsc
http://go/go-review/1016052
 2009-11-05 14:23:20 -08:00
Robert Griesemer
666afa1c02 2nd attempt: no noIndent for string lists 
- slightly better output in general
- extra indentation where we could do without
  (however that seems better for now that not having the indentation
  where it is needed)
- no information is lost, so a future better approach can fix these
  places up again

R=rsc
http://go/go-review/1017050
 2009-11-05 14:03:56 -08:00
Ken Thompson
18cb960f3e forgot a piece of debugging 
in previous change

R=rsc
http://go/go-review/1017052
 2009-11-05 13:05:07 -08:00
Ken Thompson
505fd760a2 same speedup as 6l 
R=rsc
http://go/go-review/1016050
 2009-11-05 12:47:22 -08:00
Robert Griesemer
bd4f94057f gofmt-ify syscall 
(replacement for CL 1018053)

R=r
http://go/go-review/1017047
 2009-11-05 10:55:57 -08:00
Robert Griesemer
30c7088c95 gofmt-ify template, time, unsafe, flag, fmt 
(replacement for CLs 1017039, 1017041, 1017040, 1018054)

R=r
http://go/go-review/1018060
 2009-11-05 09:40:28 -08:00
Russ Cox
1329012a23 new command hgpatch, for use by codereview extension 
R=r
http://go/go-review/1018059
 2009-11-05 09:27:19 -08:00
Robert Griesemer
3630bfbe9f gofmt-ify math, expvar, exp/spacewar 
R=rsc
http://go/go-review/1018061
 2009-11-05 09:08:08 -08:00
Robert Griesemer
e57acdca4d gofmt-ify parts of xml 
R=rsc
http://go/go-review/1017049
 2009-11-05 08:59:03 -08:00
Robert Griesemer
12dbd06f0a gofmt-ify encoding 
R=rsc
http://go/go-review/1017048
 2009-11-05 08:55:18 -08:00
Robert Griesemer
ed494c6398 gofmt-ify sort, sync 
R=rsc
http://go/go-review/1018057
 2009-11-04 23:25:29 -08:00
Robert Griesemer
314b358ab7 gofmt-ify strconv 
(and remove an empty line at the end of a file)

R=rsc
http://go/go-review/1017046
 2009-11-04 23:20:49 -08:00
Robert Griesemer
5d37705416 gofmt-ify net 
R=rsc
http://go/go-review/1017045
 2009-11-04 23:16:46 -08:00
Robert Griesemer
7df45566db gofmt-ify image 
R=rsc
http://go/go-review/1017044
 2009-11-04 22:52:28 -08:00
Robert Griesemer
ca2a69ea06 gofmt-ify hash, http 
(gofmt will be able to re-align map entries as in http nicely,
eventually)

R=rsc
http://go/go-review/1018055
 2009-11-04 22:45:59 -08:00
Robert Griesemer
b16e6ab148 gofmt-ify tabwriter 
R=rsc
http://go/go-review/1017042
 2009-11-04 22:26:48 -08:00
Robert Griesemer
1fede304ff more comment formatting: 
- preserve (some) indentation of comment text for /*-style comments
  even if the first comment line does not contain any text that might
  suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
  (this will not introduce a lot of changes since comments of this
  kind - until now - were not changed with respect to indentation)

R=rsc
http://go/go-review/1016047
 2009-11-04 22:07:13 -08:00
Robert Griesemer
841c18a95a gofmt-ify unicode 
R=r
http://go/go-review/1018051
 2009-11-04 21:39:55 -08:00
Kai Backman
55ba9d6a2c fixing (badly) linux_arm syscall. 
R=rsc
http://go/go-review/1017037
 2009-11-04 21:34:54 -08:00
Robert Griesemer
601ee4807b - add a blank before the opening { for multi-line composites 
(request by r)
- feature temporarily disabled

R=rsc
CC=r
http://go/go-review/1018052
 2009-11-04 21:15:47 -08:00
Robert Griesemer
398f220d5b gofmt-ify os 
R=r
http://go/go-review/1017034
 2009-11-04 20:42:40 -08:00
Ken Thompson
9c7535432a speed up 6l 
hopefully no change

R=rsc
http://go/go-review/1017035
 2009-11-04 18:17:57 -08:00
Russ Cox
cc1a979272 package patch 
R=r
http://go/go-review/1018043
 2009-11-04 17:55:06 -08:00
Robert Griesemer
5fca0bca61 gofmt-ify compress 
R=rsc
http://go/go-review/1016045
 2009-11-04 17:10:18 -08:00
Robert Griesemer
b6d0a22dc5 gofmt-ify ebnf 
R=r
http://go/go-review/1018050
 2009-11-04 17:05:01 -08:00
Robert Griesemer
646a2c5a42 gofmt-ify bufio 
R=rsc
http://go/go-review/1018049
 2009-11-04 17:04:21 -08:00
Robert Griesemer
03678f7417 gofmt-ify asn1 
R=rsc
http://go/go-review/1018047
 2009-11-04 17:03:08 -08:00
Robert Griesemer
517ebbb24a gofmt-ify src/pkg/archive 
R=rsc
http://go/go-review/1018046
 2009-11-04 17:02:47 -08:00
Robert Griesemer
eabcc981c5 gofmt-ify crypto 
R=agl
CC=rsc
http://go/go-review/1017032
 2009-11-04 17:02:30 -08:00
Robert Griesemer
2ce57ec10a gofmt-ify src/pkg/go (excluding printer directory due to pending CL, 
and parser.go and scanner_test.go which have minor formatting issues)

R=rsc
http://go/go-review/1016042
 2009-11-04 17:02:05 -08:00
Robert Griesemer
26c3f6c18d rename testfiles from .go -> .orig so that they won't be 
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)

R=rsc
http://go/go-review/1018045
 2009-11-04 16:50:13 -08:00
Robert Griesemer
688a6ff71d gofmt-ify bytes 
R=r
http://go/go-review/1016044
 2009-11-04 16:49:28 -08:00
Robert Griesemer
789b31a416 better placement of /*-style comments interspersed with code on one line 
R=rsc
http://go/go-review/1017030
 2009-11-04 15:33:28 -08:00
Russ Cox
5d436b9def bytes.SplitAfter and strings.SplitAfter 
most common usage is:

	lines := strings.SplitAfter(text, "\n", 0)

R=r
http://go/go-review/1018042
 2009-11-04 15:19:30 -08:00
Russ Cox
3de3af512d doc doc doc 
R=r
http://go/go-review/1016039
 2009-11-04 15:17:36 -08:00
Rob Pike
56cba8855e panic can't print interfaces well so use err.String() 
R=rsc
http://go/go-review/1016041
 2009-11-04 15:13:16 -08:00
Robert Griesemer
2f792d32be - always format blocks with closing } on a new line, even if empty 
- at the moment this also affects single-line function declarations
  because we have disabled them at the moment (but not single-line
  function literals)

R=rsc
http://go/go-review/1016040
 2009-11-04 13:31:20 -08:00
Rob Pike
98ac4c6e65 stylistic issues in a couple of cmd docs 
R=rsc
http://go/go-review/1017028
 2009-11-04 13:13:17 -08:00
Rob Pike
0d3dd3c950 document godoc and gofmt 
R=rsc
http://go/go-review/1018036
 2009-11-04 11:33:43 -08:00