1
0
mirror of https://github.com/golang/go synced 2024-11-14 21:50:30 -07:00
Commit Graph

17898 Commits

Author SHA1 Message Date
Andrew Gerrand
43d00b0942 go1.2.2
R=rsc, bradfitz
CC=golang-codereviews, golang-dev
https://golang.org/cl/95010046
2014-05-05 10:43:37 -07:00
Andrew Gerrand
2c19e64da0 [release-branch.go1.2] doc: document go1.2.2
««« CL 100110043 / 51dc50080c9f
doc: document go1.2.2

R=rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/100110043
»»»

R=iant
CC=golang-codereviews, golang-dev
https://golang.org/cl/98960043
2014-05-05 10:21:58 -07:00
Andrew Gerrand
9c9802fad5 go1.2.1
R=minux.ma, r
CC=golang-codereviews, golang-dev
https://golang.org/cl/70650043
2014-03-03 11:53:08 +11:00
Andrew Gerrand
f4e8e6d0f8 [release-branch.go1.2] doc: document Go 1.2.1
Note the installation instructions change doesn't apply here,
so I had to patch this in manually instead of using release-apply.

R=minux.ma, r
CC=golang-codereviews, golang-dev
https://golang.org/cl/69860047
2014-03-03 11:49:00 +11:00
Russ Cox
1685fbd184 [release-branch.go1.2] runtime: fix crash in runtime.GoroutineProfile
This CL is not exactly a copy of the original quoted below.
This CL omits the changes made to mgc0.c in the original.
Those changes do not apply cleanly to the Go 1.2 tree,
and they were cosmetic, simplifying code that was already
doing the right thing.

To double-check that omitting the mgc0.c change has not
invalidated the fix, I have verified by hand that the test program
in issue 6946 fails without this CL and passes with this CL.

««« CL 41640043 / e4c381446b48
runtime: fix crash in runtime.GoroutineProfile

This is a possible Go 1.2.1 candidate.

Fixes #6946.

R=iant, r
CC=golang-dev
https://golang.org/cl/41640043
»»»

LGTM=adg
R=adg
CC=golang-codereviews, golang-dev, iant, r
https://golang.org/cl/68820045
2014-02-28 17:13:59 -05:00
Russ Cox
0d2f5c0e3b [release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change the PC
««« CL 49580044 / 38cd458b1dfe
runtime: if traceback sees a breakpoint, don't change the PC

Changing the PC confuses gdb, because execution does not
continue where gdb expects it.  Not changing the PC has the
potential to confuse a stack dump, but when running under gdb
it seems better to confuse a stack dump than to confuse gdb.

Fixes #6776.

LGTM=rsc
R=golang-codereviews, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/49580044
»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/69800043
2014-02-27 22:43:47 -05:00
Russ Cox
495b91430f [release-branch.go1.2] runtime: fix data race in GC
««« CL 52090045 / 302bdb5b08b1
runtime: fix data race in GC
Fixes #5139.
Update #7065.

R=golang-codereviews, bradfitz, minux.ma
CC=golang-codereviews
https://golang.org/cl/52090045
»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/69790043
2014-02-27 22:43:34 -05:00
Russ Cox
950555c812 [release-branch.go1.2] net: ignore some errors in windows Accept
««« CL 49490043 / 7ecbc2b8ec97
net: ignore some errors in windows Accept

Fixes #6987

R=golang-codereviews, dvyukov
CC=golang-codereviews
https://golang.org/cl/49490043
»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/69780044
2014-02-27 22:43:23 -05:00
Russ Cox
d905670c2e [release-branch.go1.2] database/sql: Use all connections in pool
««« CL 40410043 / 8a7ac002f840
database/sql: Use all connections in pool

The last connection in the pool was not being handed out correctly.

R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://golang.org/cl/40410043

»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/68820044
2014-02-27 22:43:10 -05:00
Andrew Gerrand
402d3590b5 go1.2
R=golang-dev
CC=golang-dev
https://golang.org/cl/34820044
2013-11-29 08:32:31 +11:00
Andrew Gerrand
b27c7bd7ef [release-branch.go1.2] doc/install.html: fix a tag.
««« CL 30900044 / 65bf677ab8d8
doc/install.html: fix a tag.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/30900044

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/34860044
2013-11-29 07:05:05 +11:00
Andrew Gerrand
a04e34923c [release-branch.go1.2] misc/vim: describe how to get gofmt-on-save behaviour.
««« CL 31770043 / 286f0ddb799b
misc/vim: describe how to get gofmt-on-save behaviour.

Fixes #6826.

R=golang-dev, bradfitz, adg
CC=golang-dev
https://golang.org/cl/31770043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/34960043
2013-11-29 07:04:23 +11:00
Andrew Gerrand
e9dc28b0de [release-branch.go1.2] README: Fix installation instructions
««« CL 28500043 / 1140207a3395
README: Fix installation instructions
They were out of date and should refer to the source installation instructions.

Fixes #6783.

R=golang-dev, rsc, adg, dave
CC=golang-dev
https://golang.org/cl/28500043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/34880045
2013-11-29 07:03:43 +11:00
Andrew Gerrand
f0a85350e7 [release-branch.go1.2] doc: update installation instructions
««« CL 28700043 / 8b3699321603
doc: update installation instructions

Clarify that GOROOT should only be set when using a custom install path.
Remove NetBSD from binary install page (we don't provide binaries).
Remove "What's next" links from installation instructions.
Emphasize "How to Write Go Code" page.

Fixes #6613.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/28700043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/34950043
2013-11-29 07:03:02 +11:00
Andrew Gerrand
4abdb873be go1.2rc5
R=dsymonds
CC=golang-dev
https://golang.org/cl/28140043
2013-11-18 12:44:03 +11:00
Andrew Gerrand
1ca6226dda [release-branch.go1.2] C: add Marko Mikulicic (Google CLA)
««« CL 27000043 / c8d3de543c1b
C: add Marko Mikulicic (Google CLA)

R=golang-dev, crawshaw
CC=golang-dev
https://golang.org/cl/27000043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/28130043
2013-11-18 12:41:48 +11:00
Andrew Gerrand
6d8aa1bcbb [release-branch.go1.2] doc/asm: more about SP, ARM R11
««« CL 26170043 / b1edf8faa5d6
doc/asm: more about SP, ARM R11

Also rename URL to /doc/asm.

R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/26170043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/28120043
2013-11-18 12:40:54 +11:00
Andrew Gerrand
0bb20c6189 [release-branch.go1.2] encoding/gob: do not use MarshalText, UnmarshalText
««« CL 22770044 / 23fc3139589c
encoding/gob: do not use MarshalText, UnmarshalText

This seems to be the best of a long list of bad ways to fix this issue.

Fixes #6760.

R=r
CC=golang-dev
https://golang.org/cl/22770044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/28110043
2013-11-18 12:40:00 +11:00
Andrew Gerrand
3409e2a2e6 [release-branch.go1.2] encoding/gob: expose encode/decode example
««« CL 26220045 / d76ade89413f
encoding/gob: expose encode/decode example

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/26220045
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25380044
2013-11-18 12:38:31 +11:00
Andrew Gerrand
a5940dddba go1.2rc4
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/25420045
2013-11-13 15:29:48 +11:00
Andrew Gerrand
8a28f58bc9 [release-branch.go1.2] src/cmd/?a: link to new assembler document
««« CL 18430044 / 1a86e8314ff5
src/cmd/?a: link to new assembler document
Blocked on 20930043, the CL the new text references.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/18430044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25480046
2013-11-13 15:17:48 +11:00
Andrew Gerrand
af4b9ae6e1 [release-branch.go1.2] doc/asm.html: new document, a brief guide to the assembler
««« CL 20930043 / 5a585f237d28
doc/asm.html: new document, a brief guide to the assembler

Fixes #6060

R=golang-dev, iant, bradfitz, josharian, minux.ma, aram, rsc
CC=golang-dev
https://golang.org/cl/20930043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25820043
2013-11-13 15:13:59 +11:00
Andrew Gerrand
61af4f905b [release-branch.go1.2] spec: clarify rules for blank identifiers
««« CL 14415043 / 4daa80747394
spec: clarify rules for blank identifiers

This documents the status quo more precisely.
Not a language change.

Fixes #6006.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/14415043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25790043
2013-11-13 14:40:41 +11:00
Andrew Gerrand
cd618b24a6 [release-branch.go1.2] doc: use the same wording for OS X as the other OSes
««« CL 25670043 / b7308814101a
doc: use the same wording for OS X as the other OSes

I used "and above" when I should have said "or later".

Sorry for the churn.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/25670043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25780043
2013-11-13 14:39:53 +11:00
Andrew Gerrand
268d4631ae [release-branch.go1.2] doc: we support all recent versions of OS X
««« CL 25370045 / d809ded6f335
doc: we support all recent versions of OS X

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/25370045
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25580044
2013-11-13 14:39:07 +11:00
Andrew Gerrand
2b6571cdfa [release-branch.go1.2] CONTRIBUTORS: add additional e-mail address for Richard Musiol
««« CL 25360043 / 37afbf6361e2
CONTRIBUTORS: add additional e-mail address for Richard Musiol

R=adonovan
CC=golang-dev
https://golang.org/cl/25360043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25770043
2013-11-13 14:38:19 +11:00
Andrew Gerrand
02c5ab4f87 [release-branch.go1.2] A+C: Richard Musiol (individual CLA)
««« CL 25350043 / d3cc963320cd
A+C: Richard Musiol (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/25350043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25670044
2013-11-13 14:37:32 +11:00
Andrew Gerrand
9af8f45258 [release-branch.go1.2] misc/vim: add a gofmt_command flag for :Fmt
««« CL 22940044 / 39c724dd7f25
misc/vim: add a gofmt_command flag for :Fmt

R=dsymonds, dominik.honnef, n13m3y3r, rsc, kamil.kisiel
CC=golang-dev
https://golang.org/cl/22940044

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25760043
2013-11-13 14:36:45 +11:00
Andrew Gerrand
021476db3b [release-branch.go1.2] cmd/godoc: document package-level examples
««« CL 23940043 / 6ad0ec54cf2d
cmd/godoc: document package-level examples

Fixes  issue  5807 .

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/23940043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25500045
2013-11-13 14:35:59 +11:00
Andrew Gerrand
1c961995ae [release-branch.go1.2] misc/emacs: various cleanups
««« CL 20100043 / 9fe43a708b89
misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

This is identical to CL 19010044 with one exception: Making sure
it doesn't break on Emacs 22.1

R=adonovan, bradfitz, shendaras
CC=golang-dev
https://golang.org/cl/20100043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25750043
2013-11-13 14:35:13 +11:00
Andrew Gerrand
1bca9371e7 [release-branch.go1.2] emacs: allow users to customize the gofmt command, in particular, to use goimports instead.
««« CL 23680043 / 341a490e4736
emacs: allow users to customize the gofmt command, in particular, to use goimports instead.

R=adonovan
CC=golang-dev
https://golang.org/cl/23680043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25740043
2013-11-13 14:34:24 +11:00
Andrew Gerrand
6ec8f31510 [release-branch.go1.2] cmd/cgo: fix handling of array of pointers when using clang
««« CL 22840043 / e6794866ebeb
cmd/cgo: fix handling of array of pointers when using clang

Clang does not record the "size" field for pointer types,
so we must insert the size ourselves. We were already
doing this, but only for the case of pointer types.
For an array of pointer types, the setting of the size for
the nested pointer type was happening after the computation
of the size of the array type, meaning that the array type
was always computed as 0 bytes. Delay the size computation.

This bug happens on all Clang systems, not just FreeBSD.
Our test checked that cgo wrote something, not that it was correct.
FreeBSD's default clang rejects array[0] as a C struct field,
so it noticed the incorrect sizes. But the sizes were incorrect
everywhere.

Update testcdefs to check the output has the right semantics.

Fixes #6292.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/22840043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25460046
2013-11-13 14:33:38 +11:00
Andrew Gerrand
f0189653ca [release-branch.go1.2] doc: update note about GCC 4.8.2 in gccgo instructions
««« CL 22510043 / 77e77f508509
doc: update note about GCC 4.8.2 in gccgo instructions

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/22510043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25730043
2013-11-13 14:32:47 +11:00
Andrew Gerrand
f7edec22f7 [release-branch.go1.2] go/doc: add full stop of Japanese, Chinese and Korean.
««« CL 21130043 / 0685a9549d5a
go/doc: add full stop of Japanese, Chinese and Korean.

This fix will show a good synopsis on package listings in that languages.

R=adg, r
CC=golang-dev
https://golang.org/cl/21130043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25720043
2013-11-13 14:31:58 +11:00
Andrew Gerrand
9cb593dc89 [release-branch.go1.2] A+C: Ato Araki (individual CLA)
««« CL 21790043 / cbbdbdf908b9
A+C: Ato Araki (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/21790043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25640046
2013-11-13 14:31:09 +11:00
Andrew Gerrand
db1c08e7a1 [release-branch.go1.2] doc/go1.2: link to cgo documentation
««« CL 21770043 / ae58065f7dff
doc/go1.2: link to cgo documentation

I know it's linked in the previous sentence, but this new link is where I want it to be while reading this sentence.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/21770043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25640045
2013-11-13 14:30:20 +11:00
Andrew Gerrand
4f8794d3e7 [release-branch.go1.2] net/textproto: fix CanonicalMIMEHeaderKey panic
««« CL 21450043 / e081962da65c
net/textproto: fix CanonicalMIMEHeaderKey panic

Fixes #6712

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/21450043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25640044
2013-11-13 14:29:35 +11:00
Andrew Gerrand
065f8fd5a7 [release-branch.go1.2] C: add Robert Snedegar (Google CLA)
««« CL 21390044 / dc2762a9130d
C: add Robert Snedegar (Google CLA)

R=golang-dev
CC=golang-dev
https://golang.org/cl/21390044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25420044
2013-11-13 14:28:46 +11:00
Andrew Gerrand
e491f0c376 [release-branch.go1.2] C: add Brad Garcia (Google CLA)
««« CL 19990045 / 78cebfb89b21
C: add Brad Garcia (Google CLA)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/19990045
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/25700044
2013-11-13 14:27:59 +11:00
Andrew Gerrand
2eb51b1ba8 go1.2rc3
R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/19560047
2013-11-01 12:44:30 +11:00
Andrew Gerrand
4708b76f84 [release-branch.go1.2] cmd/5l, runtime: fix divide for profiling tracebacks on ARM
««« CL 19910044 / 9eb64f5ef3a6
cmd/5l, runtime: fix divide for profiling tracebacks on ARM

Two bugs:
1. The first iteration of the traceback always uses LR when provided,
which it is (only) during a profiling signal, but in fact LR is correct
only if the stack frame has not been allocated yet. Otherwise an
intervening call may have changed LR, and the saved copy in the stack
frame should be used. Fix in traceback_arm.c.

2. The division runtime call adds 8 bytes to the stack. In order to
keep the traceback routines happy, it must copy the saved LR into
the new 0(SP). Change

        SUB $8, SP

into

        MOVW    0(SP), R11 // r11 is temporary, for use by linker
        MOVW.W  R11, -8(SP)

to update SP and 0(SP) atomically, so that the traceback always
sees a saved LR at 0(SP).

Fixes #6681.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/19910044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20170048
2013-11-01 11:34:40 +11:00
Andrew Gerrand
1d78c86897 [release-branch.go1.2] doc/go1.2.html: delete repeated word
««« CL 19840043 / 938b64b0f608
doc/go1.2.html: delete repeated word
TBR=rsc

R=golang-dev
CC=golang-dev
https://golang.org/cl/19840043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20240044
2013-11-01 11:33:51 +11:00
Andrew Gerrand
28c1081208 [release-branch.go1.2] doc/go1.2.html: stack sizes, thread limits
««« CL 19600043 / 746466b52725
doc/go1.2.html: stack sizes, thread limits

R=golang-dev, minux.ma, adg, rsc
CC=golang-dev
https://golang.org/cl/19600043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20110046
2013-11-01 11:33:03 +11:00
Andrew Gerrand
8648d26c5f [release-branch.go1.2] cmd/cgo: accept extra leading _ on __cgodebug_data for all object formats
««« CL 19780043 / 8b49cdda6ff4
cmd/cgo: accept extra leading _ on __cgodebug_data for all object formats

The current Windows build breakage appears to be because
the Windows code should be looking for __cgodebug_data
not ___cgodebug_data. Dodge the question everywhere by
accepting both.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/19780043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20660043
2013-11-01 11:32:10 +11:00
Andrew Gerrand
63ff715a55 [release-branch.go1.2] database/sql: document Result methods
««« CL 19280046 / 2ad8ac71220d
database/sql: document Result methods

Fixes #5110

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/19280046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20650043
2013-11-01 11:31:18 +11:00
Andrew Gerrand
6d10afd9e5 [release-branch.go1.2] database/sql: Fix typos in doc
««« CL 17590043 / fb5224487f1b
database/sql: Fix typos in doc

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/17590043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20150046
2013-11-01 11:30:30 +11:00
Andrew Gerrand
89f0148955 [release-branch.go1.2] A+C: Jakob Borg (individual CLA).
««« CL 19510043 / ae106f792e5d
A+C: Jakob Borg (individual CLA).

R=golang-dev
CC=golang-dev
https://golang.org/cl/19510043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20570045
2013-11-01 11:29:41 +11:00
Andrew Gerrand
842a18c28f [release-branch.go1.2] time: correct path to time zone zip file on Unix
««« CL 19280043 / 9d199c7582d6
time: correct path to time zone zip file on Unix

Most Unix systems have their own time zone data,
so we almost never get far enough in the list to
discover that we cannot fall back to the zip file.
Adjust testing to exercise the final fallback.

Plan 9 and Windows were already correct
(and are the main users of the zip file).

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/19280043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20640043
2013-11-01 11:28:57 +11:00
Andrew Gerrand
6ab0f588a8 [release-branch.go1.2] encoding/xml: fix doc comment
««« CL 19300046 / 5ac568b9d67b
encoding/xml: fix doc comment

The tag is ",chardata" not "chardata".

Fixes #6631.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/19300046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20060045
2013-11-01 11:28:07 +11:00
Andrew Gerrand
71b3aca9fa [release-branch.go1.2] net/http/httputil: fix DumpRequestOut with ContentLength & false body param
««« CL 14920050 / 5ed8c82778ae
net/http/httputil: fix DumpRequestOut with ContentLength & false body param

Fixes #6471

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14920050
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20590044
2013-11-01 11:27:19 +11:00