qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 09:14:46 -07:00
Code Releases Activity
4,315 Commits 58 Branches 402 Tags 522 MiB
3b858fb808
Commit Graph

881 Commits

Author SHA1 Message Date
Russ Cox
a274099340 big: implement 386 assembly routines 
7x speedup on big and crypto/rsa unit tests.
also dropped useAsm in favor of making the
asm stubs jump to the Go versions.

R=agl1
CC=golang-dev, gri
https://golang.org/cl/157062
 2009-11-18 09:54:51 -08:00
William Josephson
4c0f262a2d Remove unnecessary execute bits. 
R=rsc
https://golang.org/cl/156077
 2009-11-18 09:19:29 -08:00
Devon H. O'Dell
659780b643 Add an intptr type to runtime; needed in FreeBSD 
In thread.c, we need to cast to whatever the native
size of intptr is on the system, but we only have
uintptr available. They're the same size, but can't
do signed casts without this one :).

R=rsc
CC=golang-dev
https://golang.org/cl/156073
 2009-11-18 09:11:39 -08:00
Devon H. O'Dell
b3f538a4fd FreeBSD/i386 work 
This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.

R=rsc
https://golang.org/cl/157055
 2009-11-17 23:58:51 -08:00
Russ Cox
744d5ae48a runtime: add ARM memmove 
R=ken2
https://golang.org/cl/156063
 2009-11-17 22:54:20 -08:00
Russ Cox
ed0beea27b copy tweaks 
* move memmove to arch-specific subdirectories
  * add memmove for arm
  * add copyright notices marking them as copied from Inferno

R=ken2
https://golang.org/cl/156061
 2009-11-17 22:16:55 -08:00
Rob Pike
ea5cc6c021 add a test for %+v in nested structures. 
threw in an embedded one for good measure.

R=rsc
CC=golang-dev
https://golang.org/cl/157058
 2009-11-17 22:14:34 -08:00
Russ Cox
41554e2528 runtime: two trivial but important bug fixes 
R=r
https://golang.org/cl/156059
 2009-11-17 22:00:30 -08:00
Ken Thompson
948f3e77e1 bug in copy 
R=rsc
https://golang.org/cl/156056
 2009-11-17 20:44:35 -08:00
Ken Thompson
c4606d05da install copy predefined 
did not test 386, but should work
shouldnt matter if copy is not used

R=rsc
https://golang.org/cl/156055
 2009-11-17 20:41:44 -08:00
Adam Langley
a8ba40823c crypto/rsa: add PKCS#1 v1.5 signature support. 
R=rsc
CC=golang-dev
https://golang.org/cl/156051
 2009-11-17 18:21:47 -08:00
Adam Langley
80b7f6a8d4 asn1: 
* add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

R=rsc
CC=golang-dev
https://golang.org/cl/156047
 2009-11-17 18:09:41 -08:00
Russ Cox
1dbd3c8d3d reflect: document that PkgPath and Name return 
empty string for unnamed types.

Fixes #249.

R=r
https://golang.org/cl/156052
 2009-11-17 16:03:14 -08:00
Russ Cox
849e6f99b8 http: do not crash accessing r.Form if ParseForm fails 
Fixes #233.

R=dsymonds1
https://golang.org/cl/154179
 2009-11-17 14:45:10 -08:00
Russ Cox
4dfd7fdde5 runtime: do not create new threads during malloc. 
the signal handling stack is a different size than
	the normal stack, so it cannot be allocated using
	the backup stack allocator.

Fixes #250.

R=agl1
CC=golang-dev
https://golang.org/cl/157044
 2009-11-17 14:42:08 -08:00
Rob Pike
6240b0110a improve documentation of runtime. there was no mention of types. 
R=rsc
CC=golang-dev
https://golang.org/cl/157042
 2009-11-17 11:44:15 -08:00
Aron Nopanen
c51ee432d1 Make non-errored RPC calls return 'nil' error to caller. 
Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.

This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.

Tests updated to check error return in success cases.

R=r, rsc
https://golang.org/cl/154159
 2009-11-17 11:29:02 -08:00
Russ Cox
b4586a7429 math: fix argument names in Atan2 
(error introduced converting from arg1, arg2)

Fixes #220.

R=r
https://golang.org/cl/156041
 2009-11-17 08:39:56 -08:00
Russ Cox
6e788e0f0f net: enforce timeouts for ReadFrom/WriteTo 
Fixes #153.

R=r
https://golang.org/cl/154177
 2009-11-17 08:39:17 -08:00
Russ Cox
a65bf95dd8 syscall: use correct pointer in recvfrom/sendto. 
linux/386 stack trace: use 32-bit hex.

Fixes #159.

R=r
https://golang.org/cl/154178
 2009-11-17 08:39:04 -08:00
Devon H. O'Dell
0489a260da FreeBSD-specific porting work. 
cgo/libmach remain unimplemented. However, compilers, runtime,
and packages are 100%. I still need to go through and implement
missing syscalls (at least make sure they're all listed), but
for all shipped functionality, this is done. Ship! ;)

R=rsc, VenkateshSrinivas
https://golang.org/cl/152142
 2009-11-17 08:20:58 -08:00
Rob Pike
30b1b9a36a Rework gobs to fix bad bug related to sharing of id's between encoder and decoder side. 
Fix is to move all decoder state into the decoder object.

Fixes #215.

R=rsc
CC=golang-dev
https://golang.org/cl/155077
 2009-11-16 23:32:30 -08:00
Rob Pike
50c04132ac fix bug causing empty strings to be become non-nil errors on client side of rpc connection. 
R=rsc
CC=golang-dev
https://golang.org/cl/155078
 2009-11-16 23:32:16 -08:00
Russ Cox
597b2a91a6 runtime: make signal handler work on 386 
R=r
https://golang.org/cl/154171
 2009-11-16 17:51:47 -08:00
Adam Langley
1cdfe9fa28 unsafe: documentation typo. 
Fixes #236.

R=r
CC=golang-dev
https://golang.org/cl/155072
 2009-11-16 15:39:04 -08:00
David Symonds
affcfe5a75 Add some primitive type aliases to exp/iterable and define Iter on them. 
R=rsc
https://golang.org/cl/155065
 2009-11-16 13:39:59 -08:00
David G. Andersen
37f71e8ad6 An asked-for-in #go-nuts extension to quickly create a repeated 
copy of a string or a byte array.
        strings.Repeat("-", 50)
	bytes.Repeat(b, 99)

R=rsc
https://golang.org/cl/155063
 2009-11-16 12:40:01 -08:00
Adam Langley
391e082ca9 crypto/md5: fix comment typo. 
Fixes #210.

R=rsc
CC=golang-dev
https://golang.org/cl/155057
 2009-11-15 14:00:46 -08:00
Russ Cox
091191336a runtime: avoid crash in Caller 
Fixes #176.

R=r
https://golang.org/cl/154146
 2009-11-15 12:57:15 -08:00
Russ Cox
a338231526 gc: five bug fixes, one better error. 
* check for struct literal assignment to private fields.
* record, fix crash involving parallel map assignment.
* avoid infinite recursion in exportassignok.
* make floating point bounds check precise.
* avoid crash on invalid receiver.

* add context to error about implicit assignment.

Fixes #86.
Fixes #88.
Fixes #158.
Fixes #174.
Fixes #201.
Fixes #204.

R=ken2
https://golang.org/cl/154144
 2009-11-15 12:57:09 -08:00
Russ Cox
a967f57d19 http.URLEscape: escape all bytes required by RFC 2396 
Fixes #125.

R=r
https://golang.org/cl/154143
 2009-11-15 12:56:50 -08:00
Rob Pike
27779dd6cb fix bug in bytes.Map and add test cases for Map in both strings and bytes packages. 
thanks to ulrik.sverdrup for the test case.

Fixes #191.

R=rsc
CC=golang-dev
https://golang.org/cl/155056
 2009-11-15 12:07:27 -08:00
Adam Langley
ad05d29103 crypto/rsa: handle the case of non-coprime blinds. 
We are dealing with the multiplicative group ℤ/pqℤ. Multiples of
either p or q are not members of the group since they cannot have an
inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.)

With p and q of typical size (> 512 bits), the probability of a random
blind [1..pq-1] being a multiple of p or q is negligible. However, in
the unit tests, much smaller sizes are used and the event could occur.

This change checks the result of the ext GCD and deals with this case.

It also increases the size of p and q in the unit test as a large
number of the keys selected were p, q = 227,169.

R=rsc
CC=golang-dev
https://golang.org/cl/154141
 2009-11-14 20:38:00 -08:00
Devon H. O'Dell
553be8427e Build changes to support work on the BSDs. 
This does still contain some FreeBSD-specific bits, but
it's a pain to do partial diffs.

R=rsc
https://golang.org/cl/152138
 2009-11-14 15:29:09 -08:00
Môshe van der Sterre
a54684f8da encoding/binary: implemented the Write function 
The ByteOrder.Put* methods are already available, this change uses
them to implement the Write function.

R=golang-dev, agl1, rsc, r
https://golang.org/cl/152141
 2009-11-14 14:42:22 -08:00
Rob Pike
0263103a05 move evaluation of null-matching instructions one iteration earlier. 
performance hit of about 20% but more intuitive results for submatches.
we need a good regexp package at some point.

Fixes #110.

R=rsc
CC=golang-dev
https://golang.org/cl/152131
 2009-11-14 12:23:24 -08:00
Abhinav Gupta
bad9738be6 xml: Fixed CDATA parsing. 
Fixes #128.

R=r, rsc
https://golang.org/cl/154126
 2009-11-14 11:46:09 -08:00
Russ Cox
933d1850ce typos 
Fixes #171.
Fixes #172.

R=agl1
https://golang.org/cl/154136
 2009-11-14 10:28:53 -08:00
David Titarenco
aebae2577a Created new Conn.Flush() public method so the fd pipeline can be drained arbitrarily by the user. 
Commented both flush methods so people know what they are looking at.

This is a necessary fix for streaming and long polling HTTP services.
Fixes #93.

R=r, rsc, david.titarenco
https://golang.org/cl/154099
 2009-11-13 18:06:47 -08:00
Nigel Tao
75829b3c51 Remove unnecessary int(h) casts in image.go. 
R=rsc
https://golang.org/cl/154125
 2009-11-13 17:40:20 -08:00
Adam Langley
a070722340 json: minor comment fix. 
I screwed up and didn't write one of the code review changes to disk
before submitting.

TBR=rsc

R=rsc
https://golang.org/cl/154122
 2009-11-13 14:59:04 -08:00
Rob Pike
f9919ba323 Explain why 
-flag true
does not work although
	-flag=true
does.

Fixes #139.

R=iant
CC=golang-dev
https://golang.org/cl/154118
 2009-11-13 13:15:18 -08:00
Adam Langley
bccc337084 json: allow one to unmarshal a top-level JSON array. 
Fixies issue 114.

R=rsc
CC=golang-dev
https://golang.org/cl/154121
 2009-11-13 13:00:45 -08:00
Russ Cox
e7b8f5faca path.TestWalk: disable error case if root 
(chmod 0 doesn't cause errors for root)

Fixes #22.

R=gri
https://golang.org/cl/152120
 2009-11-13 11:34:33 -08:00
Adam Langley
87bc9b53fd json: fix addressing of slice indexes that are multiples of 8. 
Fixes #147.

R=rsc
CC=golang-dev
https://golang.org/cl/152123
 2009-11-13 11:29:13 -08:00
Adam Langley
3f7a32405d runtime: warn about SELinux based mmap failures on Linux. 
SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.

This patch prints a warning on Linux when mmap fails with EACCES.

R=rsc
CC=golang-dev
https://golang.org/cl/152086
 2009-11-13 10:08:51 -08:00
Rob Pike
845276ae68 remove dead code from test 
R=rsc
CC=golang-dev
https://golang.org/cl/152118
 2009-11-12 23:35:45 -08:00
Kai Backman
a23746ea65 fix style nit ignored in previous cl 
R=rsc
https://golang.org/cl/152110
 2009-11-12 16:12:28 -08:00
Kai Backman
6a48aab747 add support for pre arm v6 cas. set GOARM=5 to enable. 
R=rsc
https://golang.org/cl/154101
 2009-11-12 15:23:23 -08:00
Russ Cox
b0c7d68052 os.TestSeek: use a smaller but still 64-bit seek offset. 
Might fix issue 91.

R=r
https://golang.org/cl/152108
 2009-11-12 14:55:04 -08:00
Adam Langley
454c621d91 exp/draw: correct Makefile. 
Thanks to Allister Macleod

Fixes #112.

R=rsc
CC=golang-dev
https://golang.org/cl/152102
 2009-11-12 13:55:20 -08:00
Kai Backman
6dbd142951 add cache flushing call after generating closure. 
go/test: passes 88% (306/347)

R=rsc
https://golang.org/cl/152089
 2009-11-11 23:23:11 -08:00
David Symonds
9e829c42d6 Fix capitalisation of "Git". 
R=rsc
https://golang.org/cl/154071
 2009-11-11 17:31:28 -08:00
Robert Griesemer
23843fa49e vector: s/Element/interface{}/ 
Fixes #74.

R=rsc
https://golang.org/cl/154073
 2009-11-11 17:25:51 -08:00
Adam Langley
3b092fec36 json: support \u escaping in strings 
Fixes #73.

R=rsc
CC=golang-dev
https://golang.org/cl/154072
 2009-11-11 17:13:14 -08:00
Russ Cox
2cda46dc82 fix TestRemoveAll again (tested as root this time). 
Fixes #22.

R=r
https://golang.org/cl/154069
 2009-11-11 15:48:38 -08:00
Russ Cox
f07a9e43e8 os test: do not use symlink > 255 bytes. 
Fixes #62.

R=r
https://golang.org/cl/152080
 2009-11-11 14:52:29 -08:00
Adam Langley
1941855730 Reland a112249da741, this time with missing file. 2009-11-11 13:21:37 -08:00
Russ Cox
8515a9f4e2 log test: don't assume a fixed set of letters for $GOROOT 
Fixes #27.

R=r
https://golang.org/cl/152075
 2009-11-11 13:07:46 -08:00
Russ Cox
ed86d0e70a roll back 3985: build is broken 
TBR=agl1
CC=golang-dev
https://golang.org/cl/154065
 2009-11-11 12:54:52 -08:00
Adam Langley
af1fa43a81 big: 
Turn methods that don't store the result in their receiver into
    functions in order to preserve the convention.
  Re-jig Exp and Div by moving their guts into nat.go.
  Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.

R=gri
CC=go-dev
http://codereview.prom.corp.google.com/1024038
 2009-11-11 12:34:46 -08:00
Russ Cox
1971e1bd21 os: do not test error case of TestRemoveAll when root 
Fixes #22.

R=r1, r
https://golang.org/cl/152073
 2009-11-11 12:00:34 -08:00
Russ Cox
364e564e3d use fully qualified names for hash interfaces 
Fixes #38.

R=r1, r
https://golang.org/cl/152072
 2009-11-11 12:00:15 -08:00
Russ Cox
fe1e49241c update old comment: things are much better now 
R=r
https://golang.org/cl/152057
 2009-11-10 19:59:22 -08:00
Russ Cox
92a9ddf0fa net: fix error for connect to /etc/ on some systems 
R=agl1
CC=golang-dev
https://golang.org/cl/152051
 2009-11-10 18:27:26 -08:00
Russ Cox
e23f75b3c4 net: disable more ipv6 tests 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153050
 2009-11-10 18:00:27 -08:00
Russ Cox
b4a8b353c4 net: disable ipv6 test if we know kernel won't take it. 
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153048
 2009-11-10 17:47:38 -08:00
Russ Cox
9dba695692 net: disable dns error test 
some dns resolvers (opendns, for example)
are willing to make up results for any name.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
 2009-11-10 17:39:01 -08:00
Russ Cox
484f46daea net: fix dns bug reported on irc. 
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.

tested by tossing domain and search lines from /etc/resolv.conf

Fixes #2.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
 2009-11-10 17:09:33 -08:00
Robert Griesemer
9e0d2fa89b better code for a copy loop 
R=rsc
https://golang.org/cl/152046
 2009-11-10 15:33:59 -08:00
Ken Thompson
c90d392ce3 spell it with an "e" 
R=rsc
http://go/go-review/1025037
 2009-11-10 15:05:15 -08:00
Robert Griesemer
b27f05f63b minor adjustments to package comments for better synopsis. 
R=rsc
CC=r
http://go/go-review/1026038
 2009-11-10 10:55:53 -08:00
Russ Cox
b351113b50 make regexp comment not a package comment 
R=r
http://go/go-review/1025036
 2009-11-10 09:36:48 -08:00
Russ Cox
cb94b60cfb allow user agent to mention Go. 
R=r
http://go/go-review/1024046
 2009-11-10 09:10:08 -08:00
Robert Griesemer
3d668c1b5d - minor cleanups 
- better debugging support
- gofmt -l src misc | wc -l is 0

R=rsc
http://go/go-review/1024042
 2009-11-09 22:30:07 -08:00
Robert Griesemer
3bb0032cd6 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)

R=rsc, r
http://go/go-review/1024041
 2009-11-09 21:23:52 -08:00
Robert Griesemer
baba292998 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
	- applied gofmt -w misc src
	- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1026036
 2009-11-09 21:13:17 -08:00
Robert Griesemer
1698934194 - replaced gofmt expression formatting algorithm with 
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1024040
 2009-11-09 21:09:34 -08:00
Robert Griesemer
40621d5c0d remove semis after statements in one-statement statement lists 
R=rsc, r
http://go/go-review/1025029
 2009-11-09 12:07:39 -08:00
Robert Griesemer
81672e79e4 - rename Context to exprContext to remove it from public interface 
(and to match the style of declContext)

R=rsc
http://go/go-review/1024033
 2009-11-09 10:37:36 -08:00
Robert Griesemer
53f485813e fix for nodeSize computation, used to determine if 
a node fits on one line:
- for purposes of measuring the node size in text,
  don't generate html or use a styler that could
  generate html as it will lead to overly large
  sizes

A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.

This change causes no difference to the gofmt formatting
of any files in src or misc.

R=rsc
http://go/go-review/1026034
 2009-11-09 09:34:55 -08:00
Russ Cox
71983af4a1 bug212, bug213. 
R=ken
http://go/go-review/1026032
 2009-11-08 23:22:06 -08:00
Rob Pike
e02f2b51c5 delete a pointless todo in all_test.go. 
address one in rpc/client.go

R=rsc
CC=go-dev
http://go/go-review/1026030
 2009-11-08 21:57:59 -08:00
Russ Cox
ed6eb5b577 a nagging inconsistency: capitalization of 
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.

R=r
CC=go-dev
http://go/go-review/1024026
 2009-11-08 21:46:20 -08:00
Russ Cox
830813f019 assorted cleanup 
R=r, iant
CC=go-dev
http://go/go-review/1025024
 2009-11-08 21:08:27 -08:00
Rob Pike
ceb6031ecd delete TODO now that compiler is better at % 
adjust an inconsistency in reflect/type.go's package comment

R=rsc
http://go/go-review/1026029
 2009-11-08 20:45:39 -08:00
Rob Pike
40a7db3ee9 add top-level package comments for net, reflect, malloc. 
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.

R=gri, rsc
CC=go-dev
http://go/go-review/1026026
 2009-11-08 15:57:25 -08:00
Robert Griesemer
56b4515740 added package documentation 
R=r, rsc
http://go/go-review/1025023
 2009-11-08 15:04:30 -08:00
Robert Griesemer
1a9805adcb - avoid division-by-zero crash in tabwriter 
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing

R=rsc
http://go/go-review/1026022
 2009-11-07 23:59:24 -08:00
Vish Subramanian
379150c210 Add flags of type float to the flag package. 
R=r, rsc
http://go/go-review/1026011
 2009-11-07 15:52:27 -08:00
Robert Griesemer
3317697df4 - blank before opening { for multi-line composite literals (as preferred by r) 
- blank padding around composite literal contents for a less dense look
  (most if not all composite literals were written in that style before gofmt
  ran through them)
- corresponding (internal) flag: compositeLitBlank

- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis

- the number of changes in nodes.go is huge because of the removed semis;
  hg mail requires that I gofmt the file before

With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.

R=rsc, r
http://go/go-review/1025015
 2009-11-07 13:01:52 -08:00
David Symonds
6ea866c04b Typo fixes. 
R=rsc
CC=go-dev
http://go/go-review/1026014
 2009-11-06 18:43:57 -08:00
Robert Griesemer
832ce7c1d2 format composite literal types that are "short" struct type literals 
on one line for a more compact representation of some composite Literals

R=rsc
http://go/go-review/1025008
 2009-11-06 16:34:19 -08:00
Robert Griesemer
a05a5465c8 - application of gofmt with one-line composite literal structs enabled 
- this CL is dependent on CL 1025008

R=r, rsc
http://go/go-review/1025009
 2009-11-06 16:33:53 -08:00
Robert Griesemer
368f8cbc75 - fine-tuning of one-line func heuristic (nodes.go) 
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)

R=r, rsc
CC=go-dev
http://go/go-review/1026006
 2009-11-06 14:24:38 -08:00
Adam Langley
db4e48ece9 big: fix carry error, add test case. 
crypto/x509: reenable tests.

R=gri
CC=go-dev
http://go/go-review/1026004
 2009-11-06 11:36:21 -08:00
Robert Griesemer
56eca9daed minor fixups by gofmt 
R=agl
http://go/go-review/1024009
 2009-11-06 11:00:06 -08:00
Adam Langley
ecf0690c01 crypto/x509: build fix for 32-bit 
TBR=rsc

R=rsc
CC=go-dev
http://go/go-review/1024007
 2009-11-06 09:23:40 -08:00
Adam Langley
17021f48f3 Fix add-back division test so that it triggers the add-back case on 
both 64 and 32 bit platforms.

Also, uncomment some tests that were still commented out from
debugging.

R=gri, rsc
CC=go-dev
http://go/go-review/1026003
 2009-11-06 09:05:19 -08:00
Kai Backman
52c549fc9b make 5g executables run on android/arm hardware. change OABI 
usage to EABI.

        go/test: passes 85% (296/347) on random android phone.

R=rsc
http://go/go-review/1024003
 2009-11-05 22:53:08 -08:00
Robert Griesemer
07b6becc88 - fix elf.go manually so it is idempotent for gofmt 
- with this change, `gofmt -l src/pkg | wc` is 0

R=rsc
http://go/go-review/1025002
 2009-11-05 22:05:43 -08:00
Robert Griesemer
7151d2337b missing piece gofmt'ed in reflect 
R=r, rsc
http://go/go-review/1025001
 2009-11-05 18:27:30 -08:00
Robert Griesemer
45cba57e89 gofmt'ed more stragglers 
R=rsc
http://go/go-review/1019004
 2009-11-05 18:26:16 -08:00
Robert Griesemer
48b3156908 gofmt'ed big 
R=agl
http://go/go-review/1022003
 2009-11-05 18:25:23 -08:00
Robert Griesemer
7e92eedced gofmt'ed various stragglers 
R=rsc
http://go/go-review/1022002
 2009-11-05 18:24:53 -08:00
Robert Griesemer
183edddb9d gofmt'ed more stragglers 
(now down to a handfull of files in pkg)

R=rsc
http://go/go-review/1019006
 2009-11-05 18:24:24 -08:00
Robert Griesemer
0ea9dd815a gofmt the last outstanding files in src/pkg 
- added a list of issues to printer/nodes.go

R=rsc
http://go/go-review/1024002
 2009-11-05 18:14:47 -08:00
Robert Griesemer
39fd52d3a0 gofmt'ed missing regexp file 
(one-line functions will be re-established once we have all
formatted uniformly)

R=r
http://go/go-review/1023004
 2009-11-05 17:35:40 -08:00
Robert Griesemer
38006946e6 manual fix for better gofmt result 
R=r
http://go/go-review/1019005
 2009-11-05 17:27:02 -08:00
Robert Griesemer
8cd2e76404 - gofmt'ing of some stragglers, now with correct comment indentation 
in special cases
- re-gofmt'ing of some files that are now improved

R=r, rsc
http://go/go-review/1023003
 2009-11-05 17:02:55 -08:00
Robert Griesemer
6c13f8f10e fix a comment formatting bug: 
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
  see separate CL (it fixes the same issue in those files)

R=rsc
http://go/go-review/1023002
 2009-11-05 17:02:29 -08:00
Adam Langley
fa57417dbd crypto/tls (part 6/5) 
Results of running gofmt again.

R=rsc
CC=go-dev
http://go/go-review/1022006
 2009-11-05 16:59:39 -08:00
Adam Langley
eb48f83ae2 crypto/tls (part 5/5) 
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)

Add entries to the Makefile.

R=rsc
CC=go-dev
http://go/go-review/1022005
 2009-11-05 16:44:02 -08:00
Adam Langley
950f2637c2 crypto/tls (part 4/5) 
R=rsc
CC=go-dev
http://go/go-review/1019002
 2009-11-05 16:43:29 -08:00
Robert Griesemer
10242e806f gofmt'ed parts of go 
R=rsc
http://go/go-review/1023001
 2009-11-05 15:58:28 -08:00
Adam Langley
65063bc61d big: add Div, Mod, Exp, GcdExt and several other fixes. 
R=gri, rsc
CC=go-dev
http://go/go-review/1017036
 2009-11-05 15:55:41 -08:00
Adam Langley
5e598c55dc crypto/tls (part 3) 
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)

R=rsc
CC=r
http://go/go-review/1018032
 2009-11-05 15:44:32 -08:00
Robert Griesemer
d3d3accdb7 gofmt-ify io, json, runtime, encoding 
R=rsc
http://go/go-review/1017056
 2009-11-05 15:37:55 -08:00
Robert Griesemer
6a4940ee23 gofmt'ed debug 
(excluding debug/gosym/symtab.go which has a small issue)

R=rsc
http://go/go-review/1019001
 2009-11-05 15:35:02 -08:00
Robert Griesemer
b8d88a9913 gofmt-ify strings, template 
R=r
http://go/go-review/1018064
 2009-11-05 15:12:37 -08:00
Robert Griesemer
f65e42d039 gofmt-ify gob 
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)

R=r
http://go/go-review/1016056
 2009-11-05 14:53:42 -08:00
Robert Griesemer
9786b3f1bd gofmt-ify 4s, iterable 
R=rsc
http://go/go-review/1016055
 2009-11-05 14:43:03 -08:00
Robert Griesemer
2a89915485 gofmt-ify draw 
R=rsc
http://go/go-review/1017055
 2009-11-05 14:42:28 -08:00
Robert Griesemer
9e48df682c gofmt-ify eval 
R=rsc
http://go/go-review/1016054
 2009-11-05 14:41:56 -08:00
Robert Griesemer
d2af73136e gofmt-ify ogle 
R=rsc
http://go/go-review/1016053
 2009-11-05 14:30:18 -08:00
Robert Griesemer
6238964d7b gofmt-ify nacl 
R=rsc
http://go/go-review/1018062
 2009-11-05 14:29:38 -08:00
Robert Griesemer
77334b988c gofmt-ify reflect 
- the single line structs can be fixed in another round

R=rsc
http://go/go-review/1016052
 2009-11-05 14:23:20 -08:00
Robert Griesemer
666afa1c02 2nd attempt: no noIndent for string lists 
- slightly better output in general
- extra indentation where we could do without
  (however that seems better for now that not having the indentation
  where it is needed)
- no information is lost, so a future better approach can fix these
  places up again

R=rsc
http://go/go-review/1017050
 2009-11-05 14:03:56 -08:00
Robert Griesemer
bd4f94057f gofmt-ify syscall 
(replacement for CL 1018053)

R=r
http://go/go-review/1017047
 2009-11-05 10:55:57 -08:00
Robert Griesemer
30c7088c95 gofmt-ify template, time, unsafe, flag, fmt 
(replacement for CLs 1017039, 1017041, 1017040, 1018054)

R=r
http://go/go-review/1018060
 2009-11-05 09:40:28 -08:00
Robert Griesemer
3630bfbe9f gofmt-ify math, expvar, exp/spacewar 
R=rsc
http://go/go-review/1018061
 2009-11-05 09:08:08 -08:00
Robert Griesemer
e57acdca4d gofmt-ify parts of xml 
R=rsc
http://go/go-review/1017049
 2009-11-05 08:59:03 -08:00
Robert Griesemer
12dbd06f0a gofmt-ify encoding 
R=rsc
http://go/go-review/1017048
 2009-11-05 08:55:18 -08:00
Robert Griesemer
ed494c6398 gofmt-ify sort, sync 
R=rsc
http://go/go-review/1018057
 2009-11-04 23:25:29 -08:00
Robert Griesemer
314b358ab7 gofmt-ify strconv 
(and remove an empty line at the end of a file)

R=rsc
http://go/go-review/1017046
 2009-11-04 23:20:49 -08:00
Robert Griesemer
5d37705416 gofmt-ify net 
R=rsc
http://go/go-review/1017045
 2009-11-04 23:16:46 -08:00
Robert Griesemer
7df45566db gofmt-ify image 
R=rsc
http://go/go-review/1017044
 2009-11-04 22:52:28 -08:00
Robert Griesemer
ca2a69ea06 gofmt-ify hash, http 
(gofmt will be able to re-align map entries as in http nicely,
eventually)

R=rsc
http://go/go-review/1018055
 2009-11-04 22:45:59 -08:00
Robert Griesemer
b16e6ab148 gofmt-ify tabwriter 
R=rsc
http://go/go-review/1017042
 2009-11-04 22:26:48 -08:00
Robert Griesemer
1fede304ff more comment formatting: 
- preserve (some) indentation of comment text for /*-style comments
  even if the first comment line does not contain any text that might
  suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
  (this will not introduce a lot of changes since comments of this
  kind - until now - were not changed with respect to indentation)

R=rsc
http://go/go-review/1016047
 2009-11-04 22:07:13 -08:00
Robert Griesemer
841c18a95a gofmt-ify unicode 
R=r
http://go/go-review/1018051
 2009-11-04 21:39:55 -08:00
Kai Backman
55ba9d6a2c fixing (badly) linux_arm syscall. 
R=rsc
http://go/go-review/1017037
 2009-11-04 21:34:54 -08:00
Robert Griesemer
601ee4807b - add a blank before the opening { for multi-line composites 
(request by r)
- feature temporarily disabled

R=rsc
CC=r
http://go/go-review/1018052
 2009-11-04 21:15:47 -08:00
Robert Griesemer
398f220d5b gofmt-ify os 
R=r
http://go/go-review/1017034
 2009-11-04 20:42:40 -08:00
Russ Cox
cc1a979272 package patch 
R=r
http://go/go-review/1018043
 2009-11-04 17:55:06 -08:00
Robert Griesemer
5fca0bca61 gofmt-ify compress 
R=rsc
http://go/go-review/1016045
 2009-11-04 17:10:18 -08:00
Robert Griesemer
b6d0a22dc5 gofmt-ify ebnf 
R=r
http://go/go-review/1018050
 2009-11-04 17:05:01 -08:00
Robert Griesemer
646a2c5a42 gofmt-ify bufio 
R=rsc
http://go/go-review/1018049
 2009-11-04 17:04:21 -08:00
Robert Griesemer
03678f7417 gofmt-ify asn1 
R=rsc
http://go/go-review/1018047
 2009-11-04 17:03:08 -08:00
Robert Griesemer
517ebbb24a gofmt-ify src/pkg/archive 
R=rsc
http://go/go-review/1018046
 2009-11-04 17:02:47 -08:00