Rob Findley f2c07d7d8e internal/lsp/lsprpc: improvements to daemon logging ... The gopls daemon had different default logging behavior than the sidecar gopls: by default, the daemon was started with -logfile=auto. Additionally, because most logs are reflected back to the forwarder, the actual daemon logs have very little (if any) information. This means that if you simply start gopls with -remote=auto, you'll get a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This is not a delightful experience. Fix this via several improvements: + Log lifecycle events in the Daemon, to give the log a purpose. + Give the daemon a new default log location: /tmp/gopls-daemon-<pid>.log. + Don't pass -logfile=auto to the daemon by default. Fixes golang/go#40105 Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-16 19:33:22 +00:00
..
codelens_test.go	internal/lsp: don't use -modfile for go mod commands	2020-06-22 20:30:43 +00:00
definition_test.go	internal/lsp/regtest: put testing.T back in the test func signature	2020-04-14 18:42:46 +00:00
diagnostics_test.go	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
doc.go	internal/lsp/regtest: add expository package documentation	2020-04-28 21:10:48 +00:00
env_test.go	internal/lsp: instrument work done reporting to use in regtests	2020-04-28 20:46:32 +00:00
env.go	internal/lsp/regtest: add regression tests for on-disk file changes	2020-07-01 22:06:37 +00:00
formatting_test.go	gopls, internal/lsp: support an extra formatting hook for gofumpt	2020-07-13 21:42:47 +00:00
generate_test.go	internal/lsp/regtest: add support for testing generate commands	2020-05-04 19:25:30 +00:00
imports_test.go	internal/lsp/regtest: remove stray short timeout	2020-07-08 18:38:56 +00:00
link_test.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
modfile_test.go	internal/lsp/regtest: simpler way to invert options	2020-07-16 18:20:50 +00:00
reg_test.go	internal/lsp/regtest: simpler way to invert options	2020-07-16 18:20:50 +00:00
runner.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
shared_test.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
symbol_helper_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
symbol_test.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00
unix_test.go	internal/lsp/regtest: add a t.Skip for golang/go#36824 regtest	2020-05-21 15:57:04 +00:00
vendor_test.go	internal/lsp: support go mod vendor as a command	2020-06-04 18:33:45 +00:00
watch_test.go	internal/lsp/regtest: await IWL before running tests	2020-07-08 00:37:08 +00:00
wrappers.go	internal/lsp/regtest: add regression tests for on-disk file changes	2020-07-01 22:06:37 +00:00