Rob Findley f2c07d7d8e internal/lsp/lsprpc: improvements to daemon logging ... The gopls daemon had different default logging behavior than the sidecar gopls: by default, the daemon was started with -logfile=auto. Additionally, because most logs are reflected back to the forwarder, the actual daemon logs have very little (if any) information. This means that if you simply start gopls with -remote=auto, you'll get a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This is not a delightful experience. Fix this via several improvements: + Log lifecycle events in the Daemon, to give the log a purpose. + Give the daemon a new default log location: /tmp/gopls-daemon-<pid>.log. + Don't pass -logfile=auto to the daemon by default. Fixes golang/go#40105 Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-16 19:33:22 +00:00
..
analysis	internal/lsp: extract highlighted selection to variable	2020-07-07 21:12:28 +00:00
browser
cache	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
cmd	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
debug	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
diff	internal/testenv: check that external 'diff' tool is the GNU version	2020-05-08 20:46:49 +00:00
fake	internal/lsp/regtest: use a common directory for regtest sandboxes	2020-07-09 18:15:24 +00:00
fuzzy	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
helper	internal/lsp: change to helper.go to output a formatted file	2020-01-31 20:35:38 +00:00
lsprpc	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
mod	internal/lsp: add new go.mod requires to files with unused require	2020-07-10 04:15:23 +00:00
protocol	internal/lsp: bring lsp protocol stubs up to date	2020-06-11 18:15:06 +00:00
regtest	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
snippet
source	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
testdata	internal/lsp: always show signature as the top line in hover	2020-07-13 23:52:42 +00:00
tests	internal/lsp: fix rename with Windows line endings	2020-07-10 04:00:52 +00:00
code_action.go	internal/lsp: check if analysis enabled in convenience fixes	2020-07-08 18:02:25 +00:00
command.go	internal/lsp: refactor generate code lens code	2020-07-16 13:43:19 +00:00
completion_test.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: remove VS Code-specific completion hack	2020-06-30 15:48:51 +00:00
definition.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
diagnostics.go	internal/lsp: don't use -modfile for go mod commands	2020-06-22 20:30:43 +00:00
folding_range.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
format.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
general.go	internal/lsp: watch go.{mod,sum} files, as well as Go files	2020-07-13 01:13:07 +00:00
highlight.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
hover.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
implementation.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
link.go	internal/lsp: add an importShortcut configuration	2020-07-15 23:00:36 +00:00
lsp_test.go	internal/lsp: fix rename with Windows line endings	2020-07-10 04:00:52 +00:00
progress.go	internal/lsp: refactor generate code lens code	2020-07-16 13:43:19 +00:00
references.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
rename.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
reset_golden.sh
server_gen.go	x/tools/gopls: add support for $/progress functionality	2020-03-16 21:25:24 +00:00
server.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
signature_help.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
symbols.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
text_synchronization.go	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
workspace_symbol.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00
workspace.go	gopls, internal/lsp: support an extra formatting hook for gofumpt	2020-07-13 21:42:47 +00:00