mirror of
https://github.com/golang/go
synced 2024-11-18 14:54:40 -07:00
0e85fd7561
Similar to how we report initialization loops in initorder.go and type alias loops in typecheck.go, this CL updates align.go to warn about invalid recursive types. The code is based on the loop code from initorder.go, with minimal changes to adapt from detecting variable/function initialization loops to detecting type declaration loops. Thanks to Cuong Manh Le for investigating this, helping come up with test cases, and exploring solutions. Fixes #41575 Updates #41669. Change-Id: Idb2cb8c5e1d645e62900e178fcb50af33e1700a1 Reviewed-on: https://go-review.googlesource.com/c/go/+/258177 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Trust: Matthew Dempsky <mdempsky@google.com> Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
37 lines
869 B
Go
37 lines
869 B
Go
// errorcheck
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved. Use of this
|
|
// source code is governed by a BSD-style license that can be found in
|
|
// the LICENSE file.
|
|
|
|
package p
|
|
|
|
type T1 struct { // ERROR "invalid recursive type T1\n\tLINE: T1 refers to\n\tLINE+4: T2 refers to\n\tLINE: T1$"
|
|
f2 T2
|
|
}
|
|
|
|
type T2 struct {
|
|
f1 T1
|
|
}
|
|
|
|
type a b
|
|
type b c // ERROR "invalid recursive type b\n\tLINE: b refers to\n\tLINE+1: c refers to\n\tLINE: b$"
|
|
type c b
|
|
|
|
type d e
|
|
type e f
|
|
type f f // ERROR "invalid recursive type f\n\tLINE: f refers to\n\tLINE: f$"
|
|
|
|
type g struct { // ERROR "invalid recursive type g\n\tLINE: g refers to\n\tLINE: g$"
|
|
h struct {
|
|
g
|
|
}
|
|
}
|
|
|
|
type w x
|
|
type x y // ERROR "invalid recursive type x\n\tLINE: x refers to\n\tLINE+1: y refers to\n\tLINE+2: z refers to\n\tLINE: x$"
|
|
type y struct{ z }
|
|
type z [10]x
|
|
|
|
type w2 w // refer to the type loop again
|