1
0
mirror of https://github.com/golang/go synced 2024-11-18 21:05:02 -07:00
go/godoc/static
Alan Donovan ebc87c5c5e godoc: fix bug in "internal call graph" tree widget.
Today I learned that getElementByClass returns an
HTMLContainer, not an array, so the for loop was iterating its
properties, which include:
- the methods of the type, which were filtered out by the condition;
- the array-like integer indices of the elements, which we want;
- the ids of the same elements (!), which we weren't expecting.
The net result is that various functions were called twice,
causing the tree to be double-populated and clicks to cause
and expand+collapse.

It's a miracle to me that any JS program even approximately works.

Fixes golang/go#8237

LGTM=bradfitz
R=gri, bradfitz
CC=golang-codereviews
https://golang.org/cl/141540043
2014-09-15 13:00:40 -04:00
..
analysis godoc/analysis: show analysis status in UI (source file view) 2014-07-09 07:59:55 -04:00
images go.tools/godoc: server mode: add support for type and pointer analysis. 2014-03-14 18:58:22 -04:00
bake.go go.tools/godoc: server mode: add support for type and pointer analysis. 2014-03-14 18:58:22 -04:00
bake.sh godoc: documentation of -analysis features. 2014-04-16 16:35:08 -04:00
callgraph.html go.tools/godoc/static: indent with tabs. 2014-08-26 13:21:29 -07:00
codewalk.html go.tools/godoc/static: fix & escape in codewalks 2013-10-13 22:22:48 -04:00
codewalkdir.html go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
dirlist.html go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
doc.go go.tools/godoc/static: fix import path doc typo 2014-05-05 17:42:00 -07:00
error.html go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
example.html go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
godoc.html go.tools/godoc: remove Google+ buttons 2014-09-08 10:05:20 +10:00
godocs.js godoc: fix bug in "internal call graph" tree widget. 2014-09-15 13:00:40 -04:00
implements.html go.tools/godoc/static: indent with tabs. 2014-08-26 13:21:29 -07:00
jquery.js go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
jquery.treeview.css go.tools/godoc: server mode: add support for type and pointer analysis. 2014-03-14 18:58:22 -04:00
jquery.treeview.edit.js go.tools/godoc: server mode: add support for type and pointer analysis. 2014-03-14 18:58:22 -04:00
jquery.treeview.js go.tools/godoc: server mode: add support for type and pointer analysis. 2014-03-14 18:58:22 -04:00
methodset.html go.tools/godoc/static: indent with tabs. 2014-08-26 13:21:29 -07:00
opensearch.xml go.tools/cmd: move static files into new package 'static' 2013-08-21 13:49:05 +10:00
package.html go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
package.txt go.tools/cmd/godoc/static: fix text template for variable examples. 2014-04-22 18:46:26 -04:00
play.js go.tools/godoc/static: make this the canonical source for playground JS 2013-10-01 12:11:47 +10:00
playground.js playground: add ctrl-enter shortcut for gofmt (as in the tour) 2014-08-04 15:55:39 -07:00
search.html godoc: add ability to change or disable the display of search results. 2014-01-06 09:51:01 -05:00
search.txt godoc: add search results that point to documentation instead of source. 2013-11-21 11:55:42 -05:00
searchcode.html godoc: Add package identifiers to documentation indexing. 2014-01-06 13:26:25 -05:00
searchdoc.html go.tools/godoc/static: indent with tabs. 2014-08-26 13:21:29 -07:00
searchtxt.html godoc: add ability to change or disable the display of search results. 2014-01-06 09:51:01 -05:00
static.go godoc: fix bug in "internal call graph" tree widget. 2014-09-15 13:00:40 -04:00
style.css go.tools/godoc: mention sub-repos and package indexes on packages page 2014-08-21 09:53:57 +10:00