qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 12:44:49 -07:00
Code Releases Activity
ebc87c5c5e
go/godoc
History
Alan Donovan ebc87c5c5e godoc: fix bug in "internal call graph" tree widget. 
Today I learned that getElementByClass returns an
HTMLContainer, not an array, so the for loop was iterating its
properties, which include:
- the methods of the type, which were filtered out by the condition;
- the array-like integer indices of the elements, which we want;
- the ids of the same elements (!), which we weren't expecting.
The net result is that various functions were called twice,
causing the tree to be double-populated and clicks to cause
and expand+collapse.

It's a miracle to me that any JS program even approximately works.

Fixes golang/go#8237

LGTM=bradfitz
R=gri, bradfitz
CC=golang-codereviews
https://golang.org/cl/141540043
2014-09-15 13:00:40 -04:00
..
analysis go.tools: eliminate three copies of the allPackages utility. 2014-09-11 14:14:53 -04:00
redirect go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
static godoc: fix bug in "internal call graph" tree widget. 2014-09-15 13:00:40 -04:00
util all: be more idiomatic when documenting boolean return values. 2013-07-23 10:37:43 +10:00
vfs godoc: limit concurrency to local disk filesystem 2013-12-16 11:25:50 -08:00
cmdline_test.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
cmdline.go godoc: Remove bogus messages referring to "/target". 2014-02-26 13:21:44 -05:00
corpus.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
dirtrees.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
format.go go.tools/godoc: Fix jump-to-line in source view. 2013-08-01 11:52:25 +10:00
godoc_test.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
godoc.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
index_test.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
index.go godoc: Order package results by import count. 2014-06-27 12:47:39 -04:00
linkify.go godoc: remove the last of the global variables, unexport Server 2013-07-19 10:27:53 +10:00
meta.go godoc: remove more global variables 2013-07-18 13:14:09 +10:00
page.go godoc: set expvar for http.ResponseWriter errors. 2014-01-29 10:53:45 -05:00
parser.go go.tools/godoc: ignore //line comments in source code 2014-04-03 13:12:54 -07:00
pres.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
search.go godoc: Fix dereference of nil *SearchResult. 2014-02-20 11:26:05 -05:00
server_test.go godoc: set expvar for http.ResponseWriter errors. 2014-01-29 10:53:45 -05:00
server.go go.tools/godoc: deal with fallout from $GOROOT/src/pkg -> $GOROOT/src renaming. 2014-09-10 09:02:54 -04:00
snippet.go godoc: remove more global variables 2013-07-18 13:14:09 +10:00
spec.go godoc: move bulk of the code to the package 2013-07-17 17:09:54 +10:00
spot.go godoc: add search results that point to documentation instead of source. 2013-11-21 11:55:42 -05:00
tab.go godoc: remove more global variables 2013-07-18 13:14:09 +10:00
template.go godoc: remove more global variables 2013-07-18 13:14:09 +10:00