1
0
mirror of https://github.com/golang/go synced 2024-11-19 01:04:40 -07:00
go/refactor/rename
Dominik Honnef 9c7ccd869c refactor/rename: emacs: kill go-rename buffer correctly
Match gofmt's behaviour of closing the status buffer. Don't display the
buffer in case of success as we were going to hide it instantly again,
anyway. Also, instead of using delete-window, use
gofmt--kill-error-buffer. gofmt--kill-error-buffer uses quit-window if
there's a window for the buffer, kill-buffer otherwise.

quit-window only deletes the window if it was created explicitly for the
status buffer and if it is still displaying it. This way, we won't close
windows that the user created or repurposed himself.

Additionally, this change ensures that we don't leave a *go-rename*
buffer lying around when gorename succeeded.

Fixes golang/go#10972.

Change-Id: Id1efb60d399f0062d870e925138aa827e12f3e58
Reviewed-on: https://go-review.googlesource.com/10453
Reviewed-by: Alan Donovan <adonovan@google.com>
2015-05-29 16:50:48 +00:00
..
check.go go/types: expose IsInterface predicate, eliminating 6 copies 2015-01-21 18:49:27 +00:00
mvpkg_test.go go/buildutil: use chan (not func) in the ForEachPackage API 2015-03-05 20:14:20 +00:00
mvpkg.go refactor/rename: fix misplaced 'continue'. 2015-03-17 20:38:58 +00:00
rename_test.go go/buildutil: FakeContext: create build.Context of fake file tree, for testing 2015-01-15 22:46:57 +00:00
rename.el refactor/rename: emacs: kill go-rename buffer correctly 2015-05-29 16:50:48 +00:00
rename.go refactor/rename: fix misplaced 'continue'. 2015-03-17 20:38:58 +00:00
spec.go cmd/gorename: make Usage documentation sensible in godoc 2014-12-30 16:36:43 +00:00
util.go astutil: move to go/ast/astutil 2015-01-13 15:47:47 +00:00