go/test at c35bc69c97ddde490e640c2b608941c82de65949 - go

qbit/go

mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00

History

Austin Clements 8be94b82ab runtime: drop function context from traceback Currently, gentraceback tracks the closure context of the outermost frame. This used to be important for "unstarted" calls to reflect function stubs, where "unstarted" calls are either deferred functions or the entry-point of a goroutine that hasn't run. Because reflect function stubs have a dynamic argument map, we have to reach into their closure context to fetch to map, and how to do this differs depending on whether the function has started. This was discovered in issue #25897. However, as part of the register ABI, "go" and "defer" were made much simpler, and any "go" or "defer" of a function that takes arguments or returns results gets wrapped in a closure that provides those arguments (and/or discards the results). Hence, we'll see that closure instead of a direct call to a reflect stub, and can get its static argument map without any trouble. The one case where we may still see an unstarted reflect stub is if the function takes no arguments and has no results, in which case the compiler can optimize away the wrapper closure. But in this case we know the argument map is empty: the compiler can apply this optimization precisely because the target function has no argument frame. As a result, we no longer need to track the closure context during traceback, so this CL drops all of that mechanism. We still have to be careful about the unstarted case because we can't reach into the function's locals frame to pull out its context (because it has no locals frame). We double-check that in this case we're at the function entry. I would prefer to do this with some in-code PCDATA annotations of where to find the dynamic argument map, but that's a lot of mechanism to introduce for just this. It might make sense to consider this along with #53609. Finally, we beef up the test for this so it more reliably forces the runtime down this path. It's fundamentally probabilistic, but this tweak makes it better. Scheduler testing hooks (#54475) would make it possible to write a reliable test for this. For #54466, but it's a nice clean-up all on its own. Change-Id: I16e4f2364ba2ea4b1fec1e27f971b06756e7b09f Reviewed-on: https://go-review.googlesource.com/c/go/+/424254 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Austin Clements <austin@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>		2022-09-02 19:04:48 +00:00
..
abi
alias3.dir
asmhdr.dir
bench
chan
closure3.dir
closure5.dir	test: use dot-relative imports where appropriate	2022-03-24 02:14:15 +00:00
codegen	cmd/compile: rewrite >>c<<c to &^(1<<c-1)	2022-09-02 18:51:37 +00:00
ddd2.dir
dwarf
fixedbugs	runtime: drop function context from traceback	2022-09-02 19:04:48 +00:00
import2.dir
import4.dir
interface	cmd/compile: require -p flag	2022-03-09 21:31:58 +00:00
intrinsic.dir
ken
linkname.dir	test: compile source files as if from "test" module	2022-03-24 17:50:47 +00:00
method4.dir
retjmp.dir
runtime
stress
syntax	go/parser: adjustments to error messages	2022-09-01 22:37:04 +00:00
typeparam	cmd/compile: restrict //go:notinheap to runtime/internal/sys	2022-09-02 06:22:23 +00:00
uintptrescapes.dir
64bit.go
235.go
alg.go
alias1.go
alias2.go
alias3.go
alias.go
align.go
append1.go
append.go
args.go
armimm.go
asmhdr.go
assign1.go
assign.go
atomicload.go
bigalg.go
bigmap.go
blank1.go
blank.go
bom.go
bombad.go
bounds.go
cannotassign.go
chancap.go
chanlinear.go
char_lit1.go
char_lit.go
checkbce.go
clearfat.go
closedchan.go
closure1.go
closure2.go
closure3.go
closure4.go
closure5.go
closure6.go
closure7.go
closure.go
cmp6.go
cmp.go
cmplx.go
cmplxdivide1.go
cmplxdivide.c
cmplxdivide.go
complit1.go
complit.go
compos.go
const1.go
const2.go
const3.go
const4.go
const5.go
const6.go
const7.go	go/types, types2: check integer constant literal overflow	2022-08-16 01:11:29 +00:00
const8.go	test: add more tests for const decls with ommitted RHS expressions	2022-06-28 18:11:31 +00:00
const.go
convert1.go
convert2.go
convert3.go
convert4.go
convert.go
convlit1.go
convlit.go
convT2X.go
copy1.go
copy.go
crlf.go
ddd1.go
ddd2.go
ddd.go
decl.go
declbad.go
defer.go
defererrcheck.go
deferfin.go
defernil.go
deferprint.go
deferprint.out
devirt.go
directive2.go	cmd/compile: restrict //go:notinheap to runtime/internal/sys	2022-09-02 06:22:23 +00:00
directive.go	cmd/compile: restrict //go:notinheap to runtime/internal/sys	2022-09-02 06:22:23 +00:00
divide.go
divmod.go
embedfunc.go
embedvers.go
empty.go
env.go
eof1.go
eof.go
escape2.go
escape2n.go
escape3.go
escape4.go
escape5.go
escape_array.go
escape_calls.go
escape_closure.go
escape_field.go
escape_goto.go
escape_hash_maphash.go
escape_iface_nounified.go	[dev.unified] test: break escape_iface.go into unified/nounified variants	2022-06-30 18:41:26 +00:00
escape_iface_unified.go	[dev.unified] cmd/compile/internal/noder: implicit conversions for multi-valued expressions	2022-06-30 18:42:24 +00:00
escape_iface.go	[dev.unified] test: break escape_iface.go into unified/nounified variants	2022-06-30 18:41:26 +00:00
escape_indir.go
escape_level.go
escape_map.go
escape_param.go
escape_runtime_atomic.go
escape_selfassign.go
escape_slice.go
escape_struct_param1.go
escape_struct_param2.go
escape_struct_return.go
escape_sync_atomic.go
escape_unsafe.go
escape.go
fibo.go
finprofiled.go
float_lit2.go
float_lit3.go
float_lit.go
floatcmp.go
for.go
func1.go
func2.go
func3.go
func4.go
func5.go
func6.go
func7.go
func8.go
func.go
funcdup2.go
funcdup.go
fuse.go
gc1.go
gc2.go
gc.go
gcgort.go
gcstring.go
goprint.go
goprint.out
goto.go
heapsampling.go	test/heapsampling.go: slow down allocation rate and reduce iterations	2022-05-27 21:36:06 +00:00
helloworld.go
helloworld.out
if.go
import1.go
import2.go
import4.go
import5.go
import6.go
import.go
index0.go
index1.go
index2.go
index.go
indirect1.go
indirect.go
init1.go
init.go
initcomma.go
initempty.go
initexp.go
initialize.go
initializerr.go
initloop.go
inline_big.go
inline_caller.go
inline_callers.go
inline_endian.go
inline_literal.go
inline_math_bits_rotate.go
inline_nounified.go	[dev.unified] test: extract different inline test between unified and non-unified	2022-06-15 21:22:56 +00:00
inline_sync.go
inline_unified.go	cmd/compile/internal/noder: fix inlined function literal positions	2022-08-25 18:46:22 +00:00
inline_variadic.go
inline.go	[dev.unified] test: extract different inline test between unified and non-unified	2022-06-15 21:22:56 +00:00
int_lit.go
intcvt.go
intrinsic_atomic.go	misc, test: fix test error for loong64	2022-05-20 16:16:37 +00:00
intrinsic.go
iota.go
label1.go
label.go
linkmain_run.go	cmd/compile: require -p flag	2022-03-09 21:31:58 +00:00
linkmain.go
linkname3.go
linkname.go
linkobj.go	cmd/compile: require -p flag	2022-03-09 21:31:58 +00:00
linkx_run.go
linkx.go
literal2.go
literal.go
live1.go
live2.go
live_regabi.go	cmd/compile: stop using VARKILL	2022-08-18 17:36:38 +00:00
live_uintptrkeepalive.go	all: fix spelling	2022-05-17 19:51:29 +00:00
live.go	cmd/compile: stop using VARKILL	2022-08-18 17:36:38 +00:00
loopbce.go	cmd/compile: tighten bounds for induction variables in strided loops	2022-08-31 22:04:55 +00:00
mainsig.go
makechan.go
makemap.go
makenew.go
makeslice.go
mallocfin.go
map1.go
map.go
mapclear.go
maplinear.go
maymorestack.go
mergemul.go
method1.go
method2.go
method3.go
method4.go
method5.go
method6.go
method7.go
method.go
named1.go
named.go
nil.go
nilcheck.go	[dev.unified] test: tweak nilcheck test	2022-06-30 18:41:59 +00:00
nilptr2.go
nilptr3.go
nilptr4.go
nilptr5_aix.go
nilptr5_wasm.go
nilptr5.go	cmd/compile: handle partially overlapping assignments	2022-08-23 19:56:32 +00:00
nilptr_aix.go
nilptr.go
nosplit.go	misc, test: fix test error for loong64	2022-05-20 16:16:37 +00:00
nowritebarrier.go
nul1.go
opt_branchlikely.go
parentype.go
peano.go
phiopt.go
print.go
print.out
printbig.go
printbig.out
prove_constant_folding.go	cmd/compile: fold constants found by prove	2022-05-04 20:30:17 +00:00
prove.go	cmd/compile: teach prove about bitwise OR operation	2022-08-31 09:35:45 +00:00
range.go
README.md
recover1.go
recover2.go
recover3.go
recover4.go
recover5.go
recover.go
reflectmethod1.go
reflectmethod2.go
reflectmethod3.go
reflectmethod4.go
reflectmethod5.go
reflectmethod6.go
reflectmethod7.go
reflectmethod8.go
rename1.go
rename.go
reorder2.go
reorder.go
retjmp.go
return.go
rotate0.go
rotate1.go
rotate2.go
rotate3.go
rotate.go
run.go	go/types,types2: move notinheap tests to fixedbugs directory	2022-09-02 17:46:15 +00:00
rune.go
runtime.go
shift1.go
shift2.go
shift3.go	cmd/compile: adjust types2 shift check to match go/types (cleanup)	2022-04-07 17:19:55 +00:00
sieve.go
sigchld.go
sigchld.out
simassign.go
sinit_run.go	cmd/compile: require -p flag	2022-03-09 21:31:58 +00:00
sinit.go
sizeof.go
slice3.go
slice3err.go
slicecap.go
sliceopt.go
solitaire.go
stack.go
stackobj2.go
stackobj3.go
stackobj.go
strcopy.go
strength.go
string_lit.go
stringrange.go
struct0.go
switch2.go	go/parser: adjustments to error messages	2022-09-01 22:37:04 +00:00
switch3.go
switch4.go
switch5.go
switch6.go
switch7.go
switch.go	[dev.unified] test: add switch test case for tricky nil handling	2022-07-19 23:30:49 +00:00
tinyfin.go
torture.go
turing.go
typecheck.go
typecheckloop.go
typeswitch1.go
typeswitch2.go
typeswitch2b.go
typeswitch3.go
typeswitch.go
uintptrescapes2.go
uintptrescapes3.go
uintptrescapes.go
uintptrkeepalive.go	cmd/compile: add //go:uintptrkeepalive	2022-04-21 18:06:38 +00:00
undef.go
unsafe_slice_data.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafe_string_data.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafe_string.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafebuiltins.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
used.go
utf.go
varerr.go
varinit.go
winbatch.go
writebarrier.go
zerodivide.go

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

To run just tests from specified files in this directory, execute:

../bin/go run run.go -- file1.go file2.go ...

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.