1
0
mirror of https://github.com/golang/go synced 2024-11-11 19:21:37 -07:00

go/types,types2: move notinheap tests to fixedbugs directory

So they can be added to ignored list, since the tests now require
cgo.Incomplete, which is not recognized by go/types and types2.

Updates #46731

Change-Id: I9f24e3c8605424d1f5f42ae4409437198f4c1326
Reviewed-on: https://go-review.googlesource.com/c/go/+/427142
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
This commit is contained in:
Cuong Manh Le 2022-09-02 13:32:40 +07:00 committed by Gopher Robot
parent 274528eca1
commit f45c2d7e47
6 changed files with 5 additions and 1 deletions

View File

@ -206,6 +206,8 @@ func TestStdFixed(t *testing.T) {
"issue42076.go",
"issue46903.go",
"issue51733.go",
"notinheap2.go",
"notinheap3.go",
)
}

View File

@ -208,6 +208,8 @@ func TestStdFixed(t *testing.T) {
"issue42076.go",
"issue46903.go",
"issue51733.go",
"notinheap2.go",
"notinheap3.go",
)
}

View File

@ -1965,7 +1965,6 @@ func overlayDir(dstRoot, srcRoot string) error {
// List of files that the compiler cannot errorcheck with the new typechecker (types2).
var types2Failures = setOf(
"notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap
"shift1.go", // types2 reports two new errors which are probably not right
"fixedbugs/issue10700.go", // types2 should give hint about ptr to interface
"fixedbugs/issue18331.go", // missing error about misuse of //go:noescape (irgen needs code from noder)
@ -1973,6 +1972,7 @@ var types2Failures = setOf(
"fixedbugs/issue20233.go", // types2 reports two instead of one error (preference: 1.17 compiler)
"fixedbugs/issue20245.go", // types2 reports two instead of one error (preference: 1.17 compiler)
"fixedbugs/issue31053.go", // types2 reports "unknown field" instead of "cannot refer to unexported field"
"fixedbugs/notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap
)
var types2Failures32Bit = setOf(