From f45c2d7e47e6dcfb69876092037257562813cc37 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Fri, 2 Sep 2022 13:32:40 +0700 Subject: [PATCH] go/types,types2: move notinheap tests to fixedbugs directory So they can be added to ignored list, since the tests now require cgo.Incomplete, which is not recognized by go/types and types2. Updates #46731 Change-Id: I9f24e3c8605424d1f5f42ae4409437198f4c1326 Reviewed-on: https://go-review.googlesource.com/c/go/+/427142 Run-TryBot: Cuong Manh Le Reviewed-by: Bryan Mills Auto-Submit: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Heschi Kreinick --- src/cmd/compile/internal/types2/stdlib_test.go | 2 ++ src/go/types/stdlib_test.go | 2 ++ test/{ => fixedbugs}/notinheap.go | 0 test/{ => fixedbugs}/notinheap2.go | 0 test/{ => fixedbugs}/notinheap3.go | 0 test/run.go | 2 +- 6 files changed, 5 insertions(+), 1 deletion(-) rename test/{ => fixedbugs}/notinheap.go (100%) rename test/{ => fixedbugs}/notinheap2.go (100%) rename test/{ => fixedbugs}/notinheap3.go (100%) diff --git a/src/cmd/compile/internal/types2/stdlib_test.go b/src/cmd/compile/internal/types2/stdlib_test.go index 2577abf6de..5933c29d61 100644 --- a/src/cmd/compile/internal/types2/stdlib_test.go +++ b/src/cmd/compile/internal/types2/stdlib_test.go @@ -206,6 +206,8 @@ func TestStdFixed(t *testing.T) { "issue42076.go", "issue46903.go", "issue51733.go", + "notinheap2.go", + "notinheap3.go", ) } diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go index 53333b69db..66e75c7251 100644 --- a/src/go/types/stdlib_test.go +++ b/src/go/types/stdlib_test.go @@ -208,6 +208,8 @@ func TestStdFixed(t *testing.T) { "issue42076.go", "issue46903.go", "issue51733.go", + "notinheap2.go", + "notinheap3.go", ) } diff --git a/test/notinheap.go b/test/fixedbugs/notinheap.go similarity index 100% rename from test/notinheap.go rename to test/fixedbugs/notinheap.go diff --git a/test/notinheap2.go b/test/fixedbugs/notinheap2.go similarity index 100% rename from test/notinheap2.go rename to test/fixedbugs/notinheap2.go diff --git a/test/notinheap3.go b/test/fixedbugs/notinheap3.go similarity index 100% rename from test/notinheap3.go rename to test/fixedbugs/notinheap3.go diff --git a/test/run.go b/test/run.go index 3d59e4e523..3c5b10ad32 100644 --- a/test/run.go +++ b/test/run.go @@ -1965,7 +1965,6 @@ func overlayDir(dstRoot, srcRoot string) error { // List of files that the compiler cannot errorcheck with the new typechecker (types2). var types2Failures = setOf( - "notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap "shift1.go", // types2 reports two new errors which are probably not right "fixedbugs/issue10700.go", // types2 should give hint about ptr to interface "fixedbugs/issue18331.go", // missing error about misuse of //go:noescape (irgen needs code from noder) @@ -1973,6 +1972,7 @@ var types2Failures = setOf( "fixedbugs/issue20233.go", // types2 reports two instead of one error (preference: 1.17 compiler) "fixedbugs/issue20245.go", // types2 reports two instead of one error (preference: 1.17 compiler) "fixedbugs/issue31053.go", // types2 reports "unknown field" instead of "cannot refer to unexported field" + "fixedbugs/notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap ) var types2Failures32Bit = setOf(