1
0
mirror of https://github.com/golang/go synced 2024-11-18 21:14:44 -07:00
go/dashboard/app/static
Dmitriy Vyukov a0cb59fbc3 dashboard: highlight positive changes
Initially both positive and negative changes had solid background (green and red).
Then we removed background of positive changes due to:
https://code.google.com/p/go/issues/detail?id=8624
However, Ian noted:

"I did intuitively understand that + was an increase and - was a
decrease.  I did not notice how the numbers were segregated between
the third and fourth columns.  Now that you point it out, it is
obvious.  It would be more obvious if the numbers in the fourth column
were highlighted in green."

Give positive changes green *border* (not background),
so they are still visually distinguishable from negative even in grayscale.
This is especially beneficial for perf detail view,
because currently it looks like everything is either
negative or neutral in that view (only red and black).

LGTM=adg
R=adg
CC=golang-codereviews, iant, rsc
https://golang.org/cl/159970043
2014-10-17 11:32:43 +04:00
..
status_alert.gif go.tools: add dashboard 2013-08-01 13:23:51 +10:00
status_good.gif go.tools: add dashboard 2013-08-01 13:23:51 +10:00
style.css dashboard: highlight positive changes 2014-10-17 11:32:43 +04:00