qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 16:04:44 -07:00
Code Releases Activity

dashboard: highlight positive changes

Browse Source 
Initially both positive and negative changes had solid background (green and red).
Then we removed background of positive changes due to:
https://code.google.com/p/go/issues/detail?id=8624
However, Ian noted:

"I did intuitively understand that + was an increase and - was a
decrease.  I did not notice how the numbers were segregated between
the third and fourth columns.  Now that you point it out, it is
obvious.  It would be more obvious if the numbers in the fourth column
were highlighted in green."

Give positive changes green *border* (not background),
so they are still visually distinguishable from negative even in grayscale.
This is especially beneficial for perf detail view,
because currently it looks like everything is either
negative or neutral in that view (only red and black).

LGTM=adg
R=adg
CC=golang-codereviews, iant, rsc
https://golang.org/cl/159970043
This commit is contained in:
Dmitriy Vyukov 2014-10-17 11:32:43 +04:00
parent 26439e8d81
commit a0cb59fbc3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboard/app/static/style.css
View File

@ -197,7 +197,7 @@ table thead tr {
text-overflow: ellipsis;
}
.good { text-decoration: none; color: #000000; }
.good { text-decoration: none; color: #000000; border: 2px solid #00E700}
.bad { text-decoration: none; text-shadow: 1px 1px 0 #000000; color: #FFFFFF; background: #E70000;}
.noise { text-decoration: none; color: #888; }
.fail { color: #C00; }