mirror of
https://github.com/golang/go
synced 2024-11-05 17:36:15 -07:00
20370b0cb4
Several fixes related to GOPRIVATE handling and links: + In Go source, fix links matching GOPRIVATE for external modules. Previously, in these cases we'd try to match <mod>@v1.2.3/<suffix>, which wasn't the correct input into the GOPRIVATE matching algorithm. + Similarly check GOPRIVATE for go.mod require statement hovers. + Likewise, for documentLink requests (both mod and source). + Move the existing hover regtest to link_test.go, and expand to cover all these cases. Along the way, I encountered a couple apparent bugs, which I fixed: + Correctly handle the case where there is only one require in a go.mod file. This was exercised by the regtest, so took some debugging. + Only format links [like](this) if the requested format is actually markdown. Fixes golang/go#36998 Change-Id: I92011821f646f2a7449dcca619483f83bdeb54b0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/238029 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
86 lines
2.6 KiB
Go
86 lines
2.6 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package regtest
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestHoverAndDocumentLink(t *testing.T) {
|
|
const program = `
|
|
-- go.mod --
|
|
module mod.test
|
|
|
|
go 1.12
|
|
|
|
require import.test v1.2.3
|
|
-- main.go --
|
|
package main
|
|
|
|
import "import.test/pkg"
|
|
|
|
func main() {
|
|
println(pkg.Hello)
|
|
}`
|
|
|
|
const proxy = `
|
|
-- import.test@v1.2.3/go.mod --
|
|
module import.test
|
|
|
|
go 1.12
|
|
-- import.test@v1.2.3/pkg/const.go --
|
|
package pkg
|
|
|
|
const Hello = "Hello"
|
|
`
|
|
runner.Run(t, program, func(t *testing.T, env *Env) {
|
|
env.OpenFile("main.go")
|
|
env.OpenFile("go.mod")
|
|
|
|
modLink := "https://pkg.go.dev/mod/import.test@v1.2.3"
|
|
pkgLink := "https://pkg.go.dev/import.test@v1.2.3/pkg"
|
|
|
|
// First, check that we get the expected links via hover and documentLink.
|
|
content, _ := env.Hover("main.go", env.RegexpSearch("main.go", "pkg.Hello"))
|
|
if content == nil || !strings.Contains(content.Value, pkgLink) {
|
|
t.Errorf("hover: got %v in main.go, want contains %q", content, pkgLink)
|
|
}
|
|
content, _ = env.Hover("go.mod", env.RegexpSearch("go.mod", "import.test"))
|
|
if content == nil || !strings.Contains(content.Value, pkgLink) {
|
|
t.Errorf("hover: got %v in go.mod, want contains %q", content, pkgLink)
|
|
}
|
|
links := env.DocumentLink("main.go")
|
|
if len(links) != 1 || links[0].Target != pkgLink {
|
|
t.Errorf("documentLink: got %v for main.go, want link to %q", links, pkgLink)
|
|
}
|
|
links = env.DocumentLink("go.mod")
|
|
if len(links) != 1 || links[0].Target != modLink {
|
|
t.Errorf("documentLink: got %v for go.mod, want link to %q", links, modLink)
|
|
}
|
|
|
|
// Then change the environment to make these links private.
|
|
env.ChangeEnv("GOPRIVATE=import.test")
|
|
|
|
// Finally, verify that the links are gone.
|
|
content, _ = env.Hover("main.go", env.RegexpSearch("main.go", "pkg.Hello"))
|
|
if content == nil || strings.Contains(content.Value, pkgLink) {
|
|
t.Errorf("hover: got %v in main.go, want non-empty hover without %q", content, pkgLink)
|
|
}
|
|
content, _ = env.Hover("go.mod", env.RegexpSearch("go.mod", "import.test"))
|
|
if content == nil || strings.Contains(content.Value, modLink) {
|
|
t.Errorf("hover: got %v in go.mod, want contains %q", content, modLink)
|
|
}
|
|
links = env.DocumentLink("main.go")
|
|
if len(links) != 0 {
|
|
t.Errorf("documentLink: got %d document links for main.go, want 0\nlinks: %v", len(links), links)
|
|
}
|
|
links = env.DocumentLink("go.mod")
|
|
if len(links) != 0 {
|
|
t.Errorf("documentLink: got %d document links for go.mod, want 0\nlinks: %v", len(links), links)
|
|
}
|
|
}, WithProxy(proxy))
|
|
}
|