1
0
mirror of https://github.com/golang/go synced 2024-11-05 15:16:11 -07:00
go/internal/lsp/regtest
Rob Findley 20370b0cb4 internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers
Several fixes related to GOPRIVATE handling and links:
 + In Go source, fix links matching GOPRIVATE for external modules.
   Previously, in these cases we'd try to match <mod>@v1.2.3/<suffix>,
   which wasn't the correct input into the GOPRIVATE matching algorithm.
 + Similarly check GOPRIVATE for go.mod require statement hovers.
 + Likewise, for documentLink requests (both mod and source).
 + Move the existing hover regtest to link_test.go, and expand to cover
   all these cases.

Along the way, I encountered a couple apparent bugs, which I fixed:
 + Correctly handle the case where there is only one require in a go.mod
   file. This was exercised by the regtest, so took some debugging.
 + Only format links [like](this) if the requested format is actually
   markdown.

Fixes golang/go#36998

Change-Id: I92011821f646f2a7449dcca619483f83bdeb54b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/238029
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-18 13:42:42 +00:00
..
codelens_test.go internal/lsp/regtest: move and re-enable TestRegenerateCgo 2020-06-17 21:29:13 +00:00
definition_test.go internal/lsp/regtest: put testing.T back in the test func signature 2020-04-14 18:42:46 +00:00
diagnostics_test.go internal/lsp: handle deletion of workspace packages 2020-06-17 16:12:49 +00:00
doc.go internal/lsp/regtest: add expository package documentation 2020-04-28 21:10:48 +00:00
env_test.go internal/lsp: instrument work done reporting to use in regtests 2020-04-28 20:46:32 +00:00
env.go internal/lsp/lsprpc: forward the go environment in initialize requests 2020-06-16 15:43:56 +00:00
formatting_test.go internal/lsp: fix formatting edge cases (36824) 2020-05-26 20:56:00 +00:00
generate_test.go internal/lsp/regtest: add support for testing generate commands 2020-05-04 19:25:30 +00:00
imports_test.go internal/lsp: simplify and correct fixing imports for CodeAction 2020-05-18 22:54:12 +00:00
link_test.go internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers 2020-06-18 13:42:42 +00:00
reg_test.go internal/lsp/regtest: print RPC logs when verbose output is enabled 2020-06-11 19:16:16 +00:00
runner.go internal/lsp/lsprpc: forward the go environment in initialize requests 2020-06-16 15:43:56 +00:00
shared_test.go internal/lsp: support configurable codeLens 2020-05-08 18:47:35 +00:00
symbol_helper_test.go internal/lsp/fake: define Symbol method on Editor 2020-05-11 20:27:07 +00:00
symbol_test.go internal/lsp/fake: define Symbol method on Editor 2020-05-11 20:27:07 +00:00
unix_test.go internal/lsp/regtest: add a t.Skip for golang/go#36824 regtest 2020-05-21 15:57:04 +00:00
vendor_test.go internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
wrappers.go internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers 2020-06-18 13:42:42 +00:00