Heschi Kreinick a9439ae9c1 internal/lsp: replace ParseGoHandle with concrete data ... ParseGoHandles serve two purposes: they pin cache entries so that redundant calculations are cached, and they allow users to obtain the actual parsed AST. The former is an implementation detail, and the latter turns out to just be an annoyance. Parsed Go files are obtained from two places. By far the most common is from a type checked package. But a type checked package must by definition have already parsed all the files it contains, so the PGH is already computed and cannot have failed. Type checked packages can simply return the parsed file without requiring a separate Check operation. We do want to pin the cache entries in this case, which I've done by holding on to the PGH in cache.pkg. There are some cases where we directly parse a file, such as for the FoldingRange LSP call, which doesn't need type information. Those parses can actually fail, so we do need an error check. But we don't need the PGH; in all cases we are immediately using and discarding it. So it turns out we don't actually need the PGH type at all, at least not in the public API. Instead, we can pass around a concrete struct that has the various pieces of data directly available. This uncovered a bug in typeCheck: it should fail if it encounters any real errors. Change-Id: I203bf2dd79d5d65c01392d69c2cf4f7744fde7fc Reviewed-on: https://go-review.googlesource.com/c/tools/+/244021 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-28 17:35:11 +00:00
..
code_lens.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
command.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
completion_format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
extract.go	internal/lsp: support return statements in extract function	2020-07-28 16:04:03 +00:00
folding_range.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
format_test.go	internal/lsp: handle bad formatting with CRLF line endings	2020-07-28 16:05:17 +00:00
format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
highlight.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
hover.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
identifier.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
implementation.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
options.go	internal/lsp: support refactor.extract through commands	2020-07-27 19:25:51 +00:00
references.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
rename_check.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
rename.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
signature_help.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
source_test.go	internal/lsp: fix hover for implicit type switch variable declarations	2020-07-24 02:27:22 +00:00
symbols.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
types_format.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
util.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
view.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00
workspace_symbol.go	internal/lsp: replace ParseGoHandle with concrete data	2020-07-28 17:35:11 +00:00