qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 10:04:43 -07:00
Code Releases Activity
a9439ae9c1
go/internal/lsp
History
Heschi Kreinick a9439ae9c1 internal/lsp: replace ParseGoHandle with concrete data 
ParseGoHandles serve two purposes: they pin cache entries so that
redundant calculations are cached, and they allow users to obtain the
actual parsed AST. The former is an implementation detail, and the
latter turns out to just be an annoyance.

Parsed Go files are obtained from two places. By far the most common is
from a type checked package. But a type checked package must by
definition have already parsed all the files it contains, so the PGH
is already computed and cannot have failed. Type checked packages can
simply return the parsed file without requiring a separate Check
operation. We do want to pin the cache entries in this case, which I've
done by holding on to the PGH in cache.pkg.

There are some cases where we directly parse a file, such as for the
FoldingRange LSP call, which doesn't need type information. Those parses
can actually fail, so we do need an error check. But we don't need the
PGH; in all cases we are immediately using and discarding it.

So it turns out we don't actually need the PGH type at all, at least not
in the public API. Instead, we can pass around a concrete struct that
has the various pieces of data directly available.

This uncovered a bug in typeCheck: it should fail if it encounters any
real errors.

Change-Id: I203bf2dd79d5d65c01392d69c2cf4f7744fde7fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244021
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-07-28 17:35:11 +00:00
..
analysis internal/lsp: allow narrower scope for convenience CodeActions 2020-07-27 23:36:28 +00:00
browser
cache internal/lsp: replace ParseGoHandle with concrete data 2020-07-28 17:35:11 +00:00
cmd internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: correctly invalidate metadata for batched changes 2020-07-27 19:55:46 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/fake: move to a struct for configuring the sandbox 2020-07-23 23:36:26 +00:00
mod internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
protocol internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
regtest internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: replace ParseGoHandle with concrete data 2020-07-28 17:35:11 +00:00
testdata internal/lsp: support return statements in extract function 2020-07-28 16:04:03 +00:00
tests internal/lsp: support refactor.extract through commands 2020-07-27 19:25:51 +00:00
code_action.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: replace ParseGoHandle with concrete data 2020-07-28 17:35:11 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: fix GlobPattern for watching files 2020-07-25 20:09:36 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: replace ParseGoHandle with concrete data 2020-07-28 17:35:11 +00:00
lsp_test.go internal/lsp: support refactor.extract through commands 2020-07-27 19:25:51 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
server.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00