mirror of
https://github.com/golang/go
synced 2024-11-27 00:41:31 -07:00
f4f1ba2b1e
The compiler is incorrectly rejecting switches on arrays of comparable types. It also doesn't catch incomparable structs when typechecking the switch, leading to unreadable errors during typechecking of the generated code. Fixes #3894. R=rsc CC=gobot, golang-dev, r, remy https://golang.org/cl/6442074
73 lines
1.2 KiB
Go
73 lines
1.2 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that erroneous switch statements are detected by the compiler.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
type I interface {
|
|
M()
|
|
}
|
|
|
|
func bad() {
|
|
var i I
|
|
var s string
|
|
|
|
switch i {
|
|
case s: // ERROR "mismatched types string and I|incompatible types"
|
|
}
|
|
|
|
switch s {
|
|
case i: // ERROR "mismatched types I and string|incompatible types"
|
|
}
|
|
|
|
var m, m1 map[int]int
|
|
switch m {
|
|
case nil:
|
|
case m1: // ERROR "can only compare map m to nil|map can only be compared to nil"
|
|
default:
|
|
}
|
|
|
|
var a, a1 []int
|
|
switch a {
|
|
case nil:
|
|
case a1: // ERROR "can only compare slice a to nil|slice can only be compared to nil"
|
|
default:
|
|
}
|
|
|
|
var f, f1 func()
|
|
switch f {
|
|
case nil:
|
|
case f1: // ERROR "can only compare func f to nil|func can only be compared to nil"
|
|
default:
|
|
}
|
|
|
|
var ar, ar1 [4]func()
|
|
switch ar { // ERROR "cannot switch on"
|
|
case ar1:
|
|
default:
|
|
}
|
|
|
|
var st, st1 struct{ f func() }
|
|
switch st { // ERROR "cannot switch on"
|
|
case st1:
|
|
}
|
|
}
|
|
|
|
func good() {
|
|
var i interface{}
|
|
var s string
|
|
|
|
switch i {
|
|
case s:
|
|
}
|
|
|
|
switch s {
|
|
case i:
|
|
}
|
|
}
|