1
0
mirror of https://github.com/golang/go synced 2024-11-18 19:54:44 -07:00
go/internal/lsp/source
Muir Manders a222fb47e2 internal/lsp/source: don't downrank builtin constant completions
We downrank untyped constant candidates so that we prefer candidates
whose type matches exactly. However, this was causing builtin
constants like "true" to be outranked by candidates that fuzzily match
"true". Fix by not downranking builtin constants.

Fixes golang/go#36363.

Change-Id: I14801688c96efdbb7ff9fee69f66028530df984c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/213137
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-01-07 18:15:58 +00:00
..
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
completion_format.go internal/lsp: trim address operator from completion filterText 2019-12-24 05:57:32 +00:00
completion_keywords.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_labels.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_literal.go internal/lsp: support taking address for completion candidates 2019-12-23 23:54:10 +00:00
completion_snippet.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
completion.go internal/lsp/source: don't downrank builtin constant completions 2020-01-07 18:15:58 +00:00
deep_completion.go internal/lsp/source: scan loaded packages first for completions 2019-12-30 21:21:36 +00:00
diagnostics.go internal/lsp: parallelize initial workspace load 2020-01-07 18:15:18 +00:00
errors.go internal/lsp: use the -modfile flag to update a different go.mod file 2019-12-17 22:15:16 +00:00
folding_range.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
format.go internal/imports,lsp: use callbacks for completion functions 2019-12-30 21:11:27 +00:00
highlight.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
hover.go internal/lsp: show comments for grouped variable declarations 2019-12-18 20:39:36 +00:00
identifier.go all: remove many cases of space-space 2019-12-30 19:07:42 +00:00
implementation.go internal/lsp: parallelize initial workspace load 2020-01-07 18:15:18 +00:00
options.go internal/lsp: refactor and document options 2019-12-27 05:17:27 +00:00
references.go internal/lsp: parallelize initial workspace load 2020-01-07 18:15:18 +00:00
rename_check.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
rename.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
signature_help.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
source_test.go internal/lsp: parallelize initial workspace load 2020-01-07 18:15:18 +00:00
suggested_fix.go internal/lsp: move error range computations into cache package 2019-10-21 22:12:58 +00:00
symbols.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
tidy.go internal/lsp: use the -modfile flag to update a different go.mod file 2019-12-17 22:15:16 +00:00
util.go internal/lsp: support taking address for completion candidates 2019-12-23 23:54:10 +00:00
view.go internal/lsp: parallelize initial workspace load 2020-01-07 18:15:18 +00:00