Rob Findley f2c07d7d8e internal/lsp/lsprpc: improvements to daemon logging ... The gopls daemon had different default logging behavior than the sidecar gopls: by default, the daemon was started with -logfile=auto. Additionally, because most logs are reflected back to the forwarder, the actual daemon logs have very little (if any) information. This means that if you simply start gopls with -remote=auto, you'll get a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This is not a delightful experience. Fix this via several improvements: + Log lifecycle events in the Daemon, to give the log a purpose. + Give the daemon a new default log location: /tmp/gopls-daemon-<pid>.log. + Don't pass -logfile=auto to the daemon by default. Fixes golang/go#40105 Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-16 19:33:22 +00:00
..
check.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
cmdtest.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
definition.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
folding_range.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
format.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
highlight.go	tools/gopls: add cmd support for highlight	2019-11-26 20:36:08 +00:00
implementation.go	internal/lsp: store workspace package IDs with package paths	2020-01-09 22:04:34 +00:00
imports.go	internal/lsp: fix imports issue with duplicate package decl	2020-04-16 06:17:24 +00:00
links.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
references.go	internal/lsp: add tests for references includeDeclaration setting	2020-01-23 01:39:50 +00:00
rename.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
signature.go	internal/lsp: remove unnecessary source.SignatureInformation type	2020-02-06 19:05:38 +00:00
suggested_fix.go	internal/lsp: plumb fillstruct through analysis	2020-06-15 21:22:08 +00:00
symbols.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
workspace_symbol.go	tools/gopls: add cmd support for workspace_symbol	2020-03-26 19:59:04 +00:00