Rob Findley f2c07d7d8e internal/lsp/lsprpc: improvements to daemon logging ... The gopls daemon had different default logging behavior than the sidecar gopls: by default, the daemon was started with -logfile=auto. Additionally, because most logs are reflected back to the forwarder, the actual daemon logs have very little (if any) information. This means that if you simply start gopls with -remote=auto, you'll get a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This is not a delightful experience. Fix this via several improvements: + Log lifecycle events in the Daemon, to give the log a purpose. + Give the daemon a new default log location: /tmp/gopls-daemon-<pid>.log. + Don't pass -logfile=auto to the daemon by default. Fixes golang/go#40105 Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-16 19:33:22 +00:00
..
test	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
capabilities_test.go	internal/lsp: cancel the initial workspace load when view shuts down	2020-06-12 18:06:40 +00:00
check.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
cmd_test.go	internal/lsp: share common command line test functionality	2020-04-28 14:04:16 +00:00
cmd.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
definition.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
export_test.go	internal/lsp: refactor query definition test to allow adding a new test	2019-03-18 20:06:54 +00:00
folding_range.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
format.go	internal/lsp: address staticcheck warnings	2019-10-04 02:16:23 +00:00
highlight.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
imports.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
info.go	internal/lsp/cmd: add a -vv flag for higher verbosity	2020-07-11 15:58:55 +00:00
inspect.go	internal/lsp/cmd: use JSON output for the inspect subcommand	2020-05-11 18:25:40 +00:00
links.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
prepare_rename.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
references.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
serve_test.go	internal/lsp/lsprpc: automatically resolve and start the remote gopls	2020-02-24 22:51:55 +00:00
serve.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
signature.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
suggested_fix.go	internal/lsp: extract highlighted selection to variable	2020-07-07 21:12:28 +00:00
symbols.go	internal/lsp/cmd: fix not displaying symbols result	2020-05-11 23:26:04 +00:00
workspace_symbol.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00