Rob Findley 9a0fabac01 internal/lsp: fix errors found by staticcheck ... While experimenting with different static analysis on x/tools, I noticed that there are many actionable diagnostics found by staticcheck. Fix the ones that were not false positives. Change-Id: I0b68cf1f636b57b557db879fad84fff9b7237a89 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222248 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-03-19 19:20:54 +00:00
..
check.go	internal/lsp: refactor LSP server instantiation	2020-02-06 23:12:37 +00:00
cmdtest.go	internal/lsp: add an upgrade all dependencies codelens	2020-03-02 21:30:18 +00:00
definition.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
folding_range.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
format.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
highlight.go	tools/gopls: add cmd support for highlight	2019-11-26 20:36:08 +00:00
implementation.go	internal/lsp: store workspace package IDs with package paths	2020-01-09 22:04:34 +00:00
imports.go	internal/lsp: fix golden generation for import tests	2019-12-05 21:54:53 +00:00
links.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
references.go	internal/lsp: add tests for references includeDeclaration setting	2020-01-23 01:39:50 +00:00
rename.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
signature.go	internal/lsp: remove unnecessary source.SignatureInformation type	2020-02-06 19:05:38 +00:00
suggested_fix.go	internal/lsp/cmd: improve flexibility of suggested fixes	2020-03-06 14:31:35 +00:00
symbols.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00