Rob Findley 9a0fabac01 internal/lsp: fix errors found by staticcheck ... While experimenting with different static analysis on x/tools, I noticed that there are many actionable diagnostics found by staticcheck. Fix the ones that were not false positives. Change-Id: I0b68cf1f636b57b557db879fad84fff9b7237a89 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222248 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-03-19 19:20:54 +00:00
..
browser
cache	internal/telemetry: add type safe tag keys	2020-03-18 13:29:43 +00:00
cmd	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
debug	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
diff	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
fake	x/tools/gopls: add support for $/progress functionality	2020-03-16 21:25:24 +00:00
fuzzy	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
helper	internal/lsp: change to helper.go to output a formatted file	2020-01-31 20:35:38 +00:00
lsprpc	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
mod	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
protocol	internal/telemetry: allow ProcessEvent to modify the event	2020-03-18 13:22:01 +00:00
regtest	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
snippet
source	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
testdata	internal/lsp/source: fix literal completions in variadic args	2020-03-18 05:47:22 +00:00
tests	internal/lsp/tests: fix WorkspaceSymbols tests	2020-03-11 18:46:36 +00:00
code_action.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
command.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
completion_test.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
completion.go	internal/telemetry: add type safe tag keys	2020-03-18 13:29:43 +00:00
definition.go	internal/lsp/source: return location(s) for imported packages	2020-03-09 16:25:02 +00:00
diagnostics.go	internal/lsp: move the telemetry package	2020-03-18 13:22:49 +00:00
folding_range.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
format.go	internal/lsp: support textDocument/formatting for .mod extension	2020-03-06 13:51:27 +00:00
general.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
generate.go	internal/lsp: move the telemetry package	2020-03-18 13:22:49 +00:00
highlight.go	internal/lsp: move the telemetry package	2020-03-18 13:22:49 +00:00
hover.go	internal/lsp: support textDocument/hover for .mod extension	2020-02-26 15:59:49 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
link.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
lsp_test.go	internal/lsp: support when hierarchicalDocumentSymbolSupport is false	2020-03-06 18:17:37 +00:00
references.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
reset_golden.sh
server_gen.go	x/tools/gopls: add support for $/progress functionality	2020-03-16 21:25:24 +00:00
server.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
signature_help.go	internal/telemetry: delete the event.TagOf method	2020-03-18 13:23:15 +00:00
symbols.go	internal/lsp: move the telemetry package	2020-03-18 13:22:49 +00:00
text_synchronization.go	internal/lsp: clear diagnostics for deleted files	2020-02-19 20:26:41 +00:00
workspace_symbol.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
workspace.go	internal/lsp: generate boilerplate stubs for type Server	2020-01-24 14:41:51 +00:00