Rebecca Stambler 37a045f3b9 internal/lsp: move undeclaredname suggested fix out of analysis ... This CL is a follow-up from CL 241983. I didn't realize that the undeclaredname analysis was also using the go/printer.Fprint trick, which we decided was both incorrect and inefficient. This CL does approximately the same things as CL 241983, with a few changes to make the approach more general. source.Analyzer now has a field to indicate if its suggested fix needs to be computed separately, and that is used to determine which code actions get commands. We also make helper functions to map analyses to their commands. I figured out a neater way to test suggested fixes in this CL, so I reversed the move to source_test back to lsp_test (which was the right place all along). Change-Id: I505bf4790481d887edda8b82897e541ec73fb427 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242366 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-23 23:54:27 +00:00
..
check.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
cmdtest.go	internal/lsp: support extract function	2020-07-20 18:55:41 +00:00
definition.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
folding_range.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
format.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
highlight.go	tools/gopls: add cmd support for highlight	2019-11-26 20:36:08 +00:00
implementation.go	internal/lsp: store workspace package IDs with package paths	2020-01-09 22:04:34 +00:00
imports.go	internal/lsp: fix imports issue with duplicate package decl	2020-04-16 06:17:24 +00:00
links.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
references.go	internal/lsp: add tests for references includeDeclaration setting	2020-01-23 01:39:50 +00:00
rename.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
signature.go	internal/lsp: remove unnecessary source.SignatureInformation type	2020-02-06 19:05:38 +00:00
suggested_fix.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
symbols.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
workspace_symbol.go	tools/gopls: add cmd support for workspace_symbol	2020-03-26 19:59:04 +00:00