Rebecca Stambler 37a045f3b9 internal/lsp: move undeclaredname suggested fix out of analysis ... This CL is a follow-up from CL 241983. I didn't realize that the undeclaredname analysis was also using the go/printer.Fprint trick, which we decided was both incorrect and inefficient. This CL does approximately the same things as CL 241983, with a few changes to make the approach more general. source.Analyzer now has a field to indicate if its suggested fix needs to be computed separately, and that is used to determine which code actions get commands. We also make helper functions to map analyses to their commands. I figured out a neater way to test suggested fixes in this CL, so I reversed the move to source_test back to lsp_test (which was the right place all along). Change-Id: I505bf4790481d887edda8b82897e541ec73fb427 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242366 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-23 23:54:27 +00:00
..
test	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
capabilities_test.go	internal/lsp: cancel the initial workspace load when view shuts down	2020-06-12 18:06:40 +00:00
check.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
cmd_test.go	internal/lsp: share common command line test functionality	2020-04-28 14:04:16 +00:00
cmd.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
definition.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
export_test.go	internal/lsp: refactor query definition test to allow adding a new test	2019-03-18 20:06:54 +00:00
folding_range.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
format.go	internal/lsp: address staticcheck warnings	2019-10-04 02:16:23 +00:00
highlight.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
imports.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
info.go	internal/lsp/cmd: add a -vv flag for higher verbosity	2020-07-11 15:58:55 +00:00
inspect.go	internal/lsp/cmd: use JSON output for the inspect subcommand	2020-05-11 18:25:40 +00:00
links.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
prepare_rename.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
references.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
serve_test.go	internal/lsp/lsprpc: automatically resolve and start the remote gopls	2020-02-24 22:51:55 +00:00
serve.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
signature.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
suggested_fix.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
symbols.go	internal/lsp/cmd: fix not displaying symbols result	2020-05-11 23:26:04 +00:00
workspace_symbol.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00