1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:58:34 -06:00
go/internal/lsp/cache
Rebecca Stambler 88e38c1d8d internal/lsp: make sure diagnostics only refer to existing files
We were previously sending diagnostics for nonexistent files, and then
adding them to the snapshot in the process. Remove this behavior, and
add a regression test. Case insensitive filesystems were too confusing
to write a test for, but fortunately, Filippo reported another instance
of this bug, so I used that for the regression test.

Fixes golang/go#38602

Change-Id: I4ef6b51944f3338e838875a5aafffd066e8392f4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/230315
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-05-07 02:01:22 +00:00
..
analysis.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
cache.go internal/lsp: move the debug.Instance onto the Context 2020-03-03 22:54:53 +00:00
check.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
debug.go internal/lsp/lsprpc: add a handshake between forwarder and remote 2020-02-24 22:51:04 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
external.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
load.go internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
mod.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
pkg.go internal/lsp/cache: hide type errors if we fix up the AST 2020-04-10 04:07:51 +00:00
session.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
snapshot.go internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00