1
0
mirror of https://github.com/golang/go synced 2024-11-18 12:44:49 -07:00
go/internal/lsp
Rebecca Stambler 88e38c1d8d internal/lsp: make sure diagnostics only refer to existing files
We were previously sending diagnostics for nonexistent files, and then
adding them to the snapshot in the process. Remove this behavior, and
add a regression test. Case insensitive filesystems were too confusing
to write a test for, but fortunately, Filippo reported another instance
of this bug, so I used that for the regression test.

Fixes golang/go#38602

Change-Id: I4ef6b51944f3338e838875a5aafffd066e8392f4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/230315
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-05-07 02:01:22 +00:00
..
analysis internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
cmd internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
debug internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
diff internal/lsp/diff/difftest: ignore for GOOS=illumos 2020-04-14 02:36:50 +00:00
fake internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
mod internal/lsp: don't offer suggested fixes for generated files 2020-05-01 06:56:59 +00:00
protocol internal/jsonrpc2: move the lock into logCommon 2020-04-30 04:03:07 +00:00
regtest internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
testdata internal/lsp: add comment completions for remaining exported symbols 2020-05-04 02:29:51 +00:00
tests Revert "internal/lsp: hide analysis diagnostics from generated files" 2020-04-30 19:28:56 +00:00
code_action.go internal/lsp: don't offer suggested fixes for generated files 2020-05-01 06:56:59 +00:00
command.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
completion_test.go internal/lsp: correctly handle type aliases when formatting 2020-04-23 20:53:58 +00:00
completion.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: avoid showing no-GOPATH-nor-module message so much 2020-05-02 20:28:11 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
generate.go internal/lsp: fix incorrect format strings when calling event.Error 2020-05-04 19:35:31 +00:00
highlight.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
lsp_test.go internal/lsp: avoid showing no-GOPATH-nor-module message so much 2020-05-02 20:28:11 +00:00
progress.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
signature_help.go internal/event: extract keys to their own package 2020-04-23 18:13:43 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
text_synchronization.go internal/lsp: instrument work done reporting to use in regtests 2020-04-28 20:46:32 +00:00
workspace_symbol.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00