mirror of
https://github.com/golang/go
synced 2024-11-17 22:34:47 -07:00
4c943abb95
Fixes for #49680, #49695, #45867, and #49370 all assumed that SetGCPercent(-1) doesn't block until the GC's mark phase is done, but it actually does. The cause of 3 of those 4 failures comes from the fact that at the beginning of the sweep phase, the GC does try to preempt every P once, and this may run concurrently with test code. In the fourth case, the issue was likely that only *one* of the debug_test.go tests was missing a call to SetGCPercent(-1). Just to be safe, leave a TODO there for now to remove the extraneous runtime.GC calls, but leave the calls in. Updates #49680, #49695, #45867, and #49370. Change-Id: Ibf4e64addfba18312526968bcf40f1f5d54eb3f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/369815 Reviewed-by: Austin Clements <austin@google.com> Trust: Michael Knyszek <mknyszek@google.com> Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
|---|---|---|
| .. | ||
| gcc68255 | ||
| issue8756 | ||
| issue8828 | ||
| issue9026 | ||
| issue9400 | ||
| issue9510a | ||
| issue9510b | ||
| issue20266 | ||
| issue23555a | ||
| issue23555b | ||
| issue24161arg | ||
| issue24161e0 | ||
| issue24161e1 | ||
| issue24161e2 | ||
| issue24161res | ||
| issue26213 | ||
| issue26430 | ||
| issue26743 | ||
| issue27054 | ||
| issue27340 | ||
| issue29563 | ||
| issue30527 | ||
| issue41761a | ||
| issue43639 | ||
| cgo_linux_test.go | ||
| cgo_test.go | ||
| gcc68255.go | ||
| issue8756.go | ||
| issue8828.go | ||
| issue9026.go | ||
| issue9400_linux.go | ||
| issue9510.go | ||
| issue20266.go | ||
| issue23555.go | ||
| issue24161_darwin_test.go | ||
| issue26430.go | ||
| issue26743.go | ||
| issue27340.go | ||
| issue29563.go | ||
| issue30527.go | ||
| issue41761.go | ||
| issue43639.go | ||
| test26213.go | ||