1
0
mirror of https://github.com/golang/go synced 2024-09-30 14:28:33 -06:00
go/cmd
Alan Donovan 7fdb908ead cmd/guru: fix tests now that go1.9 go/types returns fake packages
The go1.9 type checker now returns fake packages in addition to an
error if the package was not found at all.  This changes the behavior
of guru in a release-specific way, requiring the test to be split into
a common part and a go1.9-specific part.

In hindsight, perhaps it would have been better to place the
expectation in a comment alongside the query so that they can be
easily enabled or disabled together.  (The downside of that design is
that you can't batch-update all the expectations to match the actual
behavior.)

Change-Id: I58054adec428fbab7fe3c57097aefc827f89a46e
Reviewed-on: https://go-review.googlesource.com/37865
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2017-03-08 23:16:52 +00:00
..
benchcmp benchmark/parser, cmd/benchcmp: improve names of exported identifiers 2015-01-15 01:28:17 +00:00
bundle cmd/bundle: revert support for Go 1.8 aliases 2016-11-04 21:17:06 +00:00
callgraph x/tools: simplify and format code 2017-02-28 14:15:42 +00:00
cover cmd/cover: check os.Create error im html output 2017-01-08 00:00:17 +00:00
digraph tools: add import comments. 2014-12-09 22:42:16 +00:00
eg Revert "refactor/eg: remove vendor prefix from imported packages" 2016-11-30 00:13:03 +00:00
fiximports cmd/godoc, cmd/fiximports: fix or skip failing tests at tip 2016-10-12 15:24:30 +00:00
godex cmd/godex: handle printing of type aliases 2017-01-11 21:17:45 +00:00
godoc cmd/godoc, godoc: implement build.Context.IsDir, update expected error string 2017-03-05 21:32:12 +00:00
goimports cmd/goimports: use actual filename in goimports -d output 2017-02-09 17:25:24 +00:00
gomvpkg go/buildutil: TagsFlag provides a flag.Value for setting build.Context.BuildTags from -tags flag. 2015-04-23 14:10:21 +00:00
gorename cmd/gorename: -d flag prints diffs instead of rewriting files 2015-12-30 15:25:00 +00:00
goyacc x/tools/cmd/goyacc: remove unused function. 2017-03-01 14:38:58 +00:00
guru cmd/guru: fix tests now that go1.9 go/types returns fake packages 2017-03-08 23:16:52 +00:00
heapview x/tools/cmd/heapview: add a sidebar to hold navigation 2016-08-16 17:33:40 +00:00
html2article x/tools/cmd/html2article: remove unused functions 2017-03-01 14:53:04 +00:00
present x/tools: simplify and format code 2017-02-28 14:15:42 +00:00
ssadump tools: updates for minimum Go version 1.6 2017-02-07 21:06:19 +00:00
stress all: fix plan9 failures 2016-01-28 00:31:03 +00:00
stringer tools: remove go1.8-tagged files 2016-11-04 21:29:52 +00:00
tip cmd/tip: move tip.golang.org from App Engine to Kubernetes on GKE 2017-03-07 03:49:08 +00:00
toolstash x/tools: simplify and format code 2017-02-28 14:15:42 +00:00