mirror of
https://github.com/golang/go
synced 2024-11-19 03:04:42 -07:00
d4e30f1c22
This required extensive changes to the "internal" server handling and also to the way we wait for diagnostics in the "check" verb. It improves both memory and time by over an order of magnitude, hopefully allowing us to renable the tests on the builders Change-Id: I84e84ca4c449e9970ebf1d922a0a2ce0a8a49c72 Reviewed-on: https://go-review.googlesource.com/c/tools/+/175878 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
74 lines
1.8 KiB
Go
74 lines
1.8 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"time"
|
|
|
|
"golang.org/x/tools/internal/span"
|
|
)
|
|
|
|
// check implements the check verb for gopls.
|
|
type check struct {
|
|
app *Application
|
|
}
|
|
|
|
func (c *check) Name() string { return "check" }
|
|
func (c *check) Usage() string { return "<filename>" }
|
|
func (c *check) ShortHelp() string { return "show diagnostic results for the specified file" }
|
|
func (c *check) DetailedHelp(f *flag.FlagSet) {
|
|
fmt.Fprint(f.Output(), `
|
|
Example: show the diagnostic results of this file:
|
|
|
|
$ gopls check internal/lsp/cmd/check.go
|
|
|
|
gopls check flags are:
|
|
`)
|
|
f.PrintDefaults()
|
|
}
|
|
|
|
// Run performs the check on the files specified by args and prints the
|
|
// results to stdout.
|
|
func (c *check) Run(ctx context.Context, args ...string) error {
|
|
if len(args) == 0 {
|
|
// no files, so no results
|
|
return nil
|
|
}
|
|
checking := map[span.URI]*cmdFile{}
|
|
// now we ready to kick things off
|
|
conn, err := c.app.connect(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, arg := range args {
|
|
uri := span.FileURI(arg)
|
|
file := conn.AddFile(ctx, uri)
|
|
if file.err != nil {
|
|
return file.err
|
|
}
|
|
checking[uri] = file
|
|
}
|
|
// now wait for results
|
|
//TODO: maybe conn.ExecuteCommand(ctx, &protocol.ExecuteCommandParams{Command: "gopls-wait-idle"})
|
|
for _, file := range checking {
|
|
select {
|
|
case <-file.hasDiagnostics:
|
|
case <-time.Tick(30 * time.Second):
|
|
return fmt.Errorf("timed out waiting for results from %v", file.uri)
|
|
}
|
|
for _, d := range file.diagnostics {
|
|
spn, err := file.mapper.RangeSpan(d.Range)
|
|
if err != nil {
|
|
return fmt.Errorf("Could not convert position %v for %q", d.Range, d.Message)
|
|
}
|
|
fmt.Printf("%v: %v\n", spn, d.Message)
|
|
}
|
|
}
|
|
return nil
|
|
}
|