4 Commits

Author	SHA1	Message	Date
Ian Cottrell	d4e30f1c22	internal/lsp: making cmd tests fast and small ... This required extensive changes to the "internal" server handling and also to the way we wait for diagnostics in the "check" verb. It improves both memory and time by over an order of magnitude, hopefully allowing us to renable the tests on the builders Change-Id: I84e84ca4c449e9970ebf1d922a0a2ce0a8a49c72 Reviewed-on: https://go-review.googlesource.com/c/tools/+/175878 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-05-10 20:14:07 +00:00
Ian Cottrell	f558378bf8	internal/lsp: make definition use the lsp protocol ... instead of driving the source pacakge directly, it indirects through the lsp protocol (the same way check does) We are normalizing on all the command lines doing this, so that server mode is more viable in the future. Change-Id: Ib5f2a059a44a5c60a53129c554e3cc14ca72c4a8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170577 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-04-05 17:02:55 +00:00
Ian Cottrell	d996c1aa53	internal/lsp: minor comment fix ... Change-Id: I6603375beac4e321dd45f99e90d7eddbae4c6c4b Reviewed-on: https://go-review.googlesource.com/c/tools/+/170717 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-04-05 16:24:45 +00:00
Ian Cottrell	ab21143f23	internal/lsp: adding command line access to diagnostics ... Change-Id: I011e337ec2bce93199cf762c09e002442ca1bd0d Reviewed-on: https://go-review.googlesource.com/c/tools/+/167697 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-28 21:17:00 +00:00