go/test at 7b872b6d955d3e749ea62dbfced68ab5c61eae91 - go

qbit/go

mirror of https://github.com/golang/go synced 2024-11-18 06:34:53 -07:00

History

Xiangdong Ji e031318ca6 cmd/compile: ARM comparisons with 0 incorrect on overflow Some ARM rewriting rules convert 'comparing to zero' conditions of if statements to a simplified version utilizing CMN and CMP instructions to branch over condition flags, in order to save one Add or Sub caculation. Such optimizations lead to wrong branching in case an overflow/underflow occurs when executing CMN or CMP. Fix the issue by introducing new block opcodes that don't honor the overflow/underflow flag: Block-Op Meaning ARM condition codes 1. LTnoov less than MI 2. GEnoov greater than or equal PL 3. LEnoov less than or equal MI \|\| EQ 4. GTnoov greater than NEQ & PL The patch also adds a few test cases to cover scenarios that are specific to ARM and fine-tunes the code generation tests for 'x-const'. For more details please refer to the previous fix on 64-bit ARM: https://go-review.googlesource.com/c/go/+/233097 Go1 perf, 'old' is the non-optimized version, that is removing all concerned rewriting rules. name old time/op new time/op delta BinaryTree17-8 7.73s ± 0% 7.81s ± 0% +0.97% (p=0.000 n=7+8) Fannkuch11-8 7.06s ± 0% 7.00s ± 0% -0.83% (p=0.000 n=8+8) FmtFprintfEmpty-8 181ns ± 1% 183ns ± 1% +1.31% (p=0.001 n=8+8) FmtFprintfString-8 319ns ± 1% 325ns ± 2% +1.71% (p=0.009 n=7+8) FmtFprintfInt-8 358ns ± 1% 359ns ± 1% ~ (p=0.293 n=7+7) FmtFprintfIntInt-8 459ns ± 3% 456ns ± 1% ~ (p=0.869 n=8+8) FmtFprintfPrefixedInt-8 535ns ± 4% 538ns ± 4% ~ (p=0.572 n=8+8) FmtFprintfFloat-8 1.01µs ± 2% 1.01µs ± 2% ~ (p=0.625 n=8+8) FmtManyArgs-8 1.93µs ± 2% 1.93µs ± 1% ~ (p=0.979 n=8+7) GobDecode-8 16.1ms ± 1% 16.5ms ± 1% +2.32% (p=0.000 n=8+8) GobEncode-8 15.9ms ± 0% 15.8ms ± 1% -1.00% (p=0.000 n=8+7) Gzip-8 690ms ± 1% 670ms ± 0% -2.90% (p=0.000 n=8+8) Gunzip-8 109ms ± 1% 109ms ± 1% ~ (p=0.694 n=7+8) HTTPClientServer-8 149µs ± 3% 146µs ± 2% -1.70% (p=0.028 n=8+8) JSONEncode-8 50.5ms ± 1% 49.2ms ± 0% -2.60% (p=0.001 n=7+7) JSONDecode-8 135ms ± 2% 137ms ± 1% ~ (p=0.054 n=8+7) Mandelbrot200-8 951ms ± 0% 952ms ± 0% ~ (p=0.852 n=6+8) GoParse-8 9.47ms ± 1% 9.66ms ± 1% +2.01% (p=0.000 n=8+8) RegexpMatchEasy0_32-8 288ns ± 2% 277ns ± 2% -3.61% (p=0.000 n=8+8) RegexpMatchEasy0_1K-8 1.66µs ± 1% 1.69µs ± 2% +2.21% (p=0.001 n=7+7) RegexpMatchEasy1_32-8 334ns ± 1% 305ns ± 2% -8.86% (p=0.000 n=8+8) RegexpMatchEasy1_1K-8 2.14µs ± 2% 2.15µs ± 0% ~ (p=0.099 n=8+8) RegexpMatchMedium_32-8 13.3ns ± 1% 13.3ns ± 0% ~ (p=1.000 n=7+7) RegexpMatchMedium_1K-8 81.1µs ± 3% 80.7µs ± 1% ~ (p=0.955 n=7+8) RegexpMatchHard_32-8 4.26µs ± 0% 4.26µs ± 0% ~ (p=0.933 n=7+8) RegexpMatchHard_1K-8 124µs ± 0% 124µs ± 0% +0.31% (p=0.000 n=8+8) Revcomp-8 14.7ms ± 2% 14.5ms ± 1% -1.66% (p=0.003 n=8+8) Template-8 197ms ± 2% 200ms ± 3% +1.62% (p=0.021 n=8+8) TimeParse-8 1.33µs ± 1% 1.30µs ± 1% -1.86% (p=0.002 n=8+8) TimeFormat-8 3.04µs ± 1% 3.02µs ± 0% -0.60% (p=0.000 n=8+8) name old speed new speed delta GobDecode-8 47.6MB/s ± 1% 46.5MB/s ± 1% -2.28% (p=0.000 n=8+8) GobEncode-8 48.1MB/s ± 0% 48.6MB/s ± 1% +1.02% (p=0.000 n=8+7) Gzip-8 28.1MB/s ± 1% 29.0MB/s ± 0% +2.97% (p=0.000 n=8+8) Gunzip-8 178MB/s ± 1% 179MB/s ± 2% ~ (p=0.694 n=7+8) JSONEncode-8 38.4MB/s ± 1% 39.4MB/s ± 0% +2.67% (p=0.001 n=7+7) JSONDecode-8 14.3MB/s ± 2% 14.2MB/s ± 1% -0.81% (p=0.043 n=8+7) GoParse-8 6.12MB/s ± 1% 5.99MB/s ± 1% -2.00% (p=0.000 n=8+8) RegexpMatchEasy0_32-8 111MB/s ± 2% 115MB/s ± 2% +3.77% (p=0.000 n=8+8) RegexpMatchEasy0_1K-8 618MB/s ± 1% 604MB/s ± 2% -2.16% (p=0.001 n=7+7) RegexpMatchEasy1_32-8 95.7MB/s ± 1% 105.1MB/s ± 2% +9.76% (p=0.000 n=8+8) RegexpMatchEasy1_1K-8 479MB/s ± 2% 477MB/s ± 0% ~ (p=0.105 n=8+8) RegexpMatchMedium_32-8 75.2MB/s ± 1% 75.2MB/s ± 0% ~ (p=0.247 n=7+7) RegexpMatchMedium_1K-8 12.6MB/s ± 3% 12.7MB/s ± 1% ~ (p=0.538 n=7+8) RegexpMatchHard_32-8 7.52MB/s ± 0% 7.52MB/s ± 0% ~ (p=0.968 n=7+8) RegexpMatchHard_1K-8 8.26MB/s ± 0% 8.24MB/s ± 0% -0.30% (p=0.001 n=8+8) Revcomp-8 173MB/s ± 2% 176MB/s ± 1% +1.68% (p=0.003 n=8+8) Template-8 9.85MB/s ± 2% 9.69MB/s ± 3% -1.59% (p=0.021 n=8+8) Fixes #39303 Updates #38740 Change-Id: I0a5f87bfda679f66414c0041ace2ca2e28363f36 Reviewed-on: https://go-review.googlesource.com/c/go/+/236637 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>		2020-06-09 15:50:33 +00:00
..
alias3.dir
bench
chan	test/chan: fix trivial typos	2020-03-25 22:22:20 +00:00
closure3.dir
codegen	cmd/compile: ARM comparisons with 0 incorrect on overflow	2020-06-09 15:50:33 +00:00
ddd2.dir
dwarf
fixedbugs	cmd/compile: add interface equality tests	2020-06-04 06:21:55 +00:00
import2.dir
import4.dir
interface	test: add tests for runtime.itab.init	2019-11-06 09:09:59 +00:00
intrinsic.dir
ken	all: fix typos	2019-09-08 17:28:20 +00:00
linkname.dir	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
method4.dir
oldescape_linkname.dir
retjmp.dir
runtime	test: remove -newescape from regress tests	2019-08-28 19:27:20 +00:00
stress
syntax	cmd/compile/internal/syntax: better error when an assignment is used in value context	2020-02-21 22:57:52 +00:00
uintptrescapes.dir
64bit.go
235.go
alg.go
alias1.go
alias2.go
alias3.go
alias.go
align.go
append1.go
append.go
args.go
armimm.go
assign1.go
assign.go
atomicload.go
bigalg.go
bigmap.go
blank1.go	test, test/fixedbugs, crypto/x509, go/internal/gccgoimporter: fix typos	2020-03-29 17:12:56 +00:00
blank.go
bom.go
bombad.go
bounds.go
chancap.go
chanlinear.go	test, test/fixedbugs, crypto/x509, go/internal/gccgoimporter: fix typos	2020-03-29 17:12:56 +00:00
char_lit1.go
char_lit.go
checkbce.go
clearfat.go
closedchan.go
closure1.go
closure2.go	all: fix typos	2019-09-08 17:28:20 +00:00
closure3.go
closure4.go
closure.go
cmp6.go
cmp.go
cmplx.go
cmplxdivide1.go
cmplxdivide.c
cmplxdivide.go
complit1.go	cmd/compile: simplify OPTRLIT handling	2019-09-26 18:45:53 +00:00
complit.go
compos.go
const1.go
const2.go
const3.go
const4.go
const5.go
const6.go
const.go	cmd/compile: apply constant folding to ORUNESTR	2019-09-26 23:54:29 +00:00
convert1.go
convert2.go
convert3.go
convert.go
convlit1.go
convlit.go	cmd/compile: rewrite untyped constant conversion logic	2019-09-06 23:15:48 +00:00
convT2X.go
copy1.go
copy.go
crlf.go
ddd1.go	cmd/compile: rewrite untyped constant conversion logic	2019-09-06 23:15:48 +00:00
ddd2.go
ddd.go
decl.go
declbad.go
defer.go
defererrcheck.go	test: re-enable open-coded defer test on riscv64	2020-02-26 16:54:17 +00:00
deferfin.go
defernil.go	cmd/compile: on Wasm and AIX, let deferred nil function panic at invocation	2019-10-16 00:05:37 +00:00
deferprint.go
deferprint.out
devirt.go	cmd/compile: debug rewrite	2020-04-13 21:56:15 +00:00
directive.go	cmd/compile: detect and diagnose invalid //go: directive placement	2020-04-21 16:47:01 +00:00
divide.go
divmod.go
empty.go
env.go
eof1.go
eof.go
escape2.go	cmd/compile: more precise analysis of method values	2020-04-21 20:49:34 +00:00
escape2n.go	cmd/compile: more precise analysis of method values	2020-04-21 20:49:34 +00:00
escape3.go
escape4.go
escape5.go	cmd/compile: silence esc diagnostics about directiface OCONVIFACEs	2019-09-03 17:52:06 +00:00
escape_array.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_calls.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_closure.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_field.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_goto.go	cmd/compile: preserve loop depth when evaluating block	2019-09-06 01:35:46 +00:00
escape_hash_maphash.go	hash/maphash: mark call into runtime hash function as not escaping	2019-11-16 20:31:45 +00:00
escape_iface.go	cmd/compile: use underlying OCOMPLIT's position for OPTRLIT	2019-09-25 17:07:09 +00:00
escape_indir.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_level.go	cmd/compile: silence esc diagnostics about directiface OCONVIFACEs	2019-09-03 17:52:06 +00:00
escape_map.go	cmd/compile: silence esc diagnostics about directiface OCONVIFACEs	2019-09-03 17:52:06 +00:00
escape_param.go	cmd/compile: reimplement parameter leak encoding	2019-10-07 18:50:14 +00:00
escape_runtime_atomic.go
escape_selfassign.go
escape_slice.go	cmd/compile: make isSmallMakeSlice checks slice cap only	2020-03-31 21:51:51 +00:00
escape_struct_param1.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_struct_param2.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
escape_struct_return.go	test: remove -newescape from regress tests	2019-08-28 19:27:20 +00:00
escape_sync_atomic.go
escape_unsafe.go	cmd/compile: silence esc diagnostics about directiface OCONVIFACEs	2019-09-03 17:52:06 +00:00
escape.go
fibo.go
finprofiled.go	all: fix typos	2019-09-08 17:28:20 +00:00
float_lit2.go
float_lit3.go
float_lit.go
floatcmp.go
for.go
func1.go
func2.go
func3.go
func4.go
func5.go
func6.go
func7.go
func8.go
func.go
funcdup2.go
funcdup.go
gc1.go
gc2.go
gc.go
gcgort.go
gcstring.go
goprint.go	test: adjust a test to work with js/wasm's background goroutine	2019-10-10 19:38:06 +00:00
goprint.out
goto.go
heapsampling.go
helloworld.go
helloworld.out
if.go
import1.go
import2.go
import4.go
import5.go
import6.go
import.go
index0.go
index1.go
index2.go
index.go	all: fix typos	2019-09-08 17:28:20 +00:00
indirect1.go
indirect.go
init1.go
init.go
initcomma.go
initempty.go	cmd/compile: add test for skipping empty init functions	2019-11-04 20:19:15 +00:00
initialize.go
initializerr.go
initloop.go
inline_big.go	cmd/compile: output cost while inlining function with Debug['m'] > 1	2020-02-26 14:44:24 +00:00
inline_caller.go
inline_callers.go
inline_literal.go
inline_math_bits_rotate.go
inline_sync.go	test: re-enable atomic intrinsic related tests on riscv64	2020-03-25 01:11:15 +00:00
inline_variadic.go
inline.go	cmd/compile: allow mid-stack inlining when there is a cycle of recursion	2020-04-03 21:43:52 +00:00
int_lit.go
intcvt.go
intrinsic_atomic.go	test: re-enable atomic intrinsic related tests on riscv64	2020-03-25 01:11:15 +00:00
intrinsic.go
iota.go
label1.go
label.go
linkmain_run.go	test: avoid writing temporary files to GOROOT	2019-11-18 14:40:07 +00:00
linkmain.go
linkname.go	test: remove -newescape from regress tests	2019-08-28 19:27:20 +00:00
linkobj.go
linkx_run.go	cmd/compile: don't statically copy string-typed variables	2019-10-03 18:08:32 +00:00
linkx.go	[dev.link] all: clean up some TODOs	2019-11-01 20:13:05 +00:00
literal2.go
literal.go
live1.go
live2.go	cmd/compile: extend ssa.go to handle 1-element array and 1-field struct	2019-09-03 19:33:04 +00:00
live_syscall.go	cmd/compile: trim function name prefix from escape diagnostics	2019-09-16 15:30:51 +00:00
live.go	cmd/compile,cmd/link: fix and re-enable open-coded defers on riscv64	2020-01-29 16:34:44 +00:00
locklinear.go
loopbce.go	cmd/compile: detect indvars that are bound by other indvars	2019-09-26 18:47:12 +00:00
makechan.go	test: remove duplicate code from makechan/makemap	2020-04-19 07:51:23 +00:00
makemap.go	test: remove duplicate code from makechan/makemap	2020-04-19 07:51:23 +00:00
makenew.go
makeslice.go	cmd/compile: optimize make+copy pattern to avoid memclr	2020-05-07 17:50:24 +00:00
mallocfin.go
map1.go
map.go
mapclear.go
maplinear.go
mergemul.go
method1.go
method2.go
method3.go
method4.go
method5.go
method6.go
method7.go
method.go
named1.go
named.go
nil.go
nilcheck.go
nilptr2.go
nilptr3.go
nilptr4.go
nilptr5_aix.go
nilptr5_wasm.go
nilptr5.go
nilptr_aix.go
nilptr.go
nosplit.go	runtime: static lock ranking for the runtime (enabled by GOEXPERIMENT)	2020-04-07 21:51:03 +00:00
notinheap2.go
notinheap3.go
notinheap.go
nowritebarrier.go	cmd/compile: allow mid-stack inlining when there is a cycle of recursion	2020-04-03 21:43:52 +00:00
nul1.go
opt_branchlikely.go	all: fix typos	2019-09-08 17:28:20 +00:00
parentype.go
peano.go
phiopt.go
print.go
print.out
printbig.go
printbig.out
prove.go	cmd/compile: in prove, zero right shifts of positive int by #bits - 1	2020-05-11 16:23:52 +00:00
range.go
README.md
recover1.go
recover2.go	cmd/compile,runtime: generate hash functions only for types which are map keys	2019-09-03 20:41:29 +00:00
recover3.go
recover4.go
recover5.go
recover.go
reflectmethod1.go
reflectmethod2.go
reflectmethod3.go
reflectmethod4.go
reflectmethod5.go	cmd/compile: when marking REFLECTMETHOD, check for reflect package itself	2020-04-19 03:12:32 +00:00
reflectmethod6.go	cmd/compile: when marking REFLECTMETHOD, check for reflect package itself	2020-04-19 03:12:32 +00:00
rename1.go	cmd/compile: rewrite untyped constant conversion logic	2019-09-06 23:15:48 +00:00
rename.go
reorder2.go
reorder.go
retjmp.go
return.go
rotate0.go
rotate1.go
rotate2.go
rotate3.go
rotate.go
run.go	test: make runindir tests pass regardless of whether module mode is in use	2020-03-25 14:19:25 +00:00
rune.go
runtime.go
shift1.go	cmd/compile: rewrite untyped constant conversion logic	2019-09-06 23:15:48 +00:00
shift2.go
sieve.go
sigchld.go
sigchld.out
simassign.go
sinit_run.go	test: avoid writing temporary files to GOROOT	2019-11-18 14:40:07 +00:00
sinit.go
sizeof.go
slice3.go
slice3err.go
slicecap.go
sliceopt.go
solitaire.go
stack.go
stackobj2.go
stackobj3.go
stackobj.go
strcopy.go
strength.go	all: fix typos	2019-09-08 17:28:20 +00:00
string_lit.go
stringrange.go
struct0.go
switch2.go
switch3.go
switch4.go
switch5.go
switch6.go
switch7.go
switch.go
tinyfin.go
torture.go
turing.go
typecheck.go	test: add copyright notice to typecheck.go	2020-04-17 13:30:49 +00:00
typecheckloop.go
typeswitch1.go
typeswitch2.go	cmd/compile: move duplicate type-case checking into typecheck	2019-09-11 23:33:11 +00:00
typeswitch2b.go	cmd/compile/internal/gc: reword "declared and not used" error message	2019-10-28 23:34:13 +00:00
typeswitch3.go
typeswitch.go
uintptrescapes2.go	cmd/compile: fix //go:uintptrescapes for basic method calls	2019-11-05 00:26:30 +00:00
uintptrescapes3.go	cmd/compile: fix //go:uintptrescapes for basic method calls	2019-11-05 00:26:30 +00:00
uintptrescapes.go
undef.go
utf.go
varerr.go
varinit.go
winbatch.go	all: treat all files as binary, but check in .bat with CRLF	2020-06-08 15:31:43 +00:00
writebarrier.go	cmd/compile: improve generated code for concrete cases in type switches	2020-04-14 17:34:31 +00:00
zerodivide.go

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.