mirror of
https://github.com/golang/go
synced 2024-11-11 17:41:37 -07:00
cmd/compile: add test for skipping empty init functions
CL 200958 adds skipping empty init function feature without any tests for it. A codegen test sounds ideal, but it's unlikely that we can make one for now, so use a program to manipulate runtime/proc.go:initTask directly. Updates #34869 Change-Id: I2683b9a1ace36af6861af02a3a9fb18b3110b282 Reviewed-on: https://go-review.googlesource.com/c/go/+/204217 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
parent
210e3677f9
commit
26d5f032e9
@ -5361,6 +5361,7 @@ func gcd(a, b uint32) uint32 {
|
||||
}
|
||||
|
||||
// An initTask represents the set of initializations that need to be done for a package.
|
||||
// Keep in sync with ../../test/initempty.go:initTask
|
||||
type initTask struct {
|
||||
// TODO: pack the first 3 fields more tightly?
|
||||
state uintptr // 0 = uninitialized, 1 = in progress, 2 = done
|
||||
|
40
test/initempty.go
Normal file
40
test/initempty.go
Normal file
@ -0,0 +1,40 @@
|
||||
// run
|
||||
|
||||
// Copyright 2019 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
// Test that empty init functions are skipped.
|
||||
|
||||
package main
|
||||
|
||||
import _ "unsafe" // for go:linkname
|
||||
|
||||
type initTask struct {
|
||||
state uintptr
|
||||
ndeps uintptr
|
||||
nfns uintptr
|
||||
}
|
||||
|
||||
//go:linkname main_inittask main..inittask
|
||||
var main_inittask initTask
|
||||
|
||||
func main() {
|
||||
if nfns := main_inittask.nfns; nfns != 0 {
|
||||
println(nfns)
|
||||
panic("unexpected init funcs")
|
||||
}
|
||||
}
|
||||
|
||||
func init() {
|
||||
}
|
||||
|
||||
func init() {
|
||||
if false {
|
||||
}
|
||||
}
|
||||
|
||||
func init() {
|
||||
for false {
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue
Block a user