1
0
mirror of https://github.com/golang/go synced 2024-11-18 22:14:56 -07:00
go/internal/lsp
Pontus Leitzler 8d7dbee4c8 internal/lsp/source: support labeled statements when highlighting loops
When document.Highlight is called with the cursor on a loop statement or
branch statement, gopls doesn't look for labels. Placing the cursor at
the break statement below highlights the inner for loop:

Outer:
for {
    for {
        break Outer
    }
}

By making highlight label aware, and ensure that unlabeled "break" in
"switch"/"select" doesn't highlight the outer loop, this change fixes
loop highlighting.

Adding support for highlight of "switch" and "select" will be handled in
a separate CL.

Updates golang/go#39275

Change-Id: I7014aa7b0dfb1da871863ced611623be995f3944
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236524
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-06-10 05:20:24 +00:00
..
analysis internal/lsp/analysis/fillreturns: broaden type equality 2020-06-05 18:10:38 +00:00
browser
cache internal/lsp: clean out the debug handling 2020-06-06 01:49:14 +00:00
cmd internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
debug internal/lsp: minor cleanup of the client and server debug 2020-06-06 01:49:50 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: now connection shutdown works, use it 2020-06-06 01:49:04 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp: minor cleanup of the client and server debug 2020-06-06 01:49:50 +00:00
mod internal/lsp: support configurable codeLens 2020-05-08 18:47:35 +00:00
protocol internal/lsp: minor protocol cleanup 2020-06-09 12:41:32 +00:00
regtest internal/lsp: add a way for regtests to look at the diagnostics 2020-06-09 09:53:42 +00:00
snippet
source internal/lsp/source: support labeled statements when highlighting loops 2020-06-10 05:20:24 +00:00
testdata internal/lsp/source: support labeled statements when highlighting loops 2020-06-10 05:20:24 +00:00
tests internal/lsp: remove debug line 2020-06-08 17:46:01 +00:00
code_action.go internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
command.go internal/lsp: fix update code lens and add a regression test 2020-06-08 16:37:37 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: fix update code lens and add a regression test 2020-06-08 16:37:37 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: change exit handling 2020-06-03 13:14:19 +00:00
generate.go internal/lsp: add run test code lens 2020-05-12 13:19:52 +00:00
highlight.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
lsp_test.go internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
progress.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
signature_help.go internal/event: extract keys to their own package 2020-04-23 18:13:43 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
text_synchronization.go internal/lsp: lift up workdone instrumentation to didModifyFiles 2020-06-03 13:18:45 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00